Index: lams_tool_forum/conf/language/ApplicationResources.properties =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/conf/language/ApplicationResources.properties (.../ApplicationResources.properties) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/conf/language/ApplicationResources.properties (.../ApplicationResources.properties) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -157,3 +157,5 @@ #======= End labels: Exported 148 labels for en AU ===== +topic.message.attachment.hidden=Message attachment hidden +message.posting.limiting=Posting Limits \ No newline at end of file Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/ExportServlet.java =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/ExportServlet.java (.../ExportServlet.java) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/ExportServlet.java (.../ExportServlet.java) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -69,9 +69,7 @@ private class StringComparator implements Comparator{ public int compare(String o1, String o2) { if(o1 != null && o2 != null){ - int c = o1.compareTo(o2); - //to ensure String does not overlap even they have duplicated name. - return c==0?1:c; + return o1.compareTo(o2); }else if(o1 != null) return 1; else Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/LearningAction.java =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/LearningAction.java (.../LearningAction.java) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/LearningAction.java (.../LearningAction.java) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -149,12 +149,11 @@ try { mode = WebUtil.readToolAccessModeParam(request,AttributeNames.PARAM_MODE, MODE_OPTIONAL); } catch (Exception exp) { + } + if (mode == null) { //set it as default mode mode = ToolAccessMode.LEARNER; } - if (mode == null) { - throw new ForumException("Mode is required."); - } // get sessionId from HttpServletRequest Long sessionId = WebUtil.readLongParam(request, AttributeNames.PARAM_TOOL_SESSION_ID); @@ -603,7 +602,7 @@ List msgDtoList = forumService.getTopicThread(rootTopicId); updateMesssageFlag(msgDtoList); request.setAttribute(ForumConstants.AUTHORING_TOPIC_THREAD, msgDtoList); - request.setAttribute(ForumConstants.ATTR_SESSION_MAP_ID,WebUtil.readLongParam(request,ForumConstants.ATTR_SESSION_MAP_ID)); + request.setAttribute(ForumConstants.ATTR_SESSION_MAP_ID,WebUtil.readStrParam(request,ForumConstants.ATTR_SESSION_MAP_ID)); return mapping.findForward("success"); } Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java =================================================================== diff -u -rbd383652fb10a2e82b00cbcc2ed08ac02183b1d3 -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java (.../MonitoringAction.java) (revision bd383652fb10a2e82b00cbcc2ed08ac02183b1d3) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java (.../MonitoringAction.java) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -72,6 +72,7 @@ import org.lamsfoundation.lams.util.MessageService; import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.util.AttributeNames; +import org.lamsfoundation.lams.web.util.SessionMap; import org.springframework.web.context.WebApplicationContext; import org.springframework.web.context.support.WebApplicationContextUtils; @@ -84,9 +85,7 @@ private class SessionDTOComparator implements Comparator{ public int compare(SessionDTO o1, SessionDTO o2) { if(o1 != null && o2 != null){ - int c = o1.getSessionName().compareTo(o2.getSessionName()); - //to ensure session can be put into map even they have duplicated name. - return c==0?1:c; + return o1.getSessionName().compareTo(o2.getSessionName()); }else if(o1 != null) return 1; else @@ -97,16 +96,16 @@ private class ForumUserComparator implements Comparator{ public int compare(ForumUser o1, ForumUser o2) { if(o1 != null && o2 != null){ - int c = o1.getLoginName().compareTo(o2.getLoginName()); - //to ensure ForumUser can be put into map even they have duplicated name. - return c==0?1:c; + return o1.getLoginName().compareTo(o2.getLoginName()); }else if(o1 != null) return 1; else return -1; } } - + /** + * Action method entry. + */ public final ActionForward execute(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { @@ -138,6 +137,7 @@ if(param.equals("releaseMark")) return releaseMark(mapping, form, request, response); + // ***************** Miscellaneous ******************** if (param.equals("viewTopic")) { return viewTopic(mapping, form, request, response); @@ -152,13 +152,6 @@ */ private ActionForward init(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { - // read in parameters and set session attributes. - Long toolContentID = new Long(WebUtil.readLongParam(request, - AttributeNames.PARAM_TOOL_CONTENT_ID)); - request.getSession().setAttribute(AttributeNames.PARAM_TOOL_CONTENT_ID, - toolContentID); - request.getSession().setAttribute(AttributeNames.PARAM_MODE, - ToolAccessMode.TEACHER); // perform the actions for all the tabs. doTabs(mapping, form, request, response); @@ -509,10 +502,9 @@ */ private ActionForward viewActivity(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { - Long contentId = (Long) request.getSession().getAttribute( - AttributeNames.PARAM_TOOL_CONTENT_ID); + Long toolContentID = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); forumService = getForumService(); - Forum forum = forumService.getForumByContentId(contentId); + Forum forum = forumService.getForumByContentId(toolContentID); // if can not find out forum, echo back error message if (forum == null) { ActionErrors errors = new ActionErrors(); @@ -543,11 +535,10 @@ private ActionForward viewInstructions(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { - Long contentId = (Long) request.getSession().getAttribute( - AttributeNames.PARAM_TOOL_CONTENT_ID); - + Long toolContentID = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); + forumService = getForumService(); - Forum forum = forumService.getForumByContentId(contentId); + Forum forum = forumService.getForumByContentId(toolContentID); // if can not find out forum, echo back error message if (forum == null) { ActionErrors errors = new ActionErrors(); @@ -575,15 +566,14 @@ */ private ActionForward statistic(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { - Long contentID = (Long) request.getSession().getAttribute( - AttributeNames.PARAM_TOOL_CONTENT_ID); - + Long toolContentID = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); + forumService = getForumService(); Map sessionTopicsMap = new TreeMap>(this.new SessionDTOComparator()); Map sessionAvaMarkMap = new HashMap(); Map sessionTotalMsgMap = new HashMap(); - List sessList = forumService.getSessionsByContentId(contentID); + List sessList = forumService.getSessionsByContentId(toolContentID); Iterator sessIter = sessList.iterator(); while (sessIter.hasNext()) { ForumToolSession session = (ForumToolSession) sessIter.next(); @@ -689,11 +679,10 @@ */ private ActionForward userList(ActionMapping mapping, HttpServletRequest request) { - Long contentID = (Long) request.getSession().getAttribute( - AttributeNames.PARAM_TOOL_CONTENT_ID); + Long toolContentID = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); forumService = getForumService(); - List sessionsList = forumService.getSessionsByContentId(contentID); + List sessionsList = forumService.getSessionsByContentId(toolContentID); Map sessionUsersMap = new TreeMap(this.new SessionDTOComparator()); // build a map with all users in the submitFilesSessionList @@ -736,14 +725,15 @@ private Map getTopicsSortedByAuthor(List topicList) { Map> topicsByUser = new TreeMap(this.new ForumUserComparator()); Iterator iter = topicList.iterator(); + forumService = getForumService(); while (iter.hasNext()) { MessageDTO dto = (MessageDTO) iter.next(); dto.getMessage().getReport(); - List list = (List) topicsByUser - .get(dto.getMessage().getCreatedBy()); + ForumUser user = (ForumUser) dto.getMessage().getCreatedBy().clone(); + List list = (List) topicsByUser.get(user); if (list == null) { list = new ArrayList(); - topicsByUser.put(dto.getMessage().getCreatedBy(), list); + topicsByUser.put(user, list); } list.add(dto); } Index: lams_tool_forum/web/jsps/authoring/advance.jsp =================================================================== diff -u -r27d386f3472e12afab03d53dfde3ed9b1c9a44d3 -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/authoring/advance.jsp (.../advance.jsp) (revision 27d386f3472e12afab03d53dfde3ed9b1c9a44d3) +++ lams_tool_forum/web/jsps/authoring/advance.jsp (.../advance.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -28,6 +28,26 @@ + + + + + + + + + + + + + + + +

+ + + + @@ -68,22 +88,7 @@ 10 - - - - - - - - - - - - - - - Index: lams_tool_forum/web/jsps/learning/message/topicview.jsp =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/learning/message/topicview.jsp (.../topicview.jsp) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/web/jsps/learning/message/topicview.jsp (.../topicview.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -7,7 +7,7 @@ - + @@ -18,7 +18,7 @@ - + - @@ -29,10 +29,10 @@ - + - + @@ -41,12 +41,17 @@ - - - - - - + + + + + + + + + + + @@ -80,13 +85,13 @@ - + - + @@ -95,14 +100,14 @@ - + - + - + Index: lams_tool_forum/web/jsps/learning/viewforum.jsp =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/learning/viewforum.jsp (.../viewforum.jsp) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/web/jsps/learning/viewforum.jsp (.../viewforum.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -34,7 +34,7 @@ - + Index: lams_tool_forum/web/jsps/learning/viewtopic.jsp =================================================================== diff -u -r5e9e3b9c895e932ff86edb7a64cf4b81f59f766c -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/learning/viewtopic.jsp (.../viewtopic.jsp) (revision 5e9e3b9c895e932ff86edb7a64cf4b81f59f766c) +++ lams_tool_forum/web/jsps/learning/viewtopic.jsp (.../viewtopic.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -22,7 +22,7 @@

- + Index: lams_tool_forum/web/jsps/monitoring/summary.jsp =================================================================== diff -u -rbd383652fb10a2e82b00cbcc2ed08ac02183b1d3 -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/monitoring/summary.jsp (.../summary.jsp) (revision bd383652fb10a2e82b00cbcc2ed08ac02183b1d3) +++ lams_tool_forum/web/jsps/monitoring/summary.jsp (.../summary.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -48,7 +48,6 @@ - + + + - - -
@@ -94,7 +93,7 @@
- + Index: lams_tool_forum/web/jsps/monitoring/viewmarks.jsp =================================================================== diff -u -rbd383652fb10a2e82b00cbcc2ed08ac02183b1d3 -r07bc909cfe122031c6236b32088858d4cd295fe9 --- lams_tool_forum/web/jsps/monitoring/viewmarks.jsp (.../viewmarks.jsp) (revision bd383652fb10a2e82b00cbcc2ed08ac02183b1d3) +++ lams_tool_forum/web/jsps/monitoring/viewmarks.jsp (.../viewmarks.jsp) (revision 07bc909cfe122031c6236b32088858d4cd295fe9) @@ -24,16 +24,18 @@ + +
+ + , + + + +
- - , - - - -