Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/form/ExtServerCommonForm.java =================================================================== diff -u -rf0924238dddb80210e0e088cda5fe967f66ef979 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/form/ExtServerCommonForm.java (.../ExtServerCommonForm.java) (revision f0924238dddb80210e0e088cda5fe967f66ef979) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/form/ExtServerCommonForm.java (.../ExtServerCommonForm.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -23,10 +23,6 @@ private boolean disabled = false; - private Boolean learnerPresenceAvailable; - - private Boolean learnerImAvailable; - private Boolean liveEditEnabled; private Boolean enableLessonNotifications; @@ -112,22 +108,6 @@ this.disabled = disabled; } - public Boolean getLearnerPresenceAvailable() { - return learnerPresenceAvailable; - } - - public void setLearnerPresenceAvailable(Boolean learnerPresenceAvailable) { - this.learnerPresenceAvailable = learnerPresenceAvailable; - } - - public Boolean getLearnerImAvailable() { - return learnerImAvailable; - } - - public void setLearnerImAvailable(Boolean learnerImAvailable) { - this.learnerImAvailable = learnerImAvailable; - } - public Boolean getLiveEditEnabled() { return liveEditEnabled; } Index: lams_admin/web/integration/extLessonForm.jsp =================================================================== diff -u -r85121f2d5a0394c96ef2ad1859c22b82391279b7 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_admin/web/integration/extLessonForm.jsp (.../extLessonForm.jsp) (revision 85121f2d5a0394c96ef2ad1859c22b82391279b7) +++ lams_admin/web/integration/extLessonForm.jsp (.../extLessonForm.jsp) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -34,20 +34,6 @@ - - -
- - -
- -
- - -
+ Index: lams_admin/web/integration/servermaintain.jsp =================================================================== diff -u -re3a1990532eb6f5524cd15ec1feec08131d9b3d2 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_admin/web/integration/servermaintain.jsp (.../servermaintain.jsp) (revision e3a1990532eb6f5524cd15ec1feec08131d9b3d2) +++ lams_admin/web/integration/servermaintain.jsp (.../servermaintain.jsp) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -23,10 +23,6 @@ } }); - $('#learnerPresenceAvailable').change(function(){ - $('#learnerImAvailable').prop('disabled', !$(this).is(':checked')); - }).change(); - // validate signup form on keyup and submit var validator = $("#extServerForm").validate({ validClass: "is-valid", Index: lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringController.java =================================================================== diff -u -rbca8248580df6c46e6a8462d80e4341598cd9f28 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringController.java (.../AuthoringController.java) (revision bca8248580df6c46e6a8462d80e4341598cd9f28) +++ lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringController.java (.../AuthoringController.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -337,7 +337,7 @@ if (learningDesignID != null) { User user = (User) userManagementService.findById(User.class, userID); Lesson lesson = monitoringService.initializeLessonWithoutLDcopy(title, "", learningDesignID, user, null, - false, false, false, false, true, true, false, false, true, null, null); + false, false, false, true, false, false, true, null, null); Organisation organisation = monitoringService.getOrganisation(organisationID); List staffList = new LinkedList<>(); Index: lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java =================================================================== diff -u -rc1e3ca12a9ccb265363e2330dd91ce7bedbcfa35 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java (.../CentralConstants.java) (revision c1e3ca12a9ccb265363e2330dd91ce7bedbcfa35) +++ lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java (.../CentralConstants.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -172,10 +172,6 @@ public static final String PARAM_FILTER_TEXT = "filterText"; - public static final String PARAM_LEARNER_PRESENCE_ENABLE = "learnerSeeOnline"; - - public static final String PARAM_LEARNER_IM_ENABLE = "learnerInstantMessaging"; - public static final String PARAM_ENABLE_NOTIFICATIONS = "enableNotifications"; public static final String PARAM_ALLOW_LEARNER_RESTART = "allowLearnerRestart"; Index: lams_central/src/java/org/lamsfoundation/lams/web/controller/LtiController.java =================================================================== diff -u -r619fd068ec6ea6d9ba25b3c673d52f0418a7d16b -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/src/java/org/lamsfoundation/lams/web/controller/LtiController.java (.../LtiController.java) (revision 619fd068ec6ea6d9ba25b3c673d52f0418a7d16b) +++ lams_central/src/java/org/lamsfoundation/lams/web/controller/LtiController.java (.../LtiController.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -281,8 +281,7 @@ Boolean liveEditEnabled = extServer.getLiveEditEnabled() == null ? false : extServer.getLiveEditEnabled(); Lesson lesson = monitoringService.initializeLesson(title, desc, new Long(ldIdStr), organisation.getOrganisationId(), user.getUserId(), null, false, enableLessonIntro, - extServer.getLearnerPresenceAvailable(), extServer.getLearnerImAvailable(), liveEditEnabled, - extServer.getEnableLessonNotifications(), extServer.getForceLearnerRestart(), + liveEditEnabled, extServer.getEnableLessonNotifications(), extServer.getForceLearnerRestart(), extServer.getAllowLearnerRestart(), extServer.getGradebookOnComplete(), null, null); Long lessonId = lesson.getLessonId(); // 2. create lessonClass for lesson Index: lams_central/src/java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java =================================================================== diff -u -rf3e44aee5373a1233080ea5acd1cb5959bb46544 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/src/java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java (.../LessonManagerServlet.java) (revision f3e44aee5373a1233080ea5acd1cb5959bb46544) +++ lams_central/src/java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java (.../LessonManagerServlet.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -156,13 +156,6 @@ String lastNames = request.getParameter("lastNames"); String emails = request.getParameter("emails"); - String presenceEnableString = WebUtil.readStrParam(request, CentralConstants.PARAM_LEARNER_PRESENCE_ENABLE, - true); - Boolean presenceEnable = presenceEnableString == null ? null : Boolean.valueOf(presenceEnableString); - - String imEnableString = WebUtil.readStrParam(request, CentralConstants.PARAM_LEARNER_IM_ENABLE, true); - Boolean imEnable = imEnableString == null ? null : Boolean.valueOf(imEnableString); - String enableNotificationString = WebUtil.readStrParam(request, CentralConstants.PARAM_ENABLE_NOTIFICATIONS, true); Boolean enableNotifications = enableNotificationString == null ? null @@ -193,25 +186,23 @@ if (method.equals(CentralConstants.METHOD_START)) { ldId = Long.parseLong(ldIdStr); Long lessonId = startLesson(serverId, datetime, hashValue, username, ldId, courseId, title, desc, - enforceAllowLearnerRestart, country, locale, customCSV, presenceEnable, imEnable, - enableNotifications); + enforceAllowLearnerRestart, country, locale, customCSV, enableNotifications); element = document.createElement(CentralConstants.ELEM_LESSON); element.setAttribute(CentralConstants.ATTR_LESSON_ID, lessonId.toString()); } else if (method.equals(CentralConstants.METHOD_PREVIEW)) { ldId = Long.parseLong(ldIdStr); Long lessonId = startPreview(serverId, datetime, hashValue, username, ldId, courseId, title, desc, - country, locale, customCSV, presenceEnable, imEnable); + country, locale, customCSV); element = document.createElement(CentralConstants.ELEM_LESSON); element.setAttribute(CentralConstants.ATTR_LESSON_ID, lessonId.toString()); } else if (method.equals(CentralConstants.METHOD_SCHEDULE)) { ldId = Long.parseLong(ldIdStr); Long lessonId = scheduleLesson(serverId, datetime, hashValue, username, ldId, courseId, title, desc, - enforceAllowLearnerRestart, startDate, country, locale, customCSV, presenceEnable, imEnable, - enableNotifications); + enforceAllowLearnerRestart, startDate, country, locale, customCSV, enableNotifications); element = document.createElement(CentralConstants.ELEM_LESSON); element.setAttribute(CentralConstants.ATTR_LESSON_ID, lessonId.toString()); @@ -393,7 +384,7 @@ private Long startLesson(String serverId, String datetime, String hashValue, String username, long ldId, String courseId, String title, String desc, boolean enforceAllowLearnerRestart, String countryIsoCode, - String langIsoCode, String customCSV, Boolean presenceEnable, Boolean imEnable, Boolean enableNotifications) + String langIsoCode, String customCSV, Boolean enableNotifications) throws RemoteException { try { ExtServer extServer = integrationService.getExtServer(serverId); @@ -407,8 +398,7 @@ // 1. init lesson Lesson lesson = monitoringService.initializeLesson(title, desc, ldId, organisation.getOrganisationId(), user.getUserId(), customCSV, false, false, - presenceEnable == null ? extServer.getLearnerPresenceAvailable() : presenceEnable, - imEnable == null ? extServer.getLearnerImAvailable() : imEnable, extServer.getLiveEditEnabled(), + extServer.getLiveEditEnabled(), enableNotifications == null ? extServer.getEnableLessonNotifications() : enableNotifications, extServer.getForceLearnerRestart(), enforceAllowLearnerRestart ? true : extServer.getAllowLearnerRestart(), @@ -428,8 +418,8 @@ private Long scheduleLesson(String serverId, String datetime, String hashValue, String username, long ldId, String courseId, String title, String desc, boolean enforceAllowLearnerRestart, String startDate, - String countryIsoCode, String langIsoCode, String customCSV, Boolean presenceEnable, Boolean imEnable, - Boolean enableNotifications) throws RemoteException { + String countryIsoCode, String langIsoCode, String customCSV, Boolean enableNotifications) + throws RemoteException { try { ExtServer extServer = integrationService.getExtServer(serverId); Authenticator.authenticate(extServer, datetime, username, hashValue); @@ -439,8 +429,7 @@ // 1. init lesson Lesson lesson = monitoringService.initializeLesson(title, desc, ldId, orgMap.getOrganisation().getOrganisationId(), userMap.getUser().getUserId(), customCSV, false, - false, presenceEnable == null ? extServer.getLearnerPresenceAvailable() : presenceEnable, - imEnable == null ? extServer.getLearnerImAvailable() : imEnable, extServer.getLiveEditEnabled(), + false, extServer.getLiveEditEnabled(), enableNotifications == null ? extServer.getEnableLessonNotifications() : enableNotifications, extServer.getForceLearnerRestart(), enforceAllowLearnerRestart ? true : extServer.getAllowLearnerRestart(), @@ -739,9 +728,8 @@ } private Long startPreview(String serverId, String datetime, String hashValue, String username, Long ldId, - String courseId, String title, String desc, String countryIsoCode, String langIsoCode, String customCSV, - Boolean presenceEnable, Boolean imEnable) throws RemoteException { - + String courseId, String title, String desc, String countryIsoCode, String langIsoCode, String customCSV) + throws RemoteException { try { ExtServer extServer = integrationService.getExtServer(serverId); Authenticator.authenticate(extServer, datetime, username, hashValue); @@ -752,8 +740,7 @@ // 1. init lesson Lesson lesson = monitoringService.initializeLessonForPreview(title, desc, ldId, userId, customCSV, - presenceEnable == null ? extServer.getLearnerPresenceAvailable() : presenceEnable, - imEnable == null ? extServer.getLearnerImAvailable() : imEnable, extServer.getLiveEditEnabled()); + extServer.getLiveEditEnabled()); // 2. create lessonClass for lesson monitoringService.createPreviewClassForLesson(userId, lesson.getLessonId()); Index: lams_central/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r876e644c066e81c2721ffa085fd12f386e2f3bb6 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 876e644c066e81c2721ffa085fd12f386e2f3bb6) +++ lams_central/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -48,7 +48,7 @@ - <%-- only have sidebar and presence in learner main window, not in popup windows --%> + <%-- only have sidebar in learner main window, not in popup windows --%> <%-- Links placed in body instead of head. Ugly, but it works. --%> @@ -215,21 +215,6 @@ } else if ( showControlBar == 2 ) { $('#navcontent').addClass('navcontent'); } - - var presenceEnabledPatch = result.presenceEnabledPatch; - var presenceImEnabled = result.presenceImEnabled; - if ( showIM && (presenceEnabledPatch || presenceImEnabled) ) { - presenceURL = LEARNING_URL+"presenceChat.jsp?presenceEnabledPatch="+presenceEnabledPatch - +"&presenceImEnabled="+presenceImEnabled+"&lessonID="+lessonId; - - presenceURL = presenceURL + "&reloadBootstrap=true"; - - $('#presenceEnabledPatchDiv').load(presenceURL, function( response, status, xhr ) { - if ( status == "error" ) { - alert("Unable to load IM: " + xhr.status); - } - }); - } initWebsocket('commandWebsocket', LEARNING_URL.replace('http', 'ws') + 'commandWebsocket?lessonID=' + lessonId, @@ -379,10 +364,6 @@ - <%-- only have sidebar and presence in learner --%> - -
-
Index: lams_central/web/WEB-INF/tags/Page5.tag =================================================================== diff -u -r81f928586161dd03042b6353f68c7d7b8279ccde -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/web/WEB-INF/tags/Page5.tag (.../Page5.tag) (revision 81f928586161dd03042b6353f68c7d7b8279ccde) +++ lams_central/web/WEB-INF/tags/Page5.tag (.../Page5.tag) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -217,21 +217,6 @@ } else if ( showControlBar == 2 ) { $('#navcontent').addClass('navcontent'); } - - var presenceEnabledPatch = result.presenceEnabledPatch; - var presenceImEnabled = result.presenceImEnabled; - if ( showIM && (presenceEnabledPatch || presenceImEnabled) ) { - presenceURL = LEARNING_URL+"presenceChat.jsp?presenceEnabledPatch="+presenceEnabledPatch - +"&presenceImEnabled="+presenceImEnabled+"&lessonID="+lessonId; - - presenceURL = presenceURL + "&reloadBootstrap=true"; - - $('#presenceEnabledPatchDiv').load(presenceURL, function( response, status, xhr ) { - if ( status == "error" ) { - alert("Unable to load IM: " + xhr.status); - } - }); - } initWebsocket('commandWebsocket', LEARNING_URL.replace('http', 'ws') + 'commandWebsocket?lessonID=' + lessonId, @@ -381,10 +366,6 @@ - <%-- only have sidebar and presence in learner --%> - -
-
Index: lams_central/web/addLesson.jsp =================================================================== diff -u -r1b10f714f1b19a4a448ab215fdab8e469ac2fd91 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/web/addLesson.jsp (.../addLesson.jsp) (revision 1b10f714f1b19a4a448ab215fdab8e469ac2fd91) +++ lams_central/web/addLesson.jsp (.../addLesson.jsp) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -273,20 +273,6 @@
-
- -
- -
- -
- Index: lams_central/web/includes/javascript/addLesson.js =================================================================== diff -u -r03d58ffa7fa472912057c4a91a9acd1e7f8ffb5e -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/web/includes/javascript/addLesson.js (.../addLesson.js) (revision 03d58ffa7fa472912057c4a91a9acd1e7f8ffb5e) +++ lams_central/web/includes/javascript/addLesson.js (.../addLesson.js) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -222,10 +222,6 @@ } }); - $('#presenceEnableField').change(function(){ - $('#imEnableField').prop('disabled', !$(this).is(':checked')); - }); - $('#schedulingEnableField').change(function(){ if ($(this).is(':checked')) { $('#scheduleStartTime').show('slow'); Index: lams_central/web/includes/javascript/progressBar.js =================================================================== diff -u -r973a921a8f59a78026f54c84d6b04e2378bac517 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_central/web/includes/javascript/progressBar.js (.../progressBar.js) (revision 973a921a8f59a78026f54c84d6b04e2378bac517) +++ lams_central/web/includes/javascript/progressBar.js (.../progressBar.js) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -5,7 +5,6 @@ isHorizontalBar = isHorizontalBar || false, hasContentFrame = hasContentFrame || true, hasDialog = hasDialog || false, - presenceEnabled = presenceEnabled || false, REVIEW_ACTIVITY_TITLE = REVIEW_ACTIVITY_TITLE || 'Review activity', //SVG paths for activity shapes Index: lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20240115.sql =================================================================== diff -u --- lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20240115.sql (revision 0) +++ lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20240115.sql (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -0,0 +1,20 @@ +-- Turn off autocommit, so nothing is committed if there is an error +SET AUTOCOMMIT = 0; +SET FOREIGN_KEY_CHECKS=0; +-- Put all sql statements below here + +-- LDEV-5428 Remove lesson presence and chat +ALTER TABLE lams_ext_server_org_map DROP COLUMN learner_im_avail, + DROP COLUMN learner_presence_avail; +ALTER TABLE lams_lesson DROP COLUMN learner_im_avail, + DROP COLUMN learner_presence_avail; + +DROP TABLE lams_presence_user; +DROP TABLE lams_presence_chat_msgs; + +-- Put all sql statements above here + +-- If there were no errors, commit and restore autocommit to on +COMMIT; +SET AUTOCOMMIT = 1; +SET FOREIGN_KEY_CHECKS=1; Index: lams_common/src/java/org/lamsfoundation/lams/integration/ExtServer.java =================================================================== diff -u -r1c496f87123d1d2277609837e427b77c18874a79 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/integration/ExtServer.java (.../ExtServer.java) (revision 1c496f87123d1d2277609837e427b77c18874a79) +++ lams_common/src/java/org/lamsfoundation/lams/integration/ExtServer.java (.../ExtServer.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -82,12 +82,6 @@ @Column(name = "add_staff_to_all_lessons") private boolean addStaffToAllLessons; - @Column(name = "learner_presence_avail") - private Boolean learnerPresenceAvailable; - - @Column(name = "learner_im_avail") - private Boolean learnerImAvailable; - @Column(name = "live_edit_enabled") private Boolean liveEditEnabled; @@ -376,22 +370,6 @@ return getServerTypeId().intValue() == ExtServer.LTI_CONSUMER_SERVER_TYPE; } - public Boolean getLearnerPresenceAvailable() { - return learnerPresenceAvailable; - } - - public void setLearnerPresenceAvailable(Boolean learnerPresenceAvailable) { - this.learnerPresenceAvailable = learnerPresenceAvailable; - } - - public Boolean getLearnerImAvailable() { - return learnerImAvailable; - } - - public void setLearnerImAvailable(Boolean learnerImAvailable) { - this.learnerImAvailable = learnerImAvailable; - } - public Boolean getLiveEditEnabled() { return liveEditEnabled; } Index: lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java =================================================================== diff -u -rdd2d980b18a138b7fbde17e7d21e911e9be435d9 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java (.../Lesson.java) (revision dd2d980b18a138b7fbde17e7d21e911e9be435d9) +++ lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java (.../Lesson.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -226,12 +226,6 @@ @Column(name = "locked_for_edit") private boolean lockedForEdit = false; - @Column(name = "learner_presence_avail") - private boolean learnerPresenceAvailable = false; - - @Column(name = "learner_im_avail") - private boolean learnerImAvailable = false; - @Column(name = "live_edit_enabled") private boolean liveEditEnabled = false; @@ -287,22 +281,20 @@ */ public Lesson(String name, String description, Date createDateTime, User user, Integer lessonStateId, Integer previousLessonStateId, LearningDesign learningDesign, Set learnerProgresses, - Boolean enableLessonIntro, Boolean displayDesignImage, Boolean learnerPresenceAvailable, - Boolean learnerImAvailable, Boolean liveEditEnabled, Boolean enableLessonNotifications, + Boolean enableLessonIntro, Boolean displayDesignImage, Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysTolessonFinish) { - this(null, name, description, createDateTime, null, null, user, lessonStateId, previousLessonStateId, - enableLessonIntro, displayDesignImage, false, learningDesign, null, null, learnerProgresses, - learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, enableLessonNotifications, - forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysTolessonFinish); + this(null, name, description, createDateTime, null, null, user, lessonStateId, previousLessonStateId, enableLessonIntro, displayDesignImage, false, + learningDesign, null, null, learnerProgresses, liveEditEnabled, enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, + gradebookOnComplete, scheduledNumberDaysTolessonFinish); } /** full constructor */ public Lesson(Long lessonId, String name, String description, Date createDateTime, Date startDateTime, Date endDateTime, User user, Integer lessonStateId, Integer previousLessonStateId, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean lockedForEdit, LearningDesign learningDesign, LessonClass lessonClass, Organisation organisation, Set learnerProgresses, - Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled, + Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish) { this.lessonId = lessonId; @@ -316,8 +308,6 @@ this.previousLessonStateId = previousLessonStateId; this.enableLessonIntro = enableLessonIntro != null ? enableLessonIntro : false; this.displayDesignImage = displayDesignImage != null ? displayDesignImage : false; - this.learnerPresenceAvailable = learnerPresenceAvailable != null ? learnerPresenceAvailable : false; - this.learnerImAvailable = learnerImAvailable != null ? learnerImAvailable : false; this.lockedForEdit = false; this.learningDesign = learningDesign; this.lessonClass = lessonClass; @@ -344,14 +334,13 @@ * @return the lesson created. */ public static Lesson createNewLessonWithoutClass(String lessonName, String lessonDescription, User user, - LearningDesign ld, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean learnerPresenceAvailable, - Boolean learnerImAvailable, Boolean liveEditEnabled, Boolean enableLessonNotifications, + LearningDesign ld, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish) { return new Lesson(lessonName, lessonDescription, new Date(System.currentTimeMillis()), user, Lesson.CREATED, null, ld, new HashSet(), enableLessonIntro, displayDesignImage, - learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, enableLessonNotifications, - forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysToLessonFinish); + liveEditEnabled, enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, + gradebookOnComplete, scheduledNumberDaysToLessonFinish); } // --------------------------------------------------------------------- @@ -640,22 +629,6 @@ this.lockedForEdit = lockedForEdit; } - public boolean getLearnerPresenceAvailable() { - return learnerPresenceAvailable; - } - - public void setLearnerPresenceAvailable(boolean learnerPresenceAvailable) { - this.learnerPresenceAvailable = learnerPresenceAvailable; - } - - public boolean getLearnerImAvailable() { - return learnerImAvailable; - } - - public void setLearnerImAvailable(boolean learnerImAvailable) { - this.learnerImAvailable = learnerImAvailable; - } - public boolean getLiveEditEnabled() { return liveEditEnabled; } Index: lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDTO.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDTO.java (.../LessonDTO.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDTO.java (.../LessonDTO.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -56,8 +56,6 @@ private String createDateTimeString; private Date startDateTime; private Long learningDesignID; - private Boolean learnerPresenceAvailable; - private Boolean learnerImAvailable; private Boolean displayMonitor; //--------------------------------------------------------------------- @@ -78,8 +76,6 @@ this.createDateTime = lesson.getCreateDateTime(); this.createDateTimeString = lesson.getCreateDateTime().toString(); this.startDateTime = lesson.getStartDateTime(); - this.learnerPresenceAvailable = lesson.getLearnerPresenceAvailable(); - this.learnerImAvailable = lesson.getLearnerImAvailable(); } //--------------------------------------------------------------------- @@ -141,14 +137,6 @@ return learningDesignID; } - public Boolean getLearnerPresenceAvailable() { - return learnerPresenceAvailable; - } - - public Boolean getLearnerImAvailable() { - return learnerImAvailable; - } - public Boolean getDisplayMonitor() { return displayMonitor; } @@ -174,8 +162,6 @@ sb.append("createDateTime='" + getCreateDateTime() + "'; "); sb.append("createDateTimeString='" + getCreateDateTimeString() + "'; "); sb.append("startDateTime='" + getStartDateTime() + "'; "); - sb.append("learnerPresenceAvailable='" + getLearnerPresenceAvailable() + "'; "); - sb.append("learnerImAvailable='" + getLearnerImAvailable() + "'; "); sb.append("displayMonitor='" + getDisplayMonitor() + "'; "); return sb.toString(); } Index: lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDetailsDTO.java =================================================================== diff -u -r1c7084d36b0332efa632440c93c18308adc27c71 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDetailsDTO.java (.../LessonDetailsDTO.java) (revision 1c7084d36b0332efa632440c93c18308adc27c71) +++ lams_common/src/java/org/lamsfoundation/lams/lesson/dto/LessonDetailsDTO.java (.../LessonDetailsDTO.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -57,8 +57,6 @@ private Boolean lockedForEdit; private Integer lockedForEditUserId; private String lockedForEditUsername; - private Boolean learnerPresenceAvailable; - private Boolean learnerImAvailable; private Boolean liveEditEnabled; private Boolean isPreview; private String encodedLessonID; @@ -117,9 +115,6 @@ this.numberPossibleLearners = lesson.getAllLearners().size(); this.numberStartedLearners = 0; - this.learnerPresenceAvailable = lesson.getLearnerPresenceAvailable(); - this.learnerImAvailable = lesson.getLearnerImAvailable(); - this.liveEditEnabled = lesson.getLiveEditEnabled(); this.lockedForEdit = lesson.getLockedForEdit(); @@ -278,14 +273,6 @@ return numberPossibleLearners; } - public Boolean getLearnerPresenceAvailable() { - return learnerPresenceAvailable; - } - - public Boolean getLearnerImAvailable() { - return learnerImAvailable; - } - public Boolean getLockedForEdit() { return lockedForEdit; } @@ -383,14 +370,6 @@ this.numberPossibleLearners = numberPossibleLearners; } - public void setLearnerPresenceAvailable(Boolean learnerPresenceAvailable) { - this.learnerPresenceAvailable = learnerPresenceAvailable; - } - - public void setLearnerImAvailable(Boolean learnerImAvailable) { - this.learnerImAvailable = learnerImAvailable; - } - public void setLockedForEdit(Boolean lockedForEdit) { this.lockedForEdit = lockedForEdit; } Index: lams_common/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java =================================================================== diff -u -r9977d4544bd83f5f9a17c0013448b289fc077aa7 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java (.../IMonitoringService.java) (revision 9977d4544bd83f5f9a17c0013448b289fc077aa7) +++ lams_common/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java (.../IMonitoringService.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -48,10 +48,9 @@ * Intialise lesson without creating Learning Design copy, i.e. the original LD will be used. */ Lesson initializeLessonWithoutLDcopy(String lessonName, String lessonDescription, long learningDesignID, User user, - String customCSV, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean learnerPresenceAvailable, - Boolean learnerImAvailable, Boolean liveEditEnabled, Boolean enableLessonNotifications, - Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, - Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson); + String customCSV, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean liveEditEnabled, + Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, + Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson); /** *

@@ -71,40 +70,40 @@ *

* * @param lessonName - * the name of the lesson + * the name of the lesson * @param lessonDescription - * the description of the lesson. + * the description of the lesson. * @param learningDesignId - * the selected learning design + * the selected learning design * @param organisationId - * the copied sequence will be put in the default runtime sequence folder for this org, if such a folder exists. + * the copied sequence will be put in the default runtime sequence folder for this org, if such a folder + * exists. * @param userId - * the user who want to create this lesson. + * the user who want to create this lesson. * @param customCSV - * the custom comma separated values to be used by toolAdapters + * the custom comma separated values to be used by toolAdapters * @param enableLessonIntro - * display an intro page to the lesson + * display an intro page to the lesson * @param displayDesignImage - * display the design image or not + * display the design image or not * @param enableNotifications - * enable "email notifications" link for the current lesson + * enable "email notifications" link for the current lesson * @param numberDaysToLessonFinish - * number of days the lesson will be available to user since he starts it. (lesson finish scheduling feature) + * number of days the lesson will be available to user since he starts it. (lesson finish scheduling + * feature) * @return the lesson initialized. */ Lesson initializeLesson(String lessonName, String lessonDescription, long learningDesignId, Integer organisationId, Integer userID, String customCSV, Boolean enableLessonIntro, Boolean displayDesignImage, - Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled, - Boolean enableNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, + Boolean liveEditEnabled, Boolean enableNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer numberDaysToLessonFinish, Long precedingLessonId); /** * Create new lesson according to the learning design specified by the user, but for a preview session rather than a * normal learning session. The design is not assigned to any workspace folder. */ Lesson initializeLessonForPreview(String lessonName, String lessonDescription, long learningDesignId, - Integer userID, String customCSV, Boolean learnerPresenceAvailable, Boolean learnerImAvailable, - Boolean liveEditEnabled); + Integer userID, String customCSV, Boolean liveEditEnabled); /** * Setup the lesson class and organization for a lesson according to the input from monitoring GUI interface. Index: lams_common/src/java/org/lamsfoundation/lams/web/util/AttributeNames.java =================================================================== diff -u -rbca8248580df6c46e6a8462d80e4341598cd9f28 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_common/src/java/org/lamsfoundation/lams/web/util/AttributeNames.java (.../AttributeNames.java) (revision bca8248580df6c46e6a8462d80e4341598cd9f28) +++ lams_common/src/java/org/lamsfoundation/lams/web/util/AttributeNames.java (.../AttributeNames.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -67,10 +67,6 @@ public static final String PARAM_LESSON_ID = "lessonID"; public static final String PARAM_DIRECTORY_NAME = "directoryName"; public static final String PARAM_FILENAME = "filename"; - public static final String PARAM_PRESENCE_ENABLED = "presenceEnabledPatch"; - // PARAM_PRESENCE_ENABLED = "presenceEnabledPatch" : strange name used to avoid Java overwriting values in its a - // hashmap used in learner action in HomeAction.java - public static final String PARAM_PRESENCE_IM_ENABLED = "presenceImEnabled"; public static final String PARAM_CURRENT_TAB = "currentTab"; public static final String PARAM_CUSTOM_CSV = "customCSV"; public static final String PARAM_EXT_LMS_ID = "extlmsid"; Index: lams_learning/build.xml =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_learning/build.xml (.../build.xml) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_learning/build.xml (.../build.xml) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -18,10 +18,6 @@ ${ant.project.name}: Copying additional Java classes to WAR - Index: lams_learning/src/java/org/lamsfoundation/lams/learning/learningApplicationContext.xml =================================================================== diff -u -r4f526e3455fe0ed91e6a838c833f1cd916844b98 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_learning/src/java/org/lamsfoundation/lams/learning/learningApplicationContext.xml (.../learningApplicationContext.xml) (revision 4f526e3455fe0ed91e6a838c833f1cd916844b98) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/learningApplicationContext.xml (.../learningApplicationContext.xml) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -109,27 +109,6 @@ PROPAGATION_REQUIRED - - - - - - - - - - - - - - - - - PROPAGATION_REQUIRED - PROPAGATION_REQUIRED - PROPAGATION_REQUIRED - - @@ -150,12 +129,8 @@ PROPAGATION_REQUIRED - + - - - - Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/PresenceWebsocketServer.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/dao/IPresenceChatDAO.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/dao/hibernate/PresenceChatDAO.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/model/PresenceChatMessage.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/model/PresenceChatUser.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/service/IPresenceChatService.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/src/java/org/lamsfoundation/lams/learning/presence/service/PresenceChatService.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java =================================================================== diff -u -r81f928586161dd03042b6353f68c7d7b8279ccde -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java (.../LearnerController.java) (revision 81f928586161dd03042b6353f68c7d7b8279ccde) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java (.../LearnerController.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -23,15 +23,28 @@ package org.lamsfoundation.lams.learning.web.controller; -import com.fasterxml.jackson.core.JsonProcessingException; -import com.fasterxml.jackson.databind.node.JsonNodeFactory; -import com.fasterxml.jackson.databind.node.ObjectNode; +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.util.Calendar; +import java.util.Date; +import java.util.GregorianCalendar; +import java.util.HashMap; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Map.Entry; +import java.util.TimeZone; + +import javax.servlet.ServletException; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import javax.servlet.http.HttpSession; + import org.apache.log4j.Logger; import org.lamsfoundation.lams.flux.FluxMap; import org.lamsfoundation.lams.flux.FluxRegistry; import org.lamsfoundation.lams.gradebook.GradebookUserActivity; import org.lamsfoundation.lams.gradebook.service.IGradebookService; -import org.lamsfoundation.lams.learning.presence.PresenceWebsocketServer; import org.lamsfoundation.lams.learning.service.ILearnerFullService; import org.lamsfoundation.lams.learning.web.util.ActivityMapping; import org.lamsfoundation.lams.learning.web.util.LearningWebUtil; @@ -73,24 +86,13 @@ import org.springframework.web.bind.annotation.RequestParam; import org.springframework.web.bind.annotation.ResponseBody; import org.springframework.web.util.UriUtils; -import reactor.core.publisher.Flux; -import javax.servlet.ServletException; -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; -import javax.servlet.http.HttpSession; -import java.io.IOException; -import java.nio.charset.StandardCharsets; -import java.util.Calendar; -import java.util.Date; -import java.util.GregorianCalendar; -import java.util.HashMap; -import java.util.List; -import java.util.Locale; -import java.util.Map; -import java.util.Map.Entry; -import java.util.TimeZone; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.JsonNodeFactory; +import com.fasterxml.jackson.databind.node.ObjectNode; +import reactor.core.publisher.Flux; + /** *

* The action servlet that interacts with learner to start a lams learner module, join a user to the lesson and allows a @@ -375,16 +377,6 @@ return responseJSON; } - @RequestMapping("/getPresenceChatActiveUserCount") - @ResponseBody - public String getPresenceChatActiveUserCount(HttpServletRequest request, HttpServletResponse response) - throws IOException { - Long lessonId = WebUtil.readLongParam(request, AttributeNames.PARAM_LESSON_ID); - int count = PresenceWebsocketServer.getActiveUserCount(lessonId); - - return String.valueOf(count); - } - /** * Forces a move to a destination Activity in the learning sequence, redirecting to the new page rather. */ @@ -537,8 +529,6 @@ responseJSON.put(AttributeNames.PARAM_LESSON_ID, lesson.getLessonId()); responseJSON.put(AttributeNames.PARAM_TITLE, lesson.getLessonName()); responseJSON.put("allowRestart", lesson.getAllowLearnerRestart()); - responseJSON.put(AttributeNames.PARAM_PRESENCE_ENABLED, lesson.getLearnerPresenceAvailable()); - responseJSON.put(AttributeNames.PARAM_PRESENCE_IM_ENABLED, lesson.getLearnerImAvailable()); response.setContentType("application/json;charset=utf-8"); Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/web/css/presence.scss'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/web/includes/javascript/presence.js'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 0993bbd812a25ddb84feec64dd0e4847ce32d164 refers to a dead (removed) revision in file `lams_learning/web/presenceChat.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringFullService.java =================================================================== diff -u -r50ce17b539bba75dc92c9799db20a66fa118e788 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringFullService.java (.../IMonitoringFullService.java) (revision 50ce17b539bba75dc92c9799db20a66fa118e788) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringFullService.java (.../IMonitoringFullService.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -31,30 +31,6 @@ /** Get the message service, which gives access to the I18N text */ MessageService getMessageService(); - /** - * Set whether or not the learner presence button is available in monitor. Checks that the user is a staff member of - * this lesson before updating. - * - * @param lessonId - * @param userId - * @param learnerPresenceAvailable - * @return new value for learnerPresenceAvailable. Normally will be same as input parameter, will only be different - * if the value cannot be updated for some reason. - */ - Boolean togglePresenceAvailable(long lessonId, Integer userId, Boolean learnerPresenceAvailable); - - /** - * Set whether or not the learner IM button is available in monitor. Checks that the user is a staff member of this - * lesson before updating. - * - * @param lessonId - * @param userId - * @param learnerImPresenceAvailable - * @return new value for learnerPresenceImAvailable. Normally will be same as input parameter, will only be - * different if the value cannot be updated for some reason. - */ - Boolean togglePresenceImAvailable(long lessonId, Integer userId, Boolean learnerPresenceImAvailable); - /** Set whether or not to display the gradebook activity scores at the end of a lesson */ Boolean toggleGradebookOnComplete(long lessonId, Integer userId, Boolean gradebookOnComplete); Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java =================================================================== diff -u -r5ac2673214d4a3e9d831e1c468e235015b8bd0b2 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision 5ac2673214d4a3e9d831e1c468e235015b8bd0b2) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -359,10 +359,9 @@ @Override public Lesson initializeLesson(String lessonName, String lessonDescription, long learningDesignId, Integer organisationId, Integer userID, String customCSV, Boolean enableLessonIntro, - Boolean displayDesignImage, Boolean learnerPresenceAvailable, Boolean learnerImAvailable, - Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, - Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, - Long precedingLessonId) { + Boolean displayDesignImage, Boolean liveEditEnabled, Boolean enableLessonNotifications, + Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, + Integer scheduledNumberDaysToLessonFinish, Long precedingLessonId) { securityService.ensureGroupMonitor(organisationId, userID, "intializeLesson"); @@ -391,9 +390,8 @@ User user = userID != null ? (User) baseDAO.find(User.class, userID) : null; Lesson initializedLesson = initializeLesson(lessonName, lessonDescription, originalLearningDesign, user, runSeqFolder, LearningDesign.COPY_TYPE_LESSON, customCSV, enableLessonIntro, displayDesignImage, - learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, enableLessonNotifications, - forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysToLessonFinish, - precedingLesson); + liveEditEnabled, enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, + gradebookOnComplete, scheduledNumberDaysToLessonFinish, precedingLesson); logLessonStateChange(LogEvent.TYPE_TEACHER_LESSON_CREATE, initializedLesson, userID, null, initializedLesson.getLessonStateId()); @@ -402,8 +400,7 @@ @Override public Lesson initializeLessonForPreview(String lessonName, String lessonDescription, long learningDesignId, - Integer userID, String customCSV, Boolean learnerPresenceAvailable, Boolean learnerImAvailable, - Boolean liveEditEnabled) { + Integer userID, String customCSV, Boolean liveEditEnabled) { LearningDesign originalLearningDesign = learningDesignDAO.getLearningDesignById(new Long(learningDesignId)); if (originalLearningDesign == null) { throw new MonitoringServiceException( @@ -412,14 +409,13 @@ User user = userID != null ? (User) baseDAO.find(User.class, userID) : null; return initializeLesson(lessonName, lessonDescription, originalLearningDesign, user, null, - LearningDesign.COPY_TYPE_PREVIEW, customCSV, false, false, learnerPresenceAvailable, learnerImAvailable, - liveEditEnabled, true, false, false, false, null, null); + LearningDesign.COPY_TYPE_PREVIEW, customCSV, false, false, liveEditEnabled, true, false, false, false, + null, null); } @Override public Lesson initializeLessonWithoutLDcopy(String lessonName, String lessonDescription, long learningDesignID, - User user, String customCSV, Boolean enableLessonIntro, Boolean displayDesignImage, - Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled, + User user, String customCSV, Boolean enableLessonIntro, Boolean displayDesignImage, Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson) { LearningDesign learningDesign = learningDesignDAO.getLearningDesignById(learningDesignID); @@ -428,9 +424,8 @@ "Learning design for id=" + learningDesignID + " is missing. Unable to initialize lesson."); } Lesson lesson = createNewLesson(lessonName, lessonDescription, user, learningDesign, enableLessonIntro, - displayDesignImage, learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, - enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, - scheduledNumberDaysToLessonFinish, precedingLesson); + displayDesignImage, liveEditEnabled, enableLessonNotifications, forceLearnerRestart, + allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysToLessonFinish, precedingLesson); logLessonGeneralChange(LogEvent.TYPE_TEACHER_LESSON_CREATE, user != null ? user.getUserId() : null, lesson != null ? lesson.getLessonId() : null, MonitoringService.AUDIT_LESSON_CREATED_KEY, new Object[] { lessonName, learningDesign.getTitle(), learningDesign.getLearningDesignId() }); @@ -439,10 +434,9 @@ private Lesson initializeLesson(String lessonName, String lessonDescription, LearningDesign originalLearningDesign, User user, WorkspaceFolder workspaceFolder, int copyType, String customCSV, Boolean enableLessonIntro, - Boolean displayDesignImage, Boolean learnerPresenceAvailable, Boolean learnerImAvailable, - Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, - Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, - Lesson precedingLesson) { + Boolean displayDesignImage, Boolean liveEditEnabled, Boolean enableLessonNotifications, + Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, + Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson) { // copy the current learning design LearningDesign copiedLearningDesign = authoringService.copyLearningDesign(originalLearningDesign, new Integer(copyType), user, workspaceFolder, true, null, customCSV); @@ -457,9 +451,8 @@ } Lesson lesson = createNewLesson(title, lessonDescription, user, copiedLearningDesign, enableLessonIntro, - displayDesignImage, learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, - enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, - scheduledNumberDaysToLessonFinish, precedingLesson); + displayDesignImage, liveEditEnabled, enableLessonNotifications, forceLearnerRestart, + allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysToLessonFinish, precedingLesson); logLessonGeneralChange(LogEvent.TYPE_TEACHER_LESSON_CREATE, user != null ? user.getUserId() : null, lesson != null ? lesson.getLessonId() : null, MonitoringService.AUDIT_LESSON_CREATED_KEY, new Object[] { lessonName, copiedLearningDesign.getTitle(), @@ -1231,24 +1224,6 @@ } @Override - public Boolean togglePresenceAvailable(long lessonId, Integer userId, Boolean presenceAvailable) { - securityService.ensureLessonMonitor(lessonId, userId, "set presence available"); - Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); - requestedLesson.setLearnerPresenceAvailable(presenceAvailable != null ? presenceAvailable : Boolean.FALSE); - lessonDAO.updateLesson(requestedLesson); - return requestedLesson.getLearnerPresenceAvailable(); - } - - @Override - public Boolean togglePresenceImAvailable(long lessonId, Integer userId, Boolean presenceImAvailable) { - securityService.ensureLessonMonitor(lessonId, userId, "set presence instant messaging available"); - Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); - requestedLesson.setLearnerImAvailable(presenceImAvailable != null ? presenceImAvailable : Boolean.FALSE); - lessonDAO.updateLesson(requestedLesson); - return requestedLesson.getLearnerImAvailable(); - } - - @Override public Boolean toggleGradebookOnComplete(long lessonId, Integer userId, Boolean gradebookOnComplete) { securityService.ensureLessonMonitor(lessonId, userId, "set gradebook on complete"); Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); @@ -2144,13 +2119,12 @@ */ private Lesson createNewLesson(String lessonName, String lessonDescription, User user, LearningDesign copiedLearningDesign, Boolean enableLessonIntro, Boolean displayDesignImage, - Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled, - Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, - Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson) { + Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, + Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, + Lesson precedingLesson) { Lesson newLesson = Lesson.createNewLessonWithoutClass(lessonName, lessonDescription, user, copiedLearningDesign, - enableLessonIntro, displayDesignImage, learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, - enableLessonNotifications, forceLearnerRestart, allowLearnerRestart, gradebookOnComplete, - scheduledNumberDaysToLessonFinish); + enableLessonIntro, displayDesignImage, liveEditEnabled, enableLessonNotifications, forceLearnerRestart, + allowLearnerRestart, gradebookOnComplete, scheduledNumberDaysToLessonFinish); if (precedingLesson != null) { HashSet precedingLessons = new HashSet(); precedingLessons.add(precedingLesson); @@ -2859,7 +2833,6 @@ newLesson = this.initializeLesson(lesson.getLessonName(), lesson.getLessonDescription(), lesson.getLearningDesign().getLearningDesignId(), group.getOrganisationId(), creatorId, null, lesson.isEnableLessonIntro(), lesson.isDisplayDesignImage(), - lesson.getLearnerPresenceAvailable(), lesson.getLearnerImAvailable(), lesson.getLiveEditEnabled(), lesson.getEnableLessonNotifications(), lesson.getForceLearnerRestart(), lesson.getAllowLearnerRestart(), lesson.getGradebookOnComplete(), null, null); Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringController.java =================================================================== diff -u -r819399aeee074e740f0756ceafb9fd119073cb88 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringController.java (.../MonitoringController.java) (revision 819399aeee074e740f0756ceafb9fd119073cb88) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringController.java (.../MonitoringController.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -249,8 +249,6 @@ long ldId = WebUtil.readLongParam(request, AttributeNames.PARAM_LEARNINGDESIGN_ID); Integer copyType = WebUtil.readIntParam(request, "copyType", true); String customCSV = request.getParameter("customCSV"); - Boolean learnerPresenceAvailable = WebUtil.readBooleanParam(request, "learnerPresenceAvailable", false); - Boolean learnerImAvailable = WebUtil.readBooleanParam(request, "learnerImAvailable", false); Boolean liveEditEnabled = WebUtil.readBooleanParam(request, "liveEditEnabled", false); Boolean forceRestart = WebUtil.readBooleanParam(request, "forceRestart", false); Boolean allowRestart = WebUtil.readBooleanParam(request, "allowRestart", false); @@ -259,12 +257,12 @@ Lesson newLesson = null; if ((copyType != null) && copyType.equals(LearningDesign.COPY_TYPE_PREVIEW)) { newLesson = monitoringService.initializeLessonForPreview(title, desc, ldId, getUserId(), customCSV, - learnerPresenceAvailable, learnerImAvailable, liveEditEnabled); + liveEditEnabled); } else { try { newLesson = monitoringService.initializeLesson(title, desc, ldId, organisationId, getUserId(), - customCSV, false, false, learnerPresenceAvailable, learnerImAvailable, liveEditEnabled, false, - forceRestart, allowRestart, gradebookOnComplete, null, null); + customCSV, false, false, liveEditEnabled, false, forceRestart, allowRestart, + gradebookOnComplete, null, null); } catch (SecurityException e) { response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the organisation"); return null; @@ -366,8 +364,6 @@ boolean startMonitor = WebUtil.readBooleanParam(request, "startMonitor", false); boolean enableLiveEdit = WebUtil.readBooleanParam(request, "liveEditEnable", false); boolean notificationsEnable = WebUtil.readBooleanParam(request, "notificationsEnable", false); - boolean presenceEnable = WebUtil.readBooleanParam(request, "presenceEnable", false); - boolean imEnable = WebUtil.readBooleanParam(request, "imEnable", false); Integer splitNumberLessons = WebUtil.readIntParam(request, "splitNumberLessons", true); boolean schedulingEnable = WebUtil.readBooleanParam(request, "schedulingEnable", false); Long orgGroupingId = WebUtil.readLongParam(request, "orgGroupingId", true); @@ -445,7 +441,7 @@ Lesson lesson = null; try { lesson = monitoringService.initializeLesson(lessonInstanceName, introDescription, learningDesignID, - organisationId, userId, null, introEnable, introImage, presenceEnable, imEnable, + organisationId, userId, null, introEnable, introImage, enableLiveEdit, notificationsEnable, forceRestart, allowRestart, gradebookOnComplete, timeLimitIndividual, precedingLessonId); @@ -1613,50 +1609,8 @@ } /** - * Set whether or not the presence available button is available in learner. Expects parameters lessonID and - * presenceAvailable. - */ - @RequestMapping(path = "/presenceAvailable", method = RequestMethod.POST) - public String presenceAvailable(HttpServletRequest request, HttpServletResponse response) - throws IOException, ServletException { - Long lessonID = new Long(WebUtil.readLongParam(request, "lessonID")); - Integer userID = getUserId(); - Boolean presenceAvailable = WebUtil.readBooleanParam(request, "presenceAvailable", false); - - try { - monitoringService.togglePresenceAvailable(lessonID, userID, presenceAvailable); - - if (!presenceAvailable) { - monitoringService.togglePresenceImAvailable(lessonID, userID, false); - } - } catch (SecurityException e) { - response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the lesson"); - } - return null; - } - - /** - * Set whether or not the presence available button is available in learner. Expects parameters lessonID and - * presenceImAvailable. - */ - @RequestMapping(path = "/presenceImAvailable", method = RequestMethod.POST) - public String presenceImAvailable(HttpServletRequest request, HttpServletResponse response) - throws IOException, ServletException { - Long lessonID = new Long(WebUtil.readLongParam(request, "lessonID")); - Integer userID = getUserId(); - Boolean presenceImAvailable = WebUtil.readBooleanParam(request, "presenceImAvailable", false); - - try { - monitoringService.togglePresenceImAvailable(lessonID, userID, presenceImAvailable); - } catch (SecurityException e) { - response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the lesson"); - } - return null; - } - - /** * Set whether or not the activity scores / gradebook values are shown to the learner at the end of the lesson. - * Expects parameters lessonID and presenceAvailable. + * Expects parameters lessonID and gradebookOnComplete. */ @RequestMapping(path = "/gradebookOnComplete", method = RequestMethod.POST) public String gradebookOnComplete(HttpServletRequest request, HttpServletResponse response) throws IOException { Index: lams_monitoring/web/css/_monitorLesson_base.scss =================================================================== diff -u -rb2af5118e14e1c212f59996da644bc32001745c1 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/web/css/_monitorLesson_base.scss (.../_monitorLesson_base.scss) (revision b2af5118e14e1c212f59996da644bc32001745c1) +++ lams_monitoring/web/css/_monitorLesson_base.scss (.../_monitorLesson_base.scss) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -205,7 +205,7 @@ display: none; } -#lessonStartDateCell *, #presenceAvailableCount { +#lessonStartDateCell * { display: none; } Index: lams_monitoring/web/includes/javascript/monitorLesson.js =================================================================== diff -u -r81f928586161dd03042b6353f68c7d7b8279ccde -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/web/includes/javascript/monitorLesson.js (.../monitorLesson.js) (revision 81f928586161dd03042b6353f68c7d7b8279ccde) +++ lams_monitoring/web/includes/javascript/monitorLesson.js (.../monitorLesson.js) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -293,61 +293,6 @@ $('#forceBackwardsDialog').modal('hide'); }); - - $('#presenceButton').change(function(){ - var checked = $(this).prop('checked'), - data = { - 'presenceAvailable' : checked, - 'lessonID' : lessonId - }; - data[csrfTokenName] = csrfTokenValue; - $.ajax({ - url : LAMS_URL + 'monitoring/monitoring/presenceAvailable.do', - type : 'POST', - cache : false, - data : data, - success : function() { - // updatePresenceAvailableCount(); - if (checked) { - $('#imButtonWrapper').show(); - showToast(LABELS.LESSON_PRESENCE_ENABLE_ALERT); - } else { - $('#imButtonWrapper, #openImButton').hide(); - $('#imButton').prop('checked', false); - showToast(LABELS.LESSON_PRESENCE_DISABLE_ALERT); - } - } - }); - }); - - // sets instant messaging availability - $('#imButton').click(function(){ - var checked = $(this).prop('checked'), - data = { - 'presenceImAvailable' : checked, - 'lessonID' : lessonId - }; - data[csrfTokenName] = csrfTokenValue; - $.ajax({ - url : LAMS_URL + 'monitoring/monitoring/presenceImAvailable.do', - type : 'POST', - cache : false, - data : data, - success : function() { - if (checked) { - $('#openImButton').show(); - $('#openImButton').prop('disabled', false); - showToast(LABELS.LESSON_IM_ENABLE_ALERT); - } else { - $('#openImButton').hide(); - showToast(LABELS.LESSON_IM_DISABLE_ALERT); - } - } - }); - }); - - $('#openImButton').click(openChatWindow); - //enable renaming of lesson title $('#lesson-name').editable({ type: 'text', @@ -1051,16 +996,6 @@ return list; } - -function openChatWindow(){ - // variables are set in JSP page - window.open(LAMS_URL + 'learning/presenceChat.jsp?lessonID=' + lessonId - + '&presenceEnabledPatch=true&presenceImEnabled=true&presenceShown=true&createDateTime=' - + createDateTimeStr - ,'Chat' - ,'width=650,height=350,resizable=no,scrollbars=no,status=no,menubar=no,toolbar=no'); -} - function showEmailDialog(userId){ //check whether current window is a top level one (otherwise it's an iframe or popup) @@ -1089,28 +1024,6 @@ }, false, true); } -/* -function updatePresenceAvailableCount(){ - var checked = $('#presenceButton').prop('checked'); - counter = $('#presenceCounter'); - if (checked) { - $.ajax({ - dataType : 'text', - url : LAMS_URL + 'learning/learner/getPresenceChatActiveUserCount.do?', - cache : false, - data : { - 'lessonID' : lessonId - }, - success : function(result) { - counter.text(result).show(); - } - }); - } else { - counter.hide(); - } -} -*/ - function updateContributeActivities(contributeActivities) { let requiredTasksPanel = $('#required-tasks'), requiredTasksContent = $('#required-tasks-content', requiredTasksPanel); Index: lams_monitoring/web/monitor.jsp =================================================================== diff -u -r509e81cd8bc4486fab7de352c4e8cfafd38efe48 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/web/monitor.jsp (.../monitor.jsp) (revision 509e81cd8bc4486fab7de352c4e8cfafd38efe48) +++ lams_monitoring/web/monitor.jsp (.../monitor.jsp) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -108,10 +108,6 @@ SAVE_BUTTON : "", CANCEL_BUTTON : "", LEARNER_FINISHED_DIALOG_TITLE : "", - LESSON_PRESENCE_ENABLE_ALERT : "", - LESSON_PRESENCE_DISABLE_ALERT : "", - LESSON_IM_ENABLE_ALERT : "", - LESSON_IM_DISABLE_ALERT : "", LESSON_REMOVE_ALERT : "", LESSON_REMOVE_DOUBLECHECK_ALERT : "", LESSON_STATE_CREATED : "", @@ -466,33 +462,6 @@

- -
:
-
- - - - - -
- style="display: none" - - > - -
- - -
-
:
Index: lams_monitoring/web/monitorTour.jsp =================================================================== diff -u -r87c236112358ed9c229876a63816b5e14b17f2af -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_monitoring/web/monitorTour.jsp (.../monitorTour.jsp) (revision 87c236112358ed9c229876a63816b5e14b17f2af) +++ lams_monitoring/web/monitorTour.jsp (.../monitorTour.jsp) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -75,13 +75,6 @@ content: "", placement: "top", },{ - element: "#tour-lesson-im", - title: "", - content: "

", - placement: "bottom", - onShow: revealIM, - onHide: hideIM - },{ element: "#sendProgressEmail", title: "", content: "", @@ -255,32 +248,6 @@ $("body").on("click","button.morehelp", openWikiHelp); } - - function revealIM(tour) { - var checked = $('#presenceButton').hasClass('btn-success'); - if (!checked) { - $("#imButton").css('display', 'block'); - $('#imButton').prop('disabled', true); - } - checked = $('#imButton').hasClass('btn-success'); - if (!checked) { - $("#openImButton").css('display', 'block'); - $('#openImButton').prop('disabled', true); - } - } - - function hideIM(tour) { - $('#imButton').prop('disabled', false); - var checked = $('#presenceButton').hasClass('btn-success'); - if (!checked) { - $("#imButton").css('display', 'none'); - } - $('#openImButton').prop('disabled', false); - checked = $('#imButton').hasClass('btn-success'); - if (!checked) { - $("#openImButton").css('display', 'none'); - } - } // These two functions call functions from gradebook page so do not risk breaking tour if they are missing or broken function showMarkChart() { Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java =================================================================== diff -u -r2460a1f5af08b0686a1c4e4cefa94781d7bbc9c8 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 2460a1f5af08b0686a1c4e4cefa94781d7bbc9c8) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -23,6 +23,26 @@ package org.lamsfoundation.lams.tool.imageGallery.service; +import java.awt.image.BufferedImage; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.io.InputStream; +import java.sql.Timestamp; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Date; +import java.util.Iterator; +import java.util.LinkedList; +import java.util.List; +import java.util.Set; +import java.util.SortedMap; +import java.util.TreeSet; + +import javax.imageio.ImageIO; +import javax.servlet.http.HttpServletRequest; + import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; import org.lamsfoundation.lams.confidencelevel.ConfidenceLevelDTO; @@ -73,27 +93,6 @@ import org.lamsfoundation.lams.util.MessageService; import org.lamsfoundation.lams.util.imgscalr.ResizePictureUtil; -import javax.imageio.ImageIO; -import javax.servlet.http.HttpServletRequest; -import java.awt.image.BufferedImage; -import java.io.File; -import java.io.FileInputStream; -import java.io.FileNotFoundException; -import java.io.IOException; -import java.io.InputStream; -import java.sql.Timestamp; -import java.util.ArrayList; -import java.util.Collection; -import java.util.Date; -import java.util.HashMap; -import java.util.Iterator; -import java.util.LinkedList; -import java.util.List; -import java.util.Map; -import java.util.Set; -import java.util.SortedMap; -import java.util.TreeSet; - /** * @author Andrey Balan */ @@ -521,9 +520,8 @@ if (mediumIS == null) { throw new UploadImageGalleryFileException("Impossible to resize image"); } - String mediumFileName = - ImageGalleryServiceImpl.MEDIUM_FILENAME_PREFIX + fileName.substring(0, fileName.indexOf('.')) - + ".jpg"; + String mediumFileName = ImageGalleryServiceImpl.MEDIUM_FILENAME_PREFIX + + fileName.substring(0, fileName.indexOf('.')) + ".jpg"; NodeKey mediumNodeKey = imageGalleryToolContentHandler.uploadFile(mediumIS, mediumFileName, "image/jpeg"); image.setMediumFileUuid(mediumNodeKey.getNodeId()); image.setMediumFileDisplayUuid(mediumNodeKey.getUuid()); @@ -537,9 +535,8 @@ // prepare thumbnail image InputStream originalIS2 = imageGalleryToolContentHandler.getFileInputStream(nodeKey.getNodeId()); InputStream thumbnailIS = ResizePictureUtil.resize(originalIS2, thumbnailImageDimensions); - String thumbnailFileName = - ImageGalleryServiceImpl.THUMBNAIL_FILENAME_PREFIX + fileName.substring(0, fileName.indexOf('.')) - + ".jpg"; + String thumbnailFileName = ImageGalleryServiceImpl.THUMBNAIL_FILENAME_PREFIX + + fileName.substring(0, fileName.indexOf('.')) + ".jpg"; NodeKey thumbnailNodeKey = imageGalleryToolContentHandler.uploadFile(thumbnailIS, thumbnailFileName, "image/jpeg"); image.setThumbnailFileUuid(thumbnailNodeKey.getNodeId()); @@ -873,8 +870,8 @@ public void removeToolContent(Long toolContentId) throws ToolException { ImageGallery imageGallery = imageGalleryDao.getByContentId(toolContentId); if (imageGallery == null) { - ImageGalleryServiceImpl.log.warn( - "Can not remove the tool content as it does not exist, ID: " + toolContentId); + ImageGalleryServiceImpl.log + .warn("Can not remove the tool content as it does not exist, ID: " + toolContentId); return; } @@ -896,8 +893,8 @@ } ImageGallery gallery = imageGalleryDao.getByContentId(toolContentId); if (gallery == null) { - ImageGalleryServiceImpl.log.warn( - "Did not find activity with toolContentId: " + toolContentId + " to remove learner content"); + ImageGalleryServiceImpl.log + .warn("Did not find activity with toolContentId: " + toolContentId + " to remove learner content"); return; } @@ -971,12 +968,10 @@ session.setStatus(ImageGalleryConstants.COMPLETED); imageGallerySessionDao.saveObject(session); } else { - ImageGalleryServiceImpl.log.error( - "Fail to leave tool Session.Could not find shared imageGallery " + "session by given session id: " - + toolSessionId); - throw new DataMissingException( - "Fail to leave tool Session." + "Could not find shared imageGallery session by given session id: " - + toolSessionId); + ImageGalleryServiceImpl.log.error("Fail to leave tool Session.Could not find shared imageGallery " + + "session by given session id: " + toolSessionId); + throw new DataMissingException("Fail to leave tool Session." + + "Could not find shared imageGallery session by given session id: " + toolSessionId); } return toolService.completeToolSession(toolSessionId, learnerId); } Index: lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/service/CommonCartridgeServiceImpl.java =================================================================== diff -u -r2460a1f5af08b0686a1c4e4cefa94781d7bbc9c8 -r0993bbd812a25ddb84feec64dd0e4847ce32d164 --- lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/service/CommonCartridgeServiceImpl.java (.../CommonCartridgeServiceImpl.java) (revision 2460a1f5af08b0686a1c4e4cefa94781d7bbc9c8) +++ lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/service/CommonCartridgeServiceImpl.java (.../CommonCartridgeServiceImpl.java) (revision 0993bbd812a25ddb84feec64dd0e4847ce32d164) @@ -23,6 +23,20 @@ package org.lamsfoundation.lams.tool.commonCartridge.service; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.io.InputStream; +import java.sql.Timestamp; +import java.util.ArrayList; +import java.util.Date; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.SortedMap; +import java.util.SortedSet; +import java.util.TreeMap; + import org.apache.log4j.Logger; import org.lamsfoundation.lams.confidencelevel.ConfidenceLevelDTO; import org.lamsfoundation.lams.contentrepository.client.IToolContentHandler; @@ -66,22 +80,6 @@ import org.lamsfoundation.lams.util.zipfile.ZipFileUtilException; import org.springframework.web.multipart.MultipartFile; -import java.io.FileNotFoundException; -import java.io.IOException; -import java.io.InputStream; -import java.sql.Timestamp; -import java.util.ArrayList; -import java.util.Date; -import java.util.HashMap; -import java.util.Iterator; -import java.util.List; -import java.util.Map; -import java.util.Set; -import java.util.SortedMap; -import java.util.SortedSet; -import java.util.TreeMap; -import java.util.TreeSet; - /** * @author Andrey Balan */ @@ -336,8 +334,8 @@ @Override public List getUserListBySessionItem(Long sessionId, Long itemUid) { - List logList = commonCartridgeItemVisitDao.getCommonCartridgeItemLogBySession( - sessionId, itemUid); + List logList = commonCartridgeItemVisitDao + .getCommonCartridgeItemLogBySession(sessionId, itemUid); List userList = new ArrayList(logList.size()); for (CommonCartridgeItemVisitLog visit : logList) { CommonCartridgeUser user = visit.getUser(); @@ -548,8 +546,8 @@ // reset it to new toolContentId toolContentObj.setContentId(toolContentId); - CommonCartridgeUser user = commonCartridgeUserDao.getUserByUserIDAndContentID( - new Long(newUserUid.longValue()), toolContentId); + CommonCartridgeUser user = commonCartridgeUserDao + .getUserByUserIDAndContentID(new Long(newUserUid.longValue()), toolContentId); if (user == null) { user = new CommonCartridgeUser(); UserDTO sysUser = ((User) userManagementService.findById(User.class, newUserUid)).getUserDTO(); @@ -691,8 +689,8 @@ Iterator itemIterator = cartridge.getCommonCartridgeItems().iterator(); while (itemIterator.hasNext()) { CommonCartridgeItem item = itemIterator.next(); - CommonCartridgeItemVisitLog visitLog = commonCartridgeItemVisitDao.getCommonCartridgeItemLog( - item.getUid(), userId.longValue()); + CommonCartridgeItemVisitLog visitLog = commonCartridgeItemVisitDao + .getCommonCartridgeItemLog(item.getUid(), userId.longValue()); if (visitLog != null) { commonCartridgeItemVisitDao.removeObject(CommonCartridgeItemVisitLog.class, visitLog.getUid()); }