Index: lams_common/.classpath
===================================================================
diff -u -r713fdb17739e31e966736659f72f01ce087f38d1 -r0cf3b837f37930f11b640ce74c232b84d4a32731
--- lams_common/.classpath (.../.classpath) (revision 713fdb17739e31e966736659f72f01ce087f38d1)
+++ lams_common/.classpath (.../.classpath) (revision 0cf3b837f37930f11b640ce74c232b84d4a32731)
@@ -3,7 +3,6 @@
-
@@ -26,7 +25,7 @@
-
+
@@ -46,6 +45,7 @@
+
Fisheye: Tag e685b556979e8e732d257191512d4cbe2dc33bd8 refers to a dead (removed) revision in file `lams_common/.settings/org.jboss.ide.eclipse.as.core.prefs'.
Fisheye: No comparison available. Pass `N' to diff?
Index: lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java
===================================================================
diff -u -rd928f8397a77aae7efcf5b65c50222d2cec053be -r0cf3b837f37930f11b640ce74c232b84d4a32731
--- lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java (.../RatingService.java) (revision d928f8397a77aae7efcf5b65c50222d2cec053be)
+++ lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java (.../RatingService.java) (revision 0cf3b837f37930f11b640ce74c232b84d4a32731)
@@ -378,9 +378,9 @@
mapOrderIdToRatingCriteria.put(ratingCriteriaIter.getOrderId(), ratingCriteriaIter);
}
- for ( Map.Entry entry : request.getParameterMap().entrySet()) {
- log.debug("entry: "+entry.getKey()+" "+entry.getValue());
- }
+// for ( Map.Entry entry : request.getParameterMap().entrySet()) {
+// log.debug("entry: "+entry.getKey()+" "+entry.getValue());
+// }
int criteriaMaxOrderId = WebUtil.readIntParam(request, "criteriaMaxOrderId");
// i is equal to an old orderId
@@ -415,13 +415,14 @@
maxRatings = WebUtil.readIntParam(request, "maximumRates" + i, true);
}
- if ( ratingStyle == RatingCriteria.RATING_STYLE_COMMENT ) {
- explicitCommentTypeFound = true;
- }
boolean commentsEnabled = ( ratingStyle != RatingCriteria.RATING_STYLE_COMMENT ? WebUtil.readBooleanParam(request, "enableComments" + i, false) : true );
RatingCriteria ratingCriteria = mapOrderIdToRatingCriteria.get(i);
+ if ( ratingStyle == RatingCriteria.RATING_STYLE_COMMENT || (ratingCriteria != null && ratingCriteria.isCommentRating()) ) {
+ explicitCommentTypeFound = true;
+ }
+
if (StringUtils.isNotBlank(criteriaTitle)) {
int newCriteriaOrderId = WebUtil.readIntParam(request, "criteriaOrderId" + i);