Index: lams_tool_forum/conf/xdoclet/struts-actions.xml =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/conf/xdoclet/struts-actions.xml (.../struts-actions.xml) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/conf/xdoclet/struts-actions.xml (.../struts-actions.xml) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -246,22 +246,24 @@ - + Index: lams_tool_forum/conf/xdoclet/taglibs.xml =================================================================== diff -u -ra2160af2abd41d478e36906531604f57dcc15d13 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/conf/xdoclet/taglibs.xml (.../taglibs.xml) (revision a2160af2abd41d478e36906531604f57dcc15d13) +++ lams_tool_forum/conf/xdoclet/taglibs.xml (.../taglibs.xml) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -78,14 +78,10 @@ - - - - - fck-editor - /WEB-INF/fckeditor/FCKeditor.tld - - - tags-lams - /WEB-INF/lams.tld - + + + + + tags-lams + /WEB-INF/lams.tld + Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/ApplicationResources.properties =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/ApplicationResources.properties (.../ApplicationResources.properties) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/ApplicationResources.properties (.../ApplicationResources.properties) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -37,14 +37,18 @@ lable.topic.subject.by=By label.back.to.forum=Go back to froum +label.monitoring.edit.activity.cancel=Cancel +label.monitoring.edit.activity.update=Update +label.monitoring.edit.activity.edit=Edit + authoring.exception= There is a problem in forum authoring page, the reason is {0} #-------------------------END Authoring Labels END-----------------# page.title.monitoring.content.userlist=Monitoring User List page.title.monitoring.view.user.mark=View user mark page.title.monitoring.edit.user.mark=Edit user mark page.title.monitoring.view.activity=View Activity page.title.monitoring.edit.activity=Edit Activity - +page.title.monitoring.view.instructions=View Instructions ## errors errors.header= errors.footer= @@ -55,6 +59,8 @@ error.uploading = error uploading error.mark.needNumber= Mark must be int value error.mark.needInteger= Mark must be int value +error.fail.get.forum=No Forum available +error.title.empty=Title can not be blank #General Messages message.msg.maxFileSize = Max 250K Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java (.../MonitoringAction.java) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java (.../MonitoringAction.java) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -28,11 +28,16 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; +import org.apache.poi.util.StringUtil; import org.apache.struts.action.Action; +import org.apache.struts.action.ActionErrors; import org.apache.struts.action.ActionForm; import org.apache.struts.action.ActionForward; import org.apache.struts.action.ActionMapping; +import org.apache.struts.action.ActionMessage; +import org.apache.struts.action.ActionMessages; import org.lamsfoundation.lams.tool.forum.dto.MessageDTO; import org.lamsfoundation.lams.tool.forum.persistence.Forum; import org.lamsfoundation.lams.tool.forum.persistence.ForumReport; @@ -166,29 +171,33 @@ Long messageId = new Long(WebUtil.readLongParam(request,ForumConstants.MESSAGE_UID)); Long sessionId = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_SESSION_ID)); + //get Message and User from database forumService = getForumService(); Message msg = forumService.getMessage(messageId); ForumUser user = forumService.getUser(userUid); - //each back to web page + //echo back to web page + MarkForm markForm = (MarkForm) form; if(msg.getReport() != null){ - MarkForm markForm = (MarkForm) form; markForm.setMark(new Integer(msg.getReport().getMark()).toString()); markForm.setComment(msg.getReport().getComment()); } - request.setAttribute("message",MessageDTO.getMessageDTO(msg)); - request.setAttribute("user",user); - request.setAttribute(AttributeNames.PARAM_TOOL_SESSION_ID,sessionId); + markForm.setUser(user); + markForm.setMessageDto(MessageDTO.getMessageDTO(msg)); + markForm.setSessionId(sessionId); return mapping.findForward("success"); } private ActionForward updateMark(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { Long messageId = new Long(WebUtil.readLongParam(request,ForumConstants.MESSAGE_UID)); + Long userUid = new Long(WebUtil.readLongParam(request,ForumConstants.USER_UID)); + Long sessionId = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_SESSION_ID)); forumService = getForumService(); Message msg = forumService.getMessage(messageId); + //save it into database MarkForm markForm = (MarkForm) form; forumService = getForumService(); ForumReport report = msg.getReport(); @@ -200,14 +209,29 @@ report.setComment(markForm.getComment()); forumService.updateTopic(msg); + //echo back to web page + forumService = getForumService(); + List messageList = forumService.getMessagesByUserUid(userUid,sessionId); + ForumUser user = forumService.getUser(userUid); + request.setAttribute("topicList",messageList); + request.setAttribute("user",user); + request.setAttribute(AttributeNames.PARAM_TOOL_SESSION_ID,sessionId); return mapping.findForward("success"); + } private ActionForward viewActivity(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { Long contentId = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); forumService = getForumService(); - Forum forum = forumService.getForum(contentId); + Forum forum = forumService.getForumByContentId(contentId); + //if can not find out forum, echo back error message + if(forum == null){ + ActionErrors errors = new ActionErrors(); + errors.add("activity.globel", new ActionMessage("error.fail.get.forum")); + this.addErrors(request,errors); + return mapping.getInputForward(); + } String title = forum.getTitle(); String instruction = forum.getInstructions(); @@ -221,11 +245,19 @@ Long contentId = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); forumService = getForumService(); - Forum forum = forumService.getForum(contentId); + Forum forum = forumService.getForumByContentId(contentId); + //if can not find out forum, echo back error message + if(forum == null){ + ActionErrors errors = new ActionErrors(); + errors.add("activity.globel", new ActionMessage("error.fail.get.forum")); + this.addErrors(request,errors); + //echo back to screen + request.setAttribute(AttributeNames.PARAM_TOOL_CONTENT_ID,contentId); + return mapping.getInputForward(); + } String title = forum.getTitle(); String instruction = forum.getInstructions(); - request.setAttribute("title",title); request.setAttribute("instruction",instruction); request.setAttribute(AttributeNames.PARAM_TOOL_CONTENT_ID,contentId); @@ -239,7 +271,23 @@ String instruction = request.getParameter("instruction"); forumService = getForumService(); - Forum forum = forumService.getForum(contentId); + Forum forum = forumService.getForumByContentId(contentId); + //if can not find out forum, echo back error message + ActionErrors errors = new ActionErrors(); + if(forum == null){ + errors.add("activity.globel", new ActionMessage("error.fail.get.forum")); + } + if(StringUtils.isEmpty(title)){ + errors.add("activity.title", new ActionMessage("error.title.empty")); + } + //echo back to screen + request.setAttribute(AttributeNames.PARAM_TOOL_CONTENT_ID,contentId); + request.setAttribute("title",title); + request.setAttribute("instruction",instruction); + if(!errors.isEmpty()){ + this.addErrors(request,errors); + return mapping.getInputForward(); + } forum.setTitle(title); forum.setInstructions(instruction); forumService.updateForum(forum); @@ -252,7 +300,14 @@ Long contentId = new Long(WebUtil.readLongParam(request,AttributeNames.PARAM_TOOL_CONTENT_ID)); forumService = getForumService(); - Forum forum = forumService.getForum(contentId); + Forum forum = forumService.getForumByContentId(contentId); + //if can not find out forum, echo back error message + if(forum == null){ + ActionErrors errors = new ActionErrors(); + errors.add("instruction.globel", new ActionMessage("error.fail.get.forum")); + this.addErrors(request,errors); + return mapping.getInputForward(); + } ForumForm forumForm = new ForumForm(); forumForm.setForum(forum); Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MarkForm.java =================================================================== diff -u -r7845ea9e982f5c1ff7502401352b7aacd6865221 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MarkForm.java (.../MarkForm.java) (revision 7845ea9e982f5c1ff7502401352b7aacd6865221) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MarkForm.java (.../MarkForm.java) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -26,6 +26,8 @@ import org.apache.struts.action.ActionMapping; import org.apache.struts.action.ActionMessage; import org.apache.struts.validator.ValidatorForm; +import org.lamsfoundation.lams.tool.forum.dto.MessageDTO; +import org.lamsfoundation.lams.tool.forum.persistence.ForumUser; /** * @struts.form name="markForm" * @author Steve.Ni @@ -38,7 +40,11 @@ private String mark; private String comment; - /** + private ForumUser user; + private MessageDTO messageDto; + private Long sessionId; + + /** * MessageForm validation method from STRUCT interface. * */ @@ -48,16 +54,16 @@ try{ if ("".equals(mark)) { ActionMessage error = new ActionMessage("error.valueReqd"); - errors.add("message.mark", error); + errors.add("report.mark", error); }else if(!NumberUtils.isNumber(mark)){ ActionMessage error = new ActionMessage("error.mark.needNumber"); - errors.add("message.mark", error); + errors.add("report.mark", error); }else { try{ Integer.parseInt(mark); }catch(Exception e){ ActionMessage error = new ActionMessage("error.mark.needInteger"); - errors.add("message.mark", error); + errors.add("report.mark", error); } } } catch (Exception e) { @@ -78,4 +84,27 @@ public void setMark(String mark) { this.mark = mark; } + + public MessageDTO getMessageDto() { + return messageDto; + } + + public void setMessageDto(MessageDTO message) { + this.messageDto = message; + } + + public ForumUser getUser() { + return user; + } + + public void setUser(ForumUser user) { + this.user = user; + } + public Long getSessionId() { + return sessionId; + } + + public void setSessionId(Long sessionId) { + this.sessionId = sessionId; + } } Fisheye: Tag 1079ea24a56ed171c7d70985cf72de279765d386 refers to a dead (removed) revision in file `lams_tool_forum/web/WEB-INF/fckeditor/FCKeditor.tld'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_forum/web/WEB-INF/fckeditor/tlds/FCKeditor.tld =================================================================== diff -u --- lams_tool_forum/web/WEB-INF/fckeditor/tlds/FCKeditor.tld (revision 0) +++ lams_tool_forum/web/WEB-INF/fckeditor/tlds/FCKeditor.tld (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -0,0 +1,194 @@ + + + + + 2.2 + 1.1 + FCKeditor + http://fckeditor.net/tags-fckeditor + FCKeditor taglib + + editor + com.fredck.FCKeditor.tags.FCKeditorTag + JSP + + id + true + + + basePath + false + true + + + toolbarSet + false + true + + + width + false + true + + + height + false + true + + + customConfigurationsPath + false + true + + + editorAreaCSS + false + true + + + baseHref + false + true + + + skinPath + false + true + + + pluginsPath + false + true + + + fullPage + false + true + + + debug + false + true + + + autoDetectLanguage + false + true + + + defaultLanguage + false + true + + + contentLangDirection + false + true + + + enableXHTML + false + true + + + enableSourceXHTML + false + true + + + fillEmptyBlocks + false + true + + + formatSource + false + true + + + formatOutput + false + true + + + formatIndentator + false + true + + + geckoUseSPAN + false + true + + + startupFocus + false + true + + + forcePasteAsPlainText + false + true + + + forceSimpleAmpersand + false + true + + + tabSpaces + false + true + + + useBROnCarriageReturn + false + true + + + toolbarStartExpanded + false + true + + + toolbarCanCollapse + false + true + + + fontColors + false + true + + + fontNames + false + true + + + fontSizes + false + true + + + fontFormats + false + true + + + stylesXmlPath + false + true + + + linkBrowserURL + false + true + + + imageBrowserURL + false + true + + + \ No newline at end of file Index: lams_tool_forum/web/WEB-INF/struts-config.xml =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -279,21 +279,23 @@ - + Index: lams_tool_forum/web/WEB-INF/struts/tiles-defs.xml =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/WEB-INF/struts/tiles-defs.xml (.../tiles-defs.xml) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/web/WEB-INF/struts/tiles-defs.xml (.../tiles-defs.xml) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -95,7 +95,7 @@ - + Index: lams_tool_forum/web/WEB-INF/web.xml =================================================================== diff -u -r1d178e94bec7d2c17be92d2ae7690135deb2ff54 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/WEB-INF/web.xml (.../web.xml) (revision 1d178e94bec7d2c17be92d2ae7690135deb2ff54) +++ lams_tool_forum/web/WEB-INF/web.xml (.../web.xml) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -225,17 +225,13 @@ /WEB-INF/fckeditor/tlds/FCKeditor.tld - - - - - fck-editor - /WEB-INF/fckeditor/FCKeditor.tld - - - tags-lams - /WEB-INF/lams.tld - + + + + + tags-lams + /WEB-INF/lams.tld + - - - - - : - - - - - - - : - - - - - - - - - - - - - - - - - + +
+

+

+ + + + + + + + + + + + + + + + + + + + + +
:
: + +
+ + + +
+
+
Index: lams_tool_forum/web/jsps/monitoring/instructions.jsp =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/jsps/monitoring/instructions.jsp (.../instructions.jsp) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/web/jsps/monitoring/instructions.jsp (.../instructions.jsp) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -81,7 +81,11 @@ - + + + + + Index: lams_tool_forum/web/jsps/monitoring/updatemarks.jsp =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/jsps/monitoring/updatemarks.jsp (.../updatemarks.jsp) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/web/jsps/monitoring/updatemarks.jsp (.../updatemarks.jsp) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -1,63 +1,70 @@ <%@ include file="/includes/taglibs.jsp" %> + + +" /> Please assign a mark and a comment for the report by - , + ,

- + - + - + "> - + - + - - + +
- - - - - - + + + + - + + - + + + -
Marks: - +
Comments:Comments: -
+ + +
+
Index: lams_tool_forum/web/jsps/monitoring/viewactivity.jsp =================================================================== diff -u -r7e3a5a06958382ab32f15969c971d7b3e1599626 -r1079ea24a56ed171c7d70985cf72de279765d386 --- lams_tool_forum/web/jsps/monitoring/viewactivity.jsp (.../viewactivity.jsp) (revision 7e3a5a06958382ab32f15969c971d7b3e1599626) +++ lams_tool_forum/web/jsps/monitoring/viewactivity.jsp (.../viewactivity.jsp) (revision 1079ea24a56ed171c7d70985cf72de279765d386) @@ -1,25 +1,31 @@ +<%@ include file="/includes/taglibs.jsp" %> +

- - + + + +
: - +
: - +
+ +