Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerListAction.java =================================================================== diff -u -rf4e34e708b87e42dea1b6d667135f09840d79aa3 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerListAction.java (.../ServerListAction.java) (revision f4e34e708b87e42dea1b6d667135f09840d79aa3) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerListAction.java (.../ServerListAction.java) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -33,7 +33,7 @@ import org.apache.struts.action.ActionForward; import org.apache.struts.action.ActionMapping; import org.lamsfoundation.lams.admin.service.AdminServiceProxy; -import org.lamsfoundation.lams.integration.ExtServerOrgMap; +import org.lamsfoundation.lams.integration.ExtServer; /** * @@ -45,10 +45,10 @@ @SuppressWarnings("unchecked") public ActionForward execute(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { - List list = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()) - .getAllExtServerOrgMaps(); - Collections.sort(list); - request.setAttribute("servers", list); + List extServers = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()) + .getAllExtServers(); + Collections.sort(extServers); + request.setAttribute("servers", extServers); return mapping.findForward("serverlist"); } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerMaintainAction.java =================================================================== diff -u -rf4e34e708b87e42dea1b6d667135f09840d79aa3 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerMaintainAction.java (.../ServerMaintainAction.java) (revision f4e34e708b87e42dea1b6d667135f09840d79aa3) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerMaintainAction.java (.../ServerMaintainAction.java) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -22,12 +22,6 @@ */ package org.lamsfoundation.lams.admin.web; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -37,11 +31,8 @@ import org.apache.struts.action.ActionMapping; import org.apache.struts.action.DynaActionForm; import org.lamsfoundation.lams.admin.service.AdminServiceProxy; -import org.lamsfoundation.lams.integration.ExtServerOrgMap; +import org.lamsfoundation.lams.integration.ExtServer; import org.lamsfoundation.lams.integration.service.IIntegrationService; -import org.lamsfoundation.lams.usermanagement.Organisation; -import org.lamsfoundation.lams.usermanagement.OrganisationState; -import org.lamsfoundation.lams.usermanagement.OrganisationType; import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.action.LamsDispatchAction; @@ -57,30 +48,12 @@ @SuppressWarnings("unchecked") public ActionForward edit(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { - Map properties = new HashMap(); - properties.put("organisationType.organisationTypeId", OrganisationType.COURSE_TYPE); - properties.put("organisationState.organisationStateId", OrganisationState.ACTIVE); - List list = AdminServiceProxy.getService(getServlet().getServletContext()) - .findByProperties(Organisation.class, properties); - Organisation dummy = new Organisation(); - dummy.setOrganisationId(-1); - dummy.setName(AdminServiceProxy.getMessageService(getServlet().getServletContext()) - .getMessage("sysadmin.organisation.select")); - if (list == null) { - list = new ArrayList(); - } - Collections.sort(list); - list.add(0, dummy); - request.setAttribute("orgs", list); - DynaActionForm serverOrgMapForm = (DynaActionForm) form; + DynaActionForm extServerForm = (DynaActionForm) form; Integer sid = WebUtil.readIntParam(request, "sid", true); if (sid != null) { - ExtServerOrgMap map = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()) - .getExtServerOrgMap(sid); - BeanUtils.copyProperties(serverOrgMapForm, map); - if (map.getOrganisation() != null) { - serverOrgMapForm.set("orgId", map.getOrganisation().getOrganisationId()); - } + ExtServer map = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()) + .getExtServer(sid); + BeanUtils.copyProperties(extServerForm, map); } return mapping.findForward("servermaintain"); } @@ -89,26 +62,26 @@ HttpServletResponse response) throws Exception { IIntegrationService service = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()); Integer sid = WebUtil.readIntParam(request, "sid", false); - ExtServerOrgMap map = service.getExtServerOrgMap(sid); + ExtServer map = service.getExtServer(sid); map.setDisabled(true); - service.saveExtServerOrgMap(map); + service.saveExtServer(map); return mapping.findForward("serverlist"); } public ActionForward enable(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { IIntegrationService service = AdminServiceProxy.getIntegrationService(getServlet().getServletContext()); Integer sid = WebUtil.readIntParam(request, "sid", false); - ExtServerOrgMap map = service.getExtServerOrgMap(sid); + ExtServer map = service.getExtServer(sid); map.setDisabled(false); - service.saveExtServerOrgMap(map); + service.saveExtServer(map); return mapping.findForward("serverlist"); } public ActionForward delete(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", false); - AdminServiceProxy.getService(getServlet().getServletContext()).deleteById(ExtServerOrgMap.class, sid); + AdminServiceProxy.getService(getServlet().getServletContext()).deleteById(ExtServer.class, sid); return mapping.findForward("serverlist"); } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerSaveAction.java =================================================================== diff -u -rf4e34e708b87e42dea1b6d667135f09840d79aa3 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerSaveAction.java (.../ServerSaveAction.java) (revision f4e34e708b87e42dea1b6d667135f09840d79aa3) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/ServerSaveAction.java (.../ServerSaveAction.java) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -22,10 +22,7 @@ */ package org.lamsfoundation.lams.admin.web; -import java.util.ArrayList; -import java.util.HashMap; import java.util.List; -import java.util.Map; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -40,19 +37,10 @@ import org.apache.struts.action.ActionMessages; import org.apache.struts.action.DynaActionForm; import org.lamsfoundation.lams.admin.service.AdminServiceProxy; -import org.lamsfoundation.lams.integration.ExtServerOrgMap; +import org.lamsfoundation.lams.integration.ExtServer; import org.lamsfoundation.lams.integration.service.IIntegrationService; -import org.lamsfoundation.lams.usermanagement.Organisation; -import org.lamsfoundation.lams.usermanagement.OrganisationState; -import org.lamsfoundation.lams.usermanagement.OrganisationType; -import org.lamsfoundation.lams.usermanagement.SupportedLocale; -import org.lamsfoundation.lams.usermanagement.dto.UserDTO; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; -import org.lamsfoundation.lams.util.LanguageUtil; import org.lamsfoundation.lams.util.MessageService; -import org.lamsfoundation.lams.util.ValidationUtil; -import org.lamsfoundation.lams.web.session.SessionManager; -import org.lamsfoundation.lams.web.util.AttributeNames; /** *

@@ -80,65 +68,28 @@ userService = AdminServiceProxy.getService(getServlet().getServletContext()); messageService = AdminServiceProxy.getMessageService(getServlet().getServletContext()); - DynaActionForm serverOrgMapForm = (DynaActionForm) form; + DynaActionForm extServerForm = (DynaActionForm) form; ActionMessages errors = new ActionMessages(); String[] requiredFields = { "serverid", "serverkey", "servername", "prefix", "userinfoUrl", "timeoutUrl" }; for (String requiredField : requiredFields) { - if (StringUtils.trimToNull(serverOrgMapForm.getString(requiredField)) == null) { + if (StringUtils.trimToNull(extServerForm.getString(requiredField)) == null) { errors.add(requiredField, new ActionMessage("error.required", messageService.getMessage("sysadmin." + requiredField))); } } - Organisation org = null; - UserDTO user = (UserDTO) SessionManager.getSession().getAttribute(AttributeNames.USER); - if ((Boolean) serverOrgMapForm.get("newOrg")) { - String orgName = serverOrgMapForm.getString("orgName"); - if (StringUtils.trimToNull(orgName) == null) { - errors.add("orgId", - new ActionMessage("error.required", messageService.getMessage("sysadmin.organisation"))); - - } else if (!ValidationUtil.isOrgNameValid(orgName)) { - errors.add("orgId", new ActionMessage("error.name.invalid.characters")); - - } else { - - org = new Organisation(); - org.setName(orgName); - org.setParentOrganisation(userService.getRootOrganisation()); - org.setOrganisationType( - (OrganisationType) userService.findById(OrganisationType.class, OrganisationType.COURSE_TYPE)); - org.setOrganisationState( - (OrganisationState) userService.findById(OrganisationState.class, OrganisationState.ACTIVE)); - SupportedLocale locale = LanguageUtil.getDefaultLocale(); - org.setLocale(locale); - userService.saveOrganisation(org, user.getUserID()); - serverOrgMapForm.set("orgId", org.getOrganisationId()); - serverOrgMapForm.set("newOrg", false); - serverOrgMapForm.set("orgName", null); - } - - } else { - Integer orgId = (Integer) serverOrgMapForm.get("orgId"); - if (orgId.equals(-1)) { - // LDEV-1284 no need for integration organisation anymore - // errors.add("orgId",new ActionMessage("error.required", messageService.getMessage("sysadmin.organisation"))); - } else { - org = (Organisation) userService.findById(Organisation.class, orgId); - } - } - Integer sid = (Integer) serverOrgMapForm.get("sid"); + Integer sid = (Integer) extServerForm.get("sid"); if (errors.isEmpty()) {//check duplication String[] uniqueFields = { "serverid", "prefix" }; for (String uniqueField : uniqueFields) { - List list = userService.findByProperty(ExtServerOrgMap.class, uniqueField, - serverOrgMapForm.get(uniqueField)); + List list = userService.findByProperty(ExtServer.class, uniqueField, + extServerForm.get(uniqueField)); if (list != null && list.size() > 0) { if (sid.equals(-1)) {//new map errors.add(uniqueField, new ActionMessage("error.not.unique", messageService.getMessage("sysadmin." + uniqueField))); } else { - ExtServerOrgMap map = (ExtServerOrgMap) list.get(0); + ExtServer map = (ExtServer) list.get(0); if (!map.getSid().equals(sid)) { errors.add(uniqueField, new ActionMessage("error.not.unique", messageService.getMessage("sysadmin." + uniqueField))); @@ -149,33 +100,20 @@ } } if (errors.isEmpty()) { - ExtServerOrgMap map = null; + ExtServer map = null; if (sid.equals(-1)) { - map = new ExtServerOrgMap(); - BeanUtils.copyProperties(map, serverOrgMapForm); + map = new ExtServer(); + BeanUtils.copyProperties(map, extServerForm); map.setSid(null); - map.setServerTypeId(ExtServerOrgMap.INTEGRATION_SERVER_TYPE); + map.setServerTypeId(ExtServer.INTEGRATION_SERVER_TYPE); } else { - map = service.getExtServerOrgMap(sid); - BeanUtils.copyProperties(map, serverOrgMapForm); + map = service.getExtServer(sid); + BeanUtils.copyProperties(map, extServerForm); } - map.setOrganisation(org); - service.saveExtServerOrgMap(map); + service.saveExtServer(map); return mapping.findForward("success"); } else { saveErrors(request, errors); - Map properties = new HashMap(); - properties.put("organisationType.organisationTypeId", OrganisationType.COURSE_TYPE); - properties.put("organisationState.organisationStateId", OrganisationState.ACTIVE); - List list = userService.findByProperties(Organisation.class, properties); - Organisation dummy = new Organisation(); - dummy.setOrganisationId(-1); - dummy.setName(messageService.getMessage("sysadmin.organisation.select")); - if (list == null) { - list = new ArrayList(); - } - list.add(dummy); - request.setAttribute("orgs", list); return mapping.getInputForward(); } } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/LtiConsumerManagementAction.java =================================================================== diff -u -rf4e34e708b87e42dea1b6d667135f09840d79aa3 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/LtiConsumerManagementAction.java (.../LtiConsumerManagementAction.java) (revision f4e34e708b87e42dea1b6d667135f09840d79aa3) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/LtiConsumerManagementAction.java (.../LtiConsumerManagementAction.java) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -16,7 +16,7 @@ import org.apache.struts.action.ActionMessages; import org.apache.struts.action.DynaActionForm; import org.lamsfoundation.lams.admin.service.AdminServiceProxy; -import org.lamsfoundation.lams.integration.ExtServerOrgMap; +import org.lamsfoundation.lams.integration.ExtServer; import org.lamsfoundation.lams.integration.service.IIntegrationService; import org.lamsfoundation.lams.integration.util.LtiUtils; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; @@ -54,7 +54,7 @@ HttpServletResponse response) { initServices(); - List ltiConsumers = integrationService.getAllToolConsumers(); + List ltiConsumers = integrationService.getAllToolConsumers(); Collections.sort(ltiConsumers); request.setAttribute("ltiConsumers", ltiConsumers); @@ -74,7 +74,7 @@ // editing a tool consumer if (sid != null) { - ExtServerOrgMap ltiConsumer = integrationService.getExtServerOrgMap(sid); + ExtServer ltiConsumer = integrationService.getExtServer(sid); BeanUtils.copyProperties(ltiConsumerForm, ltiConsumer); String lessonFinishUrl = ltiConsumer.getLessonFinishUrl() == null ? "-" : ltiConsumer.getLessonFinishUrl(); request.setAttribute("lessonFinishUrl", lessonFinishUrl); @@ -97,9 +97,9 @@ Integer sid = WebUtil.readIntParam(request, "sid", true); boolean disable = WebUtil.readBooleanParam(request, "disable"); - ExtServerOrgMap ltiConsumer = integrationService.getExtServerOrgMap(sid); + ExtServer ltiConsumer = integrationService.getExtServer(sid); ltiConsumer.setDisabled(disable); - integrationService.saveExtServerOrgMap(ltiConsumer); + integrationService.saveExtServer(ltiConsumer); return unspecified(mapping, form, request, response); } @@ -113,7 +113,7 @@ initServices(); Integer sid = WebUtil.readIntParam(request, "sid", true); - userManagementService.deleteById(ExtServerOrgMap.class, sid); + userManagementService.deleteById(ExtServer.class, sid); return unspecified(mapping, form, request, response); } @@ -146,14 +146,14 @@ if (errors.isEmpty()) { String[] uniqueFields = { "serverid", "prefix" }; for (String uniqueField : uniqueFields) { - List list = userManagementService.findByProperty(ExtServerOrgMap.class, uniqueField, + List list = userManagementService.findByProperty(ExtServer.class, uniqueField, extServerForm.get(uniqueField)); if (list != null && list.size() > 0) { if (sid.equals(0)) {//new map errors.add(uniqueField, new ActionMessage("error.not.unique", messageService.getMessage("sysadmin." + uniqueField))); } else { - ExtServerOrgMap ltiConsumer = list.get(0); + ExtServer ltiConsumer = list.get(0); if (!ltiConsumer.getSid().equals(sid)) { errors.add(uniqueField, new ActionMessage("error.not.unique", messageService.getMessage("sysadmin." + uniqueField))); @@ -164,19 +164,19 @@ } } if (errors.isEmpty()) { - ExtServerOrgMap ltiConsumer = null; + ExtServer ltiConsumer = null; if (sid.equals(0)) { - ltiConsumer = new ExtServerOrgMap(); + ltiConsumer = new ExtServer(); BeanUtils.copyProperties(ltiConsumer, extServerForm); ltiConsumer.setSid(null); - ltiConsumer.setServerTypeId(ExtServerOrgMap.LTI_CONSUMER_SERVER_TYPE); + ltiConsumer.setServerTypeId(ExtServer.LTI_CONSUMER_SERVER_TYPE); ltiConsumer.setUserinfoUrl("blank"); ltiConsumer.setTimeoutUrl("blank"); } else { - ltiConsumer = integrationService.getExtServerOrgMap(sid); + ltiConsumer = integrationService.getExtServer(sid); BeanUtils.copyProperties(ltiConsumer, extServerForm); } - integrationService.saveExtServerOrgMap(ltiConsumer); + integrationService.saveExtServer(ltiConsumer); return unspecified(mapping, form, request, response); } else { Index: lams_admin/web/WEB-INF/struts-config.xml =================================================================== diff -u -rf4e34e708b87e42dea1b6d667135f09840d79aa3 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision f4e34e708b87e42dea1b6d667135f09840d79aa3) +++ lams_admin/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -101,7 +101,7 @@ - + @@ -116,9 +116,6 @@ - - - @@ -218,7 +215,7 @@ - - + - - - - - + + + + + - + - - +   - - + + - +   - + Index: lams_admin/web/servermaintain.jsp =================================================================== diff -u -rf7cb84defcd7ff6e4f3232f2ef1856f1311215d9 -r11b64f81e406ff277c7c35988304b0064300de57 --- lams_admin/web/servermaintain.jsp (.../servermaintain.jsp) (revision f7cb84defcd7ff6e4f3232f2ef1856f1311215d9) +++ lams_admin/web/servermaintain.jsp (.../servermaintain.jsp) (revision 11b64f81e406ff277c7c35988304b0064300de57) @@ -50,17 +50,7 @@ - - - - - - - -   - - - +  * @@ -91,12 +81,7 @@ -