Index: lams_tool_task/conf/language/lams/ApplicationResources.properties =================================================================== diff -u -r7e5ebaceffd43ff691062c0de86f16125d3c3425 -r125488b240966768429db725f4eaa19c425d8964 --- lams_tool_task/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision 7e5ebaceffd43ff691062c0de86f16125d3c3425) +++ lams_tool_task/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision 125488b240966768429db725f4eaa19c425d8964) @@ -110,7 +110,7 @@ label.monitoring.summary.title.reflection =Notebook entry label.monitoring.summary.reflection =Notebook entry label.monitoring.tasksummary.task.summary =Task summary -label.monitoring.tasksummary.task.required.to.finish =this task is required to finish this activity +label.monitoring.tasksummary.task.required.to.finish =(This task is required to finish this activity.) label.monitoring.tasksummary.parent.activity =Parent task label.monitoring.tasksummary.comments.files.enabled =Comments/files enabled label.monitoring.tasksummary.user =Learner Index: lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties =================================================================== diff -u -r7e5ebaceffd43ff691062c0de86f16125d3c3425 -r125488b240966768429db725f4eaa19c425d8964 --- lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision 7e5ebaceffd43ff691062c0de86f16125d3c3425) +++ lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision 125488b240966768429db725f4eaa19c425d8964) @@ -110,7 +110,7 @@ label.monitoring.summary.title.reflection =Notebook entry label.monitoring.summary.reflection =Notebook entry label.monitoring.tasksummary.task.summary =Task summary -label.monitoring.tasksummary.task.required.to.finish =this task is required to finish this activity +label.monitoring.tasksummary.task.required.to.finish =(This task is required to finish this activity.) label.monitoring.tasksummary.parent.activity =Parent task label.monitoring.tasksummary.comments.files.enabled =Comments/files enabled label.monitoring.tasksummary.user =Learner Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/hibernate/TaskListUserDAOHibernate.java =================================================================== diff -u -r83ca314c18ea866bb79570b6e7da25eb8729b3b4 -r125488b240966768429db725f4eaa19c425d8964 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/hibernate/TaskListUserDAOHibernate.java (.../TaskListUserDAOHibernate.java) (revision 83ca314c18ea866bb79570b6e7da25eb8729b3b4) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/hibernate/TaskListUserDAOHibernate.java (.../TaskListUserDAOHibernate.java) (revision 125488b240966768429db725f4eaa19c425d8964) @@ -177,7 +177,7 @@ Long userId = ((Number) element[0]).longValue(); String fullName = (String) element[1]; - boolean isCompleted = element[2] == null ? false : new Boolean(((Byte) element[2]).intValue() == 1); + boolean isCompleted = element[2] == null ? false : (Boolean) element[2]; Date accessDate = element[3] == null ? null : new Date(((Timestamp) element[3]).getTime()); TaskListUserDTO userDto = new TaskListUserDTO(); Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java =================================================================== diff -u -r2abc3485dc2d24ea02044a64271f3ee0d3b8c11b -r125488b240966768429db725f4eaa19c425d8964 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 2abc3485dc2d24ea02044a64271f3ee0d3b8c11b) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 125488b240966768429db725f4eaa19c425d8964) @@ -331,9 +331,24 @@ SortedSet items = getTaskListItemList(sessionMap); for (TaskListItem item : items) { if (item != null) { - // This flushs user UID info to message if this user is a new user. - item.setCreateBy(taskListUser); - itemList.add(item); + if ( item.getUid() == null ) { + // This flushs user UID info to message if this user is a new user. + item.setCreateBy(taskListUser); + itemList.add(item); + } else { + // Do not update if it is not null otherwise Edit Activity will overwrite the learner id for learner entered tasks + // But taskListUser & .getCreatedBy() are a stale lazy loaded object so need to the real things from the session + TaskListItem itemPO = service.getTaskListItemByUid(item.getUid()); + if ( itemPO != null ) { + updateTaskListItemFromSession(itemPO, item); + itemList.add(itemPO); + } else { + // something weird happened. Uid exists but can't find the task. Make it an authored task + item.setCreateBy(taskListUser); + item.setCreateByAuthor(true); + itemList.add(item); + } + } } } taskListPO.setTaskListItems(itemList); @@ -753,6 +768,30 @@ } /** + * Extract session request version of a taskListItem update the DB version of the taskListItem. + * @throws TaskListException + */ + private void updateTaskListItemFromSession(TaskListItem itemPO, TaskListItem itemFromSession) throws Exception { + /* + * BE CAREFUL: This method will copy necessary info from session to an existing TaskListItem instance. It + * gets all info EXCEPT uid, createDate, createBy, createByAuthor, attachments and comments which need be left the same + * as they were previously. If you change them then LiveEdit will change Learner created items. + */ + + itemPO.setTitle(itemFromSession.getTitle()); + itemPO.setDescription(itemFromSession.getDescription()); + itemPO.setSequenceId(itemFromSession.getSequenceId()); + itemPO.setRequired(itemFromSession.isRequired()); + itemPO.setCommentsAllowed(itemFromSession.isCommentsAllowed()); + itemPO.setCommentsRequired(itemFromSession.isCommentsRequired()); + itemPO.setFilesAllowed(itemFromSession.isFilesAllowed()); + itemPO.setFilesRequired(itemFromSession.isFilesRequired()); + itemPO.setCommentsFilesAllowed(itemFromSession.isCommentsFilesAllowed()); + itemPO.setShowCommentsToAll(itemFromSession.getShowCommentsToAll()); + itemPO.setChildTask(itemFromSession.isChildTask()); + itemPO.setParentTaskName(itemFromSession.getParentTaskName()); + } + /** * Vaidate taskList item regards to their type (url/file/learning object/website zip file) * * @param itemForm Index: lams_tool_task/web/pages/monitoring/itemsummary.jsp =================================================================== diff -u -r0d14800c7ef0085f17e151c167408984eb55f1ff -r125488b240966768429db725f4eaa19c425d8964 --- lams_tool_task/web/pages/monitoring/itemsummary.jsp (.../itemsummary.jsp) (revision 0d14800c7ef0085f17e151c167408984eb55f1ff) +++ lams_tool_task/web/pages/monitoring/itemsummary.jsp (.../itemsummary.jsp) (revision 125488b240966768429db725f4eaa19c425d8964) @@ -94,23 +94,18 @@ -
-

- -

+ + + +

-
- - - - () - -
-
- + +
+
+ -
    +
    • (: ${item.parentTaskName}) @@ -152,30 +147,40 @@
    -
    -
    + + +
    + + + + +
    + + +
    + -
    - -
    - ${sessionDto.sessionName} -
    -
    - -

    - ${groupSummary.sessionName} -

    -
    - -
    -
    -
    +
    +
    + + + +
    +
    +
    + ${ !sessionMap.isGroupedActivity || ! status.last ? '
     
    ' : ''}
    -
    +