Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/AuthoringController.java =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/AuthoringController.java (.../AuthoringController.java) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/AuthoringController.java (.../AuthoringController.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -176,7 +176,7 @@ * Display same entire authoring page content from HttpSession variable. */ @RequestMapping(path = "/init", method = RequestMethod.POST) - public String initPage(@ModelAttribute("imageGalleryForm") ImageGalleryForm startForm, HttpServletRequest request) + public String initPage(@ModelAttribute ImageGalleryForm startForm, HttpServletRequest request) throws ServletException { String sessionMapID = WebUtil.readStrParam(request, ImageGalleryConstants.ATTR_SESSION_MAP_ID); @@ -193,16 +193,15 @@ ToolAccessMode mode = WebUtil.readToolAccessModeAuthorDefaulted(request); request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); request.setAttribute("imageGalleryForm", startForm); - return "pages/authoring/authoring"; } /** * This method will persist all inforamtion in this authoring page, include all imageGallery item, information etc. */ - @RequestMapping("/update") - public String updateContent(@ModelAttribute ImageGalleryForm imageGalleryForm, HttpServletRequest request) - throws IllegalAccessException, InvocationTargetException, Exception { + @RequestMapping(path = "/update", method = RequestMethod.POST) + public String updateContent(@ModelAttribute ImageGalleryForm imageGalleryForm, + HttpServletRequest request) throws IllegalAccessException, InvocationTargetException, Exception { // get back sessionMAP SessionMap sessionMap = (SessionMap) request.getSession() @@ -373,14 +372,14 @@ * persisted. */ @RequestMapping("/saveOrUpdateImage") - public String saveOrUpdateImage(@ModelAttribute ImageGalleryItemForm itemForm, HttpServletRequest request, + public String saveOrUpdateImage(@ModelAttribute ImageGalleryItemForm imageGalleryItemForm, HttpServletRequest request, HttpServletResponse response) { - MultiValueMap errorMap = ImageGalleryUtils.validateImageGalleryItem(itemForm, true); + MultiValueMap errorMap = ImageGalleryUtils.validateImageGalleryItem(imageGalleryItemForm, true); try { if (errorMap.isEmpty()) { - extractFormToImageGalleryItem(request, itemForm); + extractFormToImageGalleryItem(request, imageGalleryItemForm); } } catch (Exception e) { // any upload exception will display as normal error message rather then throw exception directly @@ -394,7 +393,7 @@ } // set session map ID so that itemlist.jsp can get sessionMAP - request.setAttribute(ImageGalleryConstants.ATTR_SESSION_MAP_ID, itemForm.getSessionMapID()); + request.setAttribute(ImageGalleryConstants.ATTR_SESSION_MAP_ID, imageGalleryItemForm.getSessionMapID()); // return null to close this window return "pages/authoring/parts/itemlist"; } @@ -467,14 +466,14 @@ * persisted. */ @RequestMapping("/saveMultipleImages") - public String saveMultipleImages(@ModelAttribute MultipleImagesForm multipleForm, HttpServletRequest request, + public String saveMultipleImages(@ModelAttribute MultipleImagesForm multipleImagesForm, HttpServletRequest request, HttpServletResponse response) { - MultiValueMap errorMap = ImageGalleryUtils.validateMultipleImages(multipleForm, true); + MultiValueMap errorMap = ImageGalleryUtils.validateMultipleImages(multipleImagesForm, true); try { if (errorMap.isEmpty()) { - extractMultipleFormToImageGalleryItems(request, multipleForm); + extractMultipleFormToImageGalleryItems(request, multipleImagesForm); } } catch (Exception e) { // any upload exception will display as normal error message rather then throw exception directly @@ -487,7 +486,7 @@ } // set session map ID so that itemlist.jsp can get sessionMAP - request.setAttribute(ImageGalleryConstants.ATTR_SESSION_MAP_ID, multipleForm.getSessionMapID()); + request.setAttribute(ImageGalleryConstants.ATTR_SESSION_MAP_ID, multipleImagesForm.getSessionMapID()); // return null to close this window return "pages/authoring/parts/itemlist"; } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/LearningController.java =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/LearningController.java (.../LearningController.java) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/controller/LearningController.java (.../LearningController.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -259,21 +259,21 @@ * Save file or url imageGallery item into database. */ @RequestMapping("/saveNewImage") - public String saveNewImage(@ModelAttribute ImageGalleryItemForm itemForm, HttpServletRequest request, + public String saveNewImage(@ModelAttribute ImageGalleryItemForm imageGalleryItemForm, HttpServletRequest request, HttpServletResponse response) throws IOException { SessionMap sessionMap = (SessionMap) request.getSession() - .getAttribute(itemForm.getSessionMapID()); + .getAttribute(imageGalleryItemForm.getSessionMapID()); ToolAccessMode mode = (ToolAccessMode) sessionMap.get(AttributeNames.ATTR_MODE); //validate form boolean isLargeFilesAllowed = mode.isTeacher(); - MultiValueMap errorMap = ImageGalleryUtils.validateImageGalleryItem(itemForm, + MultiValueMap errorMap = ImageGalleryUtils.validateImageGalleryItem(imageGalleryItemForm, isLargeFilesAllowed); try { if (errorMap.isEmpty()) { - extractFormToImageGalleryItem(request, itemForm); + extractFormToImageGalleryItem(request, imageGalleryItemForm); } } catch (Exception e) { // any upload exception will display as normal error message rather then throw exception directly Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java (.../AdminForm.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java (.../AdminForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -20,32 +20,41 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; import javax.servlet.http.HttpServletRequest; import org.apache.struts.action.ActionErrors; -import org.apache.struts.action.ActionForm; import org.apache.struts.action.ActionMapping; import org.apache.struts.action.ActionMessage; import org.apache.struts.action.ActionMessages; +import org.lamsfoundation.lams.util.MessageService; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.util.LinkedMultiValueMap; +import org.springframework.util.MultiValueMap; /** * */ -public class AdminForm extends ActionForm { +public class AdminForm { + + @Autowired + @Qualifier("laimagMessageService") + private static MessageService messageService; + + private static final long serialVersionUID = 414425664356226L; private String mediumImageDimensions; private String thumbnailImageDimensions; - @Override - public ActionErrors validate(ActionMapping arg0, HttpServletRequest arg1) { - ActionErrors ac = new ActionErrors(); - ac.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage("this is an error")); - return ac; + public MultiValueMap validate(ActionMapping arg0, HttpServletRequest arg1) { + + MultiValueMap errorMap = new LinkedMultiValueMap(); + errorMap.add("GLOBAL", messageService.getMessage("this is an error")); + return errorMap; } public String getMediumImageDimensions() { Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java (.../ImageGalleryForm.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java (.../ImageGalleryForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -31,6 +31,7 @@ import org.apache.struts.action.ActionMapping; import org.apache.struts.upload.FormFile; import org.lamsfoundation.lams.tool.imageGallery.model.ImageGallery; +import org.springframework.web.multipart.MultipartFile; /** * @@ -40,7 +41,7 @@ * * User: Andrey Balan */ -public class ImageGalleryForm extends ActionForm { +public class ImageGalleryForm { private static final long serialVersionUID = 3599879328307492312L; private static Logger logger = Logger.getLogger(ImageGalleryForm.class.getName()); @@ -49,8 +50,8 @@ private String sessionMapID; private String contentFolderID; private int currentTab; - private FormFile offlineFile; - private FormFile onlineFile; + private MultipartFile offlineFile; + private MultipartFile onlineFile; private ImageGallery imageGallery; private boolean allowRatingsOrVote; @@ -69,12 +70,11 @@ } } - @Override - public void reset(ActionMapping mapping, HttpServletRequest request) { - String param = mapping.getParameter(); + public void reset(HttpServletRequest request) { + String param = (String) request.getAttribute("action"); // if it is start page, all data read out from database or current session // so need not reset checkbox to refresh value! - if (!StringUtils.equals(param, "start") && !StringUtils.equals(param, "initPage")) { + if (!StringUtils.equals(param, "start.do") && !StringUtils.equals(param, "initPage.do")) { imageGallery.setAllowShareImages(false); imageGallery.setLockWhenFinished(false); imageGallery.setDefineLater(false); @@ -91,19 +91,19 @@ this.currentTab = currentTab; } - public FormFile getOfflineFile() { + public MultipartFile getOfflineFile() { return offlineFile; } - public void setOfflineFile(FormFile offlineFile) { + public void setOfflineFile(MultipartFile offlineFile) { this.offlineFile = offlineFile; } - public FormFile getOnlineFile() { + public MultipartFile getOnlineFile() { return onlineFile; } - public void setOnlineFile(FormFile onlineFile) { + public void setOnlineFile(MultipartFile onlineFile) { this.onlineFile = onlineFile; } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java (.../ImageGalleryItemForm.java) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java (.../ImageGalleryItemForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -23,8 +23,6 @@ package org.lamsfoundation.lams.tool.imageGallery.web.form; -import org.apache.struts.action.ActionForm; -import org.apache.struts.upload.FormFile; import org.springframework.web.multipart.MultipartFile; /** Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java (.../ImageRatingForm.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java (.../ImageRatingForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -31,7 +31,7 @@ * * @author Andrey Balan */ -public class ImageRatingForm extends ActionForm { +public class ImageRatingForm { private static final long serialVersionUID = -8962161058929959289L; Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java (.../MultipleImagesForm.java) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java (.../MultipleImagesForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -20,11 +20,8 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; -import org.apache.struts.action.ActionForm; -import org.apache.struts.upload.FormFile; import org.springframework.web.multipart.MultipartFile; /** Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java (.../ReflectionForm.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java (.../ReflectionForm.java) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -34,7 +34,8 @@ * * */ -public class ReflectionForm extends ValidatorForm { +public class ReflectionForm { + private static final long serialVersionUID = -9054365604649146735L; private static Logger logger = Logger.getLogger(ReflectionForm.class.getName()); Index: lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -285,39 +285,35 @@ - - - - 1 - 2 - 3 - 4 - 5 - 6 - 7 - 8 - 9 - 10 + "/> + + + + + + + + + + - - - - 1 - 2 - 3 - 4 - 5 - 6 - 7 - 8 - 9 - 10 + + + + + + + + + + + Index: lams_tool_images/web/common/header.jsp =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/web/common/header.jsp (.../header.jsp) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/web/common/header.jsp (.../header.jsp) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -8,7 +8,7 @@ - + Index: lams_tool_images/web/common/tabbedheader.jsp =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/web/common/tabbedheader.jsp (.../tabbedheader.jsp) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/web/common/tabbedheader.jsp (.../tabbedheader.jsp) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -11,4 +11,4 @@ - + Index: lams_tool_images/web/pages/authoring/advance.jsp =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -1,7 +1,8 @@ <%@ include file="/common/taglibs.jsp"%> - + @@ -83,12 +84,12 @@ - display:none; + display:none; + id="${id}"/> Index: lams_tool_images/web/pages/authoring/authoring.jsp =================================================================== diff -u -r9c66807dec11ccfe2299008ded08091f487a3478 -r17eedca34ff3aaaee38fc4dc4a93301351379c60 --- lams_tool_images/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 9c66807dec11ccfe2299008ded08091f487a3478) +++ lams_tool_images/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 17eedca34ff3aaaee38fc4dc4a93301351379c60) @@ -22,7 +22,7 @@ var LABEL_MAX_FILE_SIZE = ''; var LABEL_NOT_ALLOWED_FORMAT = ''; - + - +