Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ExtServerManagementController.java =================================================================== diff -u -r7bab4cf8a0eab2795022a136e55d1f64fa3721b8 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ExtServerManagementController.java (.../ExtServerManagementController.java) (revision 7bab4cf8a0eab2795022a136e55d1f64fa3721b8) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ExtServerManagementController.java (.../ExtServerManagementController.java) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -44,6 +44,7 @@ import org.springframework.validation.BindingResult; import org.springframework.web.bind.annotation.ModelAttribute; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; /** * @author Fei Yang @@ -158,7 +159,7 @@ } } - @RequestMapping(path = "/disable") + @RequestMapping(path = "/disable", method = RequestMethod.POST) public String disable(HttpServletRequest request) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", false); ExtServer map = integrationService.getExtServer(sid); @@ -167,7 +168,7 @@ return "redirect:/extserver/serverlist.do"; } - @RequestMapping(path = "/enable") + @RequestMapping(path = "/enable", method = RequestMethod.POST) public String enable(HttpServletRequest request) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", false); ExtServer map = integrationService.getExtServer(sid); @@ -176,7 +177,7 @@ return "redirect:/extserver/serverlist.do"; } - @RequestMapping(path = "/delete") + @RequestMapping(path = "/delete", method = RequestMethod.POST) public String delete(HttpServletRequest request) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", false); userManagementService.deleteById(ExtServer.class, sid); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java =================================================================== diff -u -rccc788f07597ad3fde52adb6ff13e964b552c35d -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java (.../LtiConsumerManagementController.java) (revision ccc788f07597ad3fde52adb6ff13e964b552c35d) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java (.../LtiConsumerManagementController.java) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -79,7 +79,7 @@ /** * Disables or enables (depending on "disable" parameter) specified LTI tool consumer */ - @RequestMapping(path = "/disable") + @RequestMapping(path = "/disable", method = RequestMethod.POST) public String disable(HttpServletRequest request) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", true); boolean disable = WebUtil.readBooleanParam(request, "disable"); @@ -93,7 +93,7 @@ /** * Removes specified LTI tool consumer */ - @RequestMapping(path = "/delete") + @RequestMapping(path = "/delete", method = RequestMethod.POST) public String delete(HttpServletRequest request) throws Exception { Integer sid = WebUtil.readIntParam(request, "sid", true); userManagementService.deleteById(ExtServer.class, sid); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java =================================================================== diff -u -rf2ad75cef0c507a64877942631fee13efbc6ed50 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java (.../SignupManagementController.java) (revision f2ad75cef0c507a64877942631fee13efbc6ed50) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java (.../SignupManagementController.java) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -22,6 +22,7 @@ import org.springframework.util.MultiValueMap; import org.springframework.web.bind.annotation.ModelAttribute; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; @Controller @RequestMapping("/signupManagement") @@ -134,7 +135,7 @@ return "signupmanagement/add"; } - @RequestMapping(path = "/delete") + @RequestMapping(path = "/delete", method = RequestMethod.POST) public String delete(HttpServletRequest request) throws Exception { Integer soid = WebUtil.readIntParam(request, "soid"); Index: lams_admin/web/WEB-INF/tlds/security/csrfguard.tld =================================================================== diff -u --- lams_admin/web/WEB-INF/tlds/security/csrfguard.tld (revision 0) +++ lams_admin/web/WEB-INF/tlds/security/csrfguard.tld (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -0,0 +1,70 @@ + + + + 1.2 + 2.0 + Owasp CsrfGuard Tag Library + http://www.owasp.org/index.php/Category:OWASP_CSRFGuard_Project/Owasp.CsrfGuard.tld + + token + org.owasp.csrfguard.tag.TokenTag + empty + + uri + false + true + + + + tokenname + org.owasp.csrfguard.tag.TokenNameTag + empty + + + tokenvalue + org.owasp.csrfguard.tag.TokenValueTag + empty + + uri + false + true + + + + a + org.owasp.csrfguard.tag.ATag + true + + + form + org.owasp.csrfguard.tag.FormTag + true + + Index: lams_admin/web/WEB-INF/web.xml =================================================================== diff -u -rb935721d25817b83c29d3166a7fa9b4b9b7d3785 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/WEB-INF/web.xml (.../web.xml) (revision b935721d25817b83c29d3166a7fa9b4b9b7d3785) +++ lams_admin/web/WEB-INF/web.xml (.../web.xml) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -73,7 +73,11 @@ encoding UTF-8 - + + + CSRFGuard + org.owasp.csrfguard.CsrfGuardFilter + SystemSessionFilter @@ -87,6 +91,10 @@ HibernateFilter /* + + CSRFGuard + *.do + org.lamsfoundation.lams.dbupdates.WebAppJNDIMigrationLauncherSynchronizer @@ -180,8 +188,15 @@ tags-lams /WEB-INF/tlds/lams/lams.tld - + + + + + + csrfguard + /WEB-INF/tlds/security/csrfguard.tld + @@ -234,4 +249,4 @@ LAMS System Adminstrator SYSADMIN - \ No newline at end of file + Index: lams_admin/web/config/editconfig.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/config/editconfig.jsp (.../editconfig.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/config/editconfig.jsp (.../editconfig.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -27,9 +27,9 @@ + + - -
Index: lams_admin/web/integration/ltiConsumer.jsp =================================================================== diff -u -r63bee30ea13fab1267c0744f26929af1736a1cf9 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/integration/ltiConsumer.jsp (.../ltiConsumer.jsp) (revision 63bee30ea13fab1267c0744f26929af1736a1cf9) +++ lams_admin/web/integration/ltiConsumer.jsp (.../ltiConsumer.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -53,8 +53,8 @@

- - + + Index: lams_admin/web/integration/ltiConsumerList.jsp =================================================================== diff -u -rccc788f07597ad3fde52adb6ff13e964b552c35d -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/integration/ltiConsumerList.jsp (.../ltiConsumerList.jsp) (revision ccc788f07597ad3fde52adb6ff13e964b552c35d) +++ lams_admin/web/integration/ltiConsumerList.jsp (.../ltiConsumerList.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -51,26 +51,20 @@ Index: lams_admin/web/integration/serverlist.jsp =================================================================== diff -u -rccc788f07597ad3fde52adb6ff13e964b552c35d -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/integration/serverlist.jsp (.../serverlist.jsp) (revision ccc788f07597ad3fde52adb6ff13e964b552c35d) +++ lams_admin/web/integration/serverlist.jsp (.../serverlist.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -14,6 +14,7 @@ +

@@ -47,18 +48,18 @@

Index: lams_admin/web/integration/servermaintain.jsp =================================================================== diff -u -rf0924238dddb80210e0e088cda5fe967f66ef979 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/integration/servermaintain.jsp (.../servermaintain.jsp) (revision f0924238dddb80210e0e088cda5fe967f66ef979) +++ lams_admin/web/integration/servermaintain.jsp (.../servermaintain.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -71,8 +71,8 @@

- - + +
@@ -137,4 +137,4 @@ - \ No newline at end of file + Index: lams_admin/web/loginmaintain.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/loginmaintain.jsp (.../loginmaintain.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/loginmaintain.jsp (.../loginmaintain.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -21,8 +21,8 @@

- - + +

Index: lams_admin/web/policies/editPolicy.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/policies/editPolicy.jsp (.../editPolicy.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/policies/editPolicy.jsp (.../editPolicy.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -70,8 +70,8 @@
- - + +
- +   - - - + "/> - - - + "/>   - - - + "/>
- +   - + "/> - + "/>   - + "/>
@@ -157,4 +157,4 @@ - \ No newline at end of file + Index: lams_admin/web/signupmanagement/add.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/signupmanagement/add.jsp (.../add.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/signupmanagement/add.jsp (.../add.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -20,8 +20,8 @@ - - + +
Index: lams_admin/web/signupmanagement/list.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/signupmanagement/list.jsp (.../list.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/signupmanagement/list.jsp (.../list.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -66,9 +66,10 @@ @@ -79,4 +80,4 @@ - \ No newline at end of file + Index: lams_admin/web/taglibs.jsp =================================================================== diff -u -r9d51ed040508d8d5a10ee4033aded0c3784490a8 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/taglibs.jsp (.../taglibs.jsp) (revision 9d51ed040508d8d5a10ee4033aded0c3784490a8) +++ lams_admin/web/taglibs.jsp (.../taglibs.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -3,5 +3,6 @@ <%@ taglib uri="tags-lams" prefix="lams" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> +<%@ taglib uri="csrfguard" prefix="csrf" %> <%@ taglib uri="tags-function" prefix="fn" %> Index: lams_admin/web/timezoneManagement.jsp =================================================================== diff -u -r37bb2ae017713b44cdfd6a55cfceca28c3efab02 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_admin/web/timezoneManagement.jsp (.../timezoneManagement.jsp) (revision 37bb2ae017713b44cdfd6a55cfceca28c3efab02) +++ lams_admin/web/timezoneManagement.jsp (.../timezoneManagement.jsp) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -49,8 +49,8 @@ - - + +
- -    + +   + "/>
Index: lams_central/conf/security/Owasp.CsrfGuard.properties =================================================================== diff -u -r82166d9c82b6d5ef5fd3f22db5174bbee8a286f4 -r1840d1ada2e0a7dc494e83ed0c183f6c98b6da92 --- lams_central/conf/security/Owasp.CsrfGuard.properties (.../Owasp.CsrfGuard.properties) (revision 82166d9c82b6d5ef5fd3f22db5174bbee8a286f4) +++ lams_central/conf/security/Owasp.CsrfGuard.properties (.../Owasp.CsrfGuard.properties) (revision 1840d1ada2e0a7dc494e83ed0c183f6c98b6da92) @@ -6,6 +6,23 @@ # List of actions to check # Each key goes into a separate line prefixed with org.owasp.csrfguard.protected. # A key suffix must not contain a dot "." character + +# Admin forms +org.owasp.csrfguard.protected.adminSaveConfigSettings=/lams/admin/config/save.do +org.owasp.csrfguard.protected.adminSaveTimezone=/lams/admin/timezonemanagement/save.do +org.owasp.csrfguard.protected.adminSaveLoginpage=/lams/admin/loginsave.do +org.owasp.csrfguard.protected.adminSignupAdd=/lams/admin/signupManagement/add.do +org.owasp.csrfguard.protected.adminSignupDelete=/lams/admin/signupManagement/delete.do +org.owasp.csrfguard.protected.adminLtiConsumerSave=/lams/admin/ltiConsumerManagement/save.do +org.owasp.csrfguard.protected.adminLtiConsumerDelete=/lams/admin/ltiConsumerManagement/delete.do +org.owasp.csrfguard.protected.adminLtiConsumerToggleStatus=/lams/admin/ltiConsumerManagement/disable.do +org.owasp.csrfguard.protected.adminPolicySave=/lams/admin/policyManagement/save.do +org.owasp.csrfguard.protected.adminPolicyToggleStatus=/lams/admin/policyManagement/togglePolicyStatus.do +org.owasp.csrfguard.protected.adminExtserverSave=/lams/admin/extserver/serversave.do +org.owasp.csrfguard.protected.adminExtserverDelete=/lams/admin/extserver/delete.do +org.owasp.csrfguard.protected.adminExtserverDisable=/lams/admin/extserver/disable.do +org.owasp.csrfguard.protected.adminExtserverEnable=/lams/admin/extserver/enable.do + org.owasp.csrfguard.protected.centralSaveUserProfile=/lams/saveprofile.do org.owasp.csrfguard.protected.assessmentDefineLater=/lams/tool/laasse10/authoring/definelater.do