Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/client/Download.java =================================================================== diff -u -r6f700a19baae0fa813ac85e0b4559d0afe27523a -r1e26200cec472e799b29f548270b1a67027e9167 --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/client/Download.java (.../Download.java) (revision 6f700a19baae0fa813ac85e0b4559d0afe27523a) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/client/Download.java (.../Download.java) (revision 1e26200cec472e799b29f548270b1a67027e9167) @@ -295,11 +295,7 @@ response.addHeader("Content-Description", filename); } - InputStream in = fileNode.getFile(); - if (in == null) { - throw new FileException("File not found: " + filename); - } - in = new BufferedInputStream(in); + InputStream in = new BufferedInputStream(fileNode.getFile()); OutputStream out = response.getOutputStream(); try { int count = 0; Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java =================================================================== diff -u -r6f700a19baae0fa813ac85e0b4559d0afe27523a -r1e26200cec472e799b29f548270b1a67027e9167 --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java (.../FileDAO.java) (revision 6f700a19baae0fa813ac85e0b4559d0afe27523a) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java (.../FileDAO.java) (revision 1e26200cec472e799b29f548270b1a67027e9167) @@ -21,6 +21,7 @@ * **************************************************************** */ + package org.lamsfoundation.lams.contentrepository.dao.file; import java.io.BufferedInputStream; @@ -79,7 +80,7 @@ // with a larger buffer /** * Write out a file to the repository. Closes the stream. Overwrites any existing files. - * + * * @return the path to which the file was written */ @Override @@ -143,7 +144,7 @@ /** * Gets a file from the repository. - * + * * @param uuid * node id * @param versionId @@ -156,15 +157,16 @@ try { return new FileInputStream(paths[1]); } catch (IOException e) { - log.debug(e.getMessage()); + e.printStackTrace(); + throw new FileException("Unable to read file for uuid " + uuid + " versionId " + versionId + + " due to an IOException. Generated path was " + paths[1], e); } - return null; } /** * Delete a file from the repository. If this makes the directory * empty, then the directory should be deleted. - * + * * @return 1 if deleted okay, 0 if file not found, -1 if file found but a delete error occured. */ @Override @@ -202,7 +204,7 @@ /** * Get the actual path of the file ie the path on disk - * + * * @throws FileException */ @Override Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/NodeFactory.java =================================================================== diff -u -r6f700a19baae0fa813ac85e0b4559d0afe27523a -r1e26200cec472e799b29f548270b1a67027e9167 --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/NodeFactory.java (.../NodeFactory.java) (revision 6f700a19baae0fa813ac85e0b4559d0afe27523a) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/NodeFactory.java (.../NodeFactory.java) (revision 1e26200cec472e799b29f548270b1a67027e9167) @@ -268,9 +268,6 @@ // this is likely to recopy the Filename and Mimetype properties. if (originalNode.isNodeType(NodeType.FILENODE)) { InputStream istream = originalNode.getFile(); - if (istream == null) { - throw new FileException("File not found"); - } IValue filenameProperty = originalNode.getProperty(PropertyName.FILENAME); IValue mimetypeProperty = originalNode.getProperty(PropertyName.MIMETYPE); newNode.setFile(istream, filenameProperty != null ? filenameProperty.getString() : null, Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleRepository.java =================================================================== diff -u -r6f700a19baae0fa813ac85e0b4559d0afe27523a -r1e26200cec472e799b29f548270b1a67027e9167 --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleRepository.java (.../SimpleRepository.java) (revision 6f700a19baae0fa813ac85e0b4559d0afe27523a) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleRepository.java (.../SimpleRepository.java) (revision 1e26200cec472e799b29f548270b1a67027e9167) @@ -788,9 +788,6 @@ private void saveSigleFile(String toFileName, IVersionedNode node) throws FileException, ValueFormatException, FileUtilException, FileNotFoundException, IOException { InputStream is = node.getFile(); - if (is == null) { - throw new FileException("File not found"); - } if (toFileName == null) { IValue prop = node.getProperty(PropertyName.FILENAME); toFileName = prop != null ? prop.getString() : null; Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java =================================================================== diff -u -r6f700a19baae0fa813ac85e0b4559d0afe27523a -r1e26200cec472e799b29f548270b1a67027e9167 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 6f700a19baae0fa813ac85e0b4559d0afe27523a) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 1e26200cec472e799b29f548270b1a67027e9167) @@ -557,9 +557,6 @@ String fileName = file.getOriginalFilename(); InputStream originalIS = imageGalleryToolContentHandler.getFileInputStream(nodeKey.getUuid()); - if (originalIS == null) { - throw new UploadImageGalleryFileException("File not found"); - } BufferedImage originalImage = ImageIO.read(originalIS); //throw exception if image was not successfully read if (originalImage == null) { @@ -641,7 +638,7 @@ public void auditLogStartEditingActivityInMonitor(long toolContentID) { toolService.auditLogStartEditingActivityInMonitor(toolContentID); } - + @Override public boolean isLastActivity(Long toolSessionId) { return toolService.isLastActivity(toolSessionId);