Index: lams_common/src/java/org/lamsfoundation/lams/rating/dao/IRatingDAO.java
===================================================================
diff -u -r42cd8d7da9fa6615dbd82d376984000024b4b0fe -r223de22225bd6f7969f417b6d17ba681671af095
--- lams_common/src/java/org/lamsfoundation/lams/rating/dao/IRatingDAO.java (.../IRatingDAO.java) (revision 42cd8d7da9fa6615dbd82d376984000024b4b0fe)
+++ lams_common/src/java/org/lamsfoundation/lams/rating/dao/IRatingDAO.java (.../IRatingDAO.java) (revision 223de22225bd6f7969f417b6d17ba681671af095)
@@ -30,7 +30,6 @@
import java.util.Map;
import org.lamsfoundation.lams.rating.dto.ItemRatingCriteriaDTO;
-import org.lamsfoundation.lams.rating.dto.StyledRatingDTO;
import org.lamsfoundation.lams.rating.model.Rating;
public interface IRatingDAO {
Index: lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingDAO.java
===================================================================
diff -u -r42cd8d7da9fa6615dbd82d376984000024b4b0fe -r223de22225bd6f7969f417b6d17ba681671af095
--- lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingDAO.java (.../RatingDAO.java) (revision 42cd8d7da9fa6615dbd82d376984000024b4b0fe)
+++ lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingDAO.java (.../RatingDAO.java) (revision 223de22225bd6f7969f417b6d17ba681671af095)
@@ -89,7 +89,7 @@
// Used by tools to get the ratings and comments relating to their items. To be used within SQL and supply criteriaId as :ratingCriteriaId
// See Peer Review for example usage.
private static final String TOOL_SELECT_LEFT_JOIN_BY_USER_COMMENT = "SELECT r.item_id, r.comment "
- + " FROM lams_rating_comment r WHERE r.rating_criteria_id = :ratingCriteriaId ";
+ + " FROM lams_rating_comment r WHERE r.rating_criteria_id = :ratingCriteriaId AND r.user_id = :userId";
// Same as TOOL_SELECT_LEFT_JOIN_BY_USER_STANDARD except that it returns the average results for a single user (:userId), as left by other users
private static final String TOOL_SELECT_LEFT_JOIN_FOR_USER_STANDARD = "SELECT DISTINCT r.item_id, rc.comment, NULL rating, calc.average_rating, calc.count_vote "
Index: lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java
===================================================================
diff -u -r42cd8d7da9fa6615dbd82d376984000024b4b0fe -r223de22225bd6f7969f417b6d17ba681671af095
--- lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java (.../RatingService.java) (revision 42cd8d7da9fa6615dbd82d376984000024b4b0fe)
+++ lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java (.../RatingService.java) (revision 223de22225bd6f7969f417b6d17ba681671af095)
@@ -656,6 +656,11 @@
userRow.put("userRating", row[3] == null ? "" : numberFormat.format((Float) row[3]));
userRow.put("averageRating", row[4] == null ? "" : numberFormat.format((Double) row[4]));
userRow.put("numberOfVotes", row[5] == null ? "" : numberFormat.format((BigInteger) row[5]));
+ } else {
+ // don't have missing entries in JSON or an exception can occur if you try to access them
+ userRow.put("userRating", "");
+ userRow.put("averageRating", "");
+ userRow.put("numberOfVotes", "");
}
rows.put(userRow);
Fisheye: Tag 223de22225bd6f7969f417b6d17ba681671af095 refers to a dead (removed) revision in file `lams_tool_preview/web/pages/monitoring/criteriaToDelete.jsp'.
Fisheye: No comparison available. Pass `N' to diff?
Index: lams_tool_preview/web/pages/monitoring/criteriapart.jsp
===================================================================
diff -u
--- lams_tool_preview/web/pages/monitoring/criteriapart.jsp (revision 0)
+++ lams_tool_preview/web/pages/monitoring/criteriapart.jsp (revision 223de22225bd6f7969f417b6d17ba681671af095)
@@ -0,0 +1,144 @@
+<%@ include file="/common/taglibs.jsp"%>
+
+
+