Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java =================================================================== diff -u -r26cce7618c8f32ad2ec6a31a85b63ca4de659d87 -r3667835e31310dd9c09421264275fdb08ddd7123 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java (.../GBActivityGridRowDTO.java) (revision 26cce7618c8f32ad2ec6a31a85b63ca4de659d87) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java (.../GBActivityGridRowDTO.java) (revision 3667835e31310dd9c09421264275fdb08ddd7123) @@ -28,6 +28,7 @@ import java.util.Set; import org.lamsfoundation.lams.gradebook.util.GBGridView; +import org.lamsfoundation.lams.gradebook.util.GradebookUtil; import org.lamsfoundation.lams.learningdesign.CompetenceMapping; import org.lamsfoundation.lams.learningdesign.ToolActivity; @@ -107,8 +108,7 @@ ret.add(startDate != null ? convertDateToString(startDate, DEFAULT_DATE_FORMAT) : CELL_EMPTY); ret.add(timeTaken != null ? convertTimeToString(timeTaken) : CELL_EMPTY); ret.add(feedback); - - ret.add(markToString()); + ret.add(mark != null ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); } else if (view == GBGridView.MON_ACTIVITY) { @@ -123,19 +123,17 @@ ret.add((averageTimeTaken != null) ? convertTimeToString(averageTimeTaken) : CELL_EMPTY); ret.add(competences); + ret.add(mark != null ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); - - ret.add(averageMarkToString()); } else if (view == GBGridView.LRN_ACTIVITY) { ret.add(rowName); ret.add(status); ret.add(feedback); ret.add((averageTimeTaken != null) ? convertTimeToString(averageTimeTaken) : CELL_EMPTY); ret.add((timeTaken != null) ? convertTimeToString(timeTaken) : CELL_EMPTY); - ret.add(averageMarkToString()); + ret.add(averageMark != null ? GradebookUtil.niceFormatting(averageMark) : CELL_EMPTY); + ret.add(mark != null ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); - - ret.add(markToString()); } return ret; Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBLessonGridRowDTO.java =================================================================== diff -u -r26cce7618c8f32ad2ec6a31a85b63ca4de659d87 -r3667835e31310dd9c09421264275fdb08ddd7123 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBLessonGridRowDTO.java (.../GBLessonGridRowDTO.java) (revision 26cce7618c8f32ad2ec6a31a85b63ca4de659d87) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBLessonGridRowDTO.java (.../GBLessonGridRowDTO.java) (revision 3667835e31310dd9c09421264275fdb08ddd7123) @@ -26,6 +26,7 @@ import java.util.ArrayList; import org.lamsfoundation.lams.gradebook.util.GBGridView; +import org.lamsfoundation.lams.gradebook.util.GradebookUtil; public class GBLessonGridRowDTO extends GradebookGridRowDTO { @@ -61,7 +62,7 @@ ret.add(subGroup); ret.add(startDate); ret.add((averageTimeTaken != null && averageTimeTaken != 0) ? convertTimeToString(averageTimeTaken) : CELL_EMPTY); - ret.add((averageMark != null) ? averageMark.toString() : CELL_EMPTY); + ret.add((averageMark != null) ? GradebookUtil.niceFormatting(averageMark) : CELL_EMPTY); } else if ((view == GBGridView.LRN_COURSE) || (view == GBGridView.MON_USER)) { if (gradebookLearnerURL != null && gradebookLearnerURL.length() != 0) { @@ -77,8 +78,8 @@ ret.add((finishDate != null) ? finishDate : CELL_EMPTY); ret.add((averageTimeTaken != null && averageTimeTaken != 0) ? toItalic(convertTimeToString(averageTimeTaken)) : CELL_EMPTY); ret.add((timeTaken != null) ? convertTimeToString(timeTaken) : CELL_EMPTY); - ret.add((averageMark != null) ? toItalic(averageMark.toString()) : CELL_EMPTY); - ret.add((mark != null) ? mark.toString() : CELL_EMPTY); + ret.add((averageMark != null) ? toItalic(GradebookUtil.niceFormatting(averageMark)) : CELL_EMPTY); + ret.add((mark != null) ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); } return ret; @@ -132,5 +133,4 @@ this.finishDate = finishDate; } - } Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java =================================================================== diff -u -r26cce7618c8f32ad2ec6a31a85b63ca4de659d87 -r3667835e31310dd9c09421264275fdb08ddd7123 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java (.../GBUserGridRowDTO.java) (revision 26cce7618c8f32ad2ec6a31a85b63ca4de659d87) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java (.../GBUserGridRowDTO.java) (revision 3667835e31310dd9c09421264275fdb08ddd7123) @@ -27,6 +27,7 @@ import java.util.Date; import org.lamsfoundation.lams.gradebook.util.GBGridView; +import org.lamsfoundation.lams.gradebook.util.GradebookUtil; import org.lamsfoundation.lams.usermanagement.User; public class GBUserGridRowDTO extends GradebookGridRowDTO { @@ -63,9 +64,8 @@ ret.add(status); ret.add((timeTaken != null) ? convertTimeToString(timeTaken) : CELL_EMPTY); ret.add(feedback); - //ret.add((mark != null) ? mark.toString() : CELL_EMPTY); - ret.add(markToString()); - + ret.add((mark != null) ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); + } else if (view == GBGridView.MON_ACTIVITY){ ret.add(marksAvailable != null ? marksAvailable.toString() : ""); @@ -80,16 +80,14 @@ ret.add((timeTaken != null) ? convertTimeToString(timeTaken) : CELL_EMPTY); ret.add((output != null) ? output.toString() : CELL_EMPTY); ret.add(feedback); - //ret.add((mark != null) ? mark.toString() : CELL_EMPTY); - ret.add(markToString()); + ret.add((mark != null) ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); } else if (view == GBGridView.MON_COURSE){ ret.add(rowName); ret.add(status); ret.add((timeTaken != null) ? convertTimeToString(timeTaken) : CELL_EMPTY); ret.add(feedback); - //ret.add((mark != null) ? mark.toString() : CELL_EMPTY); - ret.add(markToString()); + ret.add((mark != null) ? GradebookUtil.niceFormatting(mark) : CELL_EMPTY); } return ret; Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookUtil.java =================================================================== diff -u -r5a5f3640c4d5fdf0c302347e7d6b502a972fd9cc -r3667835e31310dd9c09421264275fdb08ddd7123 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookUtil.java (.../GradebookUtil.java) (revision 5a5f3640c4d5fdf0c302347e7d6b502a972fd9cc) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookUtil.java (.../GradebookUtil.java) (revision 3667835e31310dd9c09421264275fdb08ddd7123) @@ -27,6 +27,7 @@ import java.io.OutputStream; import java.io.StringWriter; import java.text.SimpleDateFormat; +import java.text.DecimalFormat; import java.util.ArrayList; import java.util.Collections; import java.util.Date; @@ -176,7 +177,15 @@ return xml; } - + + public static String niceFormatting(Double mark) { + + String markStr = new DecimalFormat("##0.00").format(mark); + return markStr; + + } + + private static Document getDocument() throws ParserConfigurationException { DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance(); DocumentBuilder builder = factory.newDocumentBuilder(); Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java =================================================================== diff -u -r246994a59d7c4ff0dfd17290461e112bedfc6545 -r3667835e31310dd9c09421264275fdb08ddd7123 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java (.../GradebookAction.java) (revision 246994a59d7c4ff0dfd17290461e112bedfc6545) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java (.../GradebookAction.java) (revision 3667835e31310dd9c09421264275fdb08ddd7123) @@ -362,7 +362,7 @@ if (lesson != null && learner != null) { GradebookUserLesson lessonMark = gradebookService.getGradebookUserLesson(lessonID, userID); - writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, lessonMark.getMark().toString()); + writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, GradebookUtil.niceFormatting(lessonMark.getMark())); } else { // Grid will handle error, just log and return null logger.error("Error: request for course gradebook data with null user or lesson. lessonID: " + lessonID); @@ -406,7 +406,7 @@ Double averageMark = gradebookService.getAverageMarkForActivity(activityID, groupID); if (averageMark != null) { - writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, averageMark.toString()); + writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, GradebookUtil.niceFormatting(averageMark)); } else { writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, GradebookConstants.CELL_EMPTY); } @@ -439,7 +439,7 @@ Double averageMark = gradebookService.getAverageMarkForLesson(lessonID); if (averageMark != null) { - writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, averageMark.toString()); + writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, GradebookUtil.niceFormatting(averageMark)); } else { writeResponse(response, CONTENT_TYPE_TEXT_PLAIN, ENCODING_UTF8, GradebookConstants.CELL_EMPTY); }