Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java =================================================================== diff -u -rf2ad75cef0c507a64877942631fee13efbc6ed50 -r3920cb7cce6c4cf2c2f8aa7eec77b0b30b3629ed --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java (.../UserRolesSaveController.java) (revision f2ad75cef0c507a64877942631fee13efbc6ed50) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java (.../UserRolesSaveController.java) (revision 3920cb7cce6c4cf2c2f8aa7eec77b0b30b3629ed) @@ -75,14 +75,18 @@ request.setAttribute("org", orgId); - log.debug("userId: " + userId + ", orgId: " + orgId + " will have " + roles.length + " roles"); + if (log.isDebugEnabled()) { + String numRoles = roles != null ? Integer.toString(roles.length) : "0"; + log.debug(new StringBuilder("userId: ").append(userId).append(", orgId: ").append(orgId) + .append(" will have ").append(numRoles).append(" roles").toString()); + } Organisation org = (Organisation) userManagementService.findById(Organisation.class, orgId); User user = (User) userManagementService.findById(User.class, userId); MultiValueMap errorMap = new LinkedMultiValueMap<>(); // user must have at least 1 role - if (roles.length < 1) { + if (roles == null || roles.length < 1) { errorMap.add("roles", messageService.getMessage("error.roles.empty")); request.setAttribute("errorMap", errorMap); request.setAttribute("rolelist",