Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dbupdates/patch20181216.sql =================================================================== diff -u --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dbupdates/patch20181216.sql (revision 0) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dbupdates/patch20181216.sql (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -0,0 +1,17 @@ +-- Turn off autocommit, so nothing is committed if there is an error +SET AUTOCOMMIT = 0; +SET FOREIGN_KEY_CHECKS=0; +----------------------Put all sql statements below here------------------------- + +-- LDEV-4707 Remove never used fields from TaskListItem +ALTER TABLE tl_latask10_tasklist_item DROP COLUMN show_comments_to_all, + DROP COLUMN is_comments_files_allowed; + +UPDATE lams_tool SET tool_version='20181216' WHERE tool_signature='latask10'; + +----------------------Put all sql statements above here------------------------- + +-- If there were no errors, commit and restore autocommit to on +COMMIT; +SET AUTOCOMMIT = 1; +SET FOREIGN_KEY_CHECKS=1; \ No newline at end of file Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/model/TaskListItem.java =================================================================== diff -u -r0b3631fb6cd93265967ec5d314313e15999d9061 -r3b9eccb4b8def4d56a62641a0fe4038a60b3afe6 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/model/TaskListItem.java (.../TaskListItem.java) (revision 0b3631fb6cd93265967ec5d314313e15999d9061) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/model/TaskListItem.java (.../TaskListItem.java) (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -106,13 +106,6 @@ @Column(name = "parent_task_name") private String parentTaskName; - - // advanced options that are not used now - @Column(name = "is_comments_files_allowed") - private boolean isCommentsFilesAllowed; - - @Column(name = "show_comments_to_all") - private boolean showCommentsToAll; @OneToMany(cascade = CascadeType.ALL) @JoinColumn(name = "taskList_item_uid") @@ -354,24 +347,6 @@ this.parentTaskName = parentTaskName; } - public boolean getShowCommentsToAll() { - return showCommentsToAll; - } - - public void setShowCommentsToAll(boolean showCommentsToAll) { - this.showCommentsToAll = showCommentsToAll; - } - - public boolean isCommentsFilesAllowed() { - // true bacause we can not set it from the UI - // TODO get rid of this later - return true; - } - - public void setCommentsFilesAllowed(boolean isCommentsFilesAllowed) { - this.isCommentsFilesAllowed = isCommentsFilesAllowed; - } - /** * @return a set of Attachments to this TaskListItem. */ Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListImportContentVersionFilter.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r3b9eccb4b8def4d56a62641a0fe4038a60b3afe6 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListImportContentVersionFilter.java (.../TaskListImportContentVersionFilter.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListImportContentVersionFilter.java (.../TaskListImportContentVersionFilter.java) (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -25,6 +25,7 @@ import org.lamsfoundation.lams.learningdesign.service.ToolContentVersionFilter; import org.lamsfoundation.lams.tool.taskList.model.TaskList; +import org.lamsfoundation.lams.tool.taskList.model.TaskListItem; /** * Import filter class for different version of TaskList content. @@ -40,4 +41,12 @@ this.removeField(TaskList.class, "offlineInstructions"); this.removeField(TaskList.class, "attachments"); } + + /** + * Import 20110510 version content to 20140102 version tool server. + */ + public void up20180425To20181216() { + this.removeField(TaskListItem.class, "showCommentsToAll"); + this.removeField(TaskListItem.class, "commentsFilesAllowed"); + } } \ No newline at end of file Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/controller/AuthoringController.java =================================================================== diff -u -r8fb34ff788990c3ae25a0661090636b38bdecec2 -r3b9eccb4b8def4d56a62641a0fe4038a60b3afe6 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/controller/AuthoringController.java (.../AuthoringController.java) (revision 8fb34ff788990c3ae25a0661090636b38bdecec2) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/controller/AuthoringController.java (.../AuthoringController.java) (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -604,10 +604,6 @@ taskListItemForm.setCommentsRequired(item.isCommentsRequired()); taskListItemForm.setFilesAllowed(item.isFilesAllowed()); taskListItemForm.setFilesRequired(item.isFilesRequired()); - // The next 2 options always will be true (as it set in jsp). Waiting - // for the final decision -- if this options will be needed later. - taskListItemForm.setCommentsFilesAllowed(item.isCommentsFilesAllowed()); - taskListItemForm.setShowCommentsToAll(item.getShowCommentsToAll()); taskListItemForm.setChildTask(item.isChildTask()); taskListItemForm.setParentTaskName(item.getParentTaskName()); } @@ -654,10 +650,6 @@ item.setCommentsRequired(itemForm.isCommentsRequired()); item.setFilesAllowed(itemForm.isFilesAllowed()); item.setFilesRequired(itemForm.isFilesRequired()); - // The next 2 options always will be true (as it set in jsp). Waiting - // for the final decision -- if this options will be needed later. - item.setCommentsFilesAllowed(itemForm.isCommentsFilesAllowed()); - item.setShowCommentsToAll(itemForm.getShowCommentsToAll()); item.setChildTask(itemForm.isChildTask()); item.setParentTaskName(itemForm.getParentTaskName()); } @@ -683,8 +675,6 @@ itemPO.setCommentsRequired(itemFromSession.isCommentsRequired()); itemPO.setFilesAllowed(itemFromSession.isFilesAllowed()); itemPO.setFilesRequired(itemFromSession.isFilesRequired()); - itemPO.setCommentsFilesAllowed(itemFromSession.isCommentsFilesAllowed()); - itemPO.setShowCommentsToAll(itemFromSession.getShowCommentsToAll()); itemPO.setChildTask(itemFromSession.isChildTask()); itemPO.setParentTaskName(itemFromSession.getParentTaskName()); } Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/form/TaskListItemForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r3b9eccb4b8def4d56a62641a0fe4038a60b3afe6 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/form/TaskListItemForm.java (.../TaskListItemForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/form/TaskListItemForm.java (.../TaskListItemForm.java) (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -50,11 +50,6 @@ private boolean isFilesRequired; private boolean isChildTask; - // The next 2 options always will be true (as it set in jsp). Waiting - // for the final decision -- if this options will be needed later. - private boolean isCommentsFilesAllowed; - private boolean showCommentsToAll; - private String parentTaskName; private MultipartFile uploadedFile; @@ -250,49 +245,7 @@ this.isFilesRequired = isFilesRequired; } - // The next 2 options always will be true (as it set in jsp). Waiting - // for the final decision -- if this options will be needed later. /** - * Returns whether comments are allowed in this TaskLiskItem. - * - * @return true if comments are allowed in this TaskLiskItem, false otherwise. - */ - public boolean isCommentsFilesAllowed() { - return isCommentsFilesAllowed; - } - - /** - * Sets whether comments are allowed in this TaskLiskItem. - * - * @param isCommentsAllowed - * true if comments are allowed in this TaskLiskItem, false otherwise. - */ - public void setCommentsFilesAllowed(boolean isCommentsFilesAllowed) { - this.isCommentsFilesAllowed = isCommentsFilesAllowed; - } - - /** - * Returns whether comments are allowed to be shown to everybody for this TaskLiskItem. - * - * @return true if comments are allowed to be shown to everybody for this TaskLiskItem, false - * otherwise. - */ - public boolean getShowCommentsToAll() { - return showCommentsToAll; - } - - /** - * Sets whether comments are allowed to be shown to everybody for this TaskLiskItem or not. - * - * @param showCommentsToAll - * true if comments are allowed to be shown to everybody for this TaskLiskItem, false - * otherwise. - */ - public void setShowCommentsToAll(boolean showCommentsToAll) { - this.showCommentsToAll = showCommentsToAll; - } - - /** * Returns whether this TaskLiskItem is a child task. * * @return true if this TaskLiskItem is a child task, false otherwise. Index: lams_tool_task/web/pages/authoring/parts/addtask.jsp =================================================================== diff -u -raced7ba6c1e7c5a9a50d3f64d8cdd96dd7e76194 -r3b9eccb4b8def4d56a62641a0fe4038a60b3afe6 --- lams_tool_task/web/pages/authoring/parts/addtask.jsp (.../addtask.jsp) (revision aced7ba6c1e7c5a9a50d3f64d8cdd96dd7e76194) +++ lams_tool_task/web/pages/authoring/parts/addtask.jsp (.../addtask.jsp) (revision 3b9eccb4b8def4d56a62641a0fe4038a60b3afe6) @@ -29,11 +29,8 @@ - - -