Index: lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/AuthoringAction.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -75,7 +75,6 @@ /** * @author Marcin Cieslak - * @version $Revision$ */ public class AuthoringAction extends Action { @@ -153,7 +152,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, DacoConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int questionIndex = NumberUtils.stringToInt(request.getParameter(DacoConstants.PARAM_QUESTION_INDEX), -1); DacoQuestion question = null; DacoQuestionForm questionForm = (DacoQuestionForm) form; @@ -185,7 +184,7 @@ * question. */ - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(questionForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(questionForm.getSessionMapID()); // check whether it is "edit(old question)" or "add(new question)" SortedSet questionSet = getQuestionList(sessionMap); int questionIndex = NumberUtils.stringToInt(questionForm.getQuestionIndex(), -1); @@ -362,7 +361,7 @@ * @param request * @return */ - protected List getDeletedDacoQuestionList(SessionMap sessionMap) { + protected List getDeletedDacoQuestionList(SessionMap sessionMap) { return getListFromSession(sessionMap, DacoConstants.ATTR_DELETED_QUESTION_LIST); } @@ -373,7 +372,7 @@ * @param name * @return */ - protected List getListFromSession(SessionMap sessionMap, String name) { + protected List getListFromSession(SessionMap sessionMap, String name) { List list = (List) sessionMap.get(name); if (list == null) { list = new ArrayList(); @@ -406,7 +405,7 @@ * @param request * @return */ - protected SortedSet getQuestionList(SessionMap sessionMap) { + protected SortedSet getQuestionList(SessionMap sessionMap) { SortedSet list = (SortedSet) sessionMap.get(DacoConstants.ATTR_QUESTION_LIST); if (list == null) { @@ -429,7 +428,7 @@ protected ActionForward initPage(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws ServletException { String sessionMapID = WebUtil.readStrParam(request, DacoConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); DacoForm existForm = (DacoForm) sessionMap.get(DacoConstants.ATTR_DACO_FORM); DacoForm dacoForm = (DacoForm) form; @@ -440,11 +439,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(DacoConstants.SUCCESS); - } else { - return mapping.findForward(DacoConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(DacoConstants.SUCCESS); } /** @@ -594,7 +591,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, DacoConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int questionIndex = NumberUtils.stringToInt(request.getParameter(DacoConstants.PARAM_QUESTION_INDEX), -1); if (questionIndex != -1) { @@ -686,7 +683,7 @@ DacoForm dacoForm = (DacoForm) form; // initial Session Map - SessionMap sessionMap = new SessionMap(); + SessionMap sessionMap = new SessionMap(); request.getSession().setAttribute(sessionMap.getSessionID(), sessionMap); dacoForm.setSessionMapID(sessionMap.getSessionID()); @@ -764,18 +761,15 @@ DacoForm dacoForm = (DacoForm) form; // get back sessionMAP - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(dacoForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(dacoForm.getSessionMapID()); ToolAccessMode toolAccessMode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, toolAccessMode.toString()); ActionMessages errors = validateDacoForm(dacoForm, mapping, request); if (!errors.isEmpty()) { saveErrors(request, errors); - if (toolAccessMode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + return mapping.findForward(DacoConstants.SUCCESS); } Daco daco = dacoForm.getDaco(); @@ -788,19 +782,17 @@ dacoPO = daco; dacoPO.setCreated(new Timestamp(new Date().getTime())); dacoPO.setUpdated(new Timestamp(new Date().getTime())); + } else { service.releaseDacoFromCache(dacoPO); - if (toolAccessMode.isAuthor()) { - - Long uid = dacoPO.getUid(); - PropertyUtils.copyProperties(dacoPO, daco); - // get back UID - dacoPO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content - // (definelater) - dacoPO.setInstructions(daco.getInstructions()); - dacoPO.setTitle(daco.getTitle()); - // change define later status + + Long uid = dacoPO.getUid(); + PropertyUtils.copyProperties(dacoPO, daco); + // get back UID + dacoPO.setUid(uid); + + // if it's a teacher - change define later status + if (toolAccessMode.isTeacher()) { dacoPO.setDefineLater(false); } dacoPO.setUpdated(new Timestamp(new Date().getTime())); @@ -849,12 +841,7 @@ request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (toolAccessMode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - + return mapping.findForward(DacoConstants.SUCCESS); } protected ActionMessages validateDacoForm(DacoForm dacoForm, ActionMapping mapping, HttpServletRequest request) { @@ -866,13 +853,6 @@ new ActionMessage(DacoConstants.ERROR_MSG_RECORDLIMIT_MIN_TOOHIGH_MAX)); } - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - // Some other validation outside basic Tab. - return errors; } Index: lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/ClearSessionAction.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/ClearSessionAction.java (.../ClearSessionAction.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/action/ClearSessionAction.java (.../ClearSessionAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -33,8 +33,6 @@ * This class give a chance to clear HttpSession when user save/close authoring page. * * @author Steve.Ni - * - * @version $Revision$ */ public class ClearSessionAction extends LamsAuthoringFinishAction { Index: lams_tool_daco/web/WEB-INF/struts-config.xml =================================================================== diff -u -r14c269dab2fd9de7863a2074fd5ee1561215d066 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_daco/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 14c269dab2fd9de7863a2074fd5ee1561215d066) +++ lams_tool_daco/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -52,28 +52,46 @@ - + - + - + - - - - + + - + @@ -86,8 +104,12 @@ - + @@ -100,8 +122,12 @@ - + @@ -114,100 +140,152 @@ - - - - + - + - + - + - + - + - + - + - + - + - + - + - - + - + - + - + - + + - + Index: lams_tool_daco/web/pages/authoring/authoring.jsp =================================================================== diff -u -r756d63ed6f0fe8da2cbd61b5420f49def38d7590 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_daco/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 756d63ed6f0fe8da2cbd61b5420f49def38d7590) +++ lams_tool_daco/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -1,10 +1,8 @@ - + <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.tool.daco.DacoConstants"%> - <fmt:message key="label.common.heading" /> @@ -18,7 +16,6 @@ selectTab(tag.value); else selectTab(1); //select the default tab; - } function doSelectTab(tabId) { @@ -27,62 +24,55 @@ tag.value = tabId; // end optional tab controller stuff selectTab(tabId); - } - - - - - - - - + + + + - + + + + <%@ include file="/common/messages.jsp"%> + + + + + + + + + + + + + + + + + +
+ +
+
+ + + + +
- - <%@ include file="/common/messages.jsp"%> - - - - - - - - - - - - - - - - - - - -
- -
-
- - - - - -
Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_daco/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/AuthoringAction.java =================================================================== diff -u -rc022c18db5de76344466905b76929dd951481994 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision c022c18db5de76344466905b76929dd951481994) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -256,11 +256,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(ImageGalleryConstants.SUCCESS); - } else { - return mapping.findForward(ImageGalleryConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(ImageGalleryConstants.SUCCESS); } /** @@ -281,17 +279,8 @@ SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(imageGalleryForm.getSessionMapID()); ToolAccessMode mode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); - ActionMessages errors = validateImageGallery(imageGalleryForm, request); - if (!errors.isEmpty()) { - saveErrors(request, errors); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - } - ImageGallery imageGallery = imageGalleryForm.getImageGallery(); IImageGalleryService service = getImageGalleryService(); Long contentId = imageGalleryForm.getImageGallery().getContentId(); @@ -303,16 +292,16 @@ imageGalleryPO = imageGallery; imageGalleryPO.setCreated(new Timestamp(new Date().getTime())); imageGalleryPO.setUpdated(new Timestamp(new Date().getTime())); + } else { - if (mode.isAuthor()) { - Long uid = imageGalleryPO.getUid(); - PropertyUtils.copyProperties(imageGalleryPO, imageGallery); - // get back UID - imageGalleryPO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content (definelater) - imageGalleryPO.setInstructions(imageGallery.getInstructions()); - imageGalleryPO.setTitle(imageGallery.getTitle()); - // change define later status + + Long uid = imageGalleryPO.getUid(); + PropertyUtils.copyProperties(imageGalleryPO, imageGallery); + // get back UID + imageGalleryPO.setUid(uid); + + // if it's a teacher - change define later status + if (mode.isTeacher()) { imageGalleryPO.setDefineLater(false); } imageGalleryPO.setUpdated(new Timestamp(new Date().getTime())); @@ -387,11 +376,8 @@ imageGalleryForm.setImageGallery(imageGalleryPO); request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + + return mapping.findForward(ImageGalleryConstants.SUCCESS); } // ********************************************************** @@ -872,24 +858,6 @@ } /** - * Validate imageGallery. - * - * @param imageGalleryForm - * @return - */ - private ActionMessages validateImageGallery(ImageGalleryForm imageGalleryForm, HttpServletRequest request) { - ActionMessages errors = new ActionMessages(); - - // define it later mode(TEACHER) skip below validation. - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - return errors; - } - - /** * Get ToolAccessMode from HttpRequest parameters. Default value is AUTHOR mode. * * @param request Index: lams_tool_images/web/WEB-INF/struts-config.xml =================================================================== diff -u -rb590efa8f4c159b483268a6b5f4417b6f16c37d9 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_images/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision b590efa8f4c159b483268a6b5f4417b6f16c37d9) +++ lams_tool_images/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -85,16 +85,14 @@ parameter="initPage" validate="false"> -
- - + - + @@ -80,8 +80,7 @@
Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_images/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/action/AuthoringAction.java =================================================================== diff -u -r2bef59c032438311b6dfadac874b0a7ee4cb72de -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 2bef59c032438311b6dfadac874b0a7ee4cb72de) +++ lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -162,7 +162,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, CommonCartridgeConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int itemIdx = NumberUtils.stringToInt(request.getParameter(CommonCartridgeConstants.PARAM_ITEM_INDEX), -1); if (itemIdx != -1) { @@ -194,7 +194,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, CommonCartridgeConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int itemIdx = NumberUtils.stringToInt(request.getParameter(CommonCartridgeConstants.PARAM_ITEM_INDEX), -1); CommonCartridgeItem item = null; @@ -291,7 +291,7 @@ HttpServletResponse response) { //count uploaded resources String sessionMapID = WebUtil.readStrParam(request, CommonCartridgeConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); List uploadedCartridgeResources = getUploadedCartridgeResources(sessionMap); int countUploadedResources = uploadedCartridgeResources.size(); @@ -359,7 +359,7 @@ commonCartridgeForm.setContentFolderID(contentFolderID); // initial Session Map - SessionMap sessionMap = new SessionMap(); + SessionMap sessionMap = new SessionMap(); request.getSession().setAttribute(sessionMap.getSessionID(), sessionMap); commonCartridgeForm.setSessionMapID(sessionMap.getSessionID()); @@ -425,7 +425,7 @@ private ActionForward initPage(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws ServletException { String sessionMapID = WebUtil.readStrParam(request, CommonCartridgeConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); CommonCartridgeForm existForm = (CommonCartridgeForm) sessionMap .get(CommonCartridgeConstants.ATTR_RESOURCE_FORM); @@ -437,11 +437,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(CommonCartridgeConstants.SUCCESS); - } else { - return mapping.findForward(CommonCartridgeConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(CommonCartridgeConstants.SUCCESS); } /** @@ -460,20 +458,11 @@ CommonCartridgeForm commonCartridgeForm = (CommonCartridgeForm) form; // get back sessionMAP - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(commonCartridgeForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(commonCartridgeForm.getSessionMapID()); ToolAccessMode mode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); - ActionMessages errors = validate(commonCartridgeForm, mapping, request); - if (!errors.isEmpty()) { - saveErrors(request, errors); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - } - CommonCartridge commonCartridge = commonCartridgeForm.getCommonCartridge(); ICommonCartridgeService service = getCommonCartridgeService(); @@ -485,18 +474,18 @@ commonCartridgePO = commonCartridge; commonCartridgePO.setCreated(new Timestamp(new Date().getTime())); commonCartridgePO.setUpdated(new Timestamp(new Date().getTime())); + } else { - if (mode.isAuthor()) { - Long uid = commonCartridgePO.getUid(); - PropertyUtils.copyProperties(commonCartridgePO, commonCartridge); - // get back UID - commonCartridgePO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content (definelater) - commonCartridgePO.setInstructions(commonCartridge.getInstructions()); - commonCartridgePO.setTitle(commonCartridge.getTitle()); - // change define later status + Long uid = commonCartridgePO.getUid(); + PropertyUtils.copyProperties(commonCartridgePO, commonCartridge); + // get back UID + commonCartridgePO.setUid(uid); + + // if it's a teacher - change define later status + if (mode.isTeacher()) { commonCartridgePO.setDefineLater(false); } + commonCartridgePO.setUpdated(new Timestamp(new Date().getTime())); } @@ -549,11 +538,7 @@ commonCartridgeForm.setCommonCartridge(commonCartridgePO); request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + return mapping.findForward(CommonCartridgeConstants.SUCCESS); } // ************************************************************************************* @@ -574,7 +559,7 @@ * @param request * @return */ - private List getUploadedCartridgeResources(SessionMap sessionMap) { + private List getUploadedCartridgeResources(SessionMap sessionMap) { return getListFromSession(sessionMap, "uploadedCartridgeResources"); } @@ -584,7 +569,7 @@ * @param request * @return */ - private SortedSet getCommonCartridgeItemList(SessionMap sessionMap) { + private SortedSet getCommonCartridgeItemList(SessionMap sessionMap) { SortedSet list = (SortedSet) sessionMap .get(CommonCartridgeConstants.ATTR_RESOURCE_ITEM_LIST); if (list == null) { @@ -600,7 +585,7 @@ * @param request * @return */ - private List getDeletedCommonCartridgeItemList(SessionMap sessionMap) { + private List getDeletedCommonCartridgeItemList(SessionMap sessionMap) { return getListFromSession(sessionMap, CommonCartridgeConstants.ATTR_DELETED_RESOURCE_ITEM_LIST); } @@ -611,7 +596,7 @@ * @param name * @return */ - private List getListFromSession(SessionMap sessionMap, String name) { + private List getListFromSession(SessionMap sessionMap, String name) { List list = (List) sessionMap.get(name); if (list == null) { list = new ArrayList(); @@ -717,7 +702,7 @@ //item.setDescription(itemForm.getDescription()); } - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); List uploadedCartridgeResources = getUploadedCartridgeResources(sessionMap); uploadedCartridgeResources.clear(); uploadedCartridgeResources.addAll(items); @@ -738,7 +723,7 @@ * be set when persisting this commonCartridge item. */ - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); // check whether it is "edit(old item)" or "add(new item)" SortedSet commonCartridgeList = getCommonCartridgeItemList(sessionMap); int itemIdx = NumberUtils.stringToInt(itemForm.getItemIndex(), -1); @@ -842,25 +827,6 @@ return mode; } - private ActionMessages validate(CommonCartridgeForm commonCartridgeForm, ActionMapping mapping, - HttpServletRequest request) { - ActionMessages errors = new ActionMessages(); - // if (StringUtils.isBlank(commonCartridgeForm.getCommonCartridge().getTitle())) { - // ActionMessage error = new ActionMessage("error.resource.item.title.blank"); - // errors.add(ActionMessages.GLOBAL_MESSAGE, error); - // } - - // define it later mode(TEACHER) skip below validation. - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - // Some other validation outside basic Tab. - - return errors; - } - public ActionForward initPedagogicalPlannerForm(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { CommonCartridgePedagogicalPlannerForm plannerForm = (CommonCartridgePedagogicalPlannerForm) form; Index: lams_tool_imscc/web/WEB-INF/struts-config.xml =================================================================== diff -u -r14c269dab2fd9de7863a2074fd5ee1561215d066 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_imscc/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 14c269dab2fd9de7863a2074fd5ee1561215d066) +++ lams_tool_imscc/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -81,16 +81,14 @@ parameter="initPage" validate="false"> -
- - + + @@ -96,7 +97,7 @@ Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_imscc/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/AuthoringAction.java =================================================================== diff -u -r87785adce949853c583838c51cd9e55150ec683b -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 87785adce949853c583838c51cd9e55150ec683b) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -179,11 +179,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(PeerreviewConstants.SUCCESS); - } else { - return mapping.findForward(PeerreviewConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(PeerreviewConstants.SUCCESS); } /** @@ -206,41 +204,30 @@ .getAttribute(peerreviewForm.getSessionMapID()); ToolAccessMode mode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); - ActionMessages errors = validate(peerreviewForm, mapping, request); - if (!errors.isEmpty()) { - saveErrors(request, errors); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - } - Peerreview peerreview = peerreviewForm.getPeerreview(); IPeerreviewService service = getPeerreviewService(); - // **********************************Get Peerreview - // PO********************* + // **********************************Get Peerreview PO********************* Peerreview peerreviewPO = service.getPeerreviewByContentId(peerreviewForm.getPeerreview().getContentId()); if (peerreviewPO == null) { - // new Peerreview, create it. + // new Peerreview, create it peerreviewPO = peerreview; peerreviewPO.setCreated(new Timestamp(new Date().getTime())); peerreviewPO.setUpdated(new Timestamp(new Date().getTime())); + } else { - if (mode.isAuthor()) { - Long uid = peerreviewPO.getUid(); - PropertyUtils.copyProperties(peerreviewPO, peerreview); - // get back UID - peerreviewPO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content - // (definelater) - peerreviewPO.setInstructions(peerreview.getInstructions()); - peerreviewPO.setTitle(peerreview.getTitle()); - // change define later status + Long uid = peerreviewPO.getUid(); + PropertyUtils.copyProperties(peerreviewPO, peerreview); + // get back UID + peerreviewPO.setUid(uid); + + // if it's a teacher - change define later status + if (mode.isTeacher()) { peerreviewPO.setDefineLater(false); } + peerreviewPO.setUpdated(new Timestamp(new Date().getTime())); } @@ -268,11 +255,7 @@ peerreviewForm.setPeerreview(peerreviewPO); request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + return mapping.findForward(PeerreviewConstants.SUCCESS); } // ************************************************************************************* @@ -305,23 +288,4 @@ return mode; } - private ActionMessages validate(PeerreviewForm peerreviewForm, ActionMapping mapping, HttpServletRequest request) { - ActionMessages errors = new ActionMessages(); - // if (StringUtils.isBlank(peerreviewForm.getPeerreview().getTitle())) { - // ActionMessage error = new - // ActionMessage("error.resource.item.title.blank"); - // errors.add(ActionMessages.GLOBAL_MESSAGE, error); - // } - - // define it later mode(TEACHER) skip below validation. - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - // Some other validation outside basic Tab. - - return errors; - } - } Index: lams_tool_preview/web/WEB-INF/struts-config.xml =================================================================== diff -u -r14c269dab2fd9de7863a2074fd5ee1561215d066 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_preview/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 14c269dab2fd9de7863a2074fd5ee1561215d066) +++ lams_tool_preview/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -69,16 +69,14 @@ parameter="initPage" validate="false"> - - - + - <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.tool.peerreview.PeerreviewConstants"%> @@ -29,19 +28,17 @@ selectTab(tabId); } - + + + + + + + + - - - - - - - - - @@ -73,15 +70,14 @@ --%> - - + Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_preview/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/web/action/AuthoringAction.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -38,7 +38,6 @@ import org.apache.struts.action.ActionForm; import org.apache.struts.action.ActionForward; import org.apache.struts.action.ActionMapping; -import org.apache.struts.action.ActionMessages; import org.lamsfoundation.lams.authoring.web.AuthoringConstants; import org.lamsfoundation.lams.tool.ToolAccessMode; import org.lamsfoundation.lams.tool.spreadsheet.SpreadsheetConstants; @@ -125,7 +124,7 @@ spreadsheetForm.setContentFolderID(contentFolderID); // initial Session Map - SessionMap sessionMap = new SessionMap(); + SessionMap sessionMap = new SessionMap(); request.getSession().setAttribute(sessionMap.getSessionID(), sessionMap); spreadsheetForm.setSessionMapID(sessionMap.getSessionID()); @@ -160,7 +159,7 @@ private ActionForward initPage(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws ServletException { String sessionMapID = WebUtil.readStrParam(request, SpreadsheetConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); SpreadsheetForm existForm = (SpreadsheetForm) sessionMap.get(SpreadsheetConstants.ATTR_RESOURCE_FORM); SpreadsheetForm spreadsheetForm = (SpreadsheetForm) form; @@ -171,11 +170,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(SpreadsheetConstants.SUCCESS); - } else { - return mapping.findForward(SpreadsheetConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(SpreadsheetConstants.SUCCESS); } /** @@ -192,21 +189,9 @@ HttpServletResponse response) throws Exception { SpreadsheetForm spreadsheetForm = (SpreadsheetForm) (form); - // get back sessionMAP - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(spreadsheetForm.getSessionMapID()); - ToolAccessMode mode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); - ActionMessages errors = validate(spreadsheetForm, mapping, request); - if (!errors.isEmpty()) { - saveErrors(request, errors); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - } - Spreadsheet spreadsheet = spreadsheetForm.getSpreadsheet(); ISpreadsheetService service = getSpreadsheetService(); @@ -217,19 +202,18 @@ spreadsheetPO = spreadsheet; spreadsheetPO.setCreated(new Timestamp(new Date().getTime())); spreadsheetPO.setUpdated(new Timestamp(new Date().getTime())); + } else { - if (mode.isAuthor()) { - Long uid = spreadsheetPO.getUid(); - PropertyUtils.copyProperties(spreadsheetPO, spreadsheet); - // get back UID - spreadsheetPO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content (definelater) - spreadsheetPO.setInstructions(spreadsheet.getInstructions()); - spreadsheetPO.setCode(spreadsheet.getCode()); - spreadsheetPO.setTitle(spreadsheet.getTitle()); - // change define later status + Long uid = spreadsheetPO.getUid(); + PropertyUtils.copyProperties(spreadsheetPO, spreadsheet); + // get back UID + spreadsheetPO.setUid(uid); + + // if it's a teacher - change define later status + if (mode.isTeacher()) { spreadsheetPO.setDefineLater(false); } + spreadsheetPO.setUpdated(new Timestamp(new Date().getTime())); } @@ -252,11 +236,7 @@ spreadsheetForm.setSpreadsheet(spreadsheetPO); request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + return mapping.findForward(SpreadsheetConstants.SUCCESS); } // ************************************************************************************* @@ -288,23 +268,4 @@ return mode; } - private ActionMessages validate(SpreadsheetForm spreadsheetForm, ActionMapping mapping, - HttpServletRequest request) { - ActionMessages errors = new ActionMessages(); - // if (StringUtils.isBlank(spreadsheetForm.getSpreadsheet().getTitle())) { - // ActionMessage error = new ActionMessage("error.resource.item.title.blank"); - // errors.add(ActionMessages.GLOBAL_MESSAGE, error); - // } - - // define it later mode(TEACHER) skip below validation. - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - // Some other validation outside basic Tab. - - return errors; - } - } Index: lams_tool_spreadsheet/web/WEB-INF/struts-config.xml =================================================================== diff -u -r14c269dab2fd9de7863a2074fd5ee1561215d066 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_spreadsheet/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 14c269dab2fd9de7863a2074fd5ee1561215d066) +++ lams_tool_spreadsheet/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -73,16 +73,14 @@ parameter="initPage" validate="false"> - - - + Index: lams_tool_spreadsheet/web/pages/authoring/authoring.jsp =================================================================== diff -u -r19a48bf35052a72202cc4867e68d5666f0d05898 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_spreadsheet/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 19a48bf35052a72202cc4867e68d5666f0d05898) +++ lams_tool_spreadsheet/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -1,8 +1,7 @@ - + <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.tool.spreadsheet.SpreadsheetConstants"%> - ?lang=${pageContext.response.locale.language} @@ -35,20 +34,17 @@ } var spreadsheetCode = "${sessionMap.code}"; - - - - + + + + + + + + - - - - - - - ${lang} @@ -74,13 +70,12 @@ - - + Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_spreadsheet/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/AuthoringAction.java (.../AuthoringAction.java) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -183,7 +183,7 @@ taskListForm.setContentFolderID(contentFolderID); // initial Session Map - SessionMap sessionMap = new SessionMap(); + SessionMap sessionMap = new SessionMap(); request.getSession().setAttribute(sessionMap.getSessionID(), sessionMap); taskListForm.setSessionMapID(sessionMap.getSessionID()); @@ -254,7 +254,7 @@ private ActionForward initPage(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws ServletException { String sessionMapID = WebUtil.readStrParam(request, TaskListConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); TaskListForm existForm = (TaskListForm) sessionMap.get(TaskListConstants.ATTR_TASKLIST_FORM); TaskListForm taskListForm = (TaskListForm) form; @@ -265,11 +265,9 @@ } ToolAccessMode mode = getAccessMode(request); - if (mode.isAuthor()) { - return mapping.findForward(TaskListConstants.SUCCESS); - } else { - return mapping.findForward(TaskListConstants.DEFINE_LATER); - } + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); + + return mapping.findForward(TaskListConstants.SUCCESS); } /** @@ -287,42 +285,33 @@ TaskListForm taskListForm = (TaskListForm) form; // get back sessionMAP - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(taskListForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(taskListForm.getSessionMapID()); ToolAccessMode mode = getAccessMode(request); + request.setAttribute(AttributeNames.ATTR_MODE, mode.toString()); - ActionMessages errors = validate(taskListForm, mapping, request); - if (!errors.isEmpty()) { - saveErrors(request, errors); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } - } - TaskList taskList = taskListForm.getTaskList(); ITaskListService service = getTaskListService(); // **********************************Get TaskList PO********************* TaskList taskListPO = service.getTaskListByContentId(taskListForm.getTaskList().getContentId()); if (taskListPO == null) { - // new TaskList, create it. + // new TaskList, create it taskListPO = taskList; taskListPO.setCreated(new Timestamp(new Date().getTime())); taskListPO.setUpdated(new Timestamp(new Date().getTime())); + } else { - if (mode.isAuthor()) { - Long uid = taskListPO.getUid(); - PropertyUtils.copyProperties(taskListPO, taskList); - // get back UID - taskListPO.setUid(uid); - } else { // if it is Teacher, then just update basic tab content (definelater) - taskListPO.setInstructions(taskList.getInstructions()); - taskListPO.setTitle(taskList.getTitle()); - // change define later status + Long uid = taskListPO.getUid(); + PropertyUtils.copyProperties(taskListPO, taskList); + // get back UID + taskListPO.setUid(uid); + + // if it's a teacher - change define later status + if (mode.isTeacher()) { taskListPO.setDefineLater(false); } + taskListPO.setUpdated(new Timestamp(new Date().getTime())); } @@ -411,11 +400,7 @@ taskListForm.setTaskList(taskListPO); request.setAttribute(AuthoringConstants.LAMS_AUTHORING_SUCCESS_FLAG, Boolean.TRUE); - if (mode.isAuthor()) { - return mapping.findForward("author"); - } else { - return mapping.findForward("monitor"); - } + return mapping.findForward(TaskListConstants.SUCCESS); } // ********************************************************** @@ -453,7 +438,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, TaskListConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int itemIdx = NumberUtils.stringToInt(request.getParameter(TaskListConstants.PARAM_ITEM_INDEX), -1); TaskListItem item = null; @@ -524,7 +509,7 @@ // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, TaskListConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int itemIdx = NumberUtils.stringToInt(request.getParameter(TaskListConstants.PARAM_ITEM_INDEX), -1); if (itemIdx != -1) { @@ -583,7 +568,7 @@ private ActionForward switchItem(ActionMapping mapping, HttpServletRequest request, boolean up) { // get back sessionMAP String sessionMapID = WebUtil.readStrParam(request, TaskListConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); int itemIdx = NumberUtils.stringToInt(request.getParameter(TaskListConstants.PARAM_ITEM_INDEX), -1); if (itemIdx != -1) { @@ -628,7 +613,7 @@ * @param request * @return */ - private SortedSet getTaskListItemList(SessionMap sessionMap) { + private SortedSet getTaskListItemList(SessionMap sessionMap) { SortedSet list = (SortedSet) sessionMap .get(TaskListConstants.ATTR_TASKLIST_ITEM_LIST); if (list == null) { @@ -644,7 +629,7 @@ * @param request * @return */ - private SortedSet getTaskListConditionList(SessionMap sessionMap) { + private SortedSet getTaskListConditionList(SessionMap sessionMap) { SortedSet list = (SortedSet) sessionMap .get(TaskListConstants.ATTR_CONDITION_LIST); if (list == null) { @@ -660,7 +645,7 @@ * @param request * @return */ - private List getDeletedTaskListConditionList(SessionMap sessionMap) { + private List getDeletedTaskListConditionList(SessionMap sessionMap) { return getListFromSession(sessionMap, TaskListConstants.ATTR_DELETED_CONDITION_LIST); } @@ -670,7 +655,7 @@ * @param request * @return */ - private List getDeletedTaskListItemList(SessionMap sessionMap) { + private List getDeletedTaskListItemList(SessionMap sessionMap) { return getListFromSession(sessionMap, TaskListConstants.ATTR_DELETED_TASKLIST_ITEM_LIST); } @@ -681,7 +666,7 @@ * @param name * @return */ - private List getListFromSession(SessionMap sessionMap, String name) { + private List getListFromSession(SessionMap sessionMap, String name) { List list = (List) sessionMap.get(name); if (list == null) { list = new ArrayList(); @@ -731,7 +716,7 @@ * this taskList item. */ - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(itemForm.getSessionMapID()); // check whether it is "edit(old item)" or "add(new item)" SortedSet taskListList = getTaskListItemList(sessionMap); int itemIdx = NumberUtils.stringToInt(itemForm.getItemIndex(), -1); @@ -801,24 +786,6 @@ return mode; } - private ActionMessages validate(TaskListForm taskListForm, ActionMapping mapping, HttpServletRequest request) { - ActionMessages errors = new ActionMessages(); - // if (StringUtils.isBlank(taskListForm.getTaskList().getTitle())) { - // ActionMessage error = new ActionMessage("error.resource.item.title.blank"); - // errors.add(ActionMessages.GLOBAL_MESSAGE, error); - // } - - // define it later mode(TEACHER) skip below validation. - String modeStr = request.getParameter(AttributeNames.ATTR_MODE); - if (StringUtils.equals(modeStr, ToolAccessMode.TEACHER.toString())) { - return errors; - } - - // Some other validation outside basic Tab. - - return errors; - } - public ActionForward initPedagogicalPlannerForm(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) { TaskListPedagogicalPlannerForm plannerForm = (TaskListPedagogicalPlannerForm) form; Index: lams_tool_task/web/WEB-INF/struts-config.xml =================================================================== diff -u -r14c269dab2fd9de7863a2074fd5ee1561215d066 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_task/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 14c269dab2fd9de7863a2074fd5ee1561215d066) +++ lams_tool_task/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -81,16 +81,14 @@ parameter="initPage" validate="false"> -
- - + - - - + + + + + + - -<%-- - --%> - - - - - - - - + + + + + + + + + + + - - - + \ No newline at end of file Index: lams_tool_task/web/pages/authoring/authoring.jsp =================================================================== diff -u -rd6dcae53cbe27a85aedf62b8545ee3193ec55220 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_task/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision d6dcae53cbe27a85aedf62b8545ee3193ec55220) +++ lams_tool_task/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -1,10 +1,8 @@ - <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.tool.taskList.TaskListConstants"%> - <fmt:message key="label.authoring.title" /> @@ -18,7 +16,6 @@ selectTab(tag.value); else selectTab(1); //select the default tab; - } function doSelectTab(tabId) { @@ -67,10 +64,10 @@ - - + + @@ -111,19 +108,18 @@ - + - Fisheye: Tag 412fe7a30d27bd7402ae872029af8dd655d4a638 refers to a dead (removed) revision in file `lams_tool_task/web/pages/authoring/definelater.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_task/web/pages/monitoring/monitoring.jsp =================================================================== diff -u -rc6ad8493ef2064430e8783b28258cc9f223a3844 -r412fe7a30d27bd7402ae872029af8dd655d4a638 --- lams_tool_task/web/pages/monitoring/monitoring.jsp (.../monitoring.jsp) (revision c6ad8493ef2064430e8783b28258cc9f223a3844) +++ lams_tool_task/web/pages/monitoring/monitoring.jsp (.../monitoring.jsp) (revision 412fe7a30d27bd7402ae872029af8dd655d4a638) @@ -1,19 +1,16 @@ - <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.tool.taskList.TaskListConstants"%> - - - - <%-- param has higher level for request attribute --%> + + - <%@ include file="/common/monitorheader.jsp" %>