Index: lams_build/lib/lams/lams-gradebook.jar =================================================================== diff -u -r6c9dee81c4c1abb549b9d37ac1f7d93d07db2aad -r417b301a93d0e3b232370eef325b15a0642a8f8c Binary files differ Index: lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20180821.sql =================================================================== diff -u --- lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20180821.sql (revision 0) +++ lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20180821.sql (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -0,0 +1 @@ \ No newline at end of file Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java =================================================================== diff -u -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java (.../GradebookController.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java (.../GradebookController.java) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -246,7 +246,6 @@ : GradebookUtil.niceFormatting(averageLessonMark, isWeighted)); response.setContentType("application/json;charset=utf-8"); - response.getWriter().print(resultJSON.toString()); return resultJSON.toString(); } Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java =================================================================== diff -u -r1704c05d7e844f968d3700990957ff05f3611ba5 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java (.../GradebookMonitoringController.java) (revision 1704c05d7e844f968d3700990957ff05f3611ba5) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java (.../GradebookMonitoringController.java) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -23,6 +23,7 @@ package org.lamsfoundation.lams.gradebook.web.controller; import java.io.IOException; +import java.io.PrintWriter; import java.util.Arrays; import java.util.LinkedHashMap; import java.util.List; @@ -60,6 +61,7 @@ import org.springframework.beans.factory.annotation.Qualifier; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.ResponseBody; import com.fasterxml.jackson.databind.node.JsonNodeFactory; @@ -172,7 +174,7 @@ * @return * @throws Exception */ - @RequestMapping("/updateUserLessonGradebookData") + @RequestMapping(path = "/updateUserLessonGradebookData", method = RequestMethod.POST) @ResponseBody public void updateUserLessonGradebookData(HttpServletRequest request, HttpServletResponse response) throws Exception { @@ -212,7 +214,7 @@ * @return * @throws Exception */ - @RequestMapping("/updateUserActivityGradebookData") + @RequestMapping(path = "/updateUserActivityGradebookData", method = RequestMethod.POST) @ResponseBody public void updateUserActivityGradebookData(HttpServletRequest request, HttpServletResponse response) throws Exception { @@ -288,16 +290,18 @@ * @throws Exception */ @RequestMapping("/toggleReleaseMarks") - public String toggleReleaseMarks(HttpServletRequest request, HttpServletResponse response) throws Exception { + @ResponseBody + public void toggleReleaseMarks(HttpServletRequest request, HttpServletResponse response) throws Exception { Long lessonID = WebUtil.readLongParam(request, AttributeNames.PARAM_LESSON_ID); if (!securityService.isLessonMonitor(lessonID, getUser().getUserID(), "toggle release marks", false)) { response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the lesson"); - return null; } gradebookService.toggleMarksReleased(lessonID); response.setContentType("text/plain; charset=utf-8"); - return "success"; + PrintWriter writer = response.getWriter(); + writer.print("succes"); + } /** Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java =================================================================== diff -u -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java (.../NotebookController.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java (.../NotebookController.java) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -233,7 +233,7 @@ /** * */ - @RequestMapping(path="/updateEntry", method=RequestMethod.POST) + @RequestMapping(path="/updateEntry") public String updateEntry(@ModelAttribute NotebookForm notebookForm, HttpServletRequest request) throws IOException, ServletException { Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java =================================================================== diff -u -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -164,7 +164,7 @@ String forward = null; - String action = "requestDisplay.do?url=" + encodedURL; + String action = "requestURL.jsp?url=" + encodedURL; action = WebUtil.appendParameterToURL(action, AttributeNames.PARAM_LEARNER_PROGRESS_ID, progressId); forward = actionToForward(action, null, false); Index: lams_tool_daco/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r2e48a918c22150864aacb792f64f3103f61d3200 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_daco/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 2e48a918c22150864aacb792f64f3103f61d3200) +++ lams_tool_daco/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -434,4 +434,4 @@ - + \ No newline at end of file Index: lams_tool_doku/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r1cef918442124e8d987a285095a7504e3bc00461 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_doku/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 1cef918442124e8d987a285095a7504e3bc00461) +++ lams_tool_doku/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, @@ -435,4 +434,4 @@ - + \ No newline at end of file Index: lams_tool_imscc/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r1d6eef003bf303f75c5405b66a13ac86232cec03 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_imscc/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 1d6eef003bf303f75c5405b66a13ac86232cec03) +++ lams_tool_imscc/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, @@ -435,4 +434,4 @@ - + \ No newline at end of file Index: lams_tool_kaltura/web/WEB-INF/tags/Page.tag =================================================================== diff -u -rff911101cbe92d6813691c20c292fa04519820b4 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_kaltura/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision ff911101cbe92d6813691c20c292fa04519820b4) +++ lams_tool_kaltura/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, @@ -435,4 +434,4 @@ - + \ No newline at end of file Index: lams_tool_laqa/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_laqa/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_laqa/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_larsrc/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_larsrc/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_larsrc/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_leader/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_leader/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_leader/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_notebook/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_notebook/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_notebook/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_pixlr/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_pixlr/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_pixlr/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_scratchie/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_scratchie/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_scratchie/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_scribe/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r5d60e2334cf6775f4e4afe5755a0e56ef78540c0 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_scribe/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 5d60e2334cf6775f4e4afe5755a0e56ef78540c0) +++ lams_tool_scribe/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, }, Index: lams_tool_survey/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r417b301a93d0e3b232370eef325b15a0642a8f8c --- lams_tool_survey/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_survey/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 417b301a93d0e3b232370eef325b15a0642a8f8c) @@ -138,12 +138,12 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } function viewNotebookEntries(){ - openPopUp(LEARNING_URL + "notebook.do?method=viewAll&lessonID=" + lessonId, + openPopUp(LEARNING_URL + "notebook/viewAll.do?lessonID=" + lessonId, "Notebook", 648,1152, "no"); @@ -245,9 +245,8 @@ if ( lessonId != "" || toolSessionId != "" ) { $.ajax({ - url : LEARNING_URL + 'learner.do', + url : LEARNING_URL + 'learner/getLessonDetails.do', data : { - 'method' : 'getLessonDetails', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, },