Index: lams_tool_forum/conf/hibernate/mappings/org/lamsfoundation/lams/tool/forum/persistence/Forum.hbm.xml =================================================================== diff -u -re280cd832df020c33df6730fbee453add9e6caee -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/conf/hibernate/mappings/org/lamsfoundation/lams/tool/forum/persistence/Forum.hbm.xml (.../Forum.hbm.xml) (revision e280cd832df020c33df6730fbee453add9e6caee) +++ lams_tool_forum/conf/hibernate/mappings/org/lamsfoundation/lams/tool/forum/persistence/Forum.hbm.xml (.../Forum.hbm.xml) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -130,8 +130,8 @@ Index: lams_tool_forum/conf/xdoclet/struts-actions.xml =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/conf/xdoclet/struts-actions.xml (.../struts-actions.xml) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/conf/xdoclet/struts-actions.xml (.../struts-actions.xml) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -102,7 +102,7 @@ parameter="editTopic" scope="session"> - + Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/persistence/Forum.java =================================================================== diff -u -re280cd832df020c33df6730fbee453add9e6caee -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/persistence/Forum.java (.../Forum.java) (revision e280cd832df020c33df6730fbee453add9e6caee) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/persistence/Forum.java (.../Forum.java) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -372,11 +372,12 @@ } /** + * NOTE: The reason that relation don't use save-update to persist message is MessageSeq table need save + * a record as well. * - * * @hibernate.set lazy="true" - * inverse="false" - * cascade="save-update" + * inverse="true" + * cascade="none" * order-by="create_date desc" * @hibernate.collection-key column="forum_uid" * @hibernate.collection-one-to-many class="org.lamsfoundation.lams.tool.forum.persistence.Message" Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java (.../ForumService.java) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java (.../ForumService.java) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -661,13 +661,17 @@ user.setUserId(new Long(newUserUid.longValue())); } toolContentObj.setCreatedBy(user); + //save forum first + forumDao.saveOrUpdate(toolContentObj); + //save all authoring message one by one. //reset all resourceItem createBy user Set items = toolContentObj.getMessages(); for(Message item:items){ item.setCreatedBy(user); + item.setIsAuthored(true); + createRootTopic(toolContentObj.getUid(),null,item); } - forumDao.saveOrUpdate(toolContentObj); } catch (ImportToolContentException e) { throw new ToolException(e); } Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MessageForm.java =================================================================== diff -u -rd9c7ddef141d19423b6ab2914d153c2cb748f187 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MessageForm.java (.../MessageForm.java) (revision d9c7ddef141d19423b6ab2914d153c2cb748f187) +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/forms/MessageForm.java (.../MessageForm.java) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -24,7 +24,9 @@ /* $$Id$$ */ package org.lamsfoundation.lams.tool.forum.web.forms; +import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; +import org.apache.poi.util.StringUtil; import org.apache.struts.action.ActionErrors; import org.apache.struts.action.ActionMapping; import org.apache.struts.action.ActionMessage; @@ -64,13 +66,13 @@ */ public ActionErrors validate(ActionMapping mapping, javax.servlet.http.HttpServletRequest request) { - ActionErrors errors = super.validate(mapping, request); + ActionErrors errors = new ActionErrors(); try{ - if ("".equals(message.getSubject())) { + if (StringUtils.isBlank(message.getSubject())) { ActionMessage error = new ActionMessage("error.valueReqd"); errors.add("message.subject", error); } - if ("".equals(message.getBody())) { + if (StringUtils.isBlank(message.getBody())) { ActionMessage error = new ActionMessage("error.valueReqd"); errors.add("message.body", error); } Index: lams_tool_forum/web/WEB-INF/struts-config.xml =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/WEB-INF/struts-config.xml (.../struts-config.xml) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -116,7 +116,7 @@ type="org.lamsfoundation.lams.tool.forum.web.actions.AuthoringAction" name="messageForm" validate="true" - input="tiles:/authoring/forum/newTopic" + input="/jsps/authoring/message/create.jsp" parameter="createTopic" scope="request"> @@ -141,7 +141,7 @@ parameter="editTopic" scope="session"> - + - --> + --> Index: lams_tool_forum/web/common/messages.jsp =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/common/messages.jsp (.../messages.jsp) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/common/messages.jsp (.../messages.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -2,7 +2,7 @@
-
@@ -13,7 +13,7 @@
- +
Index: lams_tool_forum/web/images/iconInformation.gif =================================================================== diff -u Binary files differ Index: lams_tool_forum/web/images/iconWarning.gif =================================================================== diff -u Binary files differ Index: lams_tool_forum/web/jsps/authoring/basic.jsp =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/authoring/basic.jsp (.../basic.jsp) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/jsps/authoring/basic.jsp (.../basic.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -51,7 +51,7 @@ - ');" class="button"> + ');" style="float:left;width:150px" class="button"> Index: lams_tool_forum/web/jsps/authoring/message/edit.jsp =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/authoring/message/edit.jsp (.../edit.jsp) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/jsps/authoring/message/edit.jsp (.../edit.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -9,15 +9,13 @@
-
- <%@ include file="/common/messages.jsp" %> - -
- "> - <%@ include file="/jsps/message/topiceditform.jsp"%> -
-
-
+ <%@ include file="/common/messages.jsp"%> + +
+ "> + <%@ include file="/jsps/message/topiceditform.jsp"%> +
+
Index: lams_tool_forum/web/jsps/authoring/message/forbiddenedit.jsp =================================================================== diff -u -r7e5622f2a1facf741b442bd53556f769b51433b2 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/authoring/message/forbiddenedit.jsp (.../forbiddenedit.jsp) (revision 7e5622f2a1facf741b442bd53556f769b51433b2) +++ lams_tool_forum/web/jsps/authoring/message/forbiddenedit.jsp (.../forbiddenedit.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -1 +1,19 @@ -You are not the topic author, permission denied to edit it. Sorry. \ No newline at end of file +<%@ include file="/common/taglibs.jsp"%> + + + <%@ include file="/common/header.jsp"%> + + + + + + + +
+
+

You are not the topic author, permission denied to edit it. Sorry.

+
+
+ + + Index: lams_tool_forum/web/jsps/message/topiceditform.jsp =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/message/topiceditform.jsp (.../topiceditform.jsp) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/jsps/message/topiceditform.jsp (.../topiceditform.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -2,20 +2,19 @@ - + - Index: lams_tool_forum/web/jsps/message/topicform.jsp =================================================================== diff -u -r71a37d456ee2d1d277774c125ac645ef7f06fa00 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/message/topicform.jsp (.../topicform.jsp) (revision 71a37d456ee2d1d277774c125ac645ef7f06fa00) +++ lams_tool_forum/web/jsps/message/topicform.jsp (.../topicform.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -1,20 +1,19 @@
- + * - * +
- + * - *
@@ -35,24 +34,23 @@ -   - + - +
- + +
+ -
- +
- + + +
- + * - * +
- + * - *
@@ -25,18 +24,19 @@
-   
- - - - - - -
+ + + + + + +
Index: lams_tool_forum/web/jsps/message/topicview.jsp =================================================================== diff -u -rbbc64e3b60bf8b271c5cd2c41f122aba7d7d7c86 -r427a3b63491fb2f3206a785705ac247af49e1360 --- lams_tool_forum/web/jsps/message/topicview.jsp (.../topicview.jsp) (revision bbc64e3b60bf8b271c5cd2c41f122aba7d7d7c86) +++ lams_tool_forum/web/jsps/message/topicview.jsp (.../topicview.jsp) (revision 427a3b63491fb2f3206a785705ac247af49e1360) @@ -41,17 +41,17 @@ - + -    + - + -    - + +