Index: lams_common/src/java/org/lamsfoundation/lams/dao/IBaseDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/dao/IBaseDAO.java (.../IBaseDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_common/src/java/org/lamsfoundation/lams/dao/IBaseDAO.java (.../IBaseDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -75,33 +75,10 @@ */ public void insertOrUpdateAll(Collection objects); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @return void - */ public void update(String queryString); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @param value - * @return void - */ public void update(String queryString, Object value); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @param values - * @return void - */ public void update(String queryString, Object[] values); /** @@ -259,62 +236,16 @@ */ public List findAnythingLike(Object object); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @return void - */ public List find(String queryString); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @param value - * @return void - */ public List find(String queryString, Object value); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryString - * @param values - * @return void - */ public List find(String queryString, Object[] values); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryName - * @return void - */ public List findByNamedQuery(String queryName); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryName - * @param value - * @return void - */ public List findByNamedQuery(String queryName, Object value); - /** - * Just a wrapper of the method in HibernateTemplate - * shouldn't be used unless a complicated query needed - * - * @param queryName - * @param values - * @return void - */ public List findByNamedQuery(String queryName, Object[] values); /** Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java (.../IActivityDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java (.../IActivityDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -28,7 +28,6 @@ import org.lamsfoundation.lams.dao.IBaseDAO; import org.lamsfoundation.lams.learningdesign.Activity; import org.lamsfoundation.lams.learningdesign.LearningDesign; -import org.springframework.dao.DataRetrievalFailureException; /** * @author Manpreet Minhas Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java (.../ActivityDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java (.../ActivityDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -45,7 +45,7 @@ import org.lamsfoundation.lams.learningdesign.ToolActivity; import org.lamsfoundation.lams.learningdesign.ToolBranchingActivity; import org.lamsfoundation.lams.learningdesign.dao.IActivityDAO; -import org.springframework.dao.DataRetrievalFailureException; +import org.lamsfoundation.lams.tool.exception.DataMissingException; import org.springframework.stereotype.Repository; /** @@ -121,7 +121,7 @@ break; } } - throw new DataRetrievalFailureException( + throw new DataMissingException( "Unable to get activity as the activity type is unknown or missing. Activity type is " + activityType); } Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/GroupingDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/GroupingDAO.java (.../GroupingDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/GroupingDAO.java (.../GroupingDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -28,6 +28,7 @@ import java.util.Iterator; import java.util.List; +import org.hibernate.HibernateException; import org.lamsfoundation.lams.dao.hibernate.LAMSBaseDAO; import org.lamsfoundation.lams.learningdesign.Activity; import org.lamsfoundation.lams.learningdesign.ChosenGrouping; @@ -36,7 +37,6 @@ import org.lamsfoundation.lams.learningdesign.LearnerChoiceGrouping; import org.lamsfoundation.lams.learningdesign.RandomGrouping; import org.lamsfoundation.lams.learningdesign.dao.IGroupingDAO; -import org.springframework.dao.DataRetrievalFailureException; import org.springframework.stereotype.Repository; /** @@ -101,11 +101,10 @@ } else if (grouping.isLearnerChoiceGrouping()) { return (Grouping) super.find(LearnerChoiceGrouping.class, grouping.getGroupingId()); } - throw new DataRetrievalFailureException( + throw new HibernateException( "Unable to get grouping as the grouping type is unknown or missing. Grouping object is " + grouping); } return null; } - -} +} \ No newline at end of file Index: lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCommentDAO.java =================================================================== diff -u -r42cd8d7da9fa6615dbd82d376984000024b4b0fe -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCommentDAO.java (.../RatingCommentDAO.java) (revision 42cd8d7da9fa6615dbd82d376984000024b4b0fe) +++ lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCommentDAO.java (.../RatingCommentDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -145,15 +145,4 @@ return null; } } - -// @Override -// public boolean isUserCommentedItem(Long toolContentId, Long itemId, Integer userId) { -// List list = getHibernateTemplate().find(COUNT_COMMENTS_BY_ITEM_AND_USER, -// new Object[] { toolContentId, itemId, userId }); -// if (list == null || list.size() == 0) { -// return false; -// } else { -// return ((Number) list.get(0)).intValue() > 0; -// } -// } -} +} \ No newline at end of file Index: lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCriteriaDAO.java =================================================================== diff -u -r42cd8d7da9fa6615dbd82d376984000024b4b0fe -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCriteriaDAO.java (.../RatingCriteriaDAO.java) (revision 42cd8d7da9fa6615dbd82d376984000024b4b0fe) +++ lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCriteriaDAO.java (.../RatingCriteriaDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -20,7 +20,6 @@ * **************************************************************** */ - package org.lamsfoundation.lams.rating.dao.hibernate; import java.util.List; @@ -32,7 +31,7 @@ import org.lamsfoundation.lams.rating.model.LessonRatingCriteria; import org.lamsfoundation.lams.rating.model.RatingCriteria; import org.lamsfoundation.lams.rating.model.ToolActivityRatingCriteria; -import org.springframework.dao.DataRetrievalFailureException; +import org.lamsfoundation.lams.tool.exception.DataMissingException; public class RatingCriteriaDAO extends LAMSBaseDAO implements IRatingCriteriaDAO { @@ -89,7 +88,7 @@ break; } } - throw new DataRetrievalFailureException( + throw new DataMissingException( "Unable to get RatingCriteria as the RatingCriteria type is unknown or missing. RatingCriteria type is " + criteriaType); } Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IWorkspaceDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IWorkspaceDAO.java (.../IWorkspaceDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IWorkspaceDAO.java (.../IWorkspaceDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -60,16 +60,4 @@ * @return first (and expected only) workspace with this name. */ public List findWorkspaceNodes(Long workspaceId); - - /** - * Finds an object. Return null if not found (note: this - * is not the standard behaviour for Spring and Hibernate combined.) - * - * @param objClass - * @param id - * @return object built from database - */ - @Override - public Object find(Class objClass, Serializable id); - -} +} \ No newline at end of file Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/hibernate/WorkspaceDAO.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/hibernate/WorkspaceDAO.java (.../WorkspaceDAO.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/hibernate/WorkspaceDAO.java (.../WorkspaceDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -21,7 +21,6 @@ * **************************************************************** */ - package org.lamsfoundation.lams.contentrepository.dao.hibernate; import java.io.Serializable; @@ -34,7 +33,6 @@ import org.lamsfoundation.lams.contentrepository.RepositoryCheckedException; import org.lamsfoundation.lams.contentrepository.dao.IWorkspaceDAO; import org.lamsfoundation.lams.dao.hibernate.LAMSBaseDAO; -import org.springframework.orm.hibernate4.HibernateObjectRetrievalFailureException; import org.springframework.stereotype.Repository; /** @@ -92,15 +90,6 @@ return new ArrayList(nodes); } - @Override - public Object find(Class objClass, Serializable id) { - try { - return super.find(objClass, id); - } catch (HibernateObjectRetrievalFailureException e) { - return null; - } - } - public void flushSession() throws RepositoryCheckedException { try { getSessionFactory().getCurrentSession().flush(); @@ -109,5 +98,4 @@ throw new RepositoryCheckedException("Unable to write changes to db successfully (flush).", e); } } - -} +} \ No newline at end of file Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/DAO.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/DAO.java (.../DAO.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -52,7 +52,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/dao/DAO.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/dao/DAO.java (.../DAO.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/dao/DAO.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/dao/DAO.java (.../DAO.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/dao/DAO.java =================================================================== diff -u -r3399163940c61c9132223c758d274486e57ff9b7 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/dao/DAO.java (.../DAO.java) (revision 3399163940c61c9132223c758d274486e57ff9b7) +++ lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -52,7 +52,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/hibernate/ScratchieBurningQuestionDAOHibernate.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/hibernate/ScratchieBurningQuestionDAOHibernate.java (.../ScratchieBurningQuestionDAOHibernate.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/hibernate/ScratchieBurningQuestionDAOHibernate.java (.../ScratchieBurningQuestionDAOHibernate.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -48,11 +48,6 @@ private static final String FIND_BY_ITEM_UID = "from " + ScratchieBurningQuestion.class.getName() + " as r where r.scratchieItem.uid=? order by r.sessionId asc"; -// @Override -// public List getBurningQuestionsByContentId(Long contentId) { -// return getHibernateTemplate().find(FIND_BY_CONTENT_ID, new Object[] { contentId}); -// } - @Override @SuppressWarnings("unchecked") public List getBurningQuestionsByContentId(Long scratchieUid, Long sessionId) { Index: lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/DAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/DAO.java (.../DAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/dao/DAO.java (.../DAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -54,7 +54,6 @@ * @param id * the identifier (primary key) of the class * @return a populated object - * @see org.springframework.orm.ObjectRetrievalFailureException */ public Object getObject(Class clazz, Serializable id); Index: lams_tool_wiki/src/java/org/lamsfoundation/lams/tool/wiki/dao/hibernate/WikiDAO.java =================================================================== diff -u -r2f725f8ef2aa09a2663b2335bf67213074426d11 -r42e6c9c7220f8baf3b245d73b57aca9be08191ea --- lams_tool_wiki/src/java/org/lamsfoundation/lams/tool/wiki/dao/hibernate/WikiDAO.java (.../WikiDAO.java) (revision 2f725f8ef2aa09a2663b2335bf67213074426d11) +++ lams_tool_wiki/src/java/org/lamsfoundation/lams/tool/wiki/dao/hibernate/WikiDAO.java (.../WikiDAO.java) (revision 42e6c9c7220f8baf3b245d73b57aca9be08191ea) @@ -61,7 +61,6 @@ // Removing duplicate pages removeDuplicatePages(wiki); getSession().saveOrUpdate(wiki); - //this.getHibernateTemplate().flush(); } /**