Index: lams_bb_integration/web/modules/learnermonitor.jsp =================================================================== diff -u -r9d05eb517e00791c6e11d35d250f6c70e8959229 -r4a15528efb3cd57e88b550e684e9903d1131423f --- lams_bb_integration/web/modules/learnermonitor.jsp (.../learnermonitor.jsp) (revision 9d05eb517e00791c6e11d35d250f6c70e8959229) +++ lams_bb_integration/web/modules/learnermonitor.jsp (.../learnermonitor.jsp) (revision 4a15528efb3cd57e88b550e684e9903d1131423f) @@ -88,7 +88,7 @@ } String strIsDisplayDesignImage = request.getParameter("isDisplayDesignImage"); - boolean isDisplayDesignImage = strIsDisplayDesignImage.equals("true")?true:false; + boolean isDisplayDesignImage = "true".equals(strIsDisplayDesignImage)?true:false; String learningDesignImageUrl = ""; if (isDisplayDesignImage) { @@ -99,15 +99,19 @@ } //check whether user has score for this lesson - String strLineitemId = request.getParameter("lineitemid").trim(); - Id lineitemId = bbPm.generateId(Lineitem.LINEITEM_DATA_TYPE, strLineitemId); - ScoreDbLoader scoreLoader = (ScoreDbLoader) bbPm.getLoader(ScoreDbLoader.TYPE); Score current_score = null; - try { - current_score = scoreLoader.loadByCourseMembershipIdAndLineitemId(courseMembership.getId(), lineitemId); - } catch (KeyNotFoundException c) { - //no score availalbe + String strLineitemId = request.getParameter("lineitemid"); + if (strLineitemId != null) { // there won't be "lineitemid" parameter in case lesson had been created in LAMS building block version prior to 1.2 + + Id lineitemId = bbPm.generateId(Lineitem.LINEITEM_DATA_TYPE, strLineitemId.trim()); + ScoreDbLoader scoreLoader = (ScoreDbLoader) bbPm.getLoader(ScoreDbLoader.TYPE); + try { + current_score = scoreLoader.loadByCourseMembershipIdAndLineitemId(courseMembership.getId(), lineitemId); + } catch (KeyNotFoundException c) { + //no score availalbe + } } + boolean isScoreAvailable = (current_score != null); %>