Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/model/PeerreviewUser.java =================================================================== diff -u -r0e69531f65529363399c5472a6c42bae1aa88408 -r4c3cc4a8d4a35f05fd5d7c06072ff2a5c22f6260 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/model/PeerreviewUser.java (.../PeerreviewUser.java) (revision 0e69531f65529363399c5472a6c42bae1aa88408) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/model/PeerreviewUser.java (.../PeerreviewUser.java) (revision 4c3cc4a8d4a35f05fd5d7c06072ff2a5c22f6260) @@ -26,6 +26,7 @@ import org.apache.commons.lang.builder.EqualsBuilder; import org.apache.commons.lang.builder.HashCodeBuilder; import org.apache.log4j.Logger; +import org.lamsfoundation.lams.usermanagement.User; import org.lamsfoundation.lams.usermanagement.dto.UserDTO; /** @@ -53,8 +54,8 @@ public PeerreviewUser() { } - public PeerreviewUser(UserDTO user, PeerreviewSession session) { - this.userId = new Long(user.getUserID().intValue()); + public PeerreviewUser(User user, PeerreviewSession session) { + this.userId = new Long(user.getUserId()); this.firstName = user.getFirstName(); this.lastName = user.getLastName(); this.loginName = user.getLogin(); Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java =================================================================== diff -u -r189a459a13057ddecbfa3db9e36e2a2b29bef5db -r4c3cc4a8d4a35f05fd5d7c06072ff2a5c22f6260 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java (.../PeerreviewServiceImpl.java) (revision 189a459a13057ddecbfa3db9e36e2a2b29bef5db) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java (.../PeerreviewServiceImpl.java) (revision 4c3cc4a8d4a35f05fd5d7c06072ff2a5c22f6260) @@ -325,7 +325,7 @@ log.debug("Peer Review: Processing session " + toolSessionId); long start = System.currentTimeMillis(); - ArrayList userIdsAdded = new ArrayList(); + int usersAdded = 0; PeerreviewSession session = getPeerreviewSessionBySessionId(toolSessionId); Set lessonUsers = toolService.getUsersFromGroupingActivity(toolSessionId); @@ -337,15 +337,14 @@ for (User lessonUser : lessonUsers) { currentUser = lessonUser; if (!sessionUserIds.contains(lessonUser.getUserId().longValue())) { - PeerreviewUser newUser = new PeerreviewUser(lessonUser.getUserDTO(), session); - createUser(newUser); - userIdsAdded.add(lessonUser.getUserId()); + createUser(new PeerreviewUser(lessonUser, session)); + usersAdded++; } } } - log.debug("Peer Review UserCreateThread " + toolSessionId + ": Update Took " - + (System.currentTimeMillis() - start) + "ms. Added " + userIdsAdded.size()); + log.debug("Peer Review UserCreateThread " + toolSessionId + ": Update needsUpdate "+needsUpdate+" took: " + + (System.currentTimeMillis() - start) + "ms. Added " + usersAdded); creatingUsersForSessionIds.remove(toolSessionId); return true; } catch (Throwable e) {