Index: lams_build/lib/lams/lams-learning.jar =================================================================== diff -u -r6c9dee81c4c1abb549b9d37ac1f7d93d07db2aad -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 Binary files differ Index: lams_central/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_central/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_central/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -137,7 +137,7 @@ function restartLesson(){ if (confirm(restartLessonConfirmation)) { - window.location.href = LEARNING_URL + 'learner.do?method=restartLesson&lessonID=' + lessonId; + window.location.href = LEARNING_URL + 'learner/restartLesson.do?lessonID=' + lessonId; } } Index: lams_central/web/includes/javascript/progressBar.js =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_central/web/includes/javascript/progressBar.js (.../progressBar.js) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_central/web/includes/javascript/progressBar.js (.../progressBar.js) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -1009,9 +1009,8 @@ } $.ajax({ - url : LAMS_URL + 'learning/learner.do', + url : LAMS_URL + 'learning/learner/getLearnerProgress.do', data : { - 'method' : 'getLearnerProgress', 'lessonID' : lessonId, 'toolSessionID' : toolSessionId, 'userID' : bar.userId Index: lams_gradebook/.classpath =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/.classpath (.../.classpath) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_gradebook/.classpath (.../.classpath) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -2,7 +2,6 @@ - @@ -19,5 +18,6 @@ + Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookConstants.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookConstants.java (.../GradebookConstants.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/util/GradebookConstants.java (.../GradebookConstants.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -20,7 +20,6 @@ * **************************************************************** */ - package org.lamsfoundation.lams.gradebook.util; /** @@ -38,8 +37,6 @@ public static final String PARAM_ROWS = "rows"; public static final String PARAM_SIDX = "sidx"; public static final String PARAM_SORD = "sord"; - public static final String PARAM_METHOD = "method"; - public static final String PARAM_DISPATCH = "dispatch"; public static final String PARAM_LOGIN = "login"; public static final String PARAM_ID = "id"; public static final String PARAM_MARK = "mark"; Index: lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java =================================================================== diff -u -r1704c05d7e844f968d3700990957ff05f3611ba5 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java (.../GradebookController.java) (revision 1704c05d7e844f968d3700990957ff05f3611ba5) +++ lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java (.../GradebookController.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -270,7 +270,7 @@ * @return * @throws Exception */ - @RequestMapping + @RequestMapping("/getUserGridData") @ResponseBody public String getUserGridData(HttpServletRequest request, HttpServletResponse response) throws Exception { Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/struts-config.xml'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tiles-defs.xml'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_gradebook/web/WEB-INF/tlds/lams/lams.tld =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/web/WEB-INF/tlds/lams/lams.tld (.../lams.tld) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_gradebook/web/WEB-INF/tlds/lams/lams.tld (.../lams.tld) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -212,192 +212,6 @@ - - STRUTS-textarea - org.lamsfoundation.lams.web.tag.MultiLinesTextareaTag - empty - - accesskey - false - true - - - alt - false - true - - - altKey - false - true - - - bundle - false - true - - - cols - false - true - - - disabled - false - true - - - errorKey - false - true - - - errorStyle - false - true - - - errorStyleClass - false - true - - - errorStyleId - false - true - - - index - false - true - - - indexed - false - true - - - name - false - true - - - onblur - false - true - - - onchange - false - true - - - onclick - false - true - - - ondblclick - false - true - - - onfocus - false - true - - - onkeydown - false - true - - - onkeypress - false - true - - - onkeyup - false - true - - - onmousedown - false - true - - - onmousemove - false - true - - - onmouseout - false - true - - - onmouseover - false - true - - - onmouseup - false - true - - - property - true - true - - - readonly - false - true - - - rows - false - true - - - style - false - true - - - styleClass - false - true - - - styleId - false - true - - - tabindex - false - true - - - title - false - true - - - titleKey - false - true - - - value - false - true - - - Small portrait of a user User Portrait Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-bean-el.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-bean.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-html-el.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-html.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-logic-el.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-logic.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-nested.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-tiles-el.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/tlds/struts/struts-tiles.tld'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 4e2c39e0ea14d5a8aa406327a16425e81b1e6702 refers to a dead (removed) revision in file `lams_gradebook/web/WEB-INF/validation.xml'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_gradebook/web/WEB-INF/web.xml =================================================================== diff -u -r6f37a4eb8b2023d6e6dffceffa91ebdbf74c54f5 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/web/WEB-INF/web.xml (.../web.xml) (revision 6f37a4eb8b2023d6e6dffceffa91ebdbf74c54f5) +++ lams_gradebook/web/WEB-INF/web.xml (.../web.xml) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -152,42 +152,8 @@ + - - - - tags-bean - /WEB-INF/tlds/struts/struts-bean.tld - - - tags-html - /WEB-INF/tlds/struts/struts-html.tld - - - tags-logic - /WEB-INF/tlds/struts/struts-logic.tld - - - tags-tiles - /WEB-INF/tlds/struts/struts-tiles.tld - - - tags-bean-el - /WEB-INF/tlds/struts/struts-bean-el.tld - - - tags-html-el - /WEB-INF/tlds/struts/struts-html-el.tld - - - tags-logic-el - /WEB-INF/tlds/struts/struts-logic-el.tld - - - tags-tiles-el - /WEB-INF/tlds/struts/struts-tiles-el.tld - - Index: lams_gradebook/web/gradebookCourseMonitor.jsp =================================================================== diff -u -r2e48a918c22150864aacb792f64f3103f61d3200 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/web/gradebookCourseMonitor.jsp (.../gradebookCourseMonitor.jsp) (revision 2e48a918c22150864aacb792f64f3103f61d3200) +++ lams_gradebook/web/gradebookCourseMonitor.jsp (.../gradebookCourseMonitor.jsp) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -101,11 +101,11 @@ iconSet: 'fontAwesome', autoencode:false, datatype: "xml", - url: "/gradebook/gradebook/getUserGridData.do?view=monCourse&lessonID=" + lessonID, + url: "gradebook/gradebook/getUserGridData.do?view=monCourse&lessonID=" + lessonID, height: "100%", autowidth:true, cellEdit:true, - cellurl: "/gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=" + lessonID, + cellurl: "gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=" + lessonID, sortorder: "asc", sortname: "rowName", pager: subgrid_table_id + "_pager", @@ -156,7 +156,7 @@ // update the lesson average mark if (cellname == "mark") { // Update the average activity mark - $.get("/gradebook/gradebook/getAverageMarkForLesson.do", {lessonID:lessonID}, function(xml) { + $.get("gradebook/gradebook/getAverageMarkForLesson.do", {lessonID:lessonID}, function(xml) { if (xml!=null) { jQuery("#organisationGrid").setCell(row_id, "avgMark", xml, "", ""); } @@ -310,7 +310,7 @@ //modify cellurl setting to include lessonid var lessonID = jQuery("#"+subgrid_table_id).getRowData(rowid)["id"]; - $("#"+subgrid_table_id).setGridParam({cellurl: "/gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=" + lessonID + "&id=" + userID}); + $("#"+subgrid_table_id).setGridParam({cellurl: "gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=" + lessonID + "&id=" + userID}); }, afterSaveCell: function(rowid, cellname,value, iRow, iCol) { Index: lams_gradebook/web/gradebookMonitor.jsp =================================================================== diff -u -r6f37a4eb8b2023d6e6dffceffa91ebdbf74c54f5 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_gradebook/web/gradebookMonitor.jsp (.../gradebookMonitor.jsp) (revision 6f37a4eb8b2023d6e6dffceffa91ebdbf74c54f5) +++ lams_gradebook/web/gradebookMonitor.jsp (.../gradebookMonitor.jsp) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -44,7 +44,7 @@ if ( ! graphLoaded ) { $("#markChartBusy").css("display", "block"); drawHistogram('markChartDiv', - '/gradebook/gradebookMonitoring/getMarkChartData.do?lessonID=${lessonDetails.lessonID}', + 'gradebook/gradebookMonitoring/getMarkChartData.do?lessonID=${lessonDetails.lessonID}', '', ''); graphLoaded = true; $("#markChartBusy").css("display", "none"); @@ -83,7 +83,7 @@ } if (conf) { - $.get("/gradebook/gradebookMonitoring/toggleReleaseMarks.do", {lessonID:"${lessonDetails.lessonID}"}, function(xml) { + $.get("gradebook/gradebookMonitoring/toggleReleaseMarks.do", {lessonID:"${lessonDetails.lessonID}"}, function(xml) { var str = new String(xml) if (str.indexOf("success") != -1) { @@ -150,7 +150,7 @@ autoencode:false, caption: "", datatype: "xml", - url: "/gradebook/gradebook/getUserGridData.do?view=monUserView&lessonID=${lessonDetails.lessonID}", + url: "gradebook/gradebook/getUserGridData.do?view=monUserView&lessonID=${lessonDetails.lessonID}", height: "100%", width: jqgridWidth, shrinkToFit: false, @@ -161,7 +161,7 @@ pager: 'userViewPager', rowList:[10,20,30,40,50,100], rowNum:10, - cellurl: "/gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=${lessonDetails.lessonID}", + cellurl: "gradebook/gradebookMonitoring/updateUserLessonGradebookData.do?lessonID=${lessonDetails.lessonID}", colNames:["", "", "", @@ -198,14 +198,14 @@ iconSet: 'fontAwesome', autoencode:false, datatype: "xml", - url: "/gradebook/gradebook/getActivityGridData.do?lessonID=${lessonDetails.lessonID}&view=monUserView&userID=" + userID, + url: "gradebook/gradebook/getActivityGridData.do?lessonID=${lessonDetails.lessonID}&view=monUserView&userID=" + userID, height: "100%", autowidth:true, cellEdit:true, pager: subgrid_table_id + "_pager", rowList:[10,20,30,40,50,100], rowNum:10, - cellurl: "/gradebook/gradebookMonitoring/updateUserActivityGradebookData.do?lessonID=${lessonDetails.lessonID}&view=monUserView&userID=" + userID, + cellurl: "gradebook/gradebookMonitoring/updateUserActivityGradebookData.do?lessonID=${lessonDetails.lessonID}&view=monUserView&userID=" + userID, colNames: [ '', '', @@ -323,7 +323,7 @@ autoencode:false, caption: "", datatype: "xml", - url: "/gradebook/gradebook/getActivityGridData.do?view=monActivityView&lessonID=${lessonDetails.lessonID}", + url: "gradebook/gradebook/getActivityGridData.do?view=monActivityView&lessonID=${lessonDetails.lessonID}", height: "100%", width: jqgridWidth, shrinkToFit: false, @@ -366,11 +366,11 @@ iconSet: 'fontAwesome', autoencode:false, datatype: "xml", - url: "/gradebook/gradebook/getUserGridData.do?view=monActivityView&lessonID=${lessonDetails.lessonID}&activityID=" + activityID + "&groupId=" + groupID, + url: "gradebook/gradebook/getUserGridData.do?view=monActivityView&lessonID=${lessonDetails.lessonID}&activityID=" + activityID + "&groupId=" + groupID, height: "100%", autowidth:true, cellEdit:true, - cellurl: "/gradebook/gradebookMonitoring/updateUserActivityGradebookData.do?lessonID=${lessonDetails.lessonID}&view=monActivityView&activityID=" + activityID, + cellurl: "gradebook/gradebookMonitoring/updateUserActivityGradebookData.do?lessonID=${lessonDetails.lessonID}&view=monActivityView&activityID=" + activityID, sortorder: "asc", sortname: "fullName", pager: subgrid_table_id + "_pager", @@ -486,7 +486,7 @@ $("#export-grades-button").click(function() { var areaToBlock = "export-link-area"; - var exportExcelUrl = "/gradebookMonitoring/exportExcelLessonGradebook.do?lessonID=${lessonDetails.lessonID}"; + var exportExcelUrl = "gradebookMonitoring/exportExcelLessonGradebook.do?lessonID=${lessonDetails.lessonID}"; var languageLabelWait = ""; // if exportSpan is hidden then icon only mode, use small font. blockExportButton(areaToBlock, exportExcelUrl, languageLabelWait, $("#exportSpan:hidden").length > 0); Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java =================================================================== diff -u -r1704c05d7e844f968d3700990957ff05f3611ba5 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java (.../LearnerController.java) (revision 1704c05d7e844f968d3700990957ff05f3611ba5) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java (.../LearnerController.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -36,9 +36,6 @@ import javax.servlet.http.HttpSession; import org.apache.log4j.Logger; -import org.apache.struts.action.ActionForm; -import org.apache.struts.action.ActionForward; -import org.apache.struts.action.ActionMapping; import org.lamsfoundation.lams.gradebook.service.IGradebookService; import org.lamsfoundation.lams.learning.presence.PresenceWebsocketServer; import org.lamsfoundation.lams.learning.service.ICoreLearnerService; @@ -451,8 +448,9 @@ /** * Gets the lesson details based on lesson id or the current tool session */ - public ActionForward getLessonDetails(ActionMapping mapping, ActionForm form, HttpServletRequest request, - HttpServletResponse response) throws IOException { + @RequestMapping("/getLessonDetails") + @ResponseBody + public String getLessonDetails(HttpServletRequest request, HttpServletResponse response) throws IOException { ObjectNode responseJSON = JsonNodeFactory.instance.objectNode(); Lesson lesson = null; @@ -475,8 +473,7 @@ responseJSON.put(AttributeNames.PARAM_PRESENCE_IM_ENABLED, lesson.getLearnerImAvailable()); response.setContentType("application/json;charset=utf-8"); - response.getWriter().print(responseJSON.toString()); - return null; + return responseJSON.toString(); } } \ No newline at end of file Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java =================================================================== diff -u -rb546f3a46de916721f4d729ac1b0e64cc1eb9cb4 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java (.../NotebookController.java) (revision b546f3a46de916721f4d729ac1b0e64cc1eb9cb4) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/controller/NotebookController.java (.../NotebookController.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -47,6 +47,7 @@ import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.ModelAttribute; import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.context.WebApplicationContext; /** @@ -213,7 +214,7 @@ /** * */ - @RequestMapping("/processNewEntry") + @RequestMapping("/add") public String processNewEntry(@ModelAttribute NotebookForm notebookForm, HttpServletRequest request) throws IOException, ServletException { @@ -232,7 +233,7 @@ /** * */ - @RequestMapping("/updateEntry") + @RequestMapping(path="/updateEntry", method=RequestMethod.POST) public String updateEntry(@ModelAttribute NotebookForm notebookForm, HttpServletRequest request) throws IOException, ServletException { Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java =================================================================== diff -u -r2e48a918c22150864aacb792f64f3103f61d3200 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision 2e48a918c22150864aacb792f64f3103f61d3200) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -244,11 +244,7 @@ * @return */ protected String actionToForward(String action, Activity activity, boolean redirect) { - if (redirect) { - String activityURL = ActivityMapping.actionToURL(action, activity, false); - return "redirect:" + WebUtil.getStrutsForwardNameFromPath(activityURL); - } - return "forward:" + WebUtil.getStrutsForwardNameFromPath(action); + return redirect ? "redirect:" + ActivityMapping.actionToURL(action, activity, false) : "forward:" + action; } /** Index: lams_learning/web/loadToolActivity.jsp =================================================================== diff -u -rb546f3a46de916721f4d729ac1b0e64cc1eb9cb4 -r4e2c39e0ea14d5a8aa406327a16425e81b1e6702 --- lams_learning/web/loadToolActivity.jsp (.../loadToolActivity.jsp) (revision b546f3a46de916721f4d729ac1b0e64cc1eb9cb4) +++ lams_learning/web/loadToolActivity.jsp (.../loadToolActivity.jsp) (revision 4e2c39e0ea14d5a8aa406327a16425e81b1e6702) @@ -39,7 +39,6 @@ src="${lams}includes/javascript/common.js"> - @@ -98,6 +97,5 @@ -