Index: lams_tool_bbb/src/java/org/lamsfoundation/lams/tool/bbb/web/actions/AuthoringAction.java
===================================================================
diff -u -r2abc3485dc2d24ea02044a64271f3ee0d3b8c11b -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_bbb/src/java/org/lamsfoundation/lams/tool/bbb/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 2abc3485dc2d24ea02044a64271f3ee0d3b8c11b)
+++ lams_tool_bbb/src/java/org/lamsfoundation/lams/tool/bbb/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -135,9 +135,8 @@
// get bbb content.
Bbb bbb = bbbService.getBbbByContentId((Long) map.get(Constants.KEY_TOOL_CONTENT_ID));
- // update bbb content using form inputs.
- ToolAccessMode mode = (ToolAccessMode) map.get(Constants.KEY_MODE);
- copyProperties(bbb, authForm, mode);
+ // update bbb content using form inputs
+ copyProperties(bbb, authForm);
// set the update date
bbb.setUpdateDate(new Date());
@@ -166,15 +165,12 @@
* @param mode
* @return
*/
- private void copyProperties(Bbb bbb, AuthoringForm authForm, ToolAccessMode mode) {
+ private void copyProperties(Bbb bbb, AuthoringForm authForm) {
bbb.setTitle(authForm.getTitle());
bbb.setInstructions(authForm.getInstructions());
- if (mode.isAuthor()) { // Teacher cannot modify following
- bbb.setReflectOnActivity(authForm.isReflectOnActivity());
- bbb.setReflectInstructions(authForm.getReflectInstructions());
- bbb.setLockOnFinished(authForm.isLockOnFinished());
-
- }
+ bbb.setReflectOnActivity(authForm.isReflectOnActivity());
+ bbb.setReflectInstructions(authForm.getReflectInstructions());
+ bbb.setLockOnFinished(authForm.isLockOnFinished());
}
/**
Index: lams_tool_bbb/web/pages/authoring/authoring.jsp
===================================================================
diff -u -r61afce49515660ee5d017b084bcd5a2308fb3bd7 -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_bbb/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 61afce49515660ee5d017b084bcd5a2308fb3bd7)
+++ lams_tool_bbb/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -6,21 +6,15 @@
-
-
-
-
+
+
+
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
@@ -37,7 +31,6 @@
-
<%-- Page tabs --%>
@@ -46,11 +39,9 @@
-
-
Index: lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/actions/AuthoringAction.java
===================================================================
diff -u -r2abc3485dc2d24ea02044a64271f3ee0d3b8c11b -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 2abc3485dc2d24ea02044a64271f3ee0d3b8c11b)
+++ lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -53,13 +53,6 @@
import org.lamsfoundation.lams.web.util.SessionMap;
/**
- * @author
- * @version
- *
- *
- *
- *
- *
*/
public class AuthoringAction extends LamsDispatchAction {
@@ -77,7 +70,6 @@
/**
* Default method when no dispatch parameter is specified. It is expected that the parameter
* toolContentID
will be passed in. This will be used to retrieve content for this tool.
- *
*/
@Override
protected ActionForward unspecified(ActionMapping mapping, ActionForm form, HttpServletRequest request,
@@ -140,9 +132,8 @@
// get chat content.
Chat chat = chatService.getChatByContentId((Long) map.get(AuthoringAction.KEY_TOOL_CONTENT_ID));
- // update chat content using form inputs.
- ToolAccessMode mode = (ToolAccessMode) map.get(AuthoringAction.KEY_MODE);
- updateChat(chat, authForm, mode);
+ // update chat content using form inputs
+ updateChat(chat, authForm);
chatService.releaseConditionsFromCache(chat);
@@ -168,7 +159,7 @@
// set the update date
chat.setUpdateDate(new Date());
- // releasing defineLater flag so that learner can start using the tool.
+ // releasing defineLater flag so that learners can start using the tool
chat.setDefineLater(false);
chatService.saveOrUpdateChat(chat);
@@ -192,16 +183,14 @@
* @param mode
* @return
*/
- private void updateChat(Chat chat, AuthoringForm authForm, ToolAccessMode mode) {
+ private void updateChat(Chat chat, AuthoringForm authForm) {
chat.setTitle(authForm.getTitle());
chat.setInstructions(authForm.getInstructions());
- if (mode.isAuthor()) { // Teacher cannot modify following
- chat.setLockOnFinished(authForm.isLockOnFinished());
- chat.setReflectOnActivity(authForm.isReflectOnActivity());
- chat.setReflectInstructions(authForm.getReflectInstructions());
- chat.setFilteringEnabled(authForm.isFilteringEnabled());
- chat.setFilterKeywords(authForm.getFilterKeywords());
- }
+ chat.setLockOnFinished(authForm.isLockOnFinished());
+ chat.setReflectOnActivity(authForm.isReflectOnActivity());
+ chat.setReflectInstructions(authForm.getReflectInstructions());
+ chat.setFilteringEnabled(authForm.isFilteringEnabled());
+ chat.setFilterKeywords(authForm.getFilterKeywords());
}
/**
@@ -230,18 +219,18 @@
private SessionMap createSessionMap(Chat chat, ToolAccessMode mode, String contentFolderID,
Long toolContentID) {
- SessionMap map = new SessionMap();
+ SessionMap sessionMap = new SessionMap();
- map.put(AuthoringAction.KEY_MODE, mode);
- map.put(AuthoringAction.KEY_CONTENT_FOLDER_ID, contentFolderID);
- map.put(AuthoringAction.KEY_TOOL_CONTENT_ID, toolContentID);
+ sessionMap.put(AuthoringAction.KEY_MODE, mode);
+ sessionMap.put(AuthoringAction.KEY_CONTENT_FOLDER_ID, contentFolderID);
+ sessionMap.put(AuthoringAction.KEY_TOOL_CONTENT_ID, toolContentID);
+
SortedSet set = new TreeSet(new TextSearchConditionComparator());
-
if (chat.getConditions() != null) {
set.addAll(chat.getConditions());
}
- map.put(ChatConstants.ATTR_CONDITION_SET, set);
- return map;
+ sessionMap.put(ChatConstants.ATTR_CONDITION_SET, set);
+ return sessionMap;
}
/**
Index: lams_tool_chat/web/pages/authoring/authoring.jsp
===================================================================
diff -u -r8955c559e118a75bcdec763ebae2e745a0421236 -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_chat/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 8955c559e118a75bcdec763ebae2e745a0421236)
+++ lams_tool_chat/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -6,11 +6,6 @@
-
-
-
-
-
@@ -20,10 +15,8 @@
-
-
-
-
+
+
@@ -39,17 +32,15 @@
<%-- Page tabs --%>
-
-
-
-
+
+
Index: lams_tool_chat/web/pages/monitoring/monitoring.jsp
===================================================================
diff -u -r8955c559e118a75bcdec763ebae2e745a0421236 -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_chat/web/pages/monitoring/monitoring.jsp (.../monitoring.jsp) (revision 8955c559e118a75bcdec763ebae2e745a0421236)
+++ lams_tool_chat/web/pages/monitoring/monitoring.jsp (.../monitoring.jsp) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -1,25 +1,25 @@
<%@ include file="/common/taglibs.jsp"%>
<%@ page import="org.lamsfoundation.lams.tool.chat.util.ChatConstants"%>
-
-
+
+
-
-
-
-
-
-
+
+
+
+
+
+
-
+
-
+
-
-
\ No newline at end of file
+
+
\ No newline at end of file
Index: lams_tool_gmap/src/java/org/lamsfoundation/lams/tool/gmap/web/actions/AuthoringAction.java
===================================================================
diff -u -r2abc3485dc2d24ea02044a64271f3ee0d3b8c11b -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_gmap/src/java/org/lamsfoundation/lams/tool/gmap/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 2abc3485dc2d24ea02044a64271f3ee0d3b8c11b)
+++ lams_tool_gmap/src/java/org/lamsfoundation/lams/tool/gmap/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -54,7 +54,7 @@
import org.lamsfoundation.lams.web.util.SessionMap;
/**
- * @author
+ *
*/
public class AuthoringAction extends LamsDispatchAction {
@@ -145,13 +145,7 @@
// get gmap content.
Gmap gmap = gmapService.getGmapByContentId(toolContentID);
- // update gmap content using form inputs.
- ToolAccessMode mode = (ToolAccessMode) map.get(KEY_MODE);
-
- String contentFolderID = (String) map.get(AttributeNames.PARAM_CONTENT_FOLDER_ID);
GmapUser gmapUser = null;
- //check whether it is sysadmin:LDEV-906
- //if(!StringUtils.equals(contentFolderID,"-1" )){
if (gmap.getCreateBy() == null) {
HttpSession ss = SessionManager.getSession();
UserDTO user = (UserDTO) ss.getAttribute(AttributeNames.USER);
@@ -160,9 +154,9 @@
} else {
gmapUser = gmapService.getUserByUID(gmap.getCreateBy());
}
- //}
- updateGmap(gmap, authForm, mode, gmapUser);
+ // update gmap content using form inputs
+ updateGmap(gmap, authForm, gmapUser);
// do the same for the gmap markers
Set markers = gmap.getGmapMarkers();
@@ -203,32 +197,30 @@
* @param mode
* @return
*/
- private void updateGmap(Gmap gmap, AuthoringForm authForm, ToolAccessMode mode, GmapUser guser) {
+ private void updateGmap(Gmap gmap, AuthoringForm authForm, GmapUser guser) {
gmap.setTitle(authForm.getTitle());
gmap.setInstructions(authForm.getInstructions());
//updateMarkerListFromXML(authForm.getMarkersXML(), gmap, guser);
gmapService.updateMarkerListFromXML(authForm.getMarkersXML(), gmap, guser, true, null);
- if (mode.isAuthor()) { // Teacher cannot modify following
- gmap.setCreateBy(guser.getUid());
- gmap.setLockOnFinished(authForm.isLockOnFinished());
- gmap.setAllowEditMarkers(authForm.isAllowEditMarkers());
- gmap.setAllowShowAllMarkers(authForm.isAllowShowAllMarkers());
- gmap.setMaxMarkers(authForm.getMaxMarkers());
- gmap.setLimitMarkers(authForm.isLimitMarkers());
- gmap.setAllowZoom(authForm.isAllowZoom());
- gmap.setAllowTerrain(authForm.isAllowTerrain());
- gmap.setAllowSatellite(authForm.isAllowSatellite());
- gmap.setAllowHybrid(authForm.isAllowHybrid());
- gmap.setMapType(authForm.getMapType());
- gmap.setMapZoom(authForm.getMapZoom());
- gmap.setMapCenterLatitude(authForm.getMapCenterLatitude());
- gmap.setMapCenterLongitude(authForm.getMapCenterLongitude());
- gmap.setReflectOnActivity(authForm.isReflectOnActivity());
- gmap.setReflectInstructions(authForm.getReflectInstructions());
- gmap.setDefaultGeocoderAddress(authForm.getDefaultGeocoderAddress());
- }
+ gmap.setCreateBy(guser.getUid());
+ gmap.setLockOnFinished(authForm.isLockOnFinished());
+ gmap.setAllowEditMarkers(authForm.isAllowEditMarkers());
+ gmap.setAllowShowAllMarkers(authForm.isAllowShowAllMarkers());
+ gmap.setMaxMarkers(authForm.getMaxMarkers());
+ gmap.setLimitMarkers(authForm.isLimitMarkers());
+ gmap.setAllowZoom(authForm.isAllowZoom());
+ gmap.setAllowTerrain(authForm.isAllowTerrain());
+ gmap.setAllowSatellite(authForm.isAllowSatellite());
+ gmap.setAllowHybrid(authForm.isAllowHybrid());
+ gmap.setMapType(authForm.getMapType());
+ gmap.setMapZoom(authForm.getMapZoom());
+ gmap.setMapCenterLatitude(authForm.getMapCenterLatitude());
+ gmap.setMapCenterLongitude(authForm.getMapCenterLongitude());
+ gmap.setReflectOnActivity(authForm.isReflectOnActivity());
+ gmap.setReflectInstructions(authForm.getReflectInstructions());
+ gmap.setDefaultGeocoderAddress(authForm.getDefaultGeocoderAddress());
}
/**
Index: lams_tool_gmap/web/pages/authoring/authoring.jsp
===================================================================
diff -u -r5b49576bf16056685db96302cc25b044bd39e9ce -r6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb
--- lams_tool_gmap/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 5b49576bf16056685db96302cc25b044bd39e9ce)
+++ lams_tool_gmap/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 6cfcb91c5526d4bbb22cd98dbd9d04c175cba1eb)
@@ -4,7 +4,6 @@