Index: lams_tool_images/conf/language/lams/ApplicationResources_en_AU.properties =================================================================== diff -u -rec25cec0aae2211ee71688230aaa0dfd309018ad -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision ec25cec0aae2211ee71688230aaa0dfd309018ad) +++ lams_tool_images/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -183,5 +183,6 @@ label.no.maximum =No maximum label.minimum.number.words =Minimum number of words in a comment {0} warning.minimum.number.words =There is a minimum required number of words in a comment: {0}. So far you've entered {1} word(s). +label.comment.textarea.tip =Please, provide some comment here... #======= End labels: Exported 161 labels for en AU ===== Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java =================================================================== diff -u -r523ee42825f76a1a82e0b3cae120a2d35de9f36b -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java (.../ImageGalleryConstants.java) (revision 523ee42825f76a1a82e0b3cae120a2d35de9f36b) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java (.../ImageGalleryConstants.java) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -77,7 +77,6 @@ public static final String ATTR_THUMBNAIL_IMAGE_DIMENSIONS = "thumbnailImageDimensions"; public static final String ATTR_IS_GROUPED_ACTIVITY = "isGroupedActivity"; public static final String ATTR_RATING_DTOS = "ratingDtos"; - public static final String ATTR_COUNT_RATED_IMAGES = "countRatedImages"; // error message keys public static final String ERROR_MSG_NOT_ALLOWED_FORMAT = "error.resource.image.not.alowed.format"; Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java (.../IImageGalleryService.java) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java (.../IImageGalleryService.java) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -45,9 +45,9 @@ import org.lamsfoundation.lams.tool.imageGallery.model.ImageVote; /** - * @author Dapeng.Ni + * Interface that defines the contract that all ShareImageGallery service provider must follow. * - * Interface that defines the contract that all ShareImageGallery service provider must follow. + * @author Andrey Balan */ public interface IImageGalleryService extends ToolRatingManager { Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -380,15 +380,15 @@ LinkedList itemIds = new LinkedList(); itemIds.add(imageUid); - ItemRatingDTO ratingCriteria = ratingService.getRatingCriteriaDtos(contentId, itemIds, true, userId).get(0); + ItemRatingDTO ratingCriteria = getRatingCriteriaDtos(contentId, itemIds, true, userId).get(0); return ratingCriteria; } @Override public List getRatingCriteriaDtos(Long contentId, Collection itemIds, - boolean isAllItemResultsRequested, Long userId) { - return ratingService.getRatingCriteriaDtos(contentId, itemIds, isAllItemResultsRequested, userId); + boolean isCommentsByOtherUsersRequired, Long userId) { + return ratingService.getRatingCriteriaDtos(contentId, itemIds, isCommentsByOtherUsersRequired, userId); } @Override Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/LearningAction.java =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/LearningAction.java (.../LearningAction.java) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/action/LearningAction.java (.../LearningAction.java) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -226,7 +226,7 @@ // store how many items are rated if (imageGallery.isAllowRank()) { int countRatedImages = service.getCountItemsRatedByUser(imageGallery.getContentId(), userId.intValue()); - sessionMap.put(ImageGalleryConstants.ATTR_COUNT_RATED_IMAGES, countRatedImages); + sessionMap.put(AttributeNames.ATTR_COUNT_RATED_ITEMS, countRatedImages); } ActivityPositionDTO activityPosition = LearningWebUtil.putActivityPositionInRequestByToolSessionId(sessionId, @@ -495,9 +495,7 @@ sessionMap.put(ImageGalleryConstants.PARAM_COMMENTS, comments); } - ToolAccessMode mode = (ToolAccessMode) sessionMap.get(AttributeNames.ATTR_MODE); - boolean isTeacher = mode != null && mode.isTeacher(); - if (!isTeacher && imageGallery.isAllowRank()) { + if (imageGallery.isAllowRank()) { ItemRatingDTO itemRatingDto = service.getRatingCriteriaDtos(imageGallery.getContentId(), imageUid, userId); sessionMap.put(AttributeNames.ATTR_ITEM_RATING_DTO, itemRatingDto); @@ -506,7 +504,7 @@ sessionMap.put(AttributeNames.ATTR_COUNT_RATED_ITEMS, countRatedImages); } - if (!isTeacher && imageGallery.isAllowVote()) { + if (imageGallery.isAllowVote()) { boolean isVotedForThisImage = false; ImageVote imageVote = service.getImageVoteByImageAndUser(imageUid, userId); if (imageVote != null && imageVote.isVoted()) { Index: lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -36,7 +36,7 @@ - ${formContentPrefix}. + Index: lams_tool_images/web/WEB-INF/tags/Rating.tag =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/web/WEB-INF/tags/Rating.tag (.../Rating.tag) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/web/WEB-INF/tags/Rating.tag (.../Rating.tag) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -13,19 +13,16 @@ <%@ taglib uri="tags-function" prefix="fn" %> -<%@ attribute name="itemRatingDto" required="true" rtexprvalue="true"%> +<%@ attribute name="itemRatingDto" required="true" rtexprvalue="true" type="org.lamsfoundation.lams.rating.dto.ItemRatingDTO" %> <%-- Optional attribute --%> <%@ attribute name="disabled" required="false" rtexprvalue="true" %> <%@ attribute name="isItemAuthoredByUser" required="false" rtexprvalue="true" %> <%@ attribute name="maxRates" required="false" rtexprvalue="true" %> -<%@ attribute name="minRates" required="false" rtexprvalue="true" %> <%@ attribute name="countRatedItems" required="false" rtexprvalue="true" %> <%@ attribute name="yourRatingLabel" required="false" rtexprvalue="true" %> <%@ attribute name="averageRatingLabel" required="false" rtexprvalue="true" %> -<%@ attribute name="warnCommentIsBlankLabel" required="false" rtexprvalue="true" %> <%@ attribute name="minNumberWordsLabel" required="false" rtexprvalue="true" %> -<%@ attribute name="warnMinNumberWordsLabel" required="false" rtexprvalue="true" %> <%-- Default value for message key --%> @@ -37,9 +34,6 @@ - - - @@ -49,36 +43,11 @@ - - - - + - - - - - - - - - - <%--Rating stars area---------------------------------------%>
@@ -128,7 +97,7 @@
style="visibility: hidden;" + style="visibility: hidden;" > @@ -157,8 +126,8 @@
<%--Comments area---------------------------------------%> -
- + +
@@ -181,28 +150,28 @@
- - - - -
- - - - -
- - - -
-
- + +
-
-
-
- + + + +
+ + : + +
+
- -
\ No newline at end of file + + +
+
+
+ + + +
+
\ No newline at end of file Index: lams_tool_images/web/pages/learning/learning.jsp =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/web/pages/learning/learning.jsp (.../learning.jsp) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/web/pages/learning/learning.jsp (.../learning.jsp) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -52,16 +52,16 @@ clear: both; padding-top: 20px; } - #comments-area { + [id^=comments-area] { width: 400px; float: right; clear: both; padding: 10px 0 20px; } - #comment-textarea { + [id^=comment-textarea] { width: 370px; } - #comment-button { + .button.add-comment { margin-right: 2px; margin-top: 10px; } @@ -95,6 +95,9 @@ padding-top: 40px; } + + + @@ -234,7 +237,7 @@
- + @@ -251,7 +254,7 @@ <%--Comments & Ranking/Voting area----------------------------------------------%>
- <%@ include file="/pages/learning/parts/commentsarea.jsp"%> + <%@ include file="/pages/learning/parts/commentsarea.jsp"%>
<%--Reflection--------------------------------------------------%> Index: lams_tool_images/web/pages/learning/parts/commentsarea.jsp =================================================================== diff -u -r19775b178ccef32b0c96fa3ed03dcf051f48b0cf -r6d412d8329421a7647741f96d2cdc8afb4dfc207 --- lams_tool_images/web/pages/learning/parts/commentsarea.jsp (.../commentsarea.jsp) (revision 19775b178ccef32b0c96fa3ed03dcf051f48b0cf) +++ lams_tool_images/web/pages/learning/parts/commentsarea.jsp (.../commentsarea.jsp) (revision 6d412d8329421a7647741f96d2cdc8afb4dfc207) @@ -1,4 +1,5 @@ <%@ include file="/common/taglibs.jsp"%> + @@ -9,7 +10,27 @@ - + + + + + + + +