Index: lams_build/lib/lams/lams-central.jar =================================================================== diff -u -r5949a49ec6308dfce3ac7c88808da019f8260c76 -r8236da64800893104429c9b88f89d500c505a9a1 Binary files differ Index: lams_common/.classpath =================================================================== diff -u -rde5cc7dfd68d4a8ef5ebb5702afb4d42a5a9273a -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/.classpath (.../.classpath) (revision de5cc7dfd68d4a8ef5ebb5702afb4d42a5a9273a) +++ lams_common/.classpath (.../.classpath) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -4,7 +4,6 @@ - @@ -32,7 +31,7 @@ - + Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/TextSearchCondition.java =================================================================== diff -u -r51fb2a37254f24bb2a805d4ffd54482c779f43fa -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/TextSearchCondition.java (.../TextSearchCondition.java) (revision 51fb2a37254f24bb2a805d4ffd54482c779f43fa) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/TextSearchCondition.java (.../TextSearchCondition.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -32,7 +32,6 @@ import org.apache.log4j.Logger; import org.lamsfoundation.lams.learningdesign.dto.TextSearchConditionDTO; import org.lamsfoundation.lams.tool.ToolOutput; -import org.lamsfoundation.lams.web.TextSearchActionForm; /** * Condition that is based on text search. Several properties set what needs to be found in a tool output. Based on the @@ -281,17 +280,6 @@ setExcludedWordsCondition(splitSentence(excludedWordsString, TextSearchCondition.NON_WORD_DELIMITER_REGEX)); } - /** - * Fills the condition parameters using strings provided by an user in the form. - * - * @param textSearchActionForm - * form to parse - */ - public void parseConditionStrings(TextSearchActionForm textSearchActionForm) { - parseConditionStrings(textSearchActionForm.getAllWords(), textSearchActionForm.getPhrase(), - textSearchActionForm.getAnyWords(), textSearchActionForm.getExcludedWords()); - } - public void setAllWords(String allWords) { this.allWords = allWords; conditionsParsed = false; Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ILearningDesignService.java =================================================================== diff -u -rfd6ade152cf877cecaa63d3cb59d3bc53d60ca45 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ILearningDesignService.java (.../ILearningDesignService.java) (revision fd6ade152cf877cecaa63d3cb59d3bc53d60ca45) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ILearningDesignService.java (.../ILearningDesignService.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -48,6 +48,15 @@ public interface ILearningDesignService { static final String LD_SVG_TOP_DIR = FileUtil.getFullPath(Configuration.get(ConfigurationKeys.LAMS_EAR_DIR), "lams-www.war\\secure\\learning-design-images"); + + /** + * Returns a populated LearningDesign object corresponding to the given learningDesignID + * + * @param learningDesignID + * The learning_design_id of the design which has to be fetched + * @return LearningDesign The populated LearningDesign object corresponding to the given learningDesignID + */ + LearningDesign getLearningDesign(Long learningDesignID); /** * Get the learning design DTO Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/LearningDesignService.java =================================================================== diff -u -rfd6ade152cf877cecaa63d3cb59d3bc53d60ca45 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/LearningDesignService.java (.../LearningDesignService.java) (revision fd6ade152cf877cecaa63d3cb59d3bc53d60ca45) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/LearningDesignService.java (.../LearningDesignService.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -148,29 +148,19 @@ /********************************************** * Service Methods *******************************************/ + + @Override + public LearningDesign getLearningDesign(Long learningDesignID) { + return learningDesignDAO.getLearningDesignById(learningDesignID); + } - /** - * Get the learning design DTO - * - * @param learningDesignId - * @param languageCode - * Two letter language code needed to I18N the help url - * @return LearningDesignDTO - */ @Override public LearningDesignDTO getLearningDesignDTO(Long learningDesignID, String languageCode) { LearningDesign design = learningDesignID != null ? learningDesignDAO.getLearningDesignById(learningDesignID) : null; return design != null ? new LearningDesignDTO(design, activityDAO, groupingDAO, languageCode) : null; } - /** - * This method calls other validation methods which apply the validation rules to determine whether or not the - * learning design is valid. - * - * @param learningDesign - * @return list of validation errors - */ @Override public Vector validateLearningDesign(LearningDesign learningDesign) { LearningDesignValidator validator = new LearningDesignValidator(learningDesign, messageService); Index: lams_common/src/java/org/lamsfoundation/lams/questions/QuestionExporter.java =================================================================== diff -u -r1afed7dc7b62a19dfd296e395eaf469d97583af5 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/questions/QuestionExporter.java (.../QuestionExporter.java) (revision 1afed7dc7b62a19dfd296e395eaf469d97583af5) +++ lams_common/src/java/org/lamsfoundation/lams/questions/QuestionExporter.java (.../QuestionExporter.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -41,7 +41,7 @@ import org.apache.commons.io.FileUtils; import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; -import org.lamsfoundation.lams.util.CentralConstants; +import org.lamsfoundation.lams.util.CommonConstants; import org.lamsfoundation.lams.util.Configuration; import org.lamsfoundation.lams.util.ConfigurationKeys; import org.lamsfoundation.lams.util.FileUtil; @@ -99,9 +99,9 @@ try { String fileName = FileUtil.getFileName(packagePath); fileName = FileUtil.encodeFilenameForDownload(request, fileName); - response.setContentType(CentralConstants.RESPONSE_CONTENT_TYPE_DOWNLOAD); - response.setHeader(CentralConstants.HEADER_CONTENT_DISPOSITION, - CentralConstants.HEADER_CONTENT_ATTACHMENT + fileName); + response.setContentType(CommonConstants.RESPONSE_CONTENT_TYPE_DOWNLOAD); + response.setHeader(CommonConstants.HEADER_CONTENT_DISPOSITION, + CommonConstants.HEADER_CONTENT_ATTACHMENT + fileName); // write out the ZIP to respose error FileUtils.copyFile(packageFile, response.getOutputStream()); Index: lams_common/src/java/org/lamsfoundation/lams/util/CommonConstants.java =================================================================== diff -u -r471b903caa3365758fbdec0a22440b1b0b3f2947 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/util/CommonConstants.java (.../CommonConstants.java) (revision 471b903caa3365758fbdec0a22440b1b0b3f2947) +++ lams_common/src/java/org/lamsfoundation/lams/util/CommonConstants.java (.../CommonConstants.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -8,6 +8,9 @@ public static final String PARAM_SIDX = "sidx"; public static final String PARAM_SORD = "sord"; + // default coordinate used if the entry came from Flash is 0 or less. + public static final Integer DEFAULT_COORD = new Integer(10); + // XML Elemetns public static final String ELEMENT_ROWS = "rows"; public static final String ELEMENT_PAGE = "page"; @@ -17,10 +20,31 @@ public static final String ELEMENT_ID = "id"; public static final String ELEMENT_CELL = "cell"; + public static final String PARAM_LEARNING_DESIGN_ID = "ldId"; + public static final String PARAM_USE_PREFIX = "usePrefix"; + public static final String PARAM_MODE = "mode"; + public static int PORTRAIT_LARGEST_DIMENSION_LARGE = 200; public static int PORTRAIT_LARGEST_DIMENSION_MEDIUM = 80; public static int PORTRAIT_LARGEST_DIMENSION_SMALL = 35; + //used by all tool authoring action class to mark the success flag. + public static final String LAMS_AUTHORING_SUCCESS_FLAG = "LAMS_AUTHORING_SUCCESS_FLAG"; + + // used for tool content folder creation. + public static final String LAMS_WWW_FOLDER = "www/"; + + public static final String HEADER_CONTENT_DISPOSITION = "Content-Disposition"; + public static final String RESPONSE_CONTENT_TYPE_DOWNLOAD = "application/x-download"; + public static final String HEADER_CONTENT_ATTACHMENT = "attachment;filename="; + + public static final String TOOL_SIGNATURE_ASSESSMENT = "laasse10"; + public static final String TOOL_SIGNATURE_FORUM = "lafrum11"; + public static final String TOOL_SIGNATURE_LEADERSELECTION = "lalead11"; + public static final String TOOL_SIGNATURE_MCQ = "lamc11"; + public static final String TOOL_SIGNATURE_SCRATCHIE = "lascrt11"; + public static final String TOOL_SIGNATURE_PEER_REVIEW = "laprev11"; + public static final String[] COUNTRY_CODES = { "AD", "AE", "AF", "AG", "AI", "AL", "AM", "AO", "AQ", "AR", "AS", "AT", "AU", "AI", "AL", "AM", "AO", "AQ", "AR", "AS", "AT", "AU", "AW", "AX", "AZ", "BA", "BB", "BD", "BE", "BF", "BG", "BH", "BI", "BJ", "BL", "BM", "BN", "BO", "BQ", "BR", "BS", "BT", "BV", "BW", "BY", "BZ", "CA", Index: lams_common/src/java/org/lamsfoundation/lams/util/UploadFileUtil.java =================================================================== diff -u -r16db223ed22285c6c6edb6e3fa4ad7b1713cd6c1 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/util/UploadFileUtil.java (.../UploadFileUtil.java) (revision 16db223ed22285c6c6edb6e3fa4ad7b1713cd6c1) +++ lams_common/src/java/org/lamsfoundation/lams/util/UploadFileUtil.java (.../UploadFileUtil.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -32,7 +32,6 @@ import org.apache.commons.fileupload.FileItem; import org.apache.commons.fileupload.FileUploadException; import org.apache.log4j.Logger; -import org.lamsfoundation.lams.authoring.web.AuthoringConstants; /** * Wraps up interface to the Commons FileUpload as much as possible. Reads configuration information such the maximum @@ -220,7 +219,7 @@ */ public static String getUploadWebPath(String contentFolderID, String type) { return "/" + Configuration.get(ConfigurationKeys.SERVER_URL_CONTEXT_PATH) + "/" - + AuthoringConstants.LAMS_WWW_FOLDER + FileUtil.LAMS_WWW_SECURE_DIR + "/" + + CommonConstants.LAMS_WWW_FOLDER + FileUtil.LAMS_WWW_SECURE_DIR + "/" + String.join("/", UploadFileUtil.splitContentDir(contentFolderID)) + "/" + type; } Index: lams_common/src/java/org/lamsfoundation/lams/util/imgscalr/CircularByteBuffer.java =================================================================== diff -u -r5caa0c70153ab564c5d8e347c4af4baf53b01fd0 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_common/src/java/org/lamsfoundation/lams/util/imgscalr/CircularByteBuffer.java (.../CircularByteBuffer.java) (revision 5caa0c70153ab564c5d8e347c4af4baf53b01fd0) +++ lams_common/src/java/org/lamsfoundation/lams/util/imgscalr/CircularByteBuffer.java (.../CircularByteBuffer.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -21,7 +21,7 @@ */ -package org.lamsfoundation.lams.util; +package org.lamsfoundation.lams.util.imgscalr; /* * Circular Byte Buffer @@ -45,6 +45,8 @@ import java.io.InputStream; import java.io.OutputStream; +import org.apache.commons.collections.BufferOverflowException; + /** * Implements the Circular Buffer producer/consumer model for bytes. * More information about this class is available from - Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java =================================================================== diff -u -r471b903caa3365758fbdec0a22440b1b0b3f2947 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision 471b903caa3365758fbdec0a22440b1b0b3f2947) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -49,7 +49,7 @@ import org.apache.commons.collections.CollectionUtils; import org.apache.log4j.Logger; -import org.lamsfoundation.lams.authoring.service.IAuthoringService; +import org.lamsfoundation.lams.authoring.IAuthoringService; import org.lamsfoundation.lams.dao.IBaseDAO; import org.lamsfoundation.lams.events.EmailNotificationArchive; import org.lamsfoundation.lams.events.dao.EventDAO; @@ -365,7 +365,7 @@ securityService.isGroupMonitor(organisationId, userID, "intializeLesson", true); - LearningDesign originalLearningDesign = authoringService.getLearningDesign(new Long(learningDesignId)); + LearningDesign originalLearningDesign = learningDesignDAO.getLearningDesignById(new Long(learningDesignId)); if (originalLearningDesign == null) { throw new MonitoringServiceException( "Learning design for id=" + learningDesignId + " is missing. Unable to initialize lesson."); @@ -403,7 +403,7 @@ public Lesson initializeLessonForPreview(String lessonName, String lessonDescription, long learningDesignId, Integer userID, String customCSV, Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled) { - LearningDesign originalLearningDesign = authoringService.getLearningDesign(new Long(learningDesignId)); + LearningDesign originalLearningDesign = learningDesignDAO.getLearningDesignById(new Long(learningDesignId)); if (originalLearningDesign == null) { throw new MonitoringServiceException( "Learning design for id=" + learningDesignId + " is missing. Unable to initialize lesson."); @@ -421,7 +421,7 @@ Boolean learnerPresenceAvailable, Boolean learnerImAvailable, Boolean liveEditEnabled, Boolean enableLessonNotifications, Boolean forceLearnerRestart, Boolean allowLearnerRestart, Boolean gradebookOnComplete, Integer scheduledNumberDaysToLessonFinish, Lesson precedingLesson) { - LearningDesign learningDesign = authoringService.getLearningDesign(learningDesignID); + LearningDesign learningDesign = learningDesignDAO.getLearningDesignById(learningDesignID); if (learningDesign == null) { throw new MonitoringServiceException( "Learning design for id=" + learningDesignID + " is missing. Unable to initialize lesson."); @@ -445,7 +445,7 @@ // copy the current learning design LearningDesign copiedLearningDesign = authoringService.copyLearningDesign(originalLearningDesign, new Integer(copyType), user, workspaceFolder, true, null, customCSV); - authoringService.saveLearningDesign(copiedLearningDesign); + learningDesignDAO.insertOrUpdate(copiedLearningDesign); // Make all efforts to make sure it has a title String title = lessonName != null ? lessonName : copiedLearningDesign.getTitle(); Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringServiceProxy.java =================================================================== diff -u -r4338c54ef39ccdab47dc95d28deec40f23059633 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringServiceProxy.java (.../MonitoringServiceProxy.java) (revision 4338c54ef39ccdab47dc95d28deec40f23059633) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringServiceProxy.java (.../MonitoringServiceProxy.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -26,7 +26,7 @@ import javax.servlet.ServletContext; -import org.lamsfoundation.lams.authoring.service.IAuthoringService; +import org.lamsfoundation.lams.authoring.IAuthoringService; import org.lamsfoundation.lams.learning.service.ILearnerService; import org.lamsfoundation.lams.lesson.service.ILessonService; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java =================================================================== diff -u -r471b903caa3365758fbdec0a22440b1b0b3f2947 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java (.../MonitoringAction.java) (revision 471b903caa3365758fbdec0a22440b1b0b3f2947) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java (.../MonitoringAction.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -55,8 +55,7 @@ import org.apache.tomcat.util.json.JSONArray; import org.apache.tomcat.util.json.JSONException; import org.apache.tomcat.util.json.JSONObject; -import org.lamsfoundation.lams.authoring.ObjectExtractor; -import org.lamsfoundation.lams.authoring.service.IAuthoringService; +import org.lamsfoundation.lams.authoring.IAuthoringService; import org.lamsfoundation.lams.learning.service.ILearnerService; import org.lamsfoundation.lams.learningdesign.Activity; import org.lamsfoundation.lams.learningdesign.BranchingActivity; @@ -91,7 +90,7 @@ import org.lamsfoundation.lams.usermanagement.dto.UserDTO; import org.lamsfoundation.lams.usermanagement.exception.UserException; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; -import org.lamsfoundation.lams.util.CentralConstants; +import org.lamsfoundation.lams.util.CommonConstants; import org.lamsfoundation.lams.util.DateUtil; import org.lamsfoundation.lams.util.MessageService; import org.lamsfoundation.lams.util.ValidationUtil; @@ -1044,9 +1043,9 @@ case "MCQ or Assessment": //the second activity shall be a MCQ or Assessment - if (activity.isToolActivity() && (CentralConstants.TOOL_SIGNATURE_ASSESSMENT + if (activity.isToolActivity() && (CommonConstants.TOOL_SIGNATURE_ASSESSMENT .equals(((ToolActivity) activity).getTool().getToolSignature()) - || CentralConstants.TOOL_SIGNATURE_MCQ + || CommonConstants.TOOL_SIGNATURE_MCQ .equals(((ToolActivity) activity).getTool().getToolSignature()))) { return verifyNextActivityFitsTbl(nextActivity, "Leaderselection"); @@ -1056,7 +1055,7 @@ case "Leaderselection": //the third activity shall be a Leader Selection - if (activity.isToolActivity() && CentralConstants.TOOL_SIGNATURE_LEADERSELECTION + if (activity.isToolActivity() && CommonConstants.TOOL_SIGNATURE_LEADERSELECTION .equals(((ToolActivity) activity).getTool().getToolSignature())) { return verifyNextActivityFitsTbl(nextActivity, "Scratchie"); @@ -1066,7 +1065,7 @@ case "Scratchie": //the fourth activity shall be Scratchie - if (activity.isToolActivity() && CentralConstants.TOOL_SIGNATURE_SCRATCHIE + if (activity.isToolActivity() && CommonConstants.TOOL_SIGNATURE_SCRATCHIE .equals(((ToolActivity) activity).getTool().getToolSignature())) { return true; @@ -1517,7 +1516,7 @@ public ActionForward startLiveEdit(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws LearningDesignException, UserException, IOException { - long learningDesignId = WebUtil.readLongParam(request, CentralConstants.PARAM_LEARNING_DESIGN_ID); + long learningDesignId = WebUtil.readLongParam(request, CommonConstants.PARAM_LEARNING_DESIGN_ID); LearningDesign learningDesign = (LearningDesign) getUserManagementService().findById(LearningDesign.class, learningDesignId); if (learningDesign.getLessons().isEmpty()) { @@ -1769,7 +1768,7 @@ } private static int getActivityCoordinate(Integer coord) { - return (coord == null) || (coord < 0) ? ObjectExtractor.DEFAULT_COORD : coord; + return (coord == null) || (coord < 0) ? CommonConstants.DEFAULT_COORD : coord; } /** Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/TblMonitoringAction.java =================================================================== diff -u -r471b903caa3365758fbdec0a22440b1b0b3f2947 -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/TblMonitoringAction.java (.../TblMonitoringAction.java) (revision 471b903caa3365758fbdec0a22440b1b0b3f2947) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/TblMonitoringAction.java (.../TblMonitoringAction.java) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -40,12 +40,11 @@ import org.lamsfoundation.lams.monitoring.dto.TblGroupDTO; import org.lamsfoundation.lams.monitoring.dto.TblUserDTO; import org.lamsfoundation.lams.monitoring.service.IMonitoringFullService; -import org.lamsfoundation.lams.monitoring.service.IMonitoringService; import org.lamsfoundation.lams.tool.ToolSession; import org.lamsfoundation.lams.tool.service.ILamsCoreToolService; import org.lamsfoundation.lams.tool.service.ILamsToolService; import org.lamsfoundation.lams.usermanagement.User; -import org.lamsfoundation.lams.util.CentralConstants; +import org.lamsfoundation.lams.util.CommonConstants; import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.action.LamsDispatchAction; import org.lamsfoundation.lams.web.util.AttributeNames; @@ -366,7 +365,7 @@ if (activity instanceof ToolActivity) { ToolActivity toolActivity = (ToolActivity) activity; String toolSignature = toolActivity.getTool().getToolSignature(); - if (CentralConstants.TOOL_SIGNATURE_SCRATCHIE.equals(toolSignature)) { + if (CommonConstants.TOOL_SIGNATURE_SCRATCHIE.equals(toolSignature)) { isScratchieAvailable = true; break; } @@ -386,10 +385,10 @@ String toolTitle = toolActivity.getTitle(); //count only the first MCQ or Assessmnet as iRA - if (!iraPassed && (CentralConstants.TOOL_SIGNATURE_MCQ.equals(toolSignature) - || isScratchieAvailable && CentralConstants.TOOL_SIGNATURE_ASSESSMENT.equals(toolSignature))) { + if (!iraPassed && (CommonConstants.TOOL_SIGNATURE_MCQ.equals(toolSignature) + || isScratchieAvailable && CommonConstants.TOOL_SIGNATURE_ASSESSMENT.equals(toolSignature))) { iraPassed = true; - if (CentralConstants.TOOL_SIGNATURE_MCQ.equals(toolSignature)) { + if (CommonConstants.TOOL_SIGNATURE_MCQ.equals(toolSignature)) { request.setAttribute("isIraMcqAvailable", true); } else { @@ -402,30 +401,30 @@ } //aes are counted only after Scratchie activity, or for LKC TBL monitoring - if ((scratchiePassed || !isScratchieAvailable) && CentralConstants.TOOL_SIGNATURE_ASSESSMENT.equals(toolSignature)) { + if ((scratchiePassed || !isScratchieAvailable) && CommonConstants.TOOL_SIGNATURE_ASSESSMENT.equals(toolSignature)) { request.setAttribute("isAeAvailable", true); //prepare assessment details to be passed to Assessment tool assessmentToolContentIds += toolContentId + ","; assessmentActivityTitles += toolTitle + "\\,"; - } else if (CentralConstants.TOOL_SIGNATURE_FORUM.equals(toolSignature)) { + } else if (CommonConstants.TOOL_SIGNATURE_FORUM.equals(toolSignature)) { request.setAttribute("isForumAvailable", true); request.setAttribute("forumActivityId", toolActivityId); - } else if (CentralConstants.TOOL_SIGNATURE_PEER_REVIEW.equals(toolSignature)) { + } else if (CommonConstants.TOOL_SIGNATURE_PEER_REVIEW.equals(toolSignature)) { request.setAttribute("isPeerreviewAvailable", true); request.setAttribute("peerreviewToolContentId", toolContentId); //tRA is the first scratchie activity - } else if (!scratchiePassed && CentralConstants.TOOL_SIGNATURE_SCRATCHIE.equals(toolSignature)) { + } else if (!scratchiePassed && CommonConstants.TOOL_SIGNATURE_SCRATCHIE.equals(toolSignature)) { scratchiePassed = true; request.setAttribute("isScratchieAvailable", true); request.setAttribute("traToolContentId", toolContentId); request.setAttribute("traToolActivityId", toolActivityId); } - if (CentralConstants.TOOL_SIGNATURE_LEADERSELECTION.equals(toolSignature)) { + if (CommonConstants.TOOL_SIGNATURE_LEADERSELECTION.equals(toolSignature)) { request.setAttribute("leaderselectionToolActivityId", toolActivityId); request.setAttribute("leaderselectionToolContentId", toolContentId); } Index: lams_monitoring/web/tblmonitor/forum.jsp =================================================================== diff -u -rd7ed1173946998f754a2efef09d68c9e3bfe307f -r8236da64800893104429c9b88f89d500c505a9a1 --- lams_monitoring/web/tblmonitor/forum.jsp (.../forum.jsp) (revision d7ed1173946998f754a2efef09d68c9e3bfe307f) +++ lams_monitoring/web/tblmonitor/forum.jsp (.../forum.jsp) (revision 8236da64800893104429c9b88f89d500c505a9a1) @@ -1,5 +1,5 @@ <%@ include file="/template/taglibs.jsp"%> -<%@ page import="org.lamsfoundation.lams.util.CentralConstants"%> +<%@ page import="org.lamsfoundation.lams.util.CommonConstants"%>