Index: lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/dto/FileDetailsDTO.java =================================================================== diff -u -r84a9dd84fe84bb855c96c96acd137b5a38c2c2cd -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/dto/FileDetailsDTO.java (.../FileDetailsDTO.java) (revision 84a9dd84fe84bb855c96c96acd137b5a38c2c2cd) +++ lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/dto/FileDetailsDTO.java (.../FileDetailsDTO.java) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -50,7 +50,7 @@ private Date dateMarksReleased; private boolean finished; private String comments; - private Long marks; + private String marks; private Long uuID; private Long versionID; private String exportedURL; // the location of this file saved by the export function. @@ -80,7 +80,7 @@ this.reportID = report.getReportID(); this.dateMarksReleased = report.getDateMarksReleased(); this.comments = report.getComments(); - this.marks = report.getMarks(); + this.marks = report.getMarks() != null? report.getMarks().toString():""; } this.userDTO = userDTO; } @@ -155,13 +155,13 @@ /** * @return Returns the marks. */ - public Long getMarks() { + public String getMarks() { return marks; } /** * @param marks The marks to set. */ - public void setMarks(Long marks) { + public void setMarks(String marks) { this.marks = marks; } Index: lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/MonitoringAction.java =================================================================== diff -u -rca758bf56bb0e055c635f4b4252daf28d12811b2 -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/MonitoringAction.java (.../MonitoringAction.java) (revision ca758bf56bb0e055c635f4b4252daf28d12811b2) +++ lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/MonitoringAction.java (.../MonitoringAction.java) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -332,7 +332,15 @@ Long detailID = new Long(WebUtil.readLongParam(request,"detailID")); String updateMode = request.getParameter("updateMode"); - setMarkPage(request, sessionID, userID, detailID, updateMode); + submitFilesService = getSubmitFilesService(); + + List report = new ArrayList(); + report.add(submitFilesService.getFileDetails(detailID)); + + request.setAttribute("report",report); + request.setAttribute("updateMode", updateMode); + request.setAttribute(AttributeNames.PARAM_TOOL_SESSION_ID,sessionID); + return mapping.findForward("updateMark"); } @@ -356,25 +364,31 @@ String updateMode = request.getParameter("updateMode"); Long reportID= new Long(WebUtil.readLongParam(request,"reportID")); + ActionMessages errors = new ActionMessages(); //check whether the mark is validate + String markStr = request.getParameter("marks"); Long marks = null; - ActionMessages errors = new ActionMessages(); try { - marks = new Long(WebUtil.readLongParam(request,"marks")); - } catch (IllegalArgumentException e) { + marks = Long.parseLong(markStr); + } catch (Exception e) { errors.add(ActionMessages.GLOBAL_MESSAGE,new ActionMessage("errors.mark.invalid.number")); } - //if marks is invalid long, then throw error message directly. + String comments = WebUtil.readStrParam(request,"comments",true); if(!errors.isEmpty()){ - setMarkPage(request, sessionID, userID, detailID, updateMode); - //to echo back to error page. - List list = (List) request.getAttribute("report"); - if(list != null){ - FileDetailsDTO details = list.get(0); - if(details != null) - details.setComments(comments); - } + submitFilesService = getSubmitFilesService(); + List report = new ArrayList(); + FileDetailsDTO fileDetail = submitFilesService.getFileDetails(detailID); + //echo back the input, even they are wrong. + fileDetail.setComments(comments); + fileDetail.setMarks(markStr); + report.add(fileDetail); + + request.setAttribute("report",report); + request.setAttribute("updateMode", updateMode); + request.setAttribute(AttributeNames.PARAM_TOOL_SESSION_ID,sessionID); + + saveErrors(request,errors); return mapping.findForward("updateMark"); } @@ -445,13 +459,7 @@ * @param updateMode */ private void setMarkPage(HttpServletRequest request, Long sessionID, Long userID, Long detailID, String updateMode) { - submitFilesService = getSubmitFilesService(); - - request.setAttribute(AttributeNames.PARAM_TOOL_SESSION_ID,sessionID); - List report = new ArrayList(); - report.add(submitFilesService.getFileDetails(detailID)); - request.setAttribute("report",report); - request.setAttribute("updateMode", updateMode); + } /** * Save statistic information into request Index: lams_tool_sbmt/web/authoring/authoring.jsp =================================================================== diff -u -r17b9effc3c7ea57333aa800fff6d511689c32329 -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/authoring/authoring.jsp (.../authoring.jsp) (revision 17b9effc3c7ea57333aa800fff6d511689c32329) +++ lams_tool_sbmt/web/authoring/authoring.jsp (.../authoring.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -12,9 +12,11 @@ <%@ page import="org.lamsfoundation.lams.tool.sbmt.util.SbmtConstants"%> - + <fmt:message key="activity.title" /> + + Index: lams_tool_sbmt/web/includes/css/tool_custom.css =================================================================== diff -u --- lams_tool_sbmt/web/includes/css/tool_custom.css (revision 0) +++ lams_tool_sbmt/web/includes/css/tool_custom.css (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -0,0 +1,29 @@ +div.error, div.message { + background-color: #ffffcc; + border: 1px solid #000; + color: #000000; + font-family: Arial, Helvetica, sans-serif; + font-weight: normal; + margin: 10px auto; + padding: 3px; + text-align: left; + vertical-align: bottom; +} + +/* use a different color for the errors */ +div.error { + border: 2px solid red; +} +b.error { + background-color: #ffffcc; + border: 2px solid red; +} +img.validationWarning, div.errors img.icon, div.messages img.icon { + border: 0; + width: 14px; + height: 13px; + vertical-align: top; +} +div.message img.icon { + vertical-align: middle; +} Fisheye: Tag 17b9effc3c7ea57333aa800fff6d511689c32329 refers to a dead (removed) revision in file `lams_tool_sbmt/web/includes/javascript/xmlrequest.js'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_sbmt/web/learner/sbmtLearner.jsp =================================================================== diff -u -r17b9effc3c7ea57333aa800fff6d511689c32329 -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/learner/sbmtLearner.jsp (.../sbmtLearner.jsp) (revision 17b9effc3c7ea57333aa800fff6d511689c32329) +++ lams_tool_sbmt/web/learner/sbmtLearner.jsp (.../sbmtLearner.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -39,12 +39,12 @@
- +
@@ -125,6 +125,11 @@ + + + Index: lams_tool_sbmt/web/monitoring/mark/allmarks.jsp =================================================================== diff -u -r84a9dd84fe84bb855c96c96acd137b5a38c2c2cd -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/monitoring/mark/allmarks.jsp (.../allmarks.jsp) (revision 84a9dd84fe84bb855c96c96acd137b5a38c2c2cd) +++ lams_tool_sbmt/web/monitoring/mark/allmarks.jsp (.../allmarks.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -14,20 +14,32 @@ +
+

+ +

-
-

+

-

+

+
+
- - - <%@include file="filelist.jsp"%> - - - - - -
- - - -
+
+ +
+
+ + + + <%@include file="filelist.jsp"%> + + + + + +
+ + + +
+
+ +
+ \ No newline at end of file Index: lams_tool_sbmt/web/monitoring/mark/filelist.jsp =================================================================== diff -u -r84a9dd84fe84bb855c96c96acd137b5a38c2c2cd -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/monitoring/mark/filelist.jsp (.../filelist.jsp) (revision 84a9dd84fe84bb855c96c96acd137b5a38c2c2cd) +++ lams_tool_sbmt/web/monitoring/mark/filelist.jsp (.../filelist.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -38,6 +38,6 @@ property="submit" styleClass="button"> -
+
Index: lams_tool_sbmt/web/monitoring/mark/mark.jsp =================================================================== diff -u -r84a9dd84fe84bb855c96c96acd137b5a38c2c2cd -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/monitoring/mark/mark.jsp (.../mark.jsp) (revision 84a9dd84fe84bb855c96c96acd137b5a38c2c2cd) +++ lams_tool_sbmt/web/monitoring/mark/mark.jsp (.../mark.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -13,20 +13,29 @@ } - - - - - <%@include file="filelist.jsp"%> - - - - -
- - - -
+
+

+ +

+
+
+
+ + + <%@include file="filelist.jsp"%> + + + + +
+ + + +
+
+ +
+ \ No newline at end of file Index: lams_tool_sbmt/web/monitoring/mark/updatemark.jsp =================================================================== diff -u -r84a9dd84fe84bb855c96c96acd137b5a38c2c2cd -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/monitoring/mark/updatemark.jsp (.../updatemark.jsp) (revision 84a9dd84fe84bb855c96c96acd137b5a38c2c2cd) +++ lams_tool_sbmt/web/monitoring/mark/updatemark.jsp (.../updatemark.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -6,55 +6,76 @@ <fmt:message key="activity.title" /> - - + + - -
- - - - - - - - <%@include file="fileinfo.jsp"%> - - - - - - - - - - - - - - -
- -
- - - > -
- - -
- - - -    - - - -
-
-
+
+

+ +

+
+
+
+ +
+ + + + + + + + <%@include file="fileinfo.jsp"%> + + + + + + + + + + + + + + +
+ <%@include file="/common/messages.jsp"%> +
+ + + > +
+ +
+ + + +
+ + + +    + + + +
+
+
+
+ + +
+ \ No newline at end of file Index: lams_tool_sbmt/web/monitoring/monitoring.jsp =================================================================== diff -u -r57cfee7c8588098f1a856bc78093cb10aa2b1482 -r83ebe1df0e0c764033c0cde819399fd44d8f821b --- lams_tool_sbmt/web/monitoring/monitoring.jsp (.../monitoring.jsp) (revision 57cfee7c8588098f1a856bc78093cb10aa2b1482) +++ lams_tool_sbmt/web/monitoring/monitoring.jsp (.../monitoring.jsp) (revision 83ebe1df0e0c764033c0cde819399fd44d8f821b) @@ -1,13 +1,13 @@ - + <%@include file="/common/taglibs.jsp"%> <fmt:message key="activity.title" /> - + +