Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java =================================================================== diff -u -rb125be1bc92a6f11535ffa059b15a519c741b40e -r85592985e7c0ff8c521939c92f1a3da4639c5f73 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java (.../Grouping.java) (revision b125be1bc92a6f11535ffa059b15a519c741b40e) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java (.../Grouping.java) (revision 85592985e7c0ff8c521939c92f1a3da4639c5f73) @@ -288,8 +288,13 @@ this.grouper.doGrouping(this,learner); } + /** + * Return whether a learner is a existing learner for this grouping or not. + * @param learner the current leaner + * @return the boolean result + */ public boolean doesLearnerExist(User learner) { - return getGroupBy(learner).isNull(); + return !getGroupBy(learner).isNull(); } } Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java =================================================================== diff -u -rb125be1bc92a6f11535ffa059b15a519c741b40e -r85592985e7c0ff8c521939c92f1a3da4639c5f73 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java (.../RandomGrouper.java) (revision b125be1bc92a6f11535ffa059b15a519c741b40e) +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java (.../RandomGrouper.java) (revision 85592985e7c0ff8c521939c92f1a3da4639c5f73) @@ -146,7 +146,7 @@ for(Iterator i=learners.iterator();i.hasNext();) { User learner = (User)i.next(); - if(randomGrouping.doesLearnerExist(learner)) + if(!randomGrouping.doesLearnerExist(learner)) { Group selectedGroup = selectGroupToJoin((RandomGrouping)randomGrouping); selectedGroup.getUsers().add(learner); @@ -185,7 +185,7 @@ for(Iterator i = learners.iterator();i.hasNext();) { User learner = (User)i.next(); - if(randomGrouping.getGroupBy(learner).isNull()) + if(!randomGrouping.doesLearnerExist(learner)) newLearners++; }