Index: lams_tool_lamc/conf/language/ApplicationResources.properties =================================================================== diff -u -rf931ace3d9f38ea25225bd0cd55adfdcb3dfc376 -r8924c33e8d628e97e7e3668ada071f38b6372c02 --- lams_tool_lamc/conf/language/ApplicationResources.properties (.../ApplicationResources.properties) (revision f931ace3d9f38ea25225bd0cd55adfdcb3dfc376) +++ lams_tool_lamc/conf/language/ApplicationResources.properties (.../ApplicationResources.properties) (revision 8924c33e8d628e97e7e3668ada071f38b6372c02) @@ -235,8 +235,6 @@ label.export.teacher =Portfolio Export for Teacher label.candidateAnswer =Candidate Answer label.learning.forceFinishMessage =Responses are no more allowed. Please finish. -label.openPar =( -label.closePar =) label.correct =correct label.passingMark =Passing Mark: label.mcqSummary =MCQ Summary Index: lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/dao/hibernate/McOptionsContentDAO.java =================================================================== diff -u -rcaa7d3d855db20f8bb1b534ce5dc75a1d28474ea -r8924c33e8d628e97e7e3668ada071f38b6372c02 --- lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/dao/hibernate/McOptionsContentDAO.java (.../McOptionsContentDAO.java) (revision caa7d3d855db20f8bb1b534ce5dc75a1d28474ea) +++ lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/dao/hibernate/McOptionsContentDAO.java (.../McOptionsContentDAO.java) (revision 8924c33e8d628e97e7e3668ada071f38b6372c02) @@ -42,7 +42,8 @@ public class McOptionsContentDAO extends HibernateDaoSupport implements IMcOptionsContentDAO { static Logger logger = Logger.getLogger(McOptionsContentDAO.class.getName()); - private static final String FIND_MC_OPTIONS_CONTENT = "from " + McOptsContent.class.getName() + " as mco where mc_que_content_id=?"; + //private static final String FIND_MC_OPTIONS_CONTENT = "from " + McOptsContent.class.getName() + " as mco where mc_que_content_id=?"; + private static final String FIND_MC_OPTIONS_CONTENT = "from mcOptsContent in class McOptsContent where mcOptsContent.mcQueContentId=:mcQueContentUid order by mcOptsContent.uid"; private static final String LOAD_OPTION_CONTENT_BY_OPTION_TEXT = "from mcOptsContent in class McOptsContent where mcOptsContent.mcQueOptionText=:option and mcOptsContent.mcQueContentId=:mcQueContentUid"; @@ -62,7 +63,7 @@ HibernateTemplate templ = this.getHibernateTemplate(); if ( mcQueContentId != null) { List list = getSession().createQuery(FIND_MC_OPTIONS_CONTENT) - .setLong(0,mcQueContentId.longValue()) + .setLong("mcQueContentUid",mcQueContentId.longValue()) .list(); return list; } @@ -77,7 +78,7 @@ HibernateTemplate templ = this.getHibernateTemplate(); if ( mcQueContentId != null) { List list = getSession().createQuery(FIND_MC_OPTIONS_CONTENT) - .setLong(0,mcQueContentId.longValue()) + .setLong("mcQueContentUid",mcQueContentId.longValue()) .list(); if(list != null && list.size() > 0){ @@ -100,7 +101,7 @@ HibernateTemplate templ = this.getHibernateTemplate(); if ( mcQueContentId != null) { List list = getSession().createQuery(FIND_MC_OPTIONS_CONTENT) - .setLong(0,mcQueContentId.longValue()) + .setLong("mcQueContentUid",mcQueContentId.longValue()) .list(); if(list != null && list.size() > 0){ @@ -127,7 +128,7 @@ HibernateTemplate templ = this.getHibernateTemplate(); if ( mcQueContentId != null) { List list = getSession().createQuery(FIND_MC_OPTIONS_CONTENT) - .setLong(0,mcQueContentId.longValue()) + .setLong("mcQueContentUid",mcQueContentId.longValue()) .list(); if(list != null && list.size() > 0){ @@ -202,7 +203,7 @@ { HibernateTemplate templ = this.getHibernateTemplate(); List list = getSession().createQuery(FIND_MC_OPTIONS_CONTENT) - .setLong(0,mcQueContentId.longValue()) + .setLong("mcQueContentUid",mcQueContentId.longValue()) .list(); if(list != null && list.size() > 0){ Index: lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/MonitoringUtil.java =================================================================== diff -u -r71d4ba0de556ac5712891e102bf8935fa4a01810 -r8924c33e8d628e97e7e3668ada071f38b6372c02 --- lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/MonitoringUtil.java (.../MonitoringUtil.java) (revision 71d4ba0de556ac5712891e102bf8935fa4a01810) +++ lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/MonitoringUtil.java (.../MonitoringUtil.java) (revision 8924c33e8d628e97e7e3668ada071f38b6372c02) @@ -320,7 +320,7 @@ if (!mcSession.getMcContent().isRetries()) { logger.debug("retries is OFF."); - boolean attemptCorrect=false; + boolean isAttemptCorrect=false; McUsrAttempt mcUsrAttemptUser=null; while (itAttempts.hasNext()) @@ -333,17 +333,27 @@ { if (mcUsrAttempt.isAttemptCorrect()) { - attemptCorrect=true; + isAttemptCorrect=true; } } } - logger.debug("final attemptCorrect: " + attemptCorrect); + logger.debug("final isAttemptCorrect: " + isAttemptCorrect); + logger.debug("mcUsrAttemptUser: " + mcUsrAttemptUser); + McMonitoredUserDTO mcMonitoredUserDTO = new McMonitoredUserDTO(); - mcMonitoredUserDTO.setUid(mcUsrAttemptUser.getUid().toString()); mcMonitoredUserDTO.setUserName(mcQueUsr.getFullname()); mcMonitoredUserDTO.setSessionId(sessionId.toString()); mcMonitoredUserDTO.setQuestionUid(questionUid); + if (isAttemptCorrect) + { + mcMonitoredUserDTO.setMark(mcUsrAttemptUser.getMcQueContent().getWeight().toString()); + } + else + { + mcMonitoredUserDTO.setMark("0"); + } + logger.debug("final constructed mcMonitoredUserDTO: " + mcMonitoredUserDTO); listMonitoredUserContainerDTO.add(mcMonitoredUserDTO); } @@ -387,61 +397,7 @@ logger.debug("final constructed mcMonitoredUserDTO: " + mcMonitoredUserDTO); listMonitoredUserContainerDTO.add(mcMonitoredUserDTO); - - /* - McUsrAttempt mcUsrAttempt=getAttemptWithHighestOrder(listUserAttempts); - logger.debug("attempt with highest attempt order, mcUsrAttempt: " + mcUsrAttempt); - if (mcUsrAttempt != null) - { - Integer IntegerPassmark=mcUsrAttempt.getMcOptionsContent().getMcQueContent().getMcContent().getPassMark(); - logger.debug("IntegerPassmark: " + IntegerPassmark); - if ((IntegerPassmark != null) && (IntegerPassmark.intValue() >= 0)) - { - logger.debug("pasmark is defined: "); - if (mcUsrAttempt.isPassed()) - { - logger.debug("user has passed the activity"); - McMonitoredUserDTO mcMonitoredUserDTO = new McMonitoredUserDTO(); - mcMonitoredUserDTO.setMark(mcUsrAttempt.getMcQueContent().getWeight().toString()); - mcMonitoredUserDTO.setUserName(mcQueUsr.getFullname()); - mcMonitoredUserDTO.setUid(mcUsrAttempt.getUid().toString()); - mcMonitoredUserDTO.setSessionId(sessionId.toString()); - mcMonitoredUserDTO.setQuestionUid(questionUid); - - logger.debug("final constructed mcMonitoredUserDTO: " + mcMonitoredUserDTO); - listMonitoredUserContainerDTO.add(mcMonitoredUserDTO); - } - else - { - logger.debug("user did not finish the the activity yet"); - McMonitoredUserDTO mcMonitoredUserDTO = new McMonitoredUserDTO(); - mcMonitoredUserDTO.setMark("Learner still responding..."); - mcMonitoredUserDTO.setUserName(mcQueUsr.getFullname()); - mcMonitoredUserDTO.setUid(mcUsrAttempt.getUid().toString()); - mcMonitoredUserDTO.setSessionId(sessionId.toString()); - mcMonitoredUserDTO.setQuestionUid(questionUid); - - logger.debug("final constructed mcMonitoredUserDTO: " + mcMonitoredUserDTO); - listMonitoredUserContainerDTO.add(mcMonitoredUserDTO); - } - } - else - { - logger.debug("pasmark is Undefined: "); - logger.debug("pupulate user marks as if user has passed"); - McMonitoredUserDTO mcMonitoredUserDTO = new McMonitoredUserDTO(); - mcMonitoredUserDTO.setMark(mcUsrAttempt.getMcQueContent().getWeight().toString()); - mcMonitoredUserDTO.setUserName(mcQueUsr.getFullname()); - mcMonitoredUserDTO.setUid(mcUsrAttempt.getUid().toString()); - mcMonitoredUserDTO.setSessionId(sessionId.toString()); - mcMonitoredUserDTO.setQuestionUid(questionUid); - - logger.debug("final constructed mcMonitoredUserDTO: " + mcMonitoredUserDTO); - listMonitoredUserContainerDTO.add(mcMonitoredUserDTO); - } - } - */ } } } Index: lams_tool_lamc/web/monitoring/Summary.jsp =================================================================== diff -u -rf931ace3d9f38ea25225bd0cd55adfdcb3dfc376 -r8924c33e8d628e97e7e3668ada071f38b6372c02 --- lams_tool_lamc/web/monitoring/Summary.jsp (.../Summary.jsp) (revision f931ace3d9f38ea25225bd0cd55adfdcb3dfc376) +++ lams_tool_lamc/web/monitoring/Summary.jsp (.../Summary.jsp) (revision 8924c33e8d628e97e7e3668ada071f38b6372c02) @@ -101,8 +101,8 @@ -   - +   ( + ) @@ -115,9 +115,7 @@ -   - - +   ( ) @@ -153,8 +151,8 @@ -   - +   ( + ) @@ -211,8 +209,7 @@ - - + ( )