Index: lams_tool_pixlr/db/sql/create_lams_tool_pixlr.sql
===================================================================
diff -u -rb703d43cf69269e0afcc716321fd5ef42c249a43 -r892cd63b9dbbfae4d856a78e9504dd558e845913
--- lams_tool_pixlr/db/sql/create_lams_tool_pixlr.sql (.../create_lams_tool_pixlr.sql) (revision b703d43cf69269e0afcc716321fd5ef42c249a43)
+++ lams_tool_pixlr/db/sql/create_lams_tool_pixlr.sql (.../create_lams_tool_pixlr.sql) (revision 892cd63b9dbbfae4d856a78e9504dd558e845913)
@@ -26,7 +26,10 @@
reflect_on_activity,
allow_view_others_images,
image_width,
- image_height)
+ image_height,
+ image_file_name
+
+)
VALUES(
"Pixlr",
"Instructions",
@@ -40,6 +43,7 @@
0,
1,
200,
- 200
+ 200,
+ "blank.jpg"
);
Index: lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/service/PixlrService.java
===================================================================
diff -u -r40cd87b86406940f074191411cb46d955e2d5325 -r892cd63b9dbbfae4d856a78e9504dd558e845913
--- lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/service/PixlrService.java (.../PixlrService.java) (revision 40cd87b86406940f074191411cb46d955e2d5325)
+++ lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/service/PixlrService.java (.../PixlrService.java) (revision 892cd63b9dbbfae4d856a78e9504dd558e845913)
@@ -225,15 +225,27 @@
File existingFile = new File(realBaseDir + File.separator + toContent.getImageFileName());
- if (existingFile.exists()) {
+ if (existingFile.exists() && existingFile.canRead()) {
String ext = getFileExtension(toContent.getImageFileName());
String newFileName = FileUtil.generateUniqueContentFolderID() + ext;
String newFilePath = realBaseDir + File.separator + newFileName;
copyFile(existingFile, newFilePath);
return newFileName;
} else {
- return null;
+ // if cant find or read the file, just copy the default image file
+ if (existingFile.exists() && existingFile.canRead()) {
+ File existingFile2 = new File(getDefaultContent().getImageFileName());
+ String ext = getFileExtension(toContent.getImageFileName());
+ String newFileName = FileUtil.generateUniqueContentFolderID() + ext;
+ String newFilePath = realBaseDir + File.separator + newFileName;
+ copyFile(existingFile2, newFilePath);
+ return newFileName;
+ }
+ else
+ {
+ throw new PixlrException("Could not find file to copy");
+ }
}
}
@@ -375,7 +387,7 @@
copyFile(imageFile, newFilePath);
pixlr.setImageFileName(newFileName);
} else {
- pixlr.setImageFileName(PixlrConstants.DEFAULT_IMAGE_FILE_NAME);
+ pixlr.setImageFileName(getDefaultContent().getImageFileName());
}
pixlrDAO.saveOrUpdate(pixlr);
Index: lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/web/actions/AuthoringAction.java
===================================================================
diff -u -r40cd87b86406940f074191411cb46d955e2d5325 -r892cd63b9dbbfae4d856a78e9504dd558e845913
--- lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 40cd87b86406940f074191411cb46d955e2d5325)
+++ lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/web/actions/AuthoringAction.java (.../AuthoringAction.java) (revision 892cd63b9dbbfae4d856a78e9504dd558e845913)
@@ -142,11 +142,11 @@
Boolean imageExists = false;
if ((pixlr.getImageFileName() != null && !pixlr.getImageFileName().equals(""))) {
imageUrl += pixlr.getImageFileName();
- if (!pixlr.getImageFileName().equals(PixlrConstants.DEFAULT_IMAGE_FILE_NAME)) {
+ if (!pixlr.getImageFileName().equals(pixlrService.getDefaultContent().getImageFileName())) {
imageExists = true;
}
} else {
- imageUrl += PixlrConstants.DEFAULT_IMAGE_FILE_NAME;
+ imageUrl += pixlrService.getDefaultContent().getImageFileName();
}
request.setAttribute("imageURL", imageUrl);
request.setAttribute("imageExists", imageExists);
Index: lams_tool_pixlr/web/pages/learning/pixlr.jsp
===================================================================
diff -u -rb703d43cf69269e0afcc716321fd5ef42c249a43 -r892cd63b9dbbfae4d856a78e9504dd558e845913
--- lams_tool_pixlr/web/pages/learning/pixlr.jsp (.../pixlr.jsp) (revision b703d43cf69269e0afcc716321fd5ef42c249a43)
+++ lams_tool_pixlr/web/pages/learning/pixlr.jsp (.../pixlr.jsp) (revision 892cd63b9dbbfae4d856a78e9504dd558e845913)
@@ -80,7 +80,7 @@