Index: lams_tool_imscc/conf/hibernate/mappings/org/lamsfoundation/lams/tool/commonCartridge/model/CommonCartridge.hbm.xml =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r8b5473449dff565aa7166137883b3edf46f8b3ee --- lams_tool_imscc/conf/hibernate/mappings/org/lamsfoundation/lams/tool/commonCartridge/model/CommonCartridge.hbm.xml (.../CommonCartridge.hbm.xml) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_imscc/conf/hibernate/mappings/org/lamsfoundation/lams/tool/commonCartridge/model/CommonCartridge.hbm.xml (.../CommonCartridge.hbm.xml) (revision 8b5473449dff565aa7166137883b3edf46f8b3ee) @@ -61,14 +61,6 @@ /> - - items = new ArrayList<>(); items.addAll(commonCartridge.getCommonCartridgeItems()); - // check whehter finish lock is on/off - boolean lock = commonCartridge.getLockWhenFinished() && commonCartridgeUser != null - && commonCartridgeUser.isSessionFinished(); - // check whether there is only one commonCartridge item and run auto flag is true or not. boolean runAuto = false; Long runAutoItemUid = null; @@ -158,8 +154,6 @@ // basic information sessionMap.put(CommonCartridgeConstants.ATTR_TITLE, commonCartridge.getTitle()); sessionMap.put(CommonCartridgeConstants.ATTR_RESOURCE_INSTRUCTION, commonCartridge.getInstructions()); - sessionMap.put(CommonCartridgeConstants.ATTR_FINISH_LOCK, lock); - sessionMap.put(CommonCartridgeConstants.ATTR_LOCK_ON_FINISH, commonCartridge.getLockWhenFinished()); sessionMap.put(CommonCartridgeConstants.ATTR_USER_FINISHED, commonCartridgeUser != null && commonCartridgeUser.isSessionFinished()); Index: lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/form/CommonCartridgeForm.java =================================================================== diff -u -r1d6eef003bf303f75c5405b66a13ac86232cec03 -r8b5473449dff565aa7166137883b3edf46f8b3ee --- lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/form/CommonCartridgeForm.java (.../CommonCartridgeForm.java) (revision 1d6eef003bf303f75c5405b66a13ac86232cec03) +++ lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/form/CommonCartridgeForm.java (.../CommonCartridgeForm.java) (revision 8b5473449dff565aa7166137883b3edf46f8b3ee) @@ -33,8 +33,6 @@ * * CommonCartridge Form. * - * - * * User: Dapeng.Ni */ public class CommonCartridgeForm { @@ -70,7 +68,6 @@ // if it is start page, all data read out from database or current session // so need not reset checkbox to refresh value! if (!StringUtils.equals(param, "start") && !StringUtils.equals(param, "initPage")) { - commonCartridge.setLockWhenFinished(false); commonCartridge.setDefineLater(false); commonCartridge.setRunAuto(false); commonCartridge.setReflectOnActivity(false); Index: lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/servlet/CompleteItemServlet.java =================================================================== diff -u -rf2ad75cef0c507a64877942631fee13efbc6ed50 -r8b5473449dff565aa7166137883b3edf46f8b3ee --- lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/servlet/CompleteItemServlet.java (.../CompleteItemServlet.java) (revision f2ad75cef0c507a64877942631fee13efbc6ed50) +++ lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/servlet/CompleteItemServlet.java (.../CompleteItemServlet.java) (revision 8b5473449dff565aa7166137883b3edf46f8b3ee) @@ -39,6 +39,7 @@ import org.lamsfoundation.lams.tool.commonCartridge.service.ICommonCartridgeService; import org.lamsfoundation.lams.tool.commonCartridge.util.CommonCartridgeItemComparator; import org.lamsfoundation.lams.usermanagement.dto.UserDTO; +import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.session.SessionManager; import org.lamsfoundation.lams.web.util.AttributeNames; import org.lamsfoundation.lams.web.util.SessionMap; @@ -65,29 +66,16 @@ SpringBeanAutowiringSupport.processInjectionBasedOnServletContext(this, config.getServletContext()); } - /** - * The doGet method of the servlet. - * - * - * @param request - * the request send by the client to the server - * @param response - * the response send by the server to the client - * @throws ServletException - * if an error occurred - * @throws IOException - * if an error occurred - */ @Override public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { String sessionMapID = request.getParameter(CommonCartridgeConstants.ATTR_SESSION_MAP_ID); - SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); + SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(sessionMapID); - Long commonCartridgeItemUid = new Long(request.getParameter(CommonCartridgeConstants.PARAM_RESOURCE_ITEM_UID)); + Long commonCartridgeItemUid = WebUtil.readLongParam(request, CommonCartridgeConstants.PARAM_RESOURCE_ITEM_UID, + false); - HttpSession ss = SessionManager.getSession(); - // get back login user DTO + HttpSession ss = SessionManager.getSession(); UserDTO user = (UserDTO) ss.getAttribute(AttributeNames.USER); Long sessionId = (Long) sessionMap.get(CommonCartridgeConstants.ATTR_TOOL_SESSION_ID); @@ -102,21 +90,11 @@ } } - CommonCartridgeUser rUser = commonCartridgeService.getUserByIDAndSession(new Long(user.getUserID()), sessionId); - response.setContentType("text/javascript"); PrintWriter out = response.getWriter(); - - if (!rUser.isSessionFinished()) { - out.println("window.parent.opener.checkNew(false);"); - out.println("window.parent.opener=null;"); - out.println("window.parent.close();"); - } else { - out.println("window.parent.opener.checkNew(true);"); - out.println("window.parent.opener=null;"); - out.println("window.parent.close();"); - } - + out.println("window.parent.opener.checkNew();"); + out.println("window.parent.opener=null;"); + out.println("window.parent.close();"); out.println(); out.flush(); out.close(); Index: lams_tool_imscc/web/pages/authoring/advance.jsp =================================================================== diff -u -r62aaf160878735888d077bf28fac3c1989bb8fbd -r8b5473449dff565aa7166137883b3edf46f8b3ee --- lams_tool_imscc/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 62aaf160878735888d077bf28fac3c1989bb8fbd) +++ lams_tool_imscc/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 8b5473449dff565aa7166137883b3edf46f8b3ee) @@ -42,13 +42,6 @@ - - - - - - - Index: lams_tool_imscc/web/pages/learning/learning.jsp =================================================================== diff -u -raced7ba6c1e7c5a9a50d3f64d8cdd96dd7e76194 -r8b5473449dff565aa7166137883b3edf46f8b3ee --- lams_tool_imscc/web/pages/learning/learning.jsp (.../learning.jsp) (revision aced7ba6c1e7c5a9a50d3f64d8cdd96dd7e76194) +++ lams_tool_imscc/web/pages/learning/learning.jsp (.../learning.jsp) (revision 8b5473449dff565aa7166137883b3edf46f8b3ee) @@ -14,10 +14,9 @@ -