Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/assessmentApplicationContext.xml =================================================================== diff -u -rf494ac5c2f49f92be600b6392d9c85c291df7bb7 -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/assessmentApplicationContext.xml (.../assessmentApplicationContext.xml) (revision f494ac5c2f49f92be600b6392d9c85c291df7bb7) +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/assessmentApplicationContext.xml (.../assessmentApplicationContext.xml) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -106,20 +106,10 @@ - - - - + - - - - - - - Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java =================================================================== diff -u -ra78be3f1e9a9f6b7b69d12d63ca3a14f3c80b931 -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java (.../AssessmentServiceImpl.java) (revision a78be3f1e9a9f6b7b69d12d63ca3a14f3c80b931) +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java (.../AssessmentServiceImpl.java) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -154,12 +154,6 @@ private IEventNotificationService eventNotificationService; - private ILessonService lessonService; - - private IActivityDAO activityDAO; - - private IUserManagementService userService; - // ******************************************************************************* // Service method // ******************************************************************************* @@ -1814,97 +1808,6 @@ } @Override - public void recalculateMarkForLesson(UserDTO requestUserDTO, Long lessonId) { - - User requestUser = userService.getUserByLogin(requestUserDTO.getLogin()); - Lesson lesson = lessonService.getLesson(lessonId); - Organisation organisation = lesson.getOrganisation(); - - // skip doing anything if the user doesn't have permission - Integer organisationToCheckPermission = (organisation.getOrganisationType().getOrganisationTypeId() - .equals(OrganisationType.COURSE_TYPE)) ? organisation.getOrganisationId() - : organisation.getParentOrganisation().getOrganisationId(); - boolean isGroupManager = userService.isUserInRole(requestUser.getUserId(), organisationToCheckPermission, - Role.GROUP_MANAGER); - if (!(lesson.getLessonClass().isStaffMember(requestUser) || isGroupManager)) { - return; - } - - // get all lesson activities - Set lessonActivities = new TreeSet(); - /* - * Hibernate CGLIB is failing to load the first activity in the sequence as a ToolActivity for some mysterious - * reason Causes a ClassCastException when you try to cast it, even if it is a ToolActivity. - * - * THIS IS A HACK to retrieve the first tool activity manually so it can be cast as a ToolActivity - if it is - * one - */ - Activity firstActivity = activityDAO - .getActivityByActivityId(lesson.getLearningDesign().getFirstActivity().getActivityId()); - lessonActivities.add(firstActivity); - lessonActivities.addAll(lesson.getLearningDesign().getActivities()); - - // iterate through all assessment activities in the lesson - for (Activity activity : lessonActivities) { - - // check if it's assessment activity - if ((activity instanceof ToolActivity) && ((ToolActivity) activity).getTool().getToolSignature() - .equals(AssessmentConstants.TOOL_SIGNATURE)) { - ToolActivity assessmentActivity = (ToolActivity) activity; - - for (ToolSession toolSession : (Set) assessmentActivity.getToolSessions()) { - Long toolSessionId = toolSession.getToolSessionId(); - AssessmentSession assessmentSession = getAssessmentSessionBySessionId(toolSessionId); - Assessment assessment = assessmentSession.getAssessment(); - - if (assessment.isUseSelectLeaderToolOuput()) { - - AssessmentUser leader = assessmentSession.getGroupLeader(); - if (leader == null) { - continue; - } - - AssessmentResult leaderLastResult = getLastFinishedAssessmentResult(assessment.getUid(), - leader.getUserId()); - if (leaderLastResult == null) { - continue; - } - Double mark = new Double(leaderLastResult.getGrade()); - - // update marks for all learners in a group - List users = getUsersBySession(toolSessionId); - for (AssessmentUser user : users) { - copyAnswersFromLeader(user, leader); - - // propagade total mark to Gradebook - gradebookService.updateActivityMark(mark, null, user.getUserId().intValue(), toolSessionId, - false); - } - } else { - - // update marks for all learners in a group - List users = getUsersBySession(toolSessionId); - for (AssessmentUser user : users) { - AssessmentResult userLastResult = getLastFinishedAssessmentResult(assessment.getUid(), - user.getUserId()); - if (userLastResult == null) { - continue; - } - Double mark = new Double(userLastResult.getGrade()); - - // propagade total mark to Gradebook - gradebookService.updateActivityMark(mark, null, user.getUserId().intValue(), toolSessionId, - false); - } - } - - } - } - } - - } - - @Override public String getMessage(String key) { return messageService.getMessage(key); } @@ -2353,10 +2256,6 @@ this.assessmentOutputFactory = assessmentOutputFactory; } - public void setLessonService(ILessonService lessonService) { - this.lessonService = lessonService; - } - @Override public Class[] getSupportedToolOutputDefinitionClasses(int definitionType) { return getAssessmentOutputFactory().getSupportedDefinitionClasses(definitionType); @@ -2367,14 +2266,6 @@ return getAssessmentByContentId(toolContentId).getTitle(); } - public void setActivityDAO(IActivityDAO activityDAO) { - this.activityDAO = activityDAO; - } - - public void setUserService(IUserManagementService userService) { - this.userService = userService; - } - // ****************** REST methods ************************* /** Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java =================================================================== diff -u -ra78be3f1e9a9f6b7b69d12d63ca3a14f3c80b931 -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java (.../IAssessmentService.java) (revision a78be3f1e9a9f6b7b69d12d63ca3a14f3c80b931) +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java (.../IAssessmentService.java) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -428,14 +428,5 @@ Set oldReferences, Set newReferences, List deletedReferences); - /** - * Recalculate mark for leader and sets it to all members of a group. Authentication check: user must be either - * lesson stuff or group manager. - * - * @param requestUserDTO - * @param lessonId - */ - void recalculateMarkForLesson(UserDTO requestUserDTO, Long lessonId); - void releaseQuestionsAndReferencesFromCache(Assessment assessment); } Fisheye: Tag 98dbe6c2b98e6433f0721172f9c888599fb6fcf2 refers to a dead (removed) revision in file `lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/servlet/PopulateMarksServlet.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_assessment/web/WEB-INF/web.xml =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_assessment/web/WEB-INF/web.xml (.../web.xml) (revision 5e63656a12c02f7476564e278b43ff4ce86ac930) +++ lams_tool_assessment/web/WEB-INF/web.xml (.../web.xml) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -72,13 +72,7 @@ /* - - populateMarks - org.lamsfoundation.lams.tool.assessment.web.servlet.PopulateMarksServlet - - - action org.apache.struts.action.ActionServlet @@ -142,11 +136,6 @@ /download/* - - populateMarks - /populateMarks - - Index: lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/mcApplicationContext.xml =================================================================== diff -u -r1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/mcApplicationContext.xml (.../mcApplicationContext.xml) (revision 1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c) +++ lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/mcApplicationContext.xml (.../mcApplicationContext.xml) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -87,8 +87,6 @@ - - Index: lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/IMcService.java =================================================================== diff -u -r1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/IMcService.java (.../IMcService.java) (revision 1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c) +++ lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/IMcService.java (.../IMcService.java) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -221,16 +221,7 @@ List deletedQuestions); /** - * Recalculate mark for leader and sets it to all members of a group. Authentication check: user must be either - * lesson stuff or group manager. * - * @param requestUserDTO - * @param lessonId - */ - void recalculateMarkForLesson(UserDTO requestUserDTO, Long lessonId); - - /** - * * returns reflection data for all sessions * * @param mcContent Index: lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McServicePOJO.java =================================================================== diff -u -r1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McServicePOJO.java (.../McServicePOJO.java) (revision 1d3ff83fba3454c6e0e4139dc15ad6cecdfa389c) +++ lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McServicePOJO.java (.../McServicePOJO.java) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -137,8 +137,6 @@ private IAuditService auditService; private IUserManagementService userManagementService; - private ILessonService lessonService; - private IActivityDAO activityDAO; private ILearnerService learnerService; private ILamsToolService toolService; private IToolContentHandler mcToolContentHandler = null; @@ -939,94 +937,6 @@ } @Override - public void recalculateMarkForLesson(UserDTO requestUserDTO, Long lessonId) { - - User requestUser = userManagementService.getUserByLogin(requestUserDTO.getLogin()); - Lesson lesson = lessonService.getLesson(lessonId); - Organisation organisation = lesson.getOrganisation(); - - // skip doing anything if the user doesn't have permission - Integer organisationToCheckPermission = (organisation.getOrganisationType().getOrganisationTypeId() - .equals(OrganisationType.COURSE_TYPE)) ? organisation.getOrganisationId() - : organisation.getParentOrganisation().getOrganisationId(); - boolean isGroupManager = userManagementService.isUserInRole(requestUser.getUserId(), - organisationToCheckPermission, Role.GROUP_MANAGER); - if (!(lesson.getLessonClass().isStaffMember(requestUser) || isGroupManager)) { - return; - } - - // get all lesson activities - Set lessonActivities = new TreeSet(); - /* - * Hibernate CGLIB is failing to load the first activity in the sequence as a ToolActivity for some mysterious - * reason Causes a ClassCastException when you try to cast it, even if it is a ToolActivity. - * - * THIS IS A HACK to retrieve the first tool activity manually so it can be cast as a ToolActivity - if it is - * one - */ - Activity firstActivity = activityDAO - .getActivityByActivityId(lesson.getLearningDesign().getFirstActivity().getActivityId()); - lessonActivities.add(firstActivity); - lessonActivities.addAll(lesson.getLearningDesign().getActivities()); - - // iterate through all assessment activities in the lesson - for (Activity activity : lessonActivities) { - - // check if it's assessment activity - if ((activity instanceof ToolActivity) - && ((ToolActivity) activity).getTool().getToolSignature().equals(McAppConstants.MY_SIGNATURE)) { - ToolActivity mcqActivity = (ToolActivity) activity; - - for (ToolSession toolSession : (Set) mcqActivity.getToolSessions()) { - Long toolSessionId = toolSession.getToolSessionId(); - McSession mcSession = getMcSessionById(toolSessionId); - McContent mcContent = mcSession.getMcContent(); - - if (mcContent.isUseSelectLeaderToolOuput()) { - - McQueUsr leader = mcSession.getGroupLeader(); - //if there is no leader yet or leader hasn't submitted any attempts - no point in updating gradebook marks - if (leader == null || (leader.getNumberOfAttempts() == 0)) { - continue; - } - - final Double leaderMark = new Double(leader.getLastAttemptTotalMark()); - - // update marks for all learners in a group - Set users = mcSession.getMcQueUsers(); - for (McQueUsr user : users) { - copyAnswersFromLeader(user, leader); - - // propagade total mark to Gradebook - gradebookService.updateActivityMark(leaderMark, null, user.getQueUsrId().intValue(), - toolSessionId, false); - } - } else { - - // update marks for all learners in a group - Set users = mcSession.getMcQueUsers(); - for (McQueUsr user : users) { - - // if leader hasn't submitted any attempts - no point in updating gradebook marks - if (user.getNumberOfAttempts() == 0) { - continue; - } - - final Double userMark = new Double(user.getLastAttemptTotalMark()); - - // propagade total mark to Gradebook - gradebookService.updateActivityMark(userMark, null, user.getQueUsrId().intValue(), - toolSessionId, false); - } - } - - } - } - } - - } - - @Override public byte[] prepareSessionDataSpreadsheet(McContent mcContent) throws IOException { Set questions = mcContent.getMcQueContents(); @@ -1746,14 +1656,6 @@ this.userManagementService = userManagementService; } - public void setLessonService(ILessonService lessonService) { - this.lessonService = lessonService; - } - - public void setActivityDAO(IActivityDAO activityDAO) { - this.activityDAO = activityDAO; - } - public void setToolService(ILamsToolService toolService) { this.toolService = toolService; } Fisheye: Tag 98dbe6c2b98e6433f0721172f9c888599fb6fcf2 refers to a dead (removed) revision in file `lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/PopulateMarksServlet.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_lamc/web/WEB-INF/web.xml =================================================================== diff -u -r0b9090d0eea4ebffbe709fe84b35b13c787dea40 -r98dbe6c2b98e6433f0721172f9c888599fb6fcf2 --- lams_tool_lamc/web/WEB-INF/web.xml (.../web.xml) (revision 0b9090d0eea4ebffbe709fe84b35b13c787dea40) +++ lams_tool_lamc/web/WEB-INF/web.xml (.../web.xml) (revision 98dbe6c2b98e6433f0721172f9c888599fb6fcf2) @@ -98,13 +98,7 @@ 3 - - - populateMarks - org.lamsfoundation.lams.tool.mc.web.PopulateMarksServlet - - Connector @@ -129,11 +123,6 @@ download /download/* - - - populateMarks - /populateMarks - Connector