Index: lams_tool_images/.externalToolBuilders/SASS_lams_tool_images.launch =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/.externalToolBuilders/SASS_lams_tool_images.launch (.../SASS_lams_tool_images.launch) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/.externalToolBuilders/SASS_lams_tool_images.launch (.../SASS_lams_tool_images.launch) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -1,16 +1,22 @@ - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java (.../ImageGalleryConstants.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/ImageGalleryConstants.java (.../ImageGalleryConstants.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -23,7 +23,7 @@ package org.lamsfoundation.lams.tool.imageGallery; -public class ImageGalleryConstants { +public interface ImageGalleryConstants { public static final String TOOL_SIGNATURE = "laimag10"; public static final String IMAGE_GALLERY_SERVICE = "laimagImageGalleryService"; public static final String TOOL_CONTENT_HANDLER_NAME = "laimagImageGalleryToolContentHandler"; Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java (.../IImageGalleryService.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/IImageGalleryService.java (.../IImageGalleryService.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -27,7 +27,6 @@ import java.util.Map; import java.util.Set; -import org.apache.struts.upload.FormFile; import org.lamsfoundation.lams.notebook.model.NotebookEntry; import org.lamsfoundation.lams.rating.ToolRatingManager; import org.lamsfoundation.lams.rating.dto.ItemRatingDTO; @@ -40,6 +39,7 @@ import org.lamsfoundation.lams.tool.imageGallery.model.ImageGallerySession; import org.lamsfoundation.lams.tool.imageGallery.model.ImageGalleryUser; import org.lamsfoundation.lams.tool.imageGallery.model.ImageVote; +import org.springframework.web.multipart.MultipartFile; /** * Interface that defines the contract that all ShareImageGallery service provider must follow. @@ -73,7 +73,7 @@ * @param file * @throws UploadImageGalleryFileException */ - void uploadImageGalleryItemFile(ImageGalleryItem item, FormFile file) throws UploadImageGalleryFileException; + void uploadImageGalleryItemFile(ImageGalleryItem item, MultipartFile file) throws UploadImageGalleryFileException; // ********** for user methods ************* /** @@ -285,8 +285,8 @@ * Returns localized next image title. * * @param nextImageTitleNumber - * - * @return + * + * @return */ String generateNextImageTitle(Long nextImageTitleNumber); @@ -314,10 +314,10 @@ * @return */ boolean isGroupedActivity(long toolContentID); - + /** * Audit log the teacher has started editing activity in monitor. - * + * * @param toolContentID */ void auditLogStartEditingActivityInMonitor(long toolContentID); Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java (.../ImageGalleryServiceImpl.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -45,7 +45,6 @@ import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; -import org.apache.struts.upload.FormFile; import org.lamsfoundation.lams.confidencelevel.ConfidenceLevelDTO; import org.lamsfoundation.lams.contentrepository.NodeKey; import org.lamsfoundation.lams.contentrepository.exception.InvalidParameterException; @@ -99,6 +98,7 @@ import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; import org.lamsfoundation.lams.util.MessageService; import org.lamsfoundation.lams.util.imgscalr.ResizePictureUtil; +import org.springframework.web.multipart.MultipartFile; /** * @author Andrey Balan @@ -310,7 +310,7 @@ boolean isHidden = image.isHide(); image.setHide(!isHidden); imageGalleryItemDao.saveObject(image); - + // audit log Long userId = image.getCreateBy() == null ? 0L : image.getCreateBy().getUserId(); String loginName = image.getCreateBy() == null ? "No user" : image.getCreateBy().getLoginName(); @@ -347,7 +347,7 @@ @Override public ItemRatingDTO getRatingCriteriaDtos(Long contentId, Long toolSessionId, Long imageUid, Long userId) { - LinkedList itemIds = new LinkedList(); + LinkedList itemIds = new LinkedList<>(); itemIds.add(imageUid); ItemRatingDTO ratingCriteria = getRatingCriteriaDtos(contentId, toolSessionId, itemIds, true, userId).get(0); @@ -357,7 +357,8 @@ @Override public List getRatingCriteriaDtos(Long contentId, Long toolSessionId, Collection itemIds, boolean isCommentsByOtherUsersRequired, Long userId) { - return ratingService.getRatingCriteriaDtos(contentId, toolSessionId, itemIds, isCommentsByOtherUsersRequired, userId); + return ratingService.getRatingCriteriaDtos(contentId, toolSessionId, itemIds, isCommentsByOtherUsersRequired, + userId); } @Override @@ -389,31 +390,31 @@ @Override public List> getSummary(Long contentId) { - List> groupList = new ArrayList>(); - List group = new ArrayList(); + List> groupList = new ArrayList<>(); + List group = new ArrayList<>(); // get all item which is accessed by user ImageGallery imageGallery = imageGalleryDao.getByContentId(contentId); List sessionList = imageGallerySessionDao.getByContentId(contentId); for (ImageGallerySession session : sessionList) { // one new group for one session. - group = new ArrayList(); + group = new ArrayList<>(); Set groupImages = getImagesForGroup(imageGallery, session.getSessionId()); List itemRatingDtos = null; if (imageGallery.isAllowRank()) { // create itemIds list - List itemIds = new LinkedList(); + List itemIds = new LinkedList<>(); for (ImageGalleryItem image : groupImages) { itemIds.add(image.getUid()); } final Long USER_ID = -1L; final boolean IS_COMMENTS_BY_OTHER_USERS_REQUIRED = true; // !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!TODO calculate average ratings based on one // session data - itemRatingDtos = getRatingCriteriaDtos(contentId, session.getSessionId(), itemIds, IS_COMMENTS_BY_OTHER_USERS_REQUIRED, - USER_ID); + itemRatingDtos = getRatingCriteriaDtos(contentId, session.getSessionId(), itemIds, + IS_COMMENTS_BY_OTHER_USERS_REQUIRED, USER_ID); } for (ImageGalleryItem image : groupImages) { @@ -450,22 +451,22 @@ @Override public List> getImageSummary(Long contentId, Long imageUid) { - List> imageSummary = new ArrayList>(); - List group = new ArrayList(); + List> imageSummary = new ArrayList<>(); + List group = new ArrayList<>(); ImageGalleryItem image = imageGalleryItemDao.getByUid(imageUid); ImageGallery imageGallery = getImageGalleryByContentId(contentId); List sessionList; if (image.isCreateByAuthor()) { sessionList = imageGallerySessionDao.getByContentId(contentId); } else { - sessionList = new ArrayList(); + sessionList = new ArrayList<>(); sessionList.add(image.getCreateBy().getSession()); } for (ImageGallerySession session : sessionList) { // one new group for one session. - group = new ArrayList(); + group = new ArrayList<>(); // Object[] ratingForGroup = getRatingForGroup(image.getUid(), session.getSessionId()); List users = imageGalleryUserDao.getBySessionID(session.getSessionId()); @@ -511,13 +512,13 @@ @Override public Map> getReflectList(Long contentId, boolean setEntry) { - Map> map = new HashMap>(); + Map> map = new HashMap<>(); List sessionList = imageGallerySessionDao.getByContentId(contentId); for (ImageGallerySession session : sessionList) { Long sessionId = session.getSessionId(); boolean hasRefection = session.getImageGallery().isReflectOnActivity(); - Set list = new TreeSet(new ReflectDTOComparator()); + Set list = new TreeSet<>(new ReflectDTOComparator()); // get all users in this session List users = imageGalleryUserDao.getBySessionID(sessionId); for (ImageGalleryUser user : users) { @@ -541,7 +542,7 @@ } @Override - public void uploadImageGalleryItemFile(ImageGalleryItem image, FormFile file) + public void uploadImageGalleryItemFile(ImageGalleryItem image, MultipartFile file) throws UploadImageGalleryFileException { ImageGalleryConfigItem mediumImageDimensionsKey = getConfigItem( @@ -551,15 +552,14 @@ ImageGalleryConfigItem thumbnailImageDimensionsKey = getConfigItem( ImageGalleryConfigItem.KEY_THUMBNAIL_IMAGE_DIMENSIONS); int thumbnailImageDimensions = Integer.parseInt(thumbnailImageDimensionsKey.getConfigValue()); - + try { // upload file - NodeKey nodeKey = uploadFormFile(file); - image.setFileName(file.getFileName()); + NodeKey nodeKey = uploadMultipartFile(file); + image.setFileName(file.getOriginalFilename()); image.setOriginalFileUuid(nodeKey.getUuid()); - String fileName = file.getFileName(); + String fileName = file.getOriginalFilename(); - InputStream originalIS = imageGalleryToolContentHandler.getFileNode(nodeKey.getUuid()).getFile(); BufferedImage originalImage = ImageIO.read(originalIS); //throw exception if image was not successfully read @@ -569,21 +569,20 @@ //store orginalImageWidth and orginalImageHeight image.setOriginalImageWidth(originalImage.getWidth(null)); image.setOriginalImageHeight(originalImage.getHeight(null)); - + // prepare medium image InputStream mediumIS = ResizePictureUtil.resize(originalImage, mediumImageDimensions); String mediumFileName = ImageGalleryServiceImpl.MEDIUM_FILENAME_PREFIX + fileName.substring(0, fileName.indexOf('.')) + ".jpg"; - NodeKey mediumNodeKey = imageGalleryToolContentHandler.uploadFile(mediumIS, mediumFileName, - "image/jpeg"); + NodeKey mediumNodeKey = imageGalleryToolContentHandler.uploadFile(mediumIS, mediumFileName, "image/jpeg"); image.setMediumFileUuid(mediumNodeKey.getUuid()); //store MediumImageWidth and MediumImageHeight InputStream mediumIS2 = imageGalleryToolContentHandler.getFileNode(mediumNodeKey.getUuid()).getFile(); BufferedImage mediumImage = ImageIO.read(mediumIS2); image.setMediumImageWidth(mediumImage.getWidth(null)); image.setMediumImageHeight(mediumImage.getHeight(null)); mediumIS2.close(); - + // prepare thumbnail image InputStream originalIS2 = imageGalleryToolContentHandler.getFileNode(nodeKey.getUuid()).getFile(); InputStream thumbnailIS = ResizePictureUtil.resize(originalIS2, thumbnailImageDimensions); @@ -612,15 +611,15 @@ * @throws RepositoryCheckedException * @throws InvalidParameterException */ - private NodeKey uploadFormFile(FormFile file) throws UploadImageGalleryFileException { - if ((file == null) || StringUtils.isEmpty(file.getFileName())) { + private NodeKey uploadMultipartFile(MultipartFile file) throws UploadImageGalleryFileException { + if ((file == null) || StringUtils.isEmpty(file.getOriginalFilename())) { throw new UploadImageGalleryFileException( messageService.getMessage("error.msg.upload.file.not.found", new Object[] { file })); } NodeKey node = null; try { - node = imageGalleryToolContentHandler.uploadFile(file.getInputStream(), file.getFileName(), + node = imageGalleryToolContentHandler.uploadFile(file.getInputStream(), file.getOriginalFilename(), file.getContentType()); } catch (InvalidParameterException e) { throw new UploadImageGalleryFileException(messageService.getMessage("error.msg.invaid.param.upload")); @@ -638,10 +637,10 @@ public boolean isGroupedActivity(long toolContentID) { return toolService.isGroupedActivity(toolContentID); } - + @Override public void auditLogStartEditingActivityInMonitor(long toolContentID) { - toolService.auditLogStartEditingActivityInMonitor(toolContentID); + toolService.auditLogStartEditingActivityInMonitor(toolContentID); } @Override @@ -732,9 +731,9 @@ Set criterias = toolContentObj.getRatingCriterias(); if (criterias != null) { for (LearnerItemRatingCriteria criteria : criterias) { - criteria.setToolContentId(null); + criteria.setToolContentId(null); + } } - } // set ImageGalleryToolContentHandler as null to avoid copy file node in repository again. toolContentObj = ImageGallery.newInstance(toolContentObj, toolContentId); @@ -1055,12 +1054,12 @@ public ToolOutput getToolOutput(String name, Long toolSessionId, Long learnerId) { return imageGalleryOutputFactory.getToolOutput(name, this, toolSessionId, learnerId); } - + @Override public List getToolOutputs(String name, Long toolContentId) { - return new ArrayList(); + return new ArrayList<>(); } - + @Override public List getConfidenceLevels(Long toolSessionId) { return null; @@ -1086,20 +1085,23 @@ if (item.getCreateBy().getUserId() == learnerId) { Date newDate = item.getCreateDate(); if (newDate != null) { - if (startDate == null || newDate.before(startDate)) + if (startDate == null || newDate.before(startDate)) { startDate = newDate; - if (endDate == null || newDate.after(endDate)) + } + if (endDate == null || newDate.after(endDate)) { endDate = newDate; + } } } } - if (learner.isSessionFinished()) + if (learner.isSessionFinished()) { return new ToolCompletionStatus(ToolCompletionStatus.ACTIVITY_COMPLETED, startDate, endDate); - else + } else { return new ToolCompletionStatus(ToolCompletionStatus.ACTIVITY_ATTEMPTED, startDate, null); + } } - + /* =================================================================================== */ public IExportToolContentService getExportContentService() { @@ -1160,7 +1162,7 @@ @Override public Set getImagesForGroup(ImageGallery imageGallery, Long sessionId) { - TreeSet images = new TreeSet(new ImageGalleryItemComparator()); + TreeSet images = new TreeSet<>(new ImageGalleryItemComparator()); List grouppedUsers = getUserListBySessionId(sessionId); Set allImages = imageGallery.getImageGalleryItems(); Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/util/ImageGalleryUtils.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/util/ImageGalleryUtils.java (.../ImageGalleryUtils.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/util/ImageGalleryUtils.java (.../ImageGalleryUtils.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -4,93 +4,92 @@ import java.util.List; import org.apache.commons.lang.StringUtils; -import org.apache.struts.action.ActionErrors; -import org.apache.struts.action.ActionMessage; -import org.apache.struts.action.ActionMessages; -import org.apache.struts.upload.FormFile; -import org.lamsfoundation.lams.tool.imageGallery.ImageGalleryConstants; import org.lamsfoundation.lams.tool.imageGallery.web.form.ImageGalleryItemForm; import org.lamsfoundation.lams.tool.imageGallery.web.form.MultipleImagesForm; -import org.lamsfoundation.lams.util.FileValidatorUtil; +import org.lamsfoundation.lams.util.FileValidatorSpringUtil; +import org.lamsfoundation.lams.util.MessageService; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.util.LinkedMultiValueMap; +import org.springframework.util.MultiValueMap; +import org.springframework.web.multipart.MultipartFile; public class ImageGalleryUtils { + + @Autowired + @Qualifier("laimagMessageService") + private static MessageService messageService; + /** * Validate imageGallery item. - * - * @param itemForm - * @return */ - public static ActionErrors validateImageGalleryItem(ImageGalleryItemForm itemForm, boolean largeFile) { - ActionErrors errors = new ActionErrors(); + public static MultiValueMap validateImageGalleryItem(ImageGalleryItemForm itemForm, + boolean largeFile) { + MultiValueMap errorMap = new LinkedMultiValueMap<>(); + // validate file size - FileValidatorUtil.validateFileSize(itemForm.getFile(), largeFile, errors); + FileValidatorSpringUtil.validateFileSize(itemForm.getFile(), largeFile); // for edit validate: file already exist if (!itemForm.isHasFile() - && ((itemForm.getFile() == null) || StringUtils.isEmpty(itemForm.getFile().getFileName()))) { - errors.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage(ImageGalleryConstants.ERROR_MSG_FILE_BLANK)); + && ((itemForm.getFile() == null) || StringUtils.isEmpty(itemForm.getFile().getOriginalFilename()))) { + errorMap.add("GLOBAL", messageService.getMessage("error.resource.item.file.blank")); } // check for allowed format : gif, png, jpg if (itemForm.getFile() != null) { String contentType = itemForm.getFile().getContentType(); - if (isContentTypeForbidden(contentType)) { - errors.add(ActionMessages.GLOBAL_MESSAGE, - new ActionMessage(ImageGalleryConstants.ERROR_MSG_NOT_ALLOWED_FORMAT)); + if (ImageGalleryUtils.isContentTypeForbidden(contentType)) { + errorMap.add("GLOBAL", messageService.getMessage("error.resource.image.not.alowed.format")); } } - return errors; + return errorMap; } /** * Validate imageGallery item. - * - * @param multipleForm - * @return */ - public static ActionErrors validateMultipleImages(MultipleImagesForm multipleForm, boolean largeFile) { - ActionErrors errors = new ActionErrors(); + public static MultiValueMap validateMultipleImages(MultipleImagesForm multipleForm, + boolean largeFile) { - List fileList = createFileListFromMultipleForm(multipleForm); + MultiValueMap errorMap = new LinkedMultiValueMap<>(); + List fileList = ImageGalleryUtils.createFileListFromMultipleForm(multipleForm); + // validate files size - for (FormFile file : fileList) { - FileValidatorUtil.validateFileSize(file, largeFile, errors); + for (MultipartFile file : fileList) { + FileValidatorSpringUtil.validateFileSize(file, largeFile); // check for allowed format : gif, png, jpg String contentType = file.getContentType(); - if (isContentTypeForbidden(contentType)) { - errors.add(ActionMessages.GLOBAL_MESSAGE, - new ActionMessage(ImageGalleryConstants.ERROR_MSG_NOT_ALLOWED_FORMAT_FOR, file.getFileName())); + if (ImageGalleryUtils.isContentTypeForbidden(contentType)) { + errorMap.add("GLOBAL", messageService.getMessage("error.resource.image.not.alowed.format.for")); } } - return errors; + return errorMap; } /** * Create file list from multiple form. - * - * @param multipleForm - * @return */ - public static List createFileListFromMultipleForm(MultipleImagesForm multipleForm) { + public static List createFileListFromMultipleForm(MultipleImagesForm multipleForm) { - List fileList = new ArrayList(); - if (multipleForm.getFile1() != null && !StringUtils.isEmpty(multipleForm.getFile1().getFileName())) { + List fileList = new ArrayList<>(); + if (multipleForm.getFile1() != null && !StringUtils.isEmpty(multipleForm.getFile1().getOriginalFilename())) { fileList.add(multipleForm.getFile1()); } - if (multipleForm.getFile2() != null && !StringUtils.isEmpty(multipleForm.getFile2().getFileName())) { + if (multipleForm.getFile2() != null && !StringUtils.isEmpty(multipleForm.getFile2().getOriginalFilename())) { fileList.add(multipleForm.getFile2()); } - if (multipleForm.getFile3() != null && !StringUtils.isEmpty(multipleForm.getFile3().getFileName())) { + if (multipleForm.getFile3() != null && !StringUtils.isEmpty(multipleForm.getFile3().getOriginalFilename())) { fileList.add(multipleForm.getFile3()); } - if (multipleForm.getFile4() != null && !StringUtils.isEmpty(multipleForm.getFile4().getFileName())) { + if (multipleForm.getFile4() != null && !StringUtils.isEmpty(multipleForm.getFile4().getOriginalFilename())) { fileList.add(multipleForm.getFile4()); } - if (multipleForm.getFile5() != null && !StringUtils.isEmpty(multipleForm.getFile5().getFileName())) { + if (multipleForm.getFile5() != null && !StringUtils.isEmpty(multipleForm.getFile5().getOriginalFilename())) { fileList.add(multipleForm.getFile5()); } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java (.../AdminForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/AdminForm.java (.../AdminForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -20,32 +20,36 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; import javax.servlet.http.HttpServletRequest; -import org.apache.struts.action.ActionErrors; -import org.apache.struts.action.ActionForm; -import org.apache.struts.action.ActionMapping; -import org.apache.struts.action.ActionMessage; -import org.apache.struts.action.ActionMessages; +import org.lamsfoundation.lams.util.MessageService; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; +import org.springframework.util.LinkedMultiValueMap; +import org.springframework.util.MultiValueMap; /** * */ -public class AdminForm extends ActionForm { +public class AdminForm { + + @Autowired + @Qualifier("laimagMessageService") + private static MessageService messageService; + private static final long serialVersionUID = 414425664356226L; private String mediumImageDimensions; private String thumbnailImageDimensions; - @Override - public ActionErrors validate(ActionMapping arg0, HttpServletRequest arg1) { - ActionErrors ac = new ActionErrors(); - ac.add(ActionMessages.GLOBAL_MESSAGE, new ActionMessage("this is an error")); - return ac; + public MultiValueMap validate(HttpServletRequest arg1) { + + MultiValueMap errorMap = new LinkedMultiValueMap<>(); + errorMap.add("GLOBAL", messageService.getMessage("this is an error")); + return errorMap; } public String getMediumImageDimensions() { Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java (.../ImageGalleryForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryForm.java (.../ImageGalleryForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -27,10 +27,8 @@ import org.apache.commons.lang.StringUtils; import org.apache.log4j.Logger; -import org.apache.struts.action.ActionForm; -import org.apache.struts.action.ActionMapping; -import org.apache.struts.upload.FormFile; import org.lamsfoundation.lams.tool.imageGallery.model.ImageGallery; +import org.springframework.web.multipart.MultipartFile; /** * @@ -40,7 +38,7 @@ * * User: Andrey Balan */ -public class ImageGalleryForm extends ActionForm { +public class ImageGalleryForm { private static final long serialVersionUID = 3599879328307492312L; private static Logger logger = Logger.getLogger(ImageGalleryForm.class.getName()); @@ -49,8 +47,8 @@ private String sessionMapID; private String contentFolderID; private int currentTab; - private FormFile offlineFile; - private FormFile onlineFile; + private MultipartFile offlineFile; + private MultipartFile onlineFile; private ImageGallery imageGallery; private boolean allowRatingsOrVote; @@ -69,12 +67,11 @@ } } - @Override - public void reset(ActionMapping mapping, HttpServletRequest request) { - String param = mapping.getParameter(); + public void reset(HttpServletRequest request) { + String param = (String) request.getAttribute("action"); // if it is start page, all data read out from database or current session // so need not reset checkbox to refresh value! - if (!StringUtils.equals(param, "start") && !StringUtils.equals(param, "initPage")) { + if (!StringUtils.equals(param, "start.do") && !StringUtils.equals(param, "initPage.do")) { imageGallery.setAllowShareImages(false); imageGallery.setLockWhenFinished(false); imageGallery.setDefineLater(false); @@ -91,19 +88,19 @@ this.currentTab = currentTab; } - public FormFile getOfflineFile() { + public MultipartFile getOfflineFile() { return offlineFile; } - public void setOfflineFile(FormFile offlineFile) { + public void setOfflineFile(MultipartFile offlineFile) { this.offlineFile = offlineFile; } - public FormFile getOnlineFile() { + public MultipartFile getOnlineFile() { return onlineFile; } - public void setOnlineFile(FormFile onlineFile) { + public void setOnlineFile(MultipartFile onlineFile) { this.onlineFile = onlineFile; } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java (.../ImageGalleryItemForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageGalleryItemForm.java (.../ImageGalleryItemForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -23,16 +23,15 @@ package org.lamsfoundation.lams.tool.imageGallery.web.form; -import org.apache.struts.action.ActionForm; -import org.apache.struts.upload.FormFile; +import org.springframework.web.multipart.MultipartFile; /** * ImageGallery Item Form. * * * @author Andrey Balan */ -public class ImageGalleryItemForm extends ActionForm { +public class ImageGalleryItemForm { private String imageIndex; private String sessionMapID; @@ -45,7 +44,7 @@ private boolean hasFile; private Long fileUuid; private String fileName; - private FormFile file; + private MultipartFile file; //used only in monitoring private String imageUid; @@ -125,11 +124,11 @@ this.hasFile = hasFile; } - public FormFile getFile() { + public MultipartFile getFile() { return file; } - public void setFile(FormFile file) { + public void setFile(MultipartFile file) { this.file = file; } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java (.../ImageRatingForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ImageRatingForm.java (.../ImageRatingForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -20,18 +20,15 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; -import org.apache.struts.action.ActionForm; - /** * Image star rating Form. * * * @author Andrey Balan */ -public class ImageRatingForm extends ActionForm { +public class ImageRatingForm { private static final long serialVersionUID = -8962161058929959289L; Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java (.../MultipleImagesForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/MultipleImagesForm.java (.../MultipleImagesForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -20,19 +20,17 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; -import org.apache.struts.action.ActionForm; -import org.apache.struts.upload.FormFile; +import org.springframework.web.multipart.MultipartFile; /** * Multiple Images Form. * * * @author Andrey Balan */ -public class MultipleImagesForm extends ActionForm { +public class MultipleImagesForm { private static final long serialVersionUID = -5595679171112282994L; @@ -42,11 +40,11 @@ private boolean hasFile; private Long fileUuid; private String fileName; - private FormFile file1; - private FormFile file2; - private FormFile file3; - private FormFile file4; - private FormFile file5; + private MultipartFile file1; + private MultipartFile file2; + private MultipartFile file3; + private MultipartFile file4; + private MultipartFile file5; //used only in monitoring private String imageUid; @@ -83,43 +81,43 @@ this.hasFile = hasFile; } - public FormFile getFile1() { + public MultipartFile getFile1() { return file1; } - public void setFile1(FormFile file) { + public void setFile1(MultipartFile file) { this.file1 = file; } - public FormFile getFile2() { + public MultipartFile getFile2() { return file2; } - public void setFile2(FormFile file) { + public void setFile2(MultipartFile file) { this.file2 = file; } - public FormFile getFile3() { + public MultipartFile getFile3() { return file3; } - public void setFile3(FormFile file) { + public void setFile3(MultipartFile file) { this.file3 = file; } - public FormFile getFile4() { + public MultipartFile getFile4() { return file4; } - public void setFile4(FormFile file) { + public void setFile4(MultipartFile file) { this.file4 = file; } - public FormFile getFile5() { + public MultipartFile getFile5() { return file5; } - public void setFile5(FormFile file) { + public void setFile5(MultipartFile file) { this.file5 = file; } Index: lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java (.../ReflectionForm.java) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/web/form/ReflectionForm.java (.../ReflectionForm.java) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -21,11 +21,9 @@ * **************************************************************** */ - package org.lamsfoundation.lams.tool.imageGallery.web.form; import org.apache.log4j.Logger; -import org.apache.struts.validator.ValidatorForm; /** * @@ -34,7 +32,8 @@ * * */ -public class ReflectionForm extends ValidatorForm { +public class ReflectionForm { + private static final long serialVersionUID = -9054365604649146735L; private static Logger logger = Logger.getLogger(ReflectionForm.class.getName()); Index: lams_tool_images/web/WEB-INF/tags/AuthoringButton.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/AuthoringButton.tag (.../AuthoringButton.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/AuthoringButton.tag (.../AuthoringButton.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -32,7 +32,6 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> <%@ taglib uri="tags-lams" prefix="lams"%> <%@ attribute name="formID" required="true" rtexprvalue="true" %> @@ -123,11 +122,11 @@ } \ No newline at end of file Index: lams_tool_images/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag (.../AuthoringRatingAllStyleCriteria.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag (.../AuthoringRatingAllStyleCriteria.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -8,7 +8,6 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> <%@ taglib uri="tags-lams" prefix="lams"%> <%@ taglib uri="tags-function" prefix="fn" %> Index: lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/AuthoringRatingCriteria.tag (.../AuthoringRatingCriteria.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -8,9 +8,9 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> <%@ taglib uri="tags-lams" prefix="lams"%> <%@ taglib uri="tags-function" prefix="fn" %> +<%@ taglib uri="http://www.springframework.org/tags/form" prefix="form" %> <%@ attribute name="criterias" required="true" rtexprvalue="true" type="java.util.Collection" %> @@ -284,42 +284,38 @@ - - - - - 1 - 2 - 3 - 4 - 5 - 6 - 7 - 8 - 9 - 10 - + + + 1 + + + + + + + + + + - - - - - 1 - 2 - 3 - 4 - 5 - 6 - 7 - 8 - 9 - 10 - + + + + + + + + + + + + + Index: lams_tool_images/web/WEB-INF/tags/CommentsAuthor.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/CommentsAuthor.tag (.../CommentsAuthor.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/CommentsAuthor.tag (.../CommentsAuthor.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -42,23 +42,21 @@
-     -   +     +  
Index: lams_tool_images/web/WEB-INF/tags/Page.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/Page.tag (.../Page.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -4,6 +4,7 @@ <%@ taglib uri="tags-lams" prefix="lams"%> <%@ attribute name="type" required="true" rtexprvalue="true"%> +<%@ attribute name="formID" required="false" rtexprvalue="true"%> <%@ attribute name="style" required="false" rtexprvalue="true"%> <%@ attribute name="title" required="false" rtexprvalue="true"%> <%@ attribute name="titleHelpURL" required="false" rtexprvalue="true"%> @@ -88,8 +89,8 @@ - - + + ${toolForm.toolSessionID} @@ -434,4 +435,4 @@
- + \ No newline at end of file Index: lams_tool_images/web/WEB-INF/tags/Rating.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/Rating.tag (.../Rating.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/Rating.tag (.../Rating.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -8,7 +8,6 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> <%@ taglib uri="tags-lams" prefix="lams"%> <%@ taglib uri="tags-function" prefix="fn" %> Index: lams_tool_images/web/WEB-INF/tags/StyledRating.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/StyledRating.tag (.../StyledRating.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/StyledRating.tag (.../StyledRating.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -8,7 +8,6 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> <%@ taglib uri="tags-lams" prefix="lams"%> <%@ taglib uri="tags-function" prefix="fn" %> Index: lams_tool_images/web/WEB-INF/tags/TabBody.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/TabBody.tag (.../TabBody.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/TabBody.tag (.../TabBody.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -34,7 +34,6 @@ <%@ attribute name="titleKey" required="false" rtexprvalue="true"%> <%@ attribute name="page" required="false" rtexprvalue="true"%> <%@ taglib uri="tags-core" prefix="c"%> -<%@ taglib uri="tags-bean" prefix="bean"%> Index: lams_tool_images/web/WEB-INF/tags/TabBodyArea.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/TabBodyArea.tag (.../TabBodyArea.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/TabBodyArea.tag (.../TabBodyArea.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -30,7 +30,6 @@ %> <%@ taglib uri="tags-core" prefix="c"%> -<%@ taglib uri="tags-bean" prefix="bean"%>
Index: lams_tool_images/web/WEB-INF/tags/TextSearch.tag =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/tags/TextSearch.tag (.../TextSearch.tag) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/tags/TextSearch.tag (.../TextSearch.tag) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -32,12 +32,11 @@ <%@ tag body-content="scriptless" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> -<%@ taglib uri="tags-html" prefix="html" %> +<%@ taglib uri="http://www.springframework.org/tags/form" prefix="form" %> <%@ taglib uri="tags-lams" prefix="lams" %> <%-- Required attributes --%> <%@ attribute name="sessionMapID" required="true" rtexprvalue="true" %> -<%@ attribute name="wrapInFormTag" required="true" rtexprvalue="true" %> <%-- Optional attributes --%> <%@ attribute name="action" required="false" rtexprvalue="true" %> @@ -53,10 +52,10 @@ <%-- Default value for message key --%> - + - + @@ -85,52 +84,40 @@ - -
- - -

- - - - - - - - - - - - - - - - - -
- - - -
- - - -
- - - -
- - - -
- - - - - - - - - + +

+ + + + + + + + + + + + + + + + + +
+ + + +
+ + + +
+ + + +
+ + + +
\ No newline at end of file Index: lams_tool_images/web/WEB-INF/web.xml =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/WEB-INF/web.xml (.../web.xml) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/WEB-INF/web.xml (.../web.xml) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -72,27 +72,12 @@ /* - - action - org.apache.struts.action.ActionServlet - - config - /WEB-INF/struts-config.xml - - - debug - 999 - - - detail - 1 - - - validate - true - - 2 + spring + + org.springframework.web.servlet.DispatcherServlet + + 1 @@ -123,7 +108,7 @@ - action + spring *.do @@ -140,42 +125,6 @@ - - - - tags-bean - /WEB-INF/tlds/struts/struts-bean.tld - - - tags-html - /WEB-INF/tlds/struts/struts-html.tld - - - tags-logic - /WEB-INF/tlds/struts/struts-logic.tld - - - tags-tiles - /WEB-INF/tlds/struts/struts-tiles.tld - - - - tags-bean-el - /WEB-INF/tlds/struts/struts-bean-el.tld - - - tags-html-el - /WEB-INF/tlds/struts/struts-html-el.tld - - - tags-logic-el - /WEB-INF/tlds/struts/struts-logic-el.tld - - - tags-tiles-el - /WEB-INF/tlds/struts/struts-tiles-el.tld - - Index: lams_tool_images/web/common/header.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/common/header.jsp (.../header.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/common/header.jsp (.../header.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -8,7 +8,7 @@ - + Index: lams_tool_images/web/common/messages.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/common/messages.jsp (.../messages.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/common/messages.jsp (.../messages.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -1,8 +1,10 @@ -<%-- Error Messages --%> - - - -
-
-
-
\ No newline at end of file + <%@include file="/common/taglibs.jsp"%> + + + + + + + + + Index: lams_tool_images/web/common/tabbedheader.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/common/tabbedheader.jsp (.../tabbedheader.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/common/tabbedheader.jsp (.../tabbedheader.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -11,4 +11,4 @@ - + Index: lams_tool_images/web/common/taglibs.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/common/taglibs.jsp (.../taglibs.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/common/taglibs.jsp (.../taglibs.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -1,11 +1,8 @@ <%@ page language="java" errorPage="/error.jsp" pageEncoding="UTF-8" contentType="text/html;charset=utf-8" %> -<%@ taglib uri="tags-bean" prefix="bean" %> -<%@ taglib uri="tags-html" prefix="html" %> -<%@ taglib uri="tags-logic" prefix="logic" %> <%@ taglib uri="tags-function" prefix="fn" %> <%@ taglib uri="tags-core" prefix="c" %> <%@ taglib uri="tags-fmt" prefix="fmt" %> <%@ taglib uri="tags-xml" prefix="x" %> <%@ taglib uri="tags-lams" prefix="lams" %> +<%@ taglib uri="http://www.springframework.org/tags/form" prefix="form" %> - Index: lams_tool_images/web/pages/admin/config.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/pages/admin/config.jsp (.../config.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/pages/admin/config.jsp (.../config.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -12,7 +12,7 @@ - + @@ -24,16 +24,16 @@
- + + + @@ -42,12 +42,12 @@ + +
- -
- -
- -
+ " class="btn btn-primary pull-right"/> + Index: lams_tool_images/web/pages/authoring/advance.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/pages/authoring/advance.jsp (.../advance.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -1,7 +1,8 @@ <%@ include file="/common/taglibs.jsp"%> - - +
@@ -67,8 +67,8 @@
@@ -77,14 +77,14 @@
- display:none; + display:none;
- +
Index: lams_tool_images/web/pages/authoring/authoring.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/pages/authoring/authoring.jsp (.../authoring.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -22,7 +22,7 @@ var LABEL_MAX_FILE_SIZE = ''; var LABEL_NOT_ALLOWED_FORMAT = ''; - + - + - - + + - + - + - - - + + + <%@ include file="/common/messages.jsp"%>

- + - +
@@ -44,9 +44,9 @@
-
+ -
+ Index: lams_tool_images/web/pages/learning/parts/commentsarea.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/pages/learning/parts/commentsarea.jsp (.../commentsarea.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/pages/learning/parts/commentsarea.jsp (.../commentsarea.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -33,7 +33,7 @@ - + - - + + Index: lams_tool_images/web/pages/monitoring/summary.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_images/web/pages/monitoring/summary.jsp (.../summary.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_images/web/pages/monitoring/summary.jsp (.../summary.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -99,7 +99,7 @@ - ${image.thumbnailFileUuid}&preferDownload=false + download/?uuid=${image.thumbnailFileUuid}&preferDownload=false ?sessionMapID=${sessionMapID}&imageUid=${image.uid}&toolSessionID=${sessionId}&KeepThis=true&TB_iframe=true&modal=true @@ -218,9 +218,9 @@ - + - + @@ -244,7 +244,7 @@
- Index: lams_tool_lamc/web/authoring/AuthoringTabsHolder.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -r9e395fca5d7eb4a5ac4c9768642a336723a950f7 --- lams_tool_lamc/web/authoring/AuthoringTabsHolder.jsp (.../AuthoringTabsHolder.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_tool_lamc/web/authoring/AuthoringTabsHolder.jsp (.../AuthoringTabsHolder.jsp) (revision 9e395fca5d7eb4a5ac4c9768642a336723a950f7) @@ -20,10 +20,12 @@ }); }); - function submitMethod(actionMethod) { - document.McAuthoringForm.dispatch.value=actionMethod; - document.McAuthoringForm.submit(); + function submitMethod(methodName) { + var f = document.getElementById('mcAuthoringForm'); + f.action = methodName + ".do"; + f.submit(); } + function submitModifyAuthoringQuestion(questionIndexValue, actionMethod) { document.McAuthoringForm.questionIndex.value=questionIndexValue; @@ -74,12 +76,11 @@ - - - + + - + @@ -95,14 +96,14 @@ - - + \ No newline at end of file