Index: lams_tool_preview/.classpath =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/.classpath (.../.classpath) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/.classpath (.../.classpath) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -3,26 +3,27 @@ - + + + + + + - + - + + - + - + - + - - - - - - + Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/BaseDAOHibernate.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewDAOHibernate.java =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewDAOHibernate.java (.../PeerreviewDAOHibernate.java) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewDAOHibernate.java (.../PeerreviewDAOHibernate.java) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -25,6 +25,7 @@ import java.util.List; +import org.lamsfoundation.lams.dao.hibernate.LAMSBaseDAO; import org.lamsfoundation.lams.tool.peerreview.dao.PeerreviewDAO; import org.lamsfoundation.lams.tool.peerreview.model.Peerreview; @@ -34,11 +35,11 @@ * * @version $Revision$ */ -public class PeerreviewDAOHibernate extends BaseDAOHibernate implements PeerreviewDAO{ +public class PeerreviewDAOHibernate extends LAMSBaseDAO implements PeerreviewDAO{ private static final String GET_RESOURCE_BY_CONTENTID = "from "+Peerreview.class.getName()+" as r where r.contentId=?"; public Peerreview getByContentId(Long contentId) { - List list = getHibernateTemplate().find(GET_RESOURCE_BY_CONTENTID,contentId); + List list = find(GET_RESOURCE_BY_CONTENTID,contentId); if(list.size() > 0) return (Peerreview) list.get(0); else @@ -50,7 +51,7 @@ } public void delete(Peerreview peerreview) { - this.getHibernateTemplate().delete(peerreview); + delete(peerreview); } } Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewSessionDAOHibernate.java =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewSessionDAOHibernate.java (.../PeerreviewSessionDAOHibernate.java) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewSessionDAOHibernate.java (.../PeerreviewSessionDAOHibernate.java) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -25,30 +25,31 @@ import java.util.List; +import org.lamsfoundation.lams.dao.hibernate.LAMSBaseDAO; import org.lamsfoundation.lams.tool.peerreview.dao.PeerreviewSessionDAO; import org.lamsfoundation.lams.tool.peerreview.model.PeerreviewSession; -public class PeerreviewSessionDAOHibernate extends BaseDAOHibernate implements PeerreviewSessionDAO{ +public class PeerreviewSessionDAOHibernate extends LAMSBaseDAO implements PeerreviewSessionDAO{ private static final String FIND_BY_SESSION_ID = "from " + PeerreviewSession.class.getName() + " as p where p.sessionId=?"; private static final String FIND_BY_CONTENT_ID = "from " + PeerreviewSession.class.getName() + " as p where p.peerreview.contentId=?"; public PeerreviewSession getSessionBySessionId(Long sessionId) { - List list = getHibernateTemplate().find(FIND_BY_SESSION_ID,sessionId); + List list = find(FIND_BY_SESSION_ID,sessionId); if(list == null || list.size() == 0) return null; return (PeerreviewSession) list.get(0); } public List getByContentId(Long toolContentId) { - return getHibernateTemplate().find(FIND_BY_CONTENT_ID,toolContentId); + return find(FIND_BY_CONTENT_ID,toolContentId); } public void delete(PeerreviewSession session) { - this.getHibernateTemplate().delete(session); + delete(session); } public void deleteBySessionId(Long toolSessionId) { - this.removeObject(PeerreviewSession.class,toolSessionId); + removeObject(PeerreviewSession.class,toolSessionId); } } Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewUserDAOHibernate.java =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewUserDAOHibernate.java (.../PeerreviewUserDAOHibernate.java) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewUserDAOHibernate.java (.../PeerreviewUserDAOHibernate.java) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -25,11 +25,12 @@ import java.util.List; +import org.lamsfoundation.lams.dao.hibernate.LAMSBaseDAO; import org.lamsfoundation.lams.tool.peerreview.PeerreviewConstants; import org.lamsfoundation.lams.tool.peerreview.dao.PeerreviewUserDAO; import org.lamsfoundation.lams.tool.peerreview.model.PeerreviewUser; -public class PeerreviewUserDAOHibernate extends BaseDAOHibernate implements PeerreviewUserDAO { +public class PeerreviewUserDAOHibernate extends LAMSBaseDAO implements PeerreviewUserDAO { private static final String FIND_BY_USER_ID_CONTENT_ID = "FROM " + PeerreviewUser.class.getName() + " AS u WHERE u.userId =? AND u.peerreview.contentId=?"; @@ -51,39 +52,39 @@ @Override public PeerreviewUser getUserByUserIDAndSessionID(Long userID, Long sessionId) { - List list = this.getHibernateTemplate().find(FIND_BY_USER_ID_SESSION_ID, new Object[] { userID, sessionId }); + List list = find(FIND_BY_USER_ID_SESSION_ID, new Object[] { userID, sessionId }); if (list == null || list.size() == 0) return null; return (PeerreviewUser) list.get(0); } @Override public PeerreviewUser getUserByUserIDAndContentID(Long userId, Long contentId) { - List list = this.getHibernateTemplate().find(FIND_BY_USER_ID_CONTENT_ID, new Object[] { userId, contentId }); + List list = find(FIND_BY_USER_ID_CONTENT_ID, new Object[] { userId, contentId }); if (list == null || list.size() == 0) return null; return (PeerreviewUser) list.get(0); } @Override public List getBySessionID(Long sessionId) { - return this.getHibernateTemplate().find(FIND_BY_SESSION_ID, sessionId); + return find(FIND_BY_SESSION_ID, sessionId); } @Override public List getUserIdsBySessionID(Long sessionId) { - return this.getHibernateTemplate().find(GET_USERIDS_BY_SESSION_ID, sessionId); + return find(GET_USERIDS_BY_SESSION_ID, sessionId); } @Override public List getByContentId(Long toolContentId) { - return this.getHibernateTemplate().find(FIND_BY_CONTENT_ID, toolContentId); + return find(FIND_BY_CONTENT_ID, toolContentId); } @Override public int getCountUsersBySession(final Long toolSessionId, final Long excludeUserId) { - List list = getHibernateTemplate().find(GET_COUNT_USERS_FOR_SESSION, + List list = find(GET_COUNT_USERS_FOR_SESSION, new Object[] { toolSessionId, excludeUserId }); if (list == null || list.size() == 0) { return 0; Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/ims/IContentPackageConverter.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/ims/IMSManifestException.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/ims/ImscpApplicationException.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/ims/OrganizationXMLDef.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 9fc998daa072351bbb64ed9d16a1c571c8136b64 refers to a dead (removed) revision in file `lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/ims/SimpleContentPackageConverter.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/peerreviewApplicationContext.xml =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/peerreviewApplicationContext.xml (.../peerreviewApplicationContext.xml) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/peerreviewApplicationContext.xml (.../peerreviewApplicationContext.xml) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -1,10 +1,11 @@ - - - - + + + org.lamsfoundation.lams.tool.peerreview.ApplicationResources @@ -38,16 +39,16 @@ - + - + - + - + @@ -68,13 +69,13 @@ - + - + false @@ -99,3 +100,4 @@ + Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java (.../PeerreviewServiceImpl.java) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java (.../PeerreviewServiceImpl.java) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -76,7 +76,6 @@ import org.lamsfoundation.lams.tool.peerreview.model.PeerreviewUser; import org.lamsfoundation.lams.tool.peerreview.util.PeerreviewToolContentHandler; import org.lamsfoundation.lams.tool.service.ILamsToolService; -import org.lamsfoundation.lams.tool.service.LamsToolService; import org.lamsfoundation.lams.usermanagement.User; import org.lamsfoundation.lams.usermanagement.dto.UserDTO; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; @@ -520,6 +519,23 @@ } @Override + public boolean isReadOnly(Long toolContentId) { + List list = peerreviewSessionDao.getByContentId(toolContentId); + Iterator iter = list.iterator(); + while (iter.hasNext()) { + PeerreviewSession session = (PeerreviewSession) iter.next(); + if ( peerreviewUserDao.getCountUsersBySession(session.getSessionId(), -1L) == 0) { + log.debug("Peer Review isReadOnly called. Returning true. Count of users for session id "+session.getSessionId()+" is "+peerreviewUserDao.getCountUsersBySession(session.getSessionId(), -1L)); + return true; + } else { + log.debug("Peer Review isReadOnly called. Count of users for session id "+session.getSessionId()+" is 0"); + } + } + log.debug("Peer Review isReadOnly called. Returning false."); + return false; + } + + @Override public void removeToolContent(Long toolContentId, boolean removeSessionData) throws SessionDataExistsException, ToolException { Peerreview peerreview = peerreviewDao.getByContentId(toolContentId); Index: lams_tool_preview/web/WEB-INF/tlds/lams/lams.tld =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/web/WEB-INF/tlds/lams/lams.tld (.../lams.tld) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/web/WEB-INF/tlds/lams/lams.tld (.../lams.tld) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -220,7 +220,7 @@ STRUTS-textarea - org.lamsfoundation.lams.web.tag.MultiLinesTextareaTag + org.lamsfoundation.lams.web.tag.MultiLinesTextareaTag empty accesskey Index: lams_tool_preview/web/WEB-INF/web.xml =================================================================== diff -u -ra93929c9c7f7f0df676412691f2f8f9d44d201a2 -r9fc998daa072351bbb64ed9d16a1c571c8136b64 --- lams_tool_preview/web/WEB-INF/web.xml (.../web.xml) (revision a93929c9c7f7f0df676412691f2f8f9d44d201a2) +++ lams_tool_preview/web/WEB-INF/web.xml (.../web.xml) (revision 9fc998daa072351bbb64ed9d16a1c571c8136b64) @@ -1,19 +1,16 @@ - - Peer Review + +Peer Review Peer Review tool javax.servlet.jsp.jstl.fmt.localizationContext org.lamsfoundation.lams.tool.peerreview.ApplicationResources - - - contextClass - org.jboss.spring.factory.VFSXmlWebApplicationContext - contextConfigLocation classpath:/org/lamsfoundation/lams/tool/peerreview/dbupdates/autopatchContext.xml @@ -27,22 +24,10 @@ context.central - - - org.springframework.web.context.ContextLoaderListener - - - - - - org.lamsfoundation.lams.web.session.SetMaxTimeoutListener - - - hibernateFilter - org.springframework.orm.hibernate3.support.OpenSessionInViewFilter + org.lamsfoundation.lams.util.CustomizedOpenSessionInViewFilter sessionFactoryBeanName @@ -80,45 +65,40 @@ /* - + + + org.springframework.web.context.ContextLoaderListener + + - + exportPortfolio org.lamsfoundation.lams.tool.peerreview.web.servlet.ExportServlet - + - - completeItem - org.lamsfoundation.lams.tool.peerreview.web.servlet.CompleteItemServlet - + + action + org.apache.struts.action.ActionServlet + + config + /WEB-INF/struts-config.xml + + + debug + 999 + + + detail + 2 + + + validate + true + + 1 + - - action - org.apache.struts.action.ActionServlet - - config - /WEB-INF/struts-config.xml - - - debug - 999 - - - detail - 1 - - - validate - true - - 2 - - - + Connector net.fckeditor.connector.ConnectorServlet @@ -130,31 +110,31 @@ false 1 - + - + Instructions Download Instructions Download download org.lamsfoundation.lams.contentrepository.client.ToolDownload - - toolContentHandlerBeanName - peerreviewToolContentHandler - - 3 + + toolContentHandlerBeanName + forumToolContentHandler + + 3 - - action - *.do + + action + *.do - + - Connector - /ckeditor/filemanager/browser/default/connectors/jsp/connector + Connector + /ckeditor/filemanager/browser/default/connectors/jsp/connector - + download /download/* @@ -165,74 +145,93 @@ /exportPortfolio - - completeItem - /learning/completeItem - - - - + + 500 + /error.jsp + + + 403 + /403.jsp + + + 404 + /404.jsp + + + + + - + - tags-bean - /WEB-INF/tlds/struts/struts-bean.tld + tags-bean + /WEB-INF/tlds/struts/struts-bean.tld - tags-html - /WEB-INF/tlds/struts/struts-html.tld + tags-html + /WEB-INF/tlds/struts/struts-html.tld - tags-logic - /WEB-INF/tlds/struts/struts-logic.tld + tags-logic + /WEB-INF/tlds/struts/struts-logic.tld - tags-tiles - /WEB-INF/tlds/struts/struts-tiles.tld + tags-tiles + /WEB-INF/tlds/struts/struts-tiles.tld - - tags-bean-el - /WEB-INF/tlds/struts/struts-bean-el.tld + tags-bean-el + /WEB-INF/tlds/struts/struts-bean-el.tld - tags-html-el - /WEB-INF/tlds/struts/struts-html-el.tld + tags-html-el + /WEB-INF/tlds/struts/struts-html-el.tld - tags-logic-el - /WEB-INF/tlds/struts/struts-logic-el.tld + tags-logic-el + /WEB-INF/tlds/struts/struts-logic-el.tld - tags-tiles-el - /WEB-INF/tlds/struts/struts-tiles-el.tld + tags-tiles-el + /WEB-INF/tlds/struts/struts-tiles-el.tld - - - - - tags-fmt - /WEB-INF/tlds/jstl/fmt.tld - - - tags-core - /WEB-INF/tlds/jstl/c.tld - - - tags-function - /WEB-INF/tlds/jstl/fn.tld - - - tags-xml - /WEB-INF/tlds/jstl/x.tld - - - - + + + - tags-lams - /WEB-INF/tlds/lams/lams.tld + tags-fmt + /WEB-INF/tlds/jstl/fmt.tld + + tags-core + /WEB-INF/tlds/jstl/c.tld + + + tags-function + /WEB-INF/tlds/jstl/fn.tld + + + tags-xml + /WEB-INF/tlds/jstl/x.tld + + + + + + tags-permittedTaglibs + /WEB-INF/tlds/jstl/permittedTaglibs.tld + + + tags-scriptfree + /WEB-INF/tlds/jstl/scriptfree.tld + + + + + + tags-lams + /WEB-INF/tlds/lams/lams.tld + @@ -307,27 +306,14 @@ SYSADMIN - - - FORM + + + FORM LAMS - - /login.jsp - /login.jsp?failed=y - - + + /login.jsp + /login.jsp?failed=y + + - - 500 - /error.jsp - - - 403 - /403.jsp - - - 404 - /404.jsp - - - +