Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/monitoringApplicationContext.xml =================================================================== diff -u -rab2e2241e9bfa93bad93f8908850405d124daaa5 -ra09db88ffc7dee8fb92f83481015b0bc06270c19 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/monitoringApplicationContext.xml (.../monitoringApplicationContext.xml) (revision ab2e2241e9bfa93bad93f8908850405d124daaa5) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/monitoringApplicationContext.xml (.../monitoringApplicationContext.xml) (revision a09db88ffc7dee8fb92f83481015b0bc06270c19) @@ -76,6 +76,7 @@ PROPAGATION_REQUIRED PROPAGATION_REQUIRED,readOnly PROPAGATION_REQUIRED + PROPAGATION_REQUIRED Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java =================================================================== diff -u -r3dbf966d900adefc34cdad501d3c392118451cd9 -ra09db88ffc7dee8fb92f83481015b0bc06270c19 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java (.../IMonitoringService.java) (revision 3dbf966d900adefc34cdad501d3c392118451cd9) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java (.../IMonitoringService.java) (revision a09db88ffc7dee8fb92f83481015b0bc06270c19) @@ -235,7 +235,7 @@ * @return new value for learnerPresenceAvailable. Normally will be same as input parameter, will only be different * if the value cannot be updated for some reason. */ - Boolean setPresenceAvailable(long lessonId, Integer userId, Boolean learnerPresenceAvailable); + Boolean togglePresenceAvailable(long lessonId, Integer userId, Boolean learnerPresenceAvailable); /** * Set whether or not the learner IM button is available in monitor. Checks that the user is a staff member of this @@ -247,7 +247,7 @@ * @return new value for learnerPresenceImAvailable. Normally will be same as input parameter, will only be * different if the value cannot be updated for some reason. */ - Boolean setPresenceImAvailable(long lessonId, Integer userId, Boolean learnerPresenceImAvailable); + Boolean togglePresenceImAvailable(long lessonId, Integer userId, Boolean learnerPresenceImAvailable); /** * Set whether or not the live edit is available in monitor. Checks that the user is a staff member of this lesson @@ -259,7 +259,7 @@ * @return new value for liveEditEnabled. Normally will be same as input parameter, will only be different if the * value cannot be updated for some reason. */ - Boolean setLiveEditEnabled(long lessonId, Integer userId, Boolean liveEditEnabled); + Boolean toggleLiveEditEnabled(long lessonId, Integer userId, Boolean liveEditEnabled); String forceCompleteActivitiesByUser(Integer learnerId, Integer requesterId, long lessonId, Long activityId, boolean removeLearnerContent); Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java =================================================================== diff -u -r3dbf966d900adefc34cdad501d3c392118451cd9 -ra09db88ffc7dee8fb92f83481015b0bc06270c19 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision 3dbf966d900adefc34cdad501d3c392118451cd9) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java (.../MonitoringService.java) (revision a09db88ffc7dee8fb92f83481015b0bc06270c19) @@ -926,7 +926,7 @@ } @Override - public Boolean setPresenceAvailable(long lessonId, Integer userId, Boolean presenceAvailable) { + public Boolean togglePresenceAvailable(long lessonId, Integer userId, Boolean presenceAvailable) { securityService.isLessonMonitor(lessonId, userId, "set presence available", true); Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); requestedLesson.setLearnerPresenceAvailable(presenceAvailable != null ? presenceAvailable : Boolean.FALSE); @@ -935,7 +935,7 @@ } @Override - public Boolean setPresenceImAvailable(long lessonId, Integer userId, Boolean presenceImAvailable) { + public Boolean togglePresenceImAvailable(long lessonId, Integer userId, Boolean presenceImAvailable) { securityService.isLessonMonitor(lessonId, userId, "set presence instant messaging available", true); Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); requestedLesson.setLearnerImAvailable(presenceImAvailable != null ? presenceImAvailable : Boolean.FALSE); @@ -944,7 +944,7 @@ } @Override - public Boolean setLiveEditEnabled(long lessonId, Integer userId, Boolean liveEditEnabled) { + public Boolean toggleLiveEditEnabled(long lessonId, Integer userId, Boolean liveEditEnabled) { securityService.isLessonMonitor(lessonId, userId, "set live edit available", true); Lesson requestedLesson = lessonDAO.getLesson(new Long(lessonId)); requestedLesson.setLiveEditEnabled(liveEditEnabled != null ? liveEditEnabled : Boolean.FALSE); Index: lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java =================================================================== diff -u -r3dbf966d900adefc34cdad501d3c392118451cd9 -ra09db88ffc7dee8fb92f83481015b0bc06270c19 --- lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java (.../MonitoringAction.java) (revision 3dbf966d900adefc34cdad501d3c392118451cd9) +++ lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java (.../MonitoringAction.java) (revision a09db88ffc7dee8fb92f83481015b0bc06270c19) @@ -1465,10 +1465,10 @@ Boolean presenceAvailable = WebUtil.readBooleanParam(request, "presenceAvailable", false); try { - getMonitoringService().setPresenceAvailable(lessonID, userID, presenceAvailable); + getMonitoringService().togglePresenceAvailable(lessonID, userID, presenceAvailable); if (!presenceAvailable) { - getMonitoringService().setPresenceImAvailable(lessonID, userID, false); + getMonitoringService().togglePresenceImAvailable(lessonID, userID, false); } } catch (SecurityException e) { response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the lesson"); @@ -1487,7 +1487,7 @@ Boolean presenceImAvailable = WebUtil.readBooleanParam(request, "presenceImAvailable", false); try { - getMonitoringService().setPresenceImAvailable(lessonID, userID, presenceImAvailable); + getMonitoringService().togglePresenceImAvailable(lessonID, userID, presenceImAvailable); } catch (SecurityException e) { response.sendError(HttpServletResponse.SC_FORBIDDEN, "User is not a monitor in the lesson"); }