Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListServiceImpl.java =================================================================== diff -u -r1ce66fc771667c2fb1ea8111008f4b03468f6771 -ra3077b21311eada2fc8f2a67ce86e3326e0e367a --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListServiceImpl.java (.../TaskListServiceImpl.java) (revision 1ce66fc771667c2fb1ea8111008f4b03468f6771) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/service/TaskListServiceImpl.java (.../TaskListServiceImpl.java) (revision a3077b21311eada2fc8f2a67ce86e3326e0e367a) @@ -454,46 +454,6 @@ return summaryList; } - /** - * @param contentId - * @param sessionId sessionId which defines Group - * @return - */ - public List getItemListForGroup(Long contentId, Long sessionId) { - - //create the list containing all taskListItems - TaskList taskList = taskListDao.getByContentId(contentId); - ArrayList itemList = new ArrayList(); - itemList.addAll(taskList.getTaskListItems()); - - List sessionList = taskListSessionDao.getByContentId(contentId); - for(TaskListSession session:sessionList) { - Set newItems = session.getTaskListItems(); - for(TaskListItem item : newItems) { - if (!itemList.contains(item)) itemList.add(item); - } - } - - List userList = taskListUserDao.getBySessionID(sessionId); - - ArrayList groupItemList = new ArrayList(); - for (TaskListItem item:itemList) { - - if (item.isCreateByAuthor()) { - groupItemList.add(item); - } else { - for (TaskListUser user:userList) { - if (user.getUserId().equals(item.getCreateBy().getUserId())) { - groupItemList.add(item); - break; - } - } - } - } - - return groupItemList; - } - /** * {@inheritDoc} */ @@ -1104,6 +1064,48 @@ return contentId; } + /** + * Returns list of tasks from authoring + the tasks added by members of that group. + * + * @param contentId + * @param sessionId sessionId which defines Group + * @return + */ + private List getItemListForGroup(Long contentId, Long sessionId) { + + //create the list containing all taskListItems + TaskList taskList = taskListDao.getByContentId(contentId); + ArrayList itemList = new ArrayList(); + itemList.addAll(taskList.getTaskListItems()); + + List sessionList = taskListSessionDao.getByContentId(contentId); + for(TaskListSession session:sessionList) { + Set newItems = session.getTaskListItems(); + for(TaskListItem item : newItems) { + if (!itemList.contains(item)) itemList.add(item); + } + } + + List userList = taskListUserDao.getBySessionID(sessionId); + + ArrayList groupItemList = new ArrayList(); + for (TaskListItem item:itemList) { + + if (item.isCreateByAuthor()) { + groupItemList.add(item); + } else { + for (TaskListUser user:userList) { + if (user.getUserId().equals(item.getCreateBy().getUserId())) { + groupItemList.add(item); + break; + } + } + } + } + + return groupItemList; + } + /** * Process an uploaded file. * Index: lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/LearningAction.java =================================================================== diff -u -rac170eba5ee70135e473b3a5525d1743d0098bc8 -ra3077b21311eada2fc8f2a67ce86e3326e0e367a --- lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/LearningAction.java (.../LearningAction.java) (revision ac170eba5ee70135e473b3a5525d1743d0098bc8) +++ lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/LearningAction.java (.../LearningAction.java) (revision a3077b21311eada2fc8f2a67ce86e3326e0e367a) @@ -26,6 +26,7 @@ import java.io.IOException; import java.sql.Timestamp; +import java.util.ArrayList; import java.util.Comparator; import java.util.Date; import java.util.HashSet; @@ -65,6 +66,8 @@ import org.lamsfoundation.lams.tool.taskList.service.ITaskListService; import org.lamsfoundation.lams.tool.taskList.service.TaskListException; import org.lamsfoundation.lams.tool.taskList.service.UploadTaskListFileException; +import org.lamsfoundation.lams.tool.taskList.util.TaskListItemAttachmentComparator; +import org.lamsfoundation.lams.tool.taskList.util.TaskListItemCommentComparator; import org.lamsfoundation.lams.tool.taskList.util.TaskListItemComparator; import org.lamsfoundation.lams.tool.taskList.web.form.ReflectionForm; import org.lamsfoundation.lams.tool.taskList.web.form.TaskListItemForm; @@ -257,8 +260,8 @@ isPreviousTaskCompleted = item.isComplete(); //filter out comments and attachments which belong to another group - Set filteredComments = new HashSet(); - Set filteredAttachments = new HashSet(); + Set filteredComments = new TreeSet(new TaskListItemCommentComparator()); + Set filteredAttachments = new TreeSet(new TaskListItemAttachmentComparator()); if (mode.isLearner()) { List grouppedUsers = service.getUserListBySessionId(sessionId); Index: lams_tool_task/web/pages/learning/learning.jsp =================================================================== diff -u -r2cefe12c8a8c520572f32ccbb784acf55b76a6fd -ra3077b21311eada2fc8f2a67ce86e3326e0e367a --- lams_tool_task/web/pages/learning/learning.jsp (.../learning.jsp) (revision 2cefe12c8a8c520572f32ccbb784acf55b76a6fd) +++ lams_tool_task/web/pages/learning/learning.jsp (.../learning.jsp) (revision a3077b21311eada2fc8f2a67ce86e3326e0e367a) @@ -189,7 +189,7 @@
- + Index: lams_tool_task/web/pages/learning/parts/itemdetails.jsp =================================================================== diff -u -r2cefe12c8a8c520572f32ccbb784acf55b76a6fd -ra3077b21311eada2fc8f2a67ce86e3326e0e367a --- lams_tool_task/web/pages/learning/parts/itemdetails.jsp (.../itemdetails.jsp) (revision 2cefe12c8a8c520572f32ccbb784acf55b76a6fd) +++ lams_tool_task/web/pages/learning/parts/itemdetails.jsp (.../itemdetails.jsp) (revision a3077b21311eada2fc8f2a67ce86e3326e0e367a) @@ -42,7 +42,8 @@
- + +