Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/UserSearchAction.java =================================================================== diff -u -r85cc9e91bd65285a42ea0afbb8019f91fe3ceb85 -rab4fe409a7512816b4b7dd8c880f760deded927d --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/UserSearchAction.java (.../UserSearchAction.java) (revision 85cc9e91bd65285a42ea0afbb8019f91fe3ceb85) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/UserSearchAction.java (.../UserSearchAction.java) (revision ab4fe409a7512816b4b7dd8c880f760deded927d) @@ -91,24 +91,24 @@ String firstName = ((String)userSearchForm.get("firstName")).trim(); String lastName = ((String)userSearchForm.get("lastName")).trim(); - log.debug("got userId: "+userId); - log.debug("got login: "+login); - log.debug("got firstName: "+firstName); - log.debug("got lastName: "+lastName); + log.debug("got userId: '"+userId+"'"); + log.debug("got login: '"+login+"'"); + log.debug("got firstName: '"+firstName+"'"); + log.debug("got lastName: '"+lastName+"'"); List userList = new ArrayList(); - if(userId=="") { + if(userId.length()==0) { Map stringProperties = new HashMap(); - if(login!="") stringProperties.put("login","%"+login+"%"); - if(firstName!="") stringProperties.put("firstName","%"+firstName+"%"); - if(lastName!="") stringProperties.put("lastName","%"+lastName+"%"); + if(login.length()>0) stringProperties.put("login","%"+login+"%"); + if(firstName.length()>0) stringProperties.put("firstName","%"+firstName+"%"); + if(lastName.length()>0) stringProperties.put("lastName","%"+lastName+"%"); if(!stringProperties.isEmpty()) userList = getService().searchByStringProperties(User.class,stringProperties); }else{ Map objectProperties = new HashMap(); objectProperties.put("userId",userId); - if(login!="") objectProperties.put("login",login); - if(firstName!="") objectProperties.put("firstName",firstName); - if(lastName!="") objectProperties.put("lastName",lastName); + if(login.length()>0) objectProperties.put("login",login); + if(firstName.length()>0) objectProperties.put("firstName",firstName); + if(lastName.length()>0) objectProperties.put("lastName",lastName); if(!objectProperties.isEmpty()) userList = getService().findByProperties(User.class,objectProperties); }