GROUPING_SUPPORT_REQUIRED,
* then the activity is validated to ensure that the grouping exists.
@@ -315,55 +327,49 @@
*
* @param activity
*/
- private void checkIfGroupingRequired(Activity activity)
- {
-
- Integer groupingSupportType = activity.getGroupingSupportType();
- if (groupingSupportType.intValue() == Grouping.GROUPING_SUPPORT_REQUIRED)
- {
- //make sure activity has been assigned a grouping
- Grouping grouping = activity.getGrouping();
- if (grouping == null)
- {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_REQUIRED_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.GROUPING_REQUIRED_ERROR_KEY), activity.getActivityUIID()));
- }
+ private void checkIfGroupingRequired(Activity activity) {
+
+ Integer groupingSupportType = activity.getGroupingSupportType();
+ if (groupingSupportType.intValue() == Grouping.GROUPING_SUPPORT_REQUIRED) {
+ //make sure activity has been assigned a grouping
+ Grouping grouping = activity.getGrouping();
+ if (grouping == null) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_REQUIRED_ERROR_CODE, messageService
+ .getMessage(ValidationErrorDTO.GROUPING_REQUIRED_ERROR_KEY), activity.getActivityUIID()));
}
- else if(groupingSupportType.intValue() == Grouping.GROUPING_SUPPORT_NONE)
- {
- Grouping grouping = activity.getGrouping();
- if (grouping != null)
- {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_NOT_REQUIRED_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.GROUPING_NOT_REQUIRED_ERROR_KEY), activity.getActivityUIID()));
- }
+ }
+ else if (groupingSupportType.intValue() == Grouping.GROUPING_SUPPORT_NONE) {
+ Grouping grouping = activity.getGrouping();
+ if (grouping != null) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_NOT_REQUIRED_ERROR_CODE, messageService
+ .getMessage(ValidationErrorDTO.GROUPING_NOT_REQUIRED_ERROR_KEY), activity.getActivityUIID()));
}
-
+ }
+
}
-
+
/**
* If this activity is an OptionalActivity, then it must contain one or more
* activities.
*
* @param parentActivity
*/
- private void validateOptionalActivity(Activity parentActivity)
- {
-
- if (parentActivity.isOptionsActivity())
- {
- //get the child activities and check how many there are.
- OptionsActivity optionsActivity = (OptionsActivity)parentActivity;
- Set childActivities = optionsActivity.getActivities();
- int numOfChildActivities = childActivities.size();
- if(numOfChildActivities == 0)
- {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.OPTIONAL_ACTIVITY_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.OPTIONAL_ACTIVITY_ERROR_KEY), optionsActivity.getActivityUIID()));
- }
-
-
+ private void validateOptionalActivity(Activity parentActivity) {
+
+ if (parentActivity.isOptionsActivity()) {
+ //get the child activities and check how many there are.
+ OptionsActivity optionsActivity = (OptionsActivity) parentActivity;
+ Set childActivities = optionsActivity.getActivities();
+ int numOfChildActivities = childActivities.size();
+ if (numOfChildActivities == 0) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.OPTIONAL_ACTIVITY_ERROR_CODE, messageService
+ .getMessage(ValidationErrorDTO.OPTIONAL_ACTIVITY_ERROR_KEY), optionsActivity.getActivityUIID()));
}
-
+
+ }
+
}
-
+
/**
* If this activity is an GroupingActivity, the number of groups in the grouping records is greater than 0 and
* the grouping has some groups, then the actual number of groups must no exceed the desired number of groups.
@@ -372,30 +378,33 @@
*
* @param parentActivity
*/
- private void validateGroupingActivity(Activity activity)
- {
-
- if (activity.isGroupingActivity())
- {
- //get the child activities and check how many there are.
- GroupingActivity groupingActivity = (GroupingActivity)activity;
- Grouping grouping = groupingActivity.getCreateGrouping();
- if ( grouping == null ) {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_ACTIVITY_MISSING_GROUPING_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.GROUPING_ACTIVITY_MISSING_GROUPING_KEY), activity.getActivityUIID()));
- }
- Integer numGroupsInteger = null;
- if ( grouping.isRandomGrouping() ) {
- RandomGrouping random = (RandomGrouping) grouping;
- numGroupsInteger = random.getNumberOfGroups();
- } else {
- numGroupsInteger = grouping.getMaxNumberOfGroups();
- }
- int maxNumGroups = numGroupsInteger == null ? 0 : numGroupsInteger.intValue();
- if ( maxNumGroups > 0 && grouping.getGroups() != null && grouping.getGroups().size() > maxNumGroups) {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_ACTIVITY_GROUP_COUNT_MISMATCH_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.GROUPING_ACTIVITY_GROUP_COUNT_MISMATCH_KEY), activity.getActivityUIID()));
- }
+ private void validateGroupingActivity(Activity activity) {
+
+ if (activity.isGroupingActivity()) {
+ //get the child activities and check how many there are.
+ GroupingActivity groupingActivity = (GroupingActivity) activity;
+ Grouping grouping = groupingActivity.getCreateGrouping();
+ if (grouping == null) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_ACTIVITY_MISSING_GROUPING_ERROR_CODE,
+ messageService.getMessage(ValidationErrorDTO.GROUPING_ACTIVITY_MISSING_GROUPING_KEY), activity
+ .getActivityUIID()));
}
-
+ Integer numGroupsInteger = null;
+ if (grouping.isRandomGrouping()) {
+ RandomGrouping random = (RandomGrouping) grouping;
+ numGroupsInteger = random.getNumberOfGroups();
+ }
+ else {
+ numGroupsInteger = grouping.getMaxNumberOfGroups();
+ }
+ int maxNumGroups = numGroupsInteger == null ? 0 : numGroupsInteger.intValue();
+ if (maxNumGroups > 0 && grouping.getGroups() != null && grouping.getGroups().size() > maxNumGroups) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_ACTIVITY_GROUP_COUNT_MISMATCH_ERROR_CODE,
+ messageService.getMessage(ValidationErrorDTO.GROUPING_ACTIVITY_GROUP_COUNT_MISMATCH_KEY), activity
+ .getActivityUIID()));
+ }
+ }
+
}
/**
@@ -406,59 +415,57 @@
* The currentActivityId should be 1 greater than the previous activity order id.
* @param parentActivity
*/
- private void validateOptionsActivityOrderId(Activity parentActivity)
- {
+ private void validateOptionsActivityOrderId(Activity parentActivity) {
Integer thisActivityOrderId = null;
Integer previousActivityOrderId = null;
boolean validOrderId = true;
- if(parentActivity.isOptionsActivity())
- {
- OptionsActivity optionsActivity = (OptionsActivity)parentActivity;
+ if (parentActivity.isOptionsActivity()) {
+ OptionsActivity optionsActivity = (OptionsActivity) parentActivity;
Set childActivities = optionsActivity.getActivities(); //childActivities should be sorted according to order id (using the activityOrderComparator)
Iterator i = childActivities.iterator();
- while (i.hasNext() && validOrderId)
- {
- Activity childActivity = (Activity)i.next();
- thisActivityOrderId= childActivity.getOrderId();
- if (previousActivityOrderId != null)
- {
+ while (i.hasNext() && validOrderId) {
+ Activity childActivity = (Activity) i.next();
+ thisActivityOrderId = childActivity.getOrderId();
+ if (previousActivityOrderId != null) {
//compare the two numbers
- if (thisActivityOrderId==null ) {
+ if (thisActivityOrderId == null) {
validOrderId = false;
- } else if ( thisActivityOrderId.longValue() != (previousActivityOrderId.longValue() + 1)) {
+ }
+ else if (thisActivityOrderId.longValue() != previousActivityOrderId.longValue() + 1) {
validOrderId = false;
}
-
+
}
- else
- {
+ else {
//this is the first activity, since the previousActivityId is null
- if(thisActivityOrderId==null || thisActivityOrderId.longValue()!= 1)
+ if (thisActivityOrderId == null || thisActivityOrderId.longValue() != 1) {
validOrderId = false;
+ }
}
- previousActivityOrderId = thisActivityOrderId;
+ previousActivityOrderId = thisActivityOrderId;
}
-
- if (!validOrderId)
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.OPTIONAL_ACTIVITY_ORDER_ID_INVALID_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.OPTIONAL_ACTIVITY_ORDER_ID_INVALID_ERROR_KEY), optionsActivity.getActivityUIID()));
-
- }
+
+ if (!validOrderId) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.OPTIONAL_ACTIVITY_ORDER_ID_INVALID_ERROR_CODE,
+ messageService.getMessage(ValidationErrorDTO.OPTIONAL_ACTIVITY_ORDER_ID_INVALID_ERROR_KEY),
+ optionsActivity.getActivityUIID()));
+ }
+
+ }
}
-
/**
* If applyGrouping is set, then the grouping must exist
* @param activity
*/
- private void validateGroupingIfGroupingIsApplied(Activity activity)
- {
- if(activity.getApplyGrouping().booleanValue()) //if grouping is applied, ensure grouping exists
- {
- if (activity.getGrouping() == null)
- {
- errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_SELECTED_ERROR_CODE, messageService.getMessage(ValidationErrorDTO.GROUPING_SELECTED_ERROR_KEY), activity.getActivityUIID()));
- }
+ private void validateGroupingIfGroupingIsApplied(Activity activity) {
+ if (activity.getApplyGrouping().booleanValue()) //if grouping is applied, ensure grouping exists
+ {
+ if (activity.getGrouping() == null) {
+ errors.add(new ValidationErrorDTO(ValidationErrorDTO.GROUPING_SELECTED_ERROR_CODE, messageService
+ .getMessage(ValidationErrorDTO.GROUPING_SELECTED_ERROR_KEY), activity.getActivityUIID()));
}
-
+ }
+
}
}
Index: lams_common/src/java/org/lamsfoundation/lams/lesson/service/ILessonService.java
===================================================================
diff -u -r6008e13a4cc3e08a3350be02c35a22eb6ee5a9c1 -rc209be8131f22f6fe37bd8d6c14b56425a78b766
--- lams_common/src/java/org/lamsfoundation/lams/lesson/service/ILessonService.java (.../ILessonService.java) (revision 6008e13a4cc3e08a3350be02c35a22eb6ee5a9c1)
+++ lams_common/src/java/org/lamsfoundation/lams/lesson/service/ILessonService.java (.../ILessonService.java) (revision c209be8131f22f6fe37bd8d6c14b56425a78b766)
@@ -70,7 +70,7 @@
* Get the count of all the learners who have started the lesson. They may not be currently online.
*/
public Integer getCountActiveLessonLearners(Long lessonId);
-
+
/** Get the lesson details for the LAMS client. Suitable for the monitoring client.
* Contains a count of the total number of learners in the lesson and the number of active learners.
* This is a pretty intensive call as it counts all the learners in the
@@ -94,145 +94,153 @@
public abstract LessonDTO getLessonData(Long lessonId);
/**
- * If the supplied learner is not already in a group, then perform grouping for
- * the learners who have started the lesson, based on the grouping activity.
- * Currently used for random grouping.
- * This method should be used when we do have an grouping activity and learner that is
- * already part of the Hibernate session. (e.g. from the ForceComplete)
- *
- * @param lessonId lesson id (mandatory)
- * @param groupingActivity the activity that has create grouping. (mandatory)
- * @param learner the learner to be check before grouping. (mandatory)
- */
- public void performGrouping(Long lessonId, GroupingActivity groupingActivity, User learner) throws LessonServiceException;
+ * If the supplied learner is not already in a group, then perform grouping for
+ * the learners who have started the lesson, based on the grouping activity.
+ * Currently used for random grouping.
+ * This method should be used when we do have an grouping activity and learner that is
+ * already part of the Hibernate session. (e.g. from the ForceComplete)
+ *
+ * @param lessonId lesson id (mandatory)
+ * @param groupingActivity the activity that has create grouping. (mandatory)
+ * @param learner the learner to be check before grouping. (mandatory)
+ */
+ public void performGrouping(Long lessonId, GroupingActivity groupingActivity, User learner) throws LessonServiceException;
/**
- * Perform the grouping, setting the given list of learners as one group.
- * @param groupingActivity the activity that has create grouping. (mandatory)
- * @param groupName (optional)
- * @param learners to form one group (mandatory)
- */
- public void performGrouping(GroupingActivity groupingActivity, String groupName, List learners) throws LessonServiceException;
-
+ * Perform the grouping, setting the given list of learners as one group.
+ * @param groupingActivity the activity that has create grouping. (mandatory)
+ * @param groupName (optional)
+ * @param learners to form one group (mandatory)
+ */
+ public void performGrouping(GroupingActivity groupingActivity, String groupName, List learners) throws LessonServiceException;
+
/**
- * Perform the grouping, setting the given list of learners as one group. Used in suitations
- * where there is a grouping but no grouping activity (e.g. in branching).
- * @param grouping the object on which to perform the grouing. (mandatory)
- * @param groupName (optional)
- * @param learners to form one group (mandatory)
- */
- public void performGrouping(Grouping grouping, String groupName, List learners) throws LessonServiceException;
+ * Perform the grouping, setting the given list of learners as one group. Used in suitations
+ * where there is a grouping but no grouping activity (e.g. in branching).
+ * @param grouping the object on which to perform the grouing. (mandatory)
+ * @param groupName (optional)
+ * @param learners to form one group (mandatory)
+ */
+ public void performGrouping(Grouping grouping, String groupName, List learners) throws LessonServiceException;
- /**
- * Perform grouping for all the learners who have started the lesson, based on the grouping.
- * Currently used for chosen grouping and branching
- * @param lessonId lesson id (mandatory)
- * @param groupId group id (mandatory)
- * @param grouping the object on which to perform the grouing. (mandatory)
- */
- public void performGrouping(Grouping grouping, Long groupId, List learners) throws LessonServiceException;
+ /**
+ * Perform grouping for all the learners who have started the lesson, based on the grouping.
+ * Currently used for chosen grouping and branching
+ * @param lessonId lesson id (mandatory)
+ * @param groupId group id (mandatory)
+ * @param grouping the object on which to perform the grouing. (mandatory)
+ */
+ public void performGrouping(Grouping grouping, Long groupId, List learners) throws LessonServiceException;
- /**
- * Remove learners from the given group.
- * @param grouping the grouping from which to remove the learners (mandatory)
- * @param groupName if not null only remove user from this group, if null remove learner from any group.
- * @param learners the learners to be removed (mandatory)
- */
- public void removeLearnersFromGroup(Grouping grouping, Long groupId, Listnull if the requirement for equal number of learners in groups was not set
+ */
+ public Integer calculateMaxNumberOfLearnersPerGroup(Long lessonId, Long groupingId);
+
+ /**
+ * Check up the gate status to go through the gate. This also updates the gate.
+ * This method should be used when we do not have an grouping activity
+ * that is already part of the Hibernate session.
+ * @param gateid the gate that current learner is facing. It could be
+ * synch gate, schedule gate or permission gate.
+ * @param knocker the learner who wants to go through the gate.
+ * @param forceGate if forceGate==true and the lesson is a preview lesson then the gate is opened straight away.
+ * @return Updated gate details
+ */
+ public GateActivityDTO knockGate(Long gateActivityId, User knocker, boolean forceGate);
+
+ /**
+ * Check up the gate status to go through the gate. This also updates the gate.
+ * This method should be used when we do have an grouping activity
+ * that is already part of the Hibernate session.
+ * @param gate the gate that current learner is facing. It could be
+ * synch gate, schedule gate or permission gate.
+ * Don't supply the actual gate from the cached web version
+ * as it might be out of date or not attached to the session
+ * @param knocker the learner who wants to go through the gate.
+ * @param forceGate if forceGate==true and the lesson is a preview lesson then the gate is opened straight away.
+ * @return Updated gate details
+ */
+ public GateActivityDTO knockGate(GateActivity gateActivity, User knocker, boolean forceGate);
+
+ /**
* Get all the learners who may come through this gate.
* For a Group Based branch and the Teacher Grouped branch, it is the group of users in
* the Branch's group, but only the learners who have started the lesson.
* Otherwise we just get all learners who have started the lesson.
* @param gate activity
* @return List of User
*/
- public List getLearnersForGate(GateActivity gate);
-
- /**
- * Get the learner url for a particular activity.
- *
- * @param learnerId
- * @param activityId
- */
- public String getLearnerActivityURL(Integer learnerId, Long activityId);
-
- /**
- * Get the lesson for this activity. If the activity is not part of a lesson (ie is from an authoring
- * design then it will return null.
- */
- public Lesson getLessonByActivity(Activity activity);
+ public List getLearnersForGate(GateActivity gate);
- /**
- *
- * @param learnerId the learner who triggers the move
- * @param lessonId lesson id
- * @param fromActivity Activity moving from
- * @param toActivity Activity moving to (being run)
- * @return updated Learner Progress
- */
- public LearnerProgress moveToActivity(Integer learnerId, Long lessonId, Activity fromActivity, Activity toActivity);
-
- /**
- * Work out which branch to which a user should go. If the current lesson is a preview lesson, it will force
- * the user to a branch if at all possible.
- *
- * @param lesson current lesson.
- * @param BranchingActivity the branching activity
- * @param learnerId the learner who triggers the grouping.
- * @throws LearnerServiceException
- */
- public SequenceActivity determineBranch(Lesson lesson, BranchingActivity branchingActivity, Integer learnerId) throws LearnerServiceException;
+ /**
+ * Get the learner url for a particular activity.
+ *
+ * @param learnerId
+ * @param activityId
+ */
+ public String getLearnerActivityURL(Integer learnerId, Long activityId);
- /**
- * Select a particular branch - we are in preview mode and the author has selected a particular activity.
- * @param lesson current lesson.
- * @param BranchingActivity the branching activity
- * @param learnerId the learner who triggers the grouping.
- * @return branchId of the desired branch
- * @throws LearnerServiceException
- */
- public SequenceActivity selectBranch(Lesson lesson, BranchingActivity branchingActivity, Integer learnerId, Long branchId) throws LearnerServiceException;
+ /**
+ * Get the lesson for this activity. If the activity is not part of a lesson (ie is from an authoring
+ * design then it will return null.
+ */
+ public Lesson getLessonByActivity(Activity activity);
+
+ /**
+ *
+ * @param learnerId the learner who triggers the move
+ * @param lessonId lesson id
+ * @param fromActivity Activity moving from
+ * @param toActivity Activity moving to (being run)
+ * @return updated Learner Progress
+ */
+ public LearnerProgress moveToActivity(Integer learnerId, Long lessonId, Activity fromActivity, Activity toActivity);
+
+ /**
+ * Work out which branch to which a user should go. If the current lesson is a preview lesson, it will force
+ * the user to a branch if at all possible.
+ *
+ * @param lesson current lesson.
+ * @param BranchingActivity the branching activity
+ * @param learnerId the learner who triggers the grouping.
+ * @throws LearnerServiceException
+ */
+ public SequenceActivity determineBranch(Lesson lesson, BranchingActivity branchingActivity, Integer learnerId)
+ throws LearnerServiceException;
+
+ /**
+ * Select a particular branch - we are in preview mode and the author has selected a particular activity.
+ * @param lesson current lesson.
+ * @param BranchingActivity the branching activity
+ * @param learnerId the learner who triggers the grouping.
+ * @return branchId of the desired branch
+ * @throws LearnerServiceException
+ */
+ public SequenceActivity selectBranch(Lesson lesson, BranchingActivity branchingActivity, Integer learnerId, Long branchId)
+ throws LearnerServiceException;
}
Index: lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
===================================================================
diff -u -r8bc8d173f84ddf9333719585a3ddfd7a676f28be -rc209be8131f22f6fe37bd8d6c14b56425a78b766
--- lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java (.../LearnerService.java) (revision 8bc8d173f84ddf9333719585a3ddfd7a676f28be)
+++ lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java (.../LearnerService.java) (revision c209be8131f22f6fe37bd8d6c14b56425a78b766)
@@ -21,7 +21,7 @@
* ****************************************************************
*/
-/* $$Id$$ */
+/* $$Id$$ */
package org.lamsfoundation.lams.learning.service;
import java.sql.Timestamp;
@@ -49,6 +49,8 @@
import org.lamsfoundation.lams.learningdesign.Group;
import org.lamsfoundation.lams.learningdesign.Grouping;
import org.lamsfoundation.lams.learningdesign.GroupingActivity;
+import org.lamsfoundation.lams.learningdesign.LearnerChoiceGrouper;
+import org.lamsfoundation.lams.learningdesign.LearnerChoiceGrouping;
import org.lamsfoundation.lams.learningdesign.SequenceActivity;
import org.lamsfoundation.lams.learningdesign.ToolActivity;
import org.lamsfoundation.lams.learningdesign.ToolBranchingActivity;
@@ -71,612 +73,647 @@
import org.lamsfoundation.lams.usermanagement.User;
import org.lamsfoundation.lams.usermanagement.service.IUserManagementService;
import org.lamsfoundation.lams.util.MessageService;
+
/**
* This class is a facade over the Learning middle tier.
* @author chris, Jacky Fang
*/
-public class LearnerService implements ICoreLearnerService
-{
- //---------------------------------------------------------------------
- // Instance variables
- //---------------------------------------------------------------------
+public class LearnerService implements ICoreLearnerService {
+ //---------------------------------------------------------------------
+ // Instance variables
+ //---------------------------------------------------------------------
private static Logger log = Logger.getLogger(LearnerService.class);
-
- private ILearnerProgressDAO learnerProgressDAO;
- private ILessonDAO lessonDAO;
- private IActivityDAO activityDAO;
- private IGroupingDAO groupingDAO;
- private ProgressEngine progressEngine;
- private IToolSessionDAO toolSessionDAO;
- private ILamsCoreToolService lamsCoreToolService;
- private ActivityMapping activityMapping;
- private IUserManagementService userManagementService;
- private ILessonService lessonService;
- protected MessageService messageService;
-
- //---------------------------------------------------------------------
- // Inversion of Control Methods - Constructor injection
- //---------------------------------------------------------------------
-
- /** Creates a new instance of LearnerService*/
- public LearnerService(ProgressEngine progressEngine) {
- this.progressEngine = progressEngine;
- }
+ private ILearnerProgressDAO learnerProgressDAO;
+ private ILessonDAO lessonDAO;
+ private IActivityDAO activityDAO;
+ private IGroupingDAO groupingDAO;
+ private ProgressEngine progressEngine;
+ private IToolSessionDAO toolSessionDAO;
+ private ILamsCoreToolService lamsCoreToolService;
+ private ActivityMapping activityMapping;
+ private IUserManagementService userManagementService;
+ private ILessonService lessonService;
+ protected MessageService messageService;
- /** Creates a new instance of LearnerService. To be used by Spring, assuming the Spring
- * will set up the progress engine via method injection. If you are creating the bean manually
- * then use the other constructor. */
- public LearnerService() {
- }
+ //---------------------------------------------------------------------
+ // Inversion of Control Methods - Constructor injection
+ //---------------------------------------------------------------------
- //---------------------------------------------------------------------
- // Inversion of Control Methods - Method injection
- //---------------------------------------------------------------------
+ /** Creates a new instance of LearnerService*/
+ public LearnerService(ProgressEngine progressEngine) {
+ this.progressEngine = progressEngine;
+ }
+
+ /** Creates a new instance of LearnerService. To be used by Spring, assuming the Spring
+ * will set up the progress engine via method injection. If you are creating the bean manually
+ * then use the other constructor. */
+ public LearnerService() {
+ }
+
+ //---------------------------------------------------------------------
+ // Inversion of Control Methods - Method injection
+ //---------------------------------------------------------------------
/**
* Set i18n MessageService
*/
public void setMessageService(MessageService messageService) {
this.messageService = messageService;
}
- public MessageService getMessageService() {
+ public MessageService getMessageService() {
return messageService;
}
+
/**
- * @param toolSessionDAO The toolSessionDAO to set.
- */
- public void setToolSessionDAO(IToolSessionDAO toolSessionDAO)
- {
- this.toolSessionDAO = toolSessionDAO;
- }
-
- /**
- * @param lessonDAO The lessonDAO to set.
- */
- public void setLessonDAO(ILessonDAO lessonDAO)
- {
+ * @param toolSessionDAO The toolSessionDAO to set.
+ */
+ public void setToolSessionDAO(IToolSessionDAO toolSessionDAO) {
+ this.toolSessionDAO = toolSessionDAO;
+ }
+
+ /**
+ * @param lessonDAO The lessonDAO to set.
+ */
+ public void setLessonDAO(ILessonDAO lessonDAO) {
this.lessonDAO = lessonDAO;
}
- /**
- * @param learnerProgressDAO The learnerProgressDAO to set.
- */
- public void setLearnerProgressDAO(ILearnerProgressDAO learnerProgressDAO)
- {
- this.learnerProgressDAO = learnerProgressDAO;
- }
+ /**
+ * @param learnerProgressDAO The learnerProgressDAO to set.
+ */
+ public void setLearnerProgressDAO(ILearnerProgressDAO learnerProgressDAO) {
+ this.learnerProgressDAO = learnerProgressDAO;
+ }
- /**
- * @param lamsToolService The lamsToolService to set.
- */
- public void setLamsCoreToolService(ILamsCoreToolService lamsToolService)
- {
- this.lamsCoreToolService = lamsToolService;
- }
-
- public void setActivityMapping(ActivityMapping activityMapping) {
+ /**
+ * @param lamsToolService The lamsToolService to set.
+ */
+ public void setLamsCoreToolService(ILamsCoreToolService lamsToolService) {
+ lamsCoreToolService = lamsToolService;
+ }
+
+ public void setActivityMapping(ActivityMapping activityMapping) {
this.activityMapping = activityMapping;
}
-
- /**
- * @param activityDAO The activityDAO to set.
- */
- public void setActivityDAO(IActivityDAO activityDAO)
- {
- this.activityDAO = activityDAO;
- }
-
- /**
- * @param groupingDAO The groupingDAO to set.
- */
- public void setGroupingDAO(IGroupingDAO groupingDAO)
- {
- this.groupingDAO = groupingDAO;
- }
- /**
- * @return the User Management Service
- */
+
+ /**
+ * @param activityDAO The activityDAO to set.
+ */
+ public void setActivityDAO(IActivityDAO activityDAO) {
+ this.activityDAO = activityDAO;
+ }
+
+ /**
+ * @param groupingDAO The groupingDAO to set.
+ */
+ public void setGroupingDAO(IGroupingDAO groupingDAO) {
+ this.groupingDAO = groupingDAO;
+ }
+
+ /**
+ * @return the User Management Service
+ */
public IUserManagementService getUserManagementService() {
return userManagementService;
}
+
/**
* @param userService User Management Service
*/
public void setUserManagementService(IUserManagementService userService) {
- this.userManagementService = userService;
+ userManagementService = userService;
}
-
+
public void setLessonService(ILessonService lessonService) {
this.lessonService = lessonService;
}
-
- //---------------------------------------------------------------------
- // Service Methods
- //---------------------------------------------------------------------
- /**
- * Delegate to lesson dao to load up the lessons.
- * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#getActiveLessonsFor(org.lamsfoundation.lams.usermanagement.User)
- */
- public LessonDTO[] getActiveLessonsFor(Integer learnerId)
- {
- User learner = (User)userManagementService.findById(User.class,learnerId);
- List activeLessons = this.lessonDAO.getActiveLessonsForLearner(learner);
- return getLessonDataFor(activeLessons);
- }
-
- public Lesson getLesson(Long lessonId)
- {
- return lessonDAO.getLesson(lessonId);
- }
-
- /**
- * Get the lesson data for a particular lesson. In a DTO format suitable for sending to the client.
- */
- public LessonDTO getLessonData(Long lessonId)
- {
- Lesson lesson = getLesson(lessonId);
- return ( lesson != null ? lesson.getLessonData() : null );
- }
-
- /**
- * Joins a User to a lesson as a learner. It could either be a new lesson - * or a lesson that has been started.
- * - *In terms of new lesson, a new learner progress would be initialized. - * Tool session for the next activity will be initialized if necessary.
- * - *In terms of an started lesson, the learner progress will be returned - * without calculation. Tool session will be initialized if necessary. - * Note that we won't initialize tool session for current activity because - * we assume tool session will always initialize before it becomes a - * current activity.
Joins a User to a lesson as a learner. It could either be a new lesson + * or a lesson that has been started. + * + *In terms of new lesson, a new learner progress would be initialized. + * Tool session for the next activity will be initialized if necessary.
+ * + *In terms of an started lesson, the learner progress will be returned + * without calculation. Tool session will be initialized if necessary. + * Note that we won't initialize tool session for current activity because + * we assume tool session will always initialize before it becomes a + * current activity.
list = builder.getActivityList(); - - Object[] retValue = new Object[2]; - retValue[0] = list; - retValue[1] = progress.getCurrentActivity() !=null ? progress.getCurrentActivity().getActivityId() : null; - - return retValue; - } - + try { + progressEngine.setUpStartPoint(learnerProgress); + } + catch (ProgressException e) { + LearnerService.log.error("error occurred in 'setUpStartPoint':" + e.getMessage()); + throw new LearnerServiceException(e.getMessage()); + } + //Use TimeStamp rather than Date directly to keep consistent with Hibnerate persiste object. + learnerProgress.setStartDate(new Timestamp(new Date().getTime())); + learnerProgressDAO.saveLearnerProgress(learnerProgress); + } + else { - /** - * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#chooseActivity(org.lamsfoundation.lams.usermanagement.User, java.lang.Long, org.lamsfoundation.lams.learningdesign.Activity) - */ - public LearnerProgress chooseActivity(Integer learnerId, Long lessonId, Activity activity, Boolean clearCompletedFlag) - { - LearnerProgress progress = learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId); - - if ( ! progress.getCompletedActivities().contains(activity) ) { - // if we skip a sequence in an optional sequence, or have been force completed for branching / optional sequence - // and we go back to the sequence later, then the LessonComplete flag must be reset so that it will step through - // all the activities in the sequence - otherwise it will go to the "Completed" screen after the first activity in the sequence - if ( clearCompletedFlag && activity.getParentActivity() != null && activity.getParentActivity().isSequenceActivity() - && progress.isComplete() ) - progress.setLessonComplete(LearnerProgress.LESSON_NOT_COMPLETE); - - progressEngine.setActivityAttempted(progress, activity); - progress.setCurrentActivity(activity); - progress.setNextActivity(activity); + Activity currentActivity = learnerProgress.getCurrentActivity(); + if (currentActivity == null) { + // something may have gone wrong and we need to recalculate the current activity + try { + progressEngine.setUpStartPoint(learnerProgress); + } + catch (ProgressException e) { + LearnerService.log.error("error occurred in 'setUpStartPoint':" + e.getMessage()); + throw new LearnerServiceException(e.getMessage()); + } + } - learnerProgressDAO.saveLearnerProgress(progress); - } - - return progress; - } - - /** - * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#moveToActivity(java.lang.Integer, java.lang.Long, org.lamsfoundation.lams.learningdesign.Activity, org.lamsfoundation.lams.learningdesign.Activity) - */ - public LearnerProgress moveToActivity(Integer learnerId, Long lessonId, Activity fromActivity, Activity toActivity){ - LearnerProgress progress = learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId); - - if(fromActivity != null) - progress.setProgressState(fromActivity, LearnerProgress.ACTIVITY_ATTEMPTED, activityDAO); - - if(toActivity != null) { - progress.setProgressState(toActivity, LearnerProgress.ACTIVITY_ATTEMPTED, activityDAO); - progress.setCurrentActivity(toActivity); - progress.setNextActivity(toActivity); - } - - learnerProgressDAO.updateLearnerProgress(progress); - return progress; - } - - /** - * Calculates learner progress and returns the data required to be displayed - * to the learner. - * @param completedActivity the activity just completed - * @param learner the Learner - * @param learnerProgress the current progress - * @return the bean containing the display data for the Learner - * @throws LamsToolServiceException - * @throws LearnerServiceException in case of problems. - */ - public LearnerProgress calculateProgress(Activity completedActivity,Integer learnerId, LearnerProgress currentLearnerProgress) - { - try - { - LearnerProgress learnerProgress = progressEngine.calculateProgress(currentLearnerProgress.getUser(), completedActivity,currentLearnerProgress); - learnerProgressDAO.updateLearnerProgress(learnerProgress); - return learnerProgress; - } - catch (ProgressException e) - { - throw new LearnerServiceException(e.getMessage()); - } + //The restarting flag should be setup when the learner hit the exit + //button. But it is possible that user exit by closing the browser, + //In this case, we set the restarting flag again. + if (!learnerProgress.isRestarting()) { + learnerProgress.setRestarting(true); + learnerProgressDAO.updateLearnerProgress(learnerProgress); + } + } - } - - /** - * @see org.lamsfoundation.lams.learning.service.ILearnerService#completeToolSession(java.lang.Long, java.lang.Long) - */ - public String completeToolSession(Long toolSessionId, Long learnerId) - { - // this method is called by tools, so it mustn't do anything that relies on all the tools' Spring beans - // being available in the context. Hence it is defined in the ILearnerService interface, not the IFullLearnerService - // interface. If it calls any other methods then it mustn't use anything on the ICoreLearnerService interface. - - String returnURL = null; - - ToolSession toolSession = lamsCoreToolService.getToolSessionById(toolSessionId); - if ( toolSession == null ) { - // something has gone wrong - maybe due to Live Edit. The tool session supplied by the tool doesn't exist. - // have to go to a "can't do anything" screen and the user will have to hit resume. - returnURL = activityMapping.getProgressBrokenURL(); + return learnerProgress; + } - } else { - Long lessonId = toolSession.getLesson().getLessonId(); - LearnerProgress currentProgress = getProgress(new Integer(learnerId.intValue()), lessonId); - // TODO Cache the learner progress in the session, but mark it with the progress id. Then get the progress out of the session - // for ActivityAction.java.completeActivity(). Update LearningWebUtil to look under the progress id, so we don't get - // a conflict in Preview & Learner. - returnURL = activityMapping.getCompleteActivityURL(toolSession.getToolActivity().getActivityId(), currentProgress.getLearnerProgressId()); - - } - - if ( log.isDebugEnabled() ) { - log.debug("CompleteToolSession() for tool session id "+toolSessionId+" learnerId "+learnerId+" url is "+returnURL); - } - - return returnURL; - - } - - /** - * Complete the activity in the progress engine and delegate to the progress - * engine to calculate the next activity in the learning design. - * It is currently triggered by various progress engine related action classes, - * which then calculate the url to go to next, based on the ActivityMapping - * class. - * - * @param learnerId the learner who are running this activity in the design. - * @param activity the activity is being run. - * @param lessonId lesson id - * @return the updated learner progress - */ - public LearnerProgress completeActivity(Integer learnerId,Activity activity,LearnerProgress progress) - { - LearnerProgress nextLearnerProgress = null; - - // Need to synchronise the next bit of code so that if the tool calls - // this twice in quick succession, with the same parameters, it won't update - // the database twice! This may happen if a tool has a double submission problem. - // I don't want to synchronise on (this), as this could cause too much of a bottleneck, - // but if its not synchronised, we get db errors if the same tool session is completed twice - // (invalid index). I can'tfind another object on which to synchronise - Hibernate does not give me the - // same object for tool session or current progress and user is cached via login, not userid. + /** + * This method creates the tool session (if needed) for a tool activity. + * It won't try it for the child activities, as any Sequence activities inside this + * activity may have a grouping WITHIN the sequence, and then the grouped activities + * get the won't be grouped properly (See LDEV-1774). We could get the child tool activities + * for a parallel activity but that could create a bug in the future - if we ever put + * sequences inside parallel activities then we are stuck again! + * + * We look up the database to check up the existence of correspondent tool session. If the tool + * session doesn't exist, we create a new tool session instance. + * + * @param learnerProgress the learner progress we are processing. + * @throws LamsToolServiceException + */ + public void createToolSessionsIfNecessary(Activity activity, LearnerProgress learnerProgress) { + try { + if (activity != null && activity.isToolActivity()) { + ToolActivity toolActivity = (ToolActivity) activity; + createToolSessionFor(toolActivity, learnerProgress.getUser(), learnerProgress.getLesson()); + } + } + catch (LamsToolServiceException e) { + LearnerService.log.error("error occurred in 'createToolSessionFor':" + e.getMessage()); + throw new LearnerServiceException(e.getMessage()); + } + catch (ToolException e) { + LearnerService.log.error("error occurred in 'createToolSessionFor':" + e.getMessage()); + throw new LearnerServiceException(e.getMessage()); + } + } - // bottleneck synchronized (this) { - if (activity==null ) { - try { - nextLearnerProgress = progressEngine.setUpStartPoint(progress); - } catch (ProgressException e) { - log.error("error occurred in 'setUpStartPoint':"+e.getMessage(),e); - throw new LearnerServiceException(e); + /** + * Returns the current progress data of the User. + * @param learnerId the Learner's userID + * @param lessonId the Lesson to get progress from. + * @return LearnerProgess contains the learner's progress for the lesson. + * @throws LearnerServiceException in case of problems. + */ + public LearnerProgress getProgress(Integer learnerId, Long lessonId) { + return learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId); + } + + /** + * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#getProgressById(java.lang.Long) + */ + public LearnerProgress getProgressById(Long progressId) { + return learnerProgressDAO.getLearnerProgress(progressId); + } + + /** + * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#getProgressDTOByLessonId(java.lang.Long, org.lamsfoundation.lams.usermanagement.User) + */ + public LearnerProgressDTO getProgressDTOByLessonId(Long lessonId, Integer learnerId) { + return learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId).getLearnerProgressData(); + } + + /** + * @see org.lamsfoundation.lams.learning.service.ICoreLearnerService#getStructuredProgressDTOs(java.lang.Long, java.lang.Long) + */ + public Object[] getStructuredActivityURLs(Integer learnerId, Long lessonId) { + + LearnerProgress progress = learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId); + Lesson lesson = progress.getLesson(); + + ProgressBuilder builder = new ProgressBuilder(progress, activityDAO, activityMapping); + builder.parseLearningDesign(); + ListCreate a lams tool session for learner against a tool activity. This will - * have concurrency issues interms of grouped tool session because it might - * be inserting some tool session that has already been inserted by other - * member in the group. If the unique_check is broken, we need to query - * the database to get the instance instead of inserting it. It should be - * done in the Spring rollback strategy.
- * - * Once lams tool session is inserted, we need to notify the tool to its - * own session. - * - * @param toolActivity - * @param learner - * @throws LamsToolServiceException - */ - private void createToolSessionFor(ToolActivity toolActivity,User learner,Lesson lesson) throws LamsToolServiceException, ToolException - { - // if the tool session already exists, createToolSession() will return null - ToolSession toolSession = lamsCoreToolService.createToolSession(learner,toolActivity,lesson); - if ( toolSession !=null ) { - toolActivity.getToolSessions().add(toolSession); - lamsCoreToolService.notifyToolsToCreateSession(toolSession, toolActivity); - } - } - - - /** - * Create an array of lesson dto based a list of lessons. - * @param lessons the list of lessons. - * @return the lesson dto array. - */ - private LessonDTO[] getLessonDataFor(List lessons) - { - ListCreate a lams tool session for learner against a tool activity. This will + * have concurrency issues interms of grouped tool session because it might + * be inserting some tool session that has already been inserted by other + * member in the group. If the unique_check is broken, we need to query + * the database to get the instance instead of inserting it. It should be + * done in the Spring rollback strategy.
+ * + * Once lams tool session is inserted, we need to notify the tool to its + * own session. + * + * @param toolActivity + * @param learner + * @throws LamsToolServiceException + */ + private void createToolSessionFor(ToolActivity toolActivity, User learner, Lesson lesson) throws LamsToolServiceException, + ToolException { + // if the tool session already exists, createToolSession() will return null + ToolSession toolSession = lamsCoreToolService.createToolSession(learner, toolActivity, lesson); + if (toolSession != null) { + toolActivity.getToolSessions().add(toolSession); + lamsCoreToolService.notifyToolsToCreateSession(toolSession, toolActivity); + } + } - try { - if ( branchingActivity.isToolBranchingActivity() ) { - return determineToolBasedBranch(lesson, (ToolBranchingActivity)branchingActivity, learner); - - } else { - // assume either isGroupBranchingActivity() || isChosenBranchingActivity() ) - // in both cases, the branch is based on the group the learner is in. - return determineGroupBasedBranch(lesson, branchingActivity, learner); + /** + * Create an array of lesson dto based a list of lessons. + * @param lessons the list of lessons. + * @return the lesson dto array. + */ + private LessonDTO[] getLessonDataFor(List lessons) { + ListThe action servlet that triggers the system driven grouping
@@ -75,196 +74,209 @@
* @struts:action-forward name="viewGroup" path="/grouping.do?method=viewGrouping"
* @struts:action-forward name="showGroup" path=".showgroup"
* @struts:action-forward name="waitGroup" path=".waitgroup"
+ * @struts:action-forward name="chooseGroup" path=".choosegroup"
* ----------------XDoclet Tags--------------------
*
*/
-public class GroupingAction extends LamsDispatchAction
-{
+public class GroupingAction extends LamsDispatchAction {
- /** Input parameter. Boolean value */
- public static final String PARAM_FORCE_GROUPING = "force";
+ /** Input parameter. Boolean value */
+ public static final String PARAM_FORCE_GROUPING = "force";
- //---------------------------------------------------------------------
- // Instance variables
- //---------------------------------------------------------------------
+ //---------------------------------------------------------------------
+ // Instance variables
+ //---------------------------------------------------------------------
private static Logger log = Logger.getLogger(GroupingAction.class);
- //---------------------------------------------------------------------
- // Class level constants - Session Attributes
- //---------------------------------------------------------------------
+ //---------------------------------------------------------------------
+ // Class level constants - Session Attributes
+ //---------------------------------------------------------------------
public static final String GROUPS = "groups";
public static final String FINISHED_BUTTON = "finishedButton";
- public static final String LOCAL_FILES= "localFiles";
+ public static final String LOCAL_FILES = "localFiles";
public static final String TITLE = "title";
-
- //---------------------------------------------------------------------
- // Class level constants - Struts forward
- //---------------------------------------------------------------------
+ public static final String MAX_LEARNERS_PER_GROUP = "maxLearnersPerGroup";
+
+ //---------------------------------------------------------------------
+ // Class level constants - Struts forward
+ //---------------------------------------------------------------------
public static final String VIEW_GROUP = "viewGroup";
public static final String WAIT_GROUP = "waitGroup";
public static final String SHOW_GROUP = "showGroup";
-
- //---------------------------------------------------------------------
- // Struts Dispatch Method
- //---------------------------------------------------------------------
- /**
- * Perform the grouping for the users who are currently running the lesson.
- * If force is set to true, then we should be in preview mode, and we want to
- * override the chosen grouping to make it group straight away.
- *
- * @param mapping
- * @param form
- * @param request
- * @param response
- * @return
- * @throws IOException
- * @throws ServletException
- */
- public ActionForward performGrouping(ActionMapping mapping,
- ActionForm form,
- HttpServletRequest request,
- HttpServletResponse response) throws IOException,
- ServletException
- {
+ public static final String CHOOSE_GROUP = "chooseGroup";
- boolean forceGroup = WebUtil.readBooleanParam(request,PARAM_FORCE_GROUPING,false);
+ //---------------------------------------------------------------------
+ // Struts Dispatch Method
+ //---------------------------------------------------------------------
+ /**
+ * Perform the grouping for the users who are currently running the lesson.
+ * If force is set to true, then we should be in preview mode, and we want to
+ * override the chosen grouping to make it group straight away.
+ *
+ * @param mapping
+ * @param form
+ * @param request
+ * @param response
+ * @return
+ * @throws IOException
+ * @throws ServletException
+ */
+ public ActionForward performGrouping(ActionMapping mapping, ActionForm form, HttpServletRequest request,
+ HttpServletResponse response) throws IOException, ServletException {
- //initialize service object
- ICoreLearnerService learnerService = LearnerServiceProxy.getLearnerService(getServlet().getServletContext());
- LearnerProgress learnerProgress = LearningWebUtil.getLearnerProgress(request, learnerService);
+ boolean forceGroup = WebUtil.readBooleanParam(request, GroupingAction.PARAM_FORCE_GROUPING, false);
+
+ //initialize service object
+ ICoreLearnerService learnerService = LearnerServiceProxy.getLearnerService(getServlet().getServletContext());
+ LearnerProgress learnerProgress = LearningWebUtil.getLearnerProgress(request, learnerService);
Activity activity = LearningWebUtil.getActivityFromRequest(request, learnerService);
- if (!(activity instanceof GroupingActivity))
- {
- log.error(className+": activity not GroupingActivity");
+ if (!(activity instanceof GroupingActivity)) {
+ GroupingAction.log.error(LamsDispatchAction.className + ": activity not GroupingActivity");
return mapping.findForward(ActivityMapping.ERROR);
}
-
- boolean groupingDone = learnerService.performGrouping(learnerProgress.getLesson().getLessonId(),
- activity.getActivityId(),
- LearningWebUtil.getUserId(),forceGroup);
+ Long lessonId = learnerProgress.getLesson().getLessonId();
+ boolean groupingDone = learnerService.performGrouping(lessonId, activity.getActivityId(), LearningWebUtil.getUserId(),
+ forceGroup);
- LearningWebUtil.putActivityInRequest(request, activity, learnerService);
-
- DynaActionForm groupForm = (DynaActionForm)form;
- groupForm.set("previewLesson",learnerProgress.getLesson().isPreviewLesson());
- groupForm.set("title", activity.getTitle());
-
+ LearningWebUtil.putActivityInRequest(request, activity, learnerService);
+
+ DynaActionForm groupForm = (DynaActionForm) form;
+ groupForm.set("previewLesson", learnerProgress.getLesson().isPreviewLesson());
+ groupForm.set("title", activity.getTitle());
+
LearningWebUtil.setupProgressInRequest(groupForm, request, learnerProgress);
- if ( groupingDone ) {
- request.setAttribute(FINISHED_BUTTON, Boolean.TRUE);
- return mapping.findForward(VIEW_GROUP);
- }
- return mapping.findForward(WAIT_GROUP);
- }
+ if (groupingDone) {
+ request.setAttribute(GroupingAction.FINISHED_BUTTON, Boolean.TRUE);
+ return mapping.findForward(GroupingAction.VIEW_GROUP);
+ }
+ //forward to group choosing page
+ if (((GroupingActivity) activity).getCreateGrouping().isLearnerChoiceGrouping()) {
+ Integer maxNumberOfLeaernersPerGroup = learnerService.calculateMaxNumberOfLearnersPerGroup(lessonId,
+ ((GroupingActivity) activity).getCreateGrouping().getGroupingId());
+ prepareGroupData(request);
+ request.setAttribute(GroupingAction.MAX_LEARNERS_PER_GROUP, maxNumberOfLeaernersPerGroup);
+ request.setAttribute(GroupingAction.LOCAL_FILES, Boolean.FALSE);
+ return mapping.findForward(GroupingAction.CHOOSE_GROUP);
+ }
+ return mapping.findForward(GroupingAction.WAIT_GROUP);
+ }
- /**
- * Load up the grouping information and forward to the jsp page to display
- * all the groups and members.
- * @param mapping
- * @param form
- * @param request
- * @param response
- * @return
- * @throws IOException
- * @throws ServletException
- */
- public ActionForward viewGrouping(ActionMapping mapping,
- ActionForm form,
- HttpServletRequest request,
- HttpServletResponse response) throws IOException,
- ServletException
- {
- //initialize service object
- ICoreLearnerService learnerService = LearnerServiceProxy.getLearnerService(getServlet().getServletContext());
-
- SortedSet