Index: lams_tool_preview/conf/language/lams/ApplicationResources.properties =================================================================== diff -u -r0a6765ac7eb73c6b99c343a021877c48236241b8 -rc260f6f3f855894e54d3725095e56d39a139d893 --- lams_tool_preview/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision 0a6765ac7eb73c6b99c343a021877c48236241b8) +++ lams_tool_preview/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision c260f6f3f855894e54d3725095e56d39a139d893) @@ -61,7 +61,8 @@ label.rating.criterias =Rating criteria label.add.criteria =Add Criterion label.your.rating =Your rating is {0}
Avg rating {1} out of {2} votes -label.rate.limits.reminder =Rating limitation: Minimum {0} and Maximum {1}. +label.rate.limits.reminder =Rate a minimum of {0} and a maximum of {1} users. +label.rate.all.users =Rate All Users label.rate.limits.topic.reminder =You have rated {0} users already. label.rate.limits.reminder.min = You must rate at least {0} users. label.rate.limits.reminder.max = You can only rate up to {0} users. Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java =================================================================== diff -u -r48c14c8aeedd10c8cc5fd8331e21f6478fba012c -rc260f6f3f855894e54d3725095e56d39a139d893 --- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java (.../LearningAction.java) (revision 48c14c8aeedd10c8cc5fd8331e21f6478fba012c) +++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java (.../LearningAction.java) (revision c260f6f3f855894e54d3725095e56d39a139d893) @@ -537,13 +537,23 @@ (criteria.isCommentRating() || criteria.isStarStyleRating()), PeerreviewConstants.SORT_BY_USERNAME_ASC, null, peerreview.isSelfReview(), true ); - // override the min/max for stars based on old settings if needed (original Peer Review kept one setting for all criteria ) - if ( ( peerreview.getMinimumRates() > 0 || peerreview.getMaximumRates() > 0 ) && - ( dto.getRatingCriteria().getMinimumRates() == 0 && dto.getRatingCriteria().getMaximumRates() == 0 ) ) { - dto.getRatingCriteria().setMinimumRates(peerreview.getMinimumRates()); - dto.getRatingCriteria().setMaximumRates(peerreview.getMaximumRates()); + // Send the number of users to rate in rateAll, or send 0. Do not want to modify the criteria min/max as it is originally + // a Hibernate object and don't want to risk updating it in the db. Need to send a flag so why not make flag double as the + // runtime min/max value while leaving min/max as the original criteria definition. + int rateAllUsers = 0; + if ( ( criteria.isRankingStyleRating() && criteria.getMaxRating() == RatingCriteria.RATING_RANK_ALL ) || + ( criteria.isStarStyleRating() && criteria.getMinimumRates() == RatingCriteria.RATING_RANK_ALL ) ) { + rateAllUsers = service.getCountUsersBySession(toolSessionId, peerreview.isSelfReview() ? -1 : userId); + } else if ( criteria.isStarStyleRating() && + ( peerreview.getMinimumRates() > 0 || peerreview.getMaximumRates() > 0 ) && + ( dto.getRatingCriteria().getMinimumRates() == 0 && dto.getRatingCriteria().getMaximumRates() == 0 ) ) { + // override the min/max for stars based on old settings if needed (original Peer Review kept one setting for all criteria ) + // does not matter if this change gets persisted to database. + criteria.setMinimumRates(peerreview.getMinimumRates()); + criteria.setMaximumRates(peerreview.getMaximumRates()); } + request.setAttribute("rateAllUsers",rateAllUsers); request.setAttribute("criteriaRatings", dto); return mapping.findForward(PeerreviewConstants.SUCCESS); } Index: lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag =================================================================== diff -u -r4eb3e680353be3e7488977cbb2661d9e21c9aa38 -rc260f6f3f855894e54d3725095e56d39a139d893 --- lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag (.../AuthoringRatingAllStyleCriteria.tag) (revision 4eb3e680353be3e7488977cbb2661d9e21c9aa38) +++ lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag (.../AuthoringRatingAllStyleCriteria.tag) (revision c260f6f3f855894e54d3725095e56d39a139d893) @@ -196,9 +196,15 @@ reactivateArrows(); } - function generateSelect(id, validate, zeroDescription, orderId, currentValue) { - var str = ''; + if ( zeroDescription ) { + str += ''; + } for (var i = 1; i < 11; i++) { str += ''; } @@ -263,12 +269,7 @@ } else if ( style == 2 ) { var rankingStr = '
 ' - + '
'; + + generateSelect('maxRating' + orderId, null, null, orderId, maxRating); row.append(jQuery('', { 'class': 'criteria-info', html: '
'+ inputField + rankingStr @@ -330,7 +331,25 @@ var maxRateDropDown = document.getElementById("maximumRates" + orderId); var maxLimit = parseInt(maxRateDropDown.options[maxRateDropDown.selectedIndex].value); - if ((minLimit > maxLimit) && !(maxLimit == 0)) { + // RANK ALL + if ( minLimit == -1 || maxLimit == -1 ) { + if ( isMinimum ) { + if ( minLimit == -1 ) { + maxRateDropDown.selectedIndex = 0; + } else { + maxRateDropDown.selectedIndex = minRateDropDown.selectedIndex; + } + } else { + if ( maxLimit == -1 ) { + minRateDropDown.selectedIndex = 0; + } else { + minRateDropDown.selectedIndex = maxRateDropDown.selectedIndex; + } + } + } + + // OTHERWISE MIN <= MAX + else if ((minLimit > maxLimit) && !(maxLimit == 0)) { if (isMinimum) { minRateDropDown.selectedIndex = maxRateDropDown.selectedIndex; } else { Index: lams_tool_preview/web/pages/learning/hedging.jsp =================================================================== diff -u -rd2f1cafab9126e3848663764c082b76ccf2de0c5 -rc260f6f3f855894e54d3725095e56d39a139d893 --- lams_tool_preview/web/pages/learning/hedging.jsp (.../hedging.jsp) (revision d2f1cafab9126e3848663764c082b76ccf2de0c5) +++ lams_tool_preview/web/pages/learning/hedging.jsp (.../hedging.jsp) (revision c260f6f3f855894e54d3725095e56d39a139d893) @@ -14,6 +14,13 @@ }); currentMark = mark; $("#totalMark").html(currentMark); + + if ( currentMark == ${criteriaRatings.ratingCriteria.maxRating} ) { + showButtons(); + } else { + hideButtons(); + } + } function submitEntry(next){ @@ -24,7 +31,6 @@ $("#editForm").submit(); } else { alert('${criteriaRatings.ratingCriteria.maxRating}'); - showButtons(); } } Index: lams_tool_preview/web/pages/learning/learning.jsp =================================================================== diff -u -r2cad2462df185fce685da61762fb06d98ebee415 -rc260f6f3f855894e54d3725095e56d39a139d893 --- lams_tool_preview/web/pages/learning/learning.jsp (.../learning.jsp) (revision 2cad2462df185fce685da61762fb06d98ebee415) +++ lams_tool_preview/web/pages/learning/learning.jsp (.../learning.jsp) (revision c260f6f3f855894e54d3725095e56d39a139d893) @@ -40,10 +40,10 @@ - + - - - - - + + - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + +