Index: lams_learning/web/discussion/monitor5.jsp =================================================================== diff -u -rfc63987bf348f0821378370cd71e6b933129edfd -rc52f84ea751e7f1bdfb0574df665fa66081217f9 --- lams_learning/web/discussion/monitor5.jsp (.../monitor5.jsp) (revision fc63987bf348f0821378370cd71e6b933129edfd) +++ lams_learning/web/discussion/monitor5.jsp (.../monitor5.jsp) (revision c52f84ea751e7f1bdfb0574df665fa66081217f9) @@ -22,21 +22,21 @@ /* Start button is hidden by default */ display: none; } - + .discussion-sentiment-table-header-row td { /* Table headers look better this way */ font-weight: bold; text-align: left !important; } - + .discussion-sentiment-table-stay-header-row td { background-color: rgba(255, 195, 55, 1); } - + .discussion-sentiment-table-move-header-row td { background-color: rgba(5, 204, 214, 1); } - + .discussion-sentiment-table-option-row td:first-child { /* Option cells are slightly moved to the right */ padding-left: 30px; @@ -64,8 +64,8 @@ var widget = $('#discussion-sentiment-chart-card-content-' + toolQuestionUid + (burningQuestionUid ? '-' + burningQuestionUid : '')) .data('stop', true) .closest('.discussion-sentiment-chart-card').addClass('disabled'); - $('.discussion-sentiment-stop-button', widget).remove(); - $('.discussion-sentiment-start-button', widget).show(); + $('.discussion-sentiment-stop-button', widget).remove(); + $('.discussion-sentiment-start-button', widget).show(); } function getDiscussionSentimentMonitorData(toolQuestionUid, burningQuestionUid) { @@ -83,7 +83,7 @@ } // process raw data in response, which is "option" -> "number of votes" - var data = response.votes, + var data = response.votes, stayVotes = 0, moveVotes = 0, idSuffix = toolQuestionUid + (burningQuestionUid ? '-' + burningQuestionUid : ''); @@ -102,7 +102,7 @@ } } $('#discussion-sentiment-table-move-header-votes-' + idSuffix).text(moveVotes); - + var totalVotes = stayVotes + moveVotes; $('#discussion-sentiment-votes-' + idSuffix).text(totalVotes); var stayPercent = totalVotes === 0 ? 0 : Math.round(stayVotes / totalVotes * 100); @@ -115,7 +115,7 @@ // currently options are 1-4 (stay) and 11-14 (move) continue; } - + var votes = data[optionNumber], optionRow = $('#discussion-sentiment-table-option-row-' + idSuffix + '-' + optionNumber); if (votes && totalVotes > 0) { @@ -147,7 +147,7 @@ // create a new chart chartCanvas = $('').appendTo(chartCell); - + var ctx = chartCanvas[0].getContext('2d'), chart = new Chart(ctx, { type : 'doughnut', @@ -163,7 +163,7 @@ data : chartData, backgroundColor : [ 'rgba(255, 195, 55, 1)', 'rgba(5, 204, 214, 1)' - + ], borderWidth : 0, } ], @@ -201,16 +201,16 @@ } }); } - + $(document).ready(function(){ var toolQuestionUid = ${param.toolQuestionUid}, burningQuestionUid = '${param.burningQuestionUid}', idSuffix = toolQuestionUid + (burningQuestionUid ? '-' + burningQuestionUid : ''), // how often to refresh the chart dataRefreshInterval = 5 * 1000; getDiscussionSentimentMonitorData(toolQuestionUid, burningQuestionUid); - - + + var dataRefresh = window.setInterval(function(){ var cardContent = $('#discussion-sentiment-chart-card-content-' + idSuffix), // If in TBL monitor the tab with the chart got refreshed, then old interval is still ticking. @@ -222,7 +222,7 @@ } getDiscussionSentimentMonitorData(toolQuestionUid, burningQuestionUid); }, dataRefreshInterval); - + $('#discussion-sentiment-chart-card-content-' + idSuffix).data('dataRefresh', dataRefresh); }); @@ -253,9 +253,9 @@
-
+
-
+
+
Index: lams_monitoring/web/grouping/viewGroups.jsp =================================================================== diff -u -rd0f4c3bdd871e236755472c8443c337b2b96e48c -rc52f84ea751e7f1bdfb0574df665fa66081217f9 --- lams_monitoring/web/grouping/viewGroups.jsp (.../viewGroups.jsp) (revision d0f4c3bdd871e236755472c8443c337b2b96e48c) +++ lams_monitoring/web/grouping/viewGroups.jsp (.../viewGroups.jsp) (revision c52f84ea751e7f1bdfb0574df665fa66081217f9) @@ -19,7 +19,6 @@ http://www.gnu.org/licenses/gpl.txt --%> - <%@ include file="/taglibs.jsp"%> @@ -29,11 +28,8 @@ - - - - -
+ + @@ -85,12 +81,5 @@ -
- -
- - - - -
\ No newline at end of file + + Index: lams_monitoring/web/includes/javascript/monitorLesson.js =================================================================== diff -u -r6ca7c6f9b49fe23c7f11e22e40334749c6b7d13f -rc52f84ea751e7f1bdfb0574df665fa66081217f9 --- lams_monitoring/web/includes/javascript/monitorLesson.js (.../monitorLesson.js) (revision 6ca7c6f9b49fe23c7f11e22e40334749c6b7d13f) +++ lams_monitoring/web/includes/javascript/monitorLesson.js (.../monitorLesson.js) (revision c52f84ea751e7f1bdfb0574df665fa66081217f9) @@ -410,7 +410,6 @@ }, success : function(response) { - // update lesson state label lessonStateId = +response.lessonStateID; var label = null, @@ -445,7 +444,8 @@ labelColour = 'danger'; break; } - $('#lessonStateLabel').attr('class', 'btn btn-sm btn-' + labelColour).html(label + ' '); + $('#lessonStateLabel').attr('class', 'btn btn-sm btn-' + labelColour) + .html(label + (lessonStateId == 7 ? '' : '')); // update available options in change state dropdown menu var selectField = $('#lessonStateField'); @@ -478,9 +478,8 @@ lessonFinishDateSpan = $('#lessonFinishDateSpan'), lessonStateChanger = $('#lessonStateChanger'), stateLabel = $('#lessonStateLabel'); - switch (lessonStateId) { - // created but not started lesson + //created but not started lesson case 1: scheduleControls.css('display','inline'); if ( response.finishDate ) { @@ -768,7 +767,8 @@ case 7: showConfirm(LABELS.LESSON_REMOVE_ALERT, function() { showConfirm(LABELS.LESSON_REMOVE_DOUBLECHECK_ALERT, function() { - method = "removeLesson"; + // this is a callback, so standard processing won't work here + applyStateChange(state, "removeLesson"); }); }); break; @@ -1898,7 +1898,7 @@ } $(definePortrait(learner.portraitId, learner.id, STYLE_SMALL, true, LAMS_URL)) .css({ - 'left' : learnerIndex * (activity.learnerCount < 5 ? 46 : 28) + 'px', + 'left' : learnerIndex * (activity.learnerCount < 4 ? 46 : 28) + 'px', 'z-index' : 100 + learnerIndex, 'padding-top' : '2px' }) @@ -2430,12 +2430,12 @@ $('.accordion-button', itemHeader) .attr('data-bs-target', '#' + itemCollapseId) .attr('aria-controls', itemCollapseId) - .prepend('' + learner.firstName + ' ' + learner.lastName + '') + .prepend('' + learner.lastName + ', ' + learner.firstName + '') .prepend(portraitSmall); $('.accordion-completed-activity-count', itemHeader).text(learner.completedActivityCount).tooltip(); $('.accordion-completed-lesson', itemHeader).toggle(learner.completedLesson).tooltip(); - $('.learners-accordion-name', item).text(learner.firstName + ' ' + learner.lastName); + $('.learners-accordion-name', item).text(learner.lastName + ', ' + learner.firstName); $('.learners-accordion-login', item).html('' + learner.login); $('.learners-accordion-email', item).html('' + learner.email + ''); Index: lams_monitoring/web/monitor.jsp =================================================================== diff -u -r6ca7c6f9b49fe23c7f11e22e40334749c6b7d13f -rc52f84ea751e7f1bdfb0574df665fa66081217f9 --- lams_monitoring/web/monitor.jsp (.../monitor.jsp) (revision 6ca7c6f9b49fe23c7f11e22e40334749c6b7d13f) +++ lams_monitoring/web/monitor.jsp (.../monitor.jsp) (revision c52f84ea751e7f1bdfb0574df665fa66081217f9) @@ -330,69 +330,77 @@
- -
-
+ + +
+ + +
- -
-
-
-
-
- - -
+ +
+
+ +
+
+ + +
- -
-
-
- - +
+
+ + +
+
- -
- -
+ +
-
- - - - +
+ + + + +
-
+
+
+ + + + + + +
+

+ +

+ + + + -
-
-
- - - - - -
-

- -

+
+
+ + +
-
-
-
- - - -
-
- - - -
- -
-
- - +
+
+
+ - + - + - @@ -356,7 +354,6 @@ - - -
@@ -321,14 +317,16 @@
- + + + + @@ -451,23 +448,28 @@
-
-
+
+
+
-
+
- -
-
- + +
- -
+ + + +
+ +
@@ -518,7 +520,6 @@ - @@ -620,8 +621,7 @@ -
-
+
-
- - -
-
- - +
-
-
+