Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java (.../LtiConsumerManagementController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java (.../LtiConsumerManagementController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -156,7 +156,7 @@ List listServer = userManagementService.findByProperty(ExtServer.class, "serverid", ltiConsumerForm.getServerid()); if (listServer != null && listServer.size() > 0) { - if (sid.equals(0)) {//new map + if (sid == null) {//new map errorMap.add("serverid", messageService.getMessage("error.not.unique", new Object[] { messageService.getMessage("sysadmin.serverid") })); } else { @@ -171,7 +171,7 @@ List listPrefix = userManagementService.findByProperty(ExtServer.class, "prefix", ltiConsumerForm.getPrefix()); if (listPrefix != null && listPrefix.size() > 0) { - if (sid.equals(0)) {//new map + if (sid == null) {//new map errorMap.add("prefix", messageService.getMessage("error.not.unique", new Object[] { messageService.getMessage("sysadmin.prefix") })); } else { @@ -186,7 +186,7 @@ if (errorMap.isEmpty()) { ExtServer ltiConsumer = null; - if (sid.equals(0)) { + if (sid == null) { ltiConsumer = new ExtServer(); BeanUtils.copyProperties(ltiConsumer, ltiConsumerForm); ltiConsumer.setSid(null); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgManageController.java =================================================================== diff -u -r79b6147f263fbc3c92e2db7d98227fa8f7358851 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgManageController.java (.../OrgManageController.java) (revision 79b6147f263fbc3c92e2db7d98227fa8f7358851) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgManageController.java (.../OrgManageController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -80,6 +80,7 @@ // Get organisation whose child organisations we will populate the OrgManageForm with Integer orgId = WebUtil.readIntParam(request, "org", true); + if (orgId == null) { orgId = (Integer) request.getAttribute("org"); } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgSaveController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgSaveController.java (.../OrgSaveController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgSaveController.java (.../OrgSaveController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -121,7 +121,7 @@ OrganisationState state = (OrganisationState) service.findById(OrganisationState.class, organisationForm.getStateId()); - if (orgId != 0) { + if (orgId != null) { if (service.canEditGroup(user.getUserID(), orgId)) { org = (Organisation) service.findById(Organisation.class, orgId); // set archived date only when it first changes to become archived @@ -142,7 +142,7 @@ org.setParentOrganisation( (Organisation) service.findById(Organisation.class, organisationForm.getParentId())); org.setOrganisationType( - (OrganisationType) service.findById(OrganisationType.class, organisationForm.getOrgId())); + (OrganisationType) service.findById(OrganisationType.class, organisationForm.getTypeId())); writeAuditLog(user, org, organisationForm, org.getOrganisationState(), org.getLocale()); } org.setLocale(locale); @@ -171,7 +171,7 @@ String message; // audit log entries for organisation attribute changes - if (orgForm.getOrgId() != 0) { + if (orgForm.getOrgId() != null) { final String key = "audit.organisation.change"; String[] args = new String[4]; args[1] = org.getName() + "(" + org.getOrganisationId() + ")"; Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ServerSaveController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ServerSaveController.java (.../ServerSaveController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ServerSaveController.java (.../ServerSaveController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -116,7 +116,7 @@ errorMap.add("prefix", messageService.getMessage("error.not.unique", new Object[] { messageService.getMessage("sysadmin.prefix") })); } else { - ExtServer map = (ExtServer) listServer.get(0); + ExtServer map = (ExtServer) listPrefix.get(0); if (!map.getSid().equals(sid)) { errorMap.add("prefix", messageService.getMessage("error.not.unique", new Object[] { messageService.getMessage("sysadmin.prefix") })); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java =================================================================== diff -u -r8fda3f2b8430c0d3e57a94953e84582eb3aad8c6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java (.../UserController.java) (revision 8fda3f2b8430c0d3e57a94953e84582eb3aad8c6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java (.../UserController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -345,7 +345,7 @@ } } - @RequestMapping(path = "/delete", method = RequestMethod.POST) + @RequestMapping(path = "/delete") public String delete(HttpServletRequest request) throws Exception { initServices(); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgController.java =================================================================== diff -u -r0aee88559b0d79e0516dd3630c24111361aeb787 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgController.java (.../UserOrgController.java) (revision 0aee88559b0d79e0516dd3630c24111361aeb787) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgController.java (.../UserOrgController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -70,14 +70,13 @@ service = AdminServiceProxy.getService(applicationContext.getServletContext()); messageService = AdminServiceProxy.getMessageService(applicationContext.getServletContext()); - //ActionMessages errors = new ActionMessages(); Integer orgId = WebUtil.readIntParam(request, "orgId", true); log.debug("orgId: " + orgId); // get org name Organisation organisation = (Organisation) service.findById(Organisation.class, orgId); if ((orgId == null) || (orgId <= 0) || organisation == null) { - request.setAttribute("errorName", "UserOrgAction"); + request.setAttribute("errorName", "UserOrgController"); request.setAttribute("errorMessage", messageService.getMessage("error.org.invalid")); return "error"; } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleController.java =================================================================== diff -u -r0aee88559b0d79e0516dd3630c24111361aeb787 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleController.java (.../UserOrgRoleController.java) (revision 0aee88559b0d79e0516dd3630c24111361aeb787) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleController.java (.../UserOrgRoleController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -41,6 +41,7 @@ import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Controller; +import org.springframework.validation.BindingResult; import org.springframework.web.bind.annotation.ModelAttribute; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestMethod; @@ -72,8 +73,9 @@ @Autowired private WebApplicationContext applicationContext; + @SuppressWarnings("unchecked") @RequestMapping(path = "/userorgrole") - public String execute(@ModelAttribute UserOrgRoleForm userOrgRoleForm, HttpServletRequest request) + public String execute(@ModelAttribute UserOrgRoleForm userOrgRoleForm, BindingResult result, HttpServletRequest request) throws Exception { service = AdminServiceProxy.getService(applicationContext.getServletContext()); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java (.../UserOrgRoleSaveController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java (.../UserOrgRoleSaveController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -90,12 +90,8 @@ log.debug("orgId: " + orgId); request.setAttribute("org", orgId); - request.getSession().removeAttribute("UserOrgRoleForm"); + request.getSession().removeAttribute("userOrgRoleForm"); - if (request.getAttribute("CANCEL") != null) { - return "redirect:/usermanage.do"; - } - // save UserOrganisation memberships, and the associated roles; // for subgroups, if user is not a member of the parent group then add to that as well. for (int i = 0; i < userBeans.size(); i++) { Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgSaveController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgSaveController.java (.../UserOrgSaveController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgSaveController.java (.../UserOrgSaveController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -70,7 +70,7 @@ @Autowired private WebApplicationContext applicationContext; - @RequestMapping(path = "/userorgsave", method = RequestMethod.POST) + @RequestMapping(path = "/userorgsave") public String execute(@ModelAttribute UserOrgForm userOrgForm, HttpServletRequest request, HttpServletResponse response) throws Exception { @@ -137,7 +137,7 @@ organisation.getOrganisationType())); request.setAttribute("newUserOrganisations", newUserOrganisations); request.setAttribute("orgId", orgId); - return "redirect:/userorgrole.do"; + return "forward:/userorgrole.do"; } } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesController.java =================================================================== diff -u -r198db26e45c4083d69e39fcd40ffed3f7918fc58 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesController.java (.../UserRolesController.java) (revision 198db26e45c4083d69e39fcd40ffed3f7918fc58) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesController.java (.../UserRolesController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -155,11 +155,10 @@ i++; } } else { - Errors messages = null; - messages.reject("roles", messageService.getMessage("msg.add.to.org", org.getName())); + errorMap.add("roles", messageService.getMessage("msg.add.to.org", org.getName())); } userRolesForm.setRoles(roles); - + request.setAttribute("errorMap", errorMap); return "userrole"; } Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserSaveController.java =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserSaveController.java (.../UserSaveController.java) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserSaveController.java (.../UserSaveController.java) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -119,7 +119,7 @@ } User user = null; - if (userId != 0) { + if (userId != null) { edit = true; user = (User) UserSaveController.service.findById(User.class, userId); } @@ -232,20 +232,20 @@ if (errorMap.isEmpty()) { if ((orgId == null) || (orgId == 0)) { - return "redirect:../usersearch.do"; + return "redirect:/usersearch.do"; } if (edit) { request.setAttribute("org", orgId); - return "redirect:../usermanage.do"; + return "redirect:/usermanage.do"; } else { request.setAttribute("orgId", orgId); request.setAttribute("userId", user.getUserId()); - return "redirect:../userroles.do"; + return "redirect:/userroles.do"; } } else { request.setAttribute("orgId", orgId); request.setAttribute("errorMap", errorMap); - return "forward:../user/edit.do"; + return "forward:/user/edit.do"; } } @@ -255,6 +255,7 @@ UserSaveController.service = AdminServiceProxy.getService(applicationContext.getServletContext()); Integer userId = WebUtil.readIntParam(request, "userId", true); + userForm.setUserId(userId); ISecurityService securityService = AdminServiceProxy.getSecurityService(applicationContext.getServletContext()); Integer loggeduserId = ((UserDTO) SessionManager.getSession().getAttribute(AttributeNames.USER)).getUserID(); @@ -287,7 +288,7 @@ user.setSalt(salt); user.setPassword(passwordHash); UserSaveController.service.saveUser(user); - return "redirect:../user/edit.do"; + return "forward:/user/edit.do"; } request.setAttribute("errorMap", errorMap); return "userChangePass"; Index: lams_admin/web/import/importexcel.jsp =================================================================== diff -u -r472fb979e3afdb43a7d537e588c5204554ba9f38 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/import/importexcel.jsp (.../importexcel.jsp) (revision 472fb979e3afdb43a7d537e588c5204554ba9f38) +++ lams_admin/web/import/importexcel.jsp (.../importexcel.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -54,6 +54,7 @@ + Index: lams_admin/web/organisation/list.jsp =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/organisation/list.jsp (.../list.jsp) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/web/organisation/list.jsp (.../list.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -147,7 +147,7 @@ - " /> +   Index: lams_admin/web/user.jsp =================================================================== diff -u -r79b6147f263fbc3c92e2db7d98227fa8f7358851 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/user.jsp (.../user.jsp) (revision 79b6147f263fbc3c92e2db7d98227fa8f7358851) +++ lams_admin/web/user.jsp (.../user.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -501,12 +501,12 @@
- +
- + " />
Index: lams_admin/web/userChangePass.jsp =================================================================== diff -u -r198db26e45c4083d69e39fcd40ffed3f7918fc58 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/userChangePass.jsp (.../userChangePass.jsp) (revision 198db26e45c4083d69e39fcd40ffed3f7918fc58) +++ lams_admin/web/userChangePass.jsp (.../userChangePass.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -85,8 +85,8 @@ -
- + +
Index: lams_admin/web/userorg.jsp =================================================================== diff -u -r79b6147f263fbc3c92e2db7d98227fa8f7358851 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/userorg.jsp (.../userorg.jsp) (revision 79b6147f263fbc3c92e2db7d98227fa8f7358851) +++ lams_admin/web/userorg.jsp (.../userorg.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -168,15 +168,6 @@

- <%-- Error Messages --%> - - - - - - - -
Index: lams_admin/web/userorgrole.jsp =================================================================== diff -u -r79b6147f263fbc3c92e2db7d98227fa8f7358851 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/userorgrole.jsp (.../userorgrole.jsp) (revision 79b6147f263fbc3c92e2db7d98227fa8f7358851) +++ lams_admin/web/userorgrole.jsp (.../userorgrole.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -2,9 +2,10 @@ <%@ include file="/taglibs.jsp"%> + - + ${title} @@ -16,69 +17,73 @@ + ${title}: - -

- - : " class="btn btn-default"> - - - : userorgmanage.do?org=" class="btn btn-default"> - - - - : " class="btn btn-default"> - - - -

- -

- - - - - + +

+ + : " class="btn btn-default"> + + + : userorgmanage.do?org=" class="btn btn-default"> + + + + : " class="btn btn-default"> + + + +

+ +

+ + + + +
+ + + + + + + - - - - - - - + + - - - - - -
" + onclick="toggleCheckboxes(, this);" + onkeyup="toggleCheckboxes(, this);" />  + role.
  - role.
+ * + - * +   -   -
- -

-
- -
- - " /> -
+ + + + + +

+
+ +
+ + " /> +
-
+ +
Index: lams_admin/web/userrole.jsp =================================================================== diff -u -rec30ad2cd8a7b048f296533bcb70fdafd80a3be6 -rc9e22b65129fe7561d7e66f5d6338557b0f3236a --- lams_admin/web/userrole.jsp (.../userrole.jsp) (revision ec30ad2cd8a7b048f296533bcb70fdafd80a3be6) +++ lams_admin/web/userrole.jsp (.../userrole.jsp) (revision c9e22b65129fe7561d7e66f5d6338557b0f3236a) @@ -65,7 +65,7 @@
:
- + role.