Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java
===================================================================
diff -u -rf2d64fc903d09f04b37223c41e8d5a18fa0d35eb -rd4f878f99390e0f6405420dc960cfefe3e87aa97
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java (.../GradeBookService.java) (revision f2d64fc903d09f04b37223c41e8d5a18fa0d35eb)
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java (.../GradeBookService.java) (revision d4f878f99390e0f6405420dc960cfefe3e87aa97)
@@ -468,7 +468,7 @@
status = "";
} else if (learnerProgress.getAttemptedActivities() != null
&& learnerProgress.getAttemptedActivities().size() > 0) {
- status = "
";
+ status = "
";
}
}
return status;
@@ -486,7 +486,7 @@
if (learnerProgress != null) {
byte statusByte = learnerProgress.getProgressState(activity);
if (statusByte == LearnerProgress.ACTIVITY_ATTEMPTED) {
- return "
";
+ return "
";
} else if (statusByte == LearnerProgress.ACTIVITY_COMPLETED) {
return "
";
}
Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java
===================================================================
diff -u -rf2d64fc903d09f04b37223c41e8d5a18fa0d35eb -rd4f878f99390e0f6405420dc960cfefe3e87aa97
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java (.../GradeBookAction.java) (revision f2d64fc903d09f04b37223c41e8d5a18fa0d35eb)
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java (.../GradeBookAction.java) (revision d4f878f99390e0f6405420dc960cfefe3e87aa97)
@@ -129,7 +129,9 @@
if (learner != null) {
gradeBookActivityDTOs = gradeBookService.getGBActivityRowsForLearner(lesson, learner);
} else {
- // TODO: handle error
+ // return null and the grid will report the error
+ logger.error("No learner found for: " + login);
+ return null;
}
} else if (method.equals("activityView")) {
gradeBookActivityDTOs = gradeBookService.getGBActivityRowsForLesson(lesson);
@@ -164,7 +166,7 @@
PrintWriter out = response.getWriter();
out.print(ret);
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
@@ -216,7 +218,9 @@
if(activity != null) {
gradeBookUserDTOs = gradeBookService.getGBUserRowsForActivity(lesson, activity);
} else {
- // TODO: handle error
+ // return null and the grid will report an error
+ logger.error("No activity found for: " + activityID);
+ return null;
}
}
@@ -267,7 +271,7 @@
PrintWriter out = response.getWriter();
out.print(ret);
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java
===================================================================
diff -u -rf2d64fc903d09f04b37223c41e8d5a18fa0d35eb -rd4f878f99390e0f6405420dc960cfefe3e87aa97
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java (.../GradeBookMonitoringAction.java) (revision f2d64fc903d09f04b37223c41e8d5a18fa0d35eb)
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java (.../GradeBookMonitoringAction.java) (revision d4f878f99390e0f6405420dc960cfefe3e87aa97)
@@ -143,7 +143,7 @@
}
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
}
@@ -197,7 +197,7 @@
}
} else {
- // TODO: handle error
+ logger.error("Lesson or activity missing for lesson: " + lessonID + "and activity: " + activityID);
}
return null;
}
Index: lams_central/web/gradebook/gradeBookMonitor.jsp
===================================================================
diff -u -r47101746bff31dacb65b68c23f4c75ff8f5f4933 -rd4f878f99390e0f6405420dc960cfefe3e87aa97
--- lams_central/web/gradebook/gradeBookMonitor.jsp (.../gradeBookMonitor.jsp) (revision 47101746bff31dacb65b68c23f4c75ff8f5f4933)
+++ lams_central/web/gradebook/gradeBookMonitor.jsp (.../gradeBookMonitor.jsp) (revision d4f878f99390e0f6405420dc960cfefe3e87aa97)
@@ -25,9 +25,10 @@
jQuery("#userView").jqGrid({
caption: "Learner View",
datatype: "xml",
- url: "