Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/DummyLearnerAction.java =================================================================== diff -u -r6c93a29e621c20da5662066e4be018eab3f5d17d -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/DummyLearnerAction.java (.../DummyLearnerAction.java) (revision 6c93a29e621c20da5662066e4be018eab3f5d17d) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/DummyLearnerAction.java (.../DummyLearnerAction.java) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -41,6 +41,7 @@ import org.lamsfoundation.lams.lesson.dto.LessonDTO; import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.action.LamsDispatchAction; +import org.lamsfoundation.lams.web.util.AttributeNames; /** @@ -144,7 +145,7 @@ //get user and lesson based on request. Integer learner = LearningWebUtil.getUserId(); - long lessonID = WebUtil.readLongParam(request,LearningWebUtil.PARAM_LESSON_ID); + long lessonID = WebUtil.readLongParam(request,AttributeNames.PARAM_LESSON_ID); if(log.isDebugEnabled()) Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/GroupingAction.java =================================================================== diff -u -r4f63e229406635f45a2a98726c9c47e554210e01 -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/GroupingAction.java (.../GroupingAction.java) (revision 4f63e229406635f45a2a98726c9c47e554210e01) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/GroupingAction.java (.../GroupingAction.java) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -46,6 +46,7 @@ import org.lamsfoundation.lams.learningdesign.GroupingActivity; import org.lamsfoundation.lams.lesson.LearnerProgress; import org.lamsfoundation.lams.web.action.LamsDispatchAction; +import org.lamsfoundation.lams.web.util.AttributeNames; /** @@ -158,7 +159,7 @@ groups.addAll(grouping.getGroups()); request.getSession().setAttribute(GROUPS,groups); - request.setAttribute(LearningWebUtil.PARAM_ACTIVITY_ID, activity.getActivityId()); + request.setAttribute(AttributeNames.PARAM_ACTIVITY_ID, activity.getActivityId()); return mapping.findForward(SHOW_GROUP); } Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/LearnerAction.java =================================================================== diff -u -r6c93a29e621c20da5662066e4be018eab3f5d17d -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/LearnerAction.java (.../LearnerAction.java) (revision 6c93a29e621c20da5662066e4be018eab3f5d17d) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/LearnerAction.java (.../LearnerAction.java) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -146,7 +146,7 @@ //get user and lesson based on request. Integer learner = LearningWebUtil.getUserId(); - long lessonID = WebUtil.readLongParam(request,LearningWebUtil.PARAM_LESSON_ID); + long lessonID = WebUtil.readLongParam(request,AttributeNames.PARAM_LESSON_ID); if(log.isDebugEnabled()) @@ -361,7 +361,7 @@ try { //get parameter - long activityId = WebUtil.readLongParam(request,LearningWebUtil.PARAM_ACTIVITY_ID); + long activityId = WebUtil.readLongParam(request,AttributeNames.PARAM_ACTIVITY_ID); //initialize service object ActivityMapping activityMapping = LearnerServiceProxy.getActivityMapping(this.getServlet().getServletContext()); Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java =================================================================== diff -u -r2b6827b06455b7269c88062bd218427529ee0a4c -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision 2b6827b06455b7269c88062bd218427529ee0a4c) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java (.../ActivityMapping.java) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -38,16 +38,15 @@ import org.lamsfoundation.lams.learning.service.ILearnerService; import org.lamsfoundation.lams.learning.service.LearnerServiceException; import org.lamsfoundation.lams.learningdesign.Activity; -import org.lamsfoundation.lams.learningdesign.ParallelActivity; import org.lamsfoundation.lams.learningdesign.ToolActivity; import org.lamsfoundation.lams.lesson.LearnerProgress; -import org.lamsfoundation.lams.tool.ToolAccessMode; import org.lamsfoundation.lams.tool.exception.LamsToolServiceException; import org.lamsfoundation.lams.tool.service.ILamsCoreToolService; import org.lamsfoundation.lams.usermanagement.User; import org.lamsfoundation.lams.util.Configuration; import org.lamsfoundation.lams.util.ConfigurationKeys; import org.lamsfoundation.lams.util.WebUtil; +import org.lamsfoundation.lams.web.util.AttributeNames; /** * This class contains the standard struts action mappings for errors as @@ -321,8 +320,9 @@ if (activity != null) { - url += url.indexOf("?") > -1 ? "&" : "?"; - url += "activityId=" + activity.getActivityId(); + url = WebUtil.appendParameterToURL(url, + AttributeNames.PARAM_ACTIVITY_ID, + activity.getActivityId().toString()); } if (useContext) { Index: lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/LearningWebUtil.java =================================================================== diff -u -r6c93a29e621c20da5662066e4be018eab3f5d17d -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/LearningWebUtil.java (.../LearningWebUtil.java) (revision 6c93a29e621c20da5662066e4be018eab3f5d17d) +++ lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/LearningWebUtil.java (.../LearningWebUtil.java) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -53,9 +53,7 @@ //--------------------------------------------------------------------- // Class level constants - session attributes //--------------------------------------------------------------------- - public static final String PARAM_LESSON_ID = "lessonId"; - public static final String PARAM_ACTIVITY_ID = "activityId"; - public static final String PARAM_PROGRESS_ID = "progressId"; + public static final String PARAM_PROGRESS_ID = "progressID"; /** * Helper method to retrieve the user data. Gets the id from the user details @@ -84,12 +82,12 @@ public static Long getLessonId(HttpServletRequest request) { HttpSession ss = SessionManager.getSession(); - Long lessonId = (Long)ss.getAttribute(PARAM_LESSON_ID); + Long lessonId = (Long)ss.getAttribute(AttributeNames.PARAM_LESSON_ID); if(lessonId ==null) { // not in the session - is it in the request? - lessonId = WebUtil.readLongParam(request,PARAM_LESSON_ID,true); + lessonId = WebUtil.readLongParam(request,AttributeNames.PARAM_LESSON_ID,true); } return lessonId; } @@ -108,9 +106,9 @@ { HttpSession ss = SessionManager.getSession(); if ( lessonId != null ) { - ss.setAttribute(PARAM_LESSON_ID, lessonId); + ss.setAttribute(AttributeNames.PARAM_LESSON_ID, lessonId); } else { - ss.removeAttribute(PARAM_LESSON_ID); + ss.removeAttribute(AttributeNames.PARAM_LESSON_ID); } } @@ -183,7 +181,7 @@ if(activity == null) { - long activityId = WebUtil.readLongParam(request,PARAM_ACTIVITY_ID); + long activityId = WebUtil.readLongParam(request,AttributeNames.PARAM_ACTIVITY_ID); activity = learnerService.getActivity(new Long(activityId)); Index: lams_learning/web/WEB-INF/struts/struts-config.xml =================================================================== diff -u -r57e83f8443e586e862dae836429599459eade2c0 -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/web/WEB-INF/struts/struts-config.xml (.../struts-config.xml) (revision 57e83f8443e586e862dae836429599459eade2c0) +++ lams_learning/web/WEB-INF/struts/struts-config.xml (.../struts-config.xml) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -118,15 +118,20 @@ scope="request" /> + - - + + - + + + + + + Index: lams_learning/web/dummyControlFrame.jsp =================================================================== diff -u -r440554bb4a9a414c6e3e676a93de72de3298951c -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/web/dummyControlFrame.jsp (.../dummyControlFrame.jsp) (revision 440554bb4a9a414c6e3e676a93de72de3298951c) +++ lams_learning/web/dummyControlFrame.jsp (.../dummyControlFrame.jsp) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -69,7 +69,7 @@
-
&lessonId=" target="contentFrame">Participate +
&lessonID=" target="contentFrame">Participate
exportWaitingPage.jsp?mode=learner&lessonID=');>Export Portfolio
Index: lams_learning/web/grouping/show.jsp =================================================================== diff -u -r4f63e229406635f45a2a98726c9c47e554210e01 -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/web/grouping/show.jsp (.../show.jsp) (revision 4f63e229406635f45a2a98726c9c47e554210e01) +++ lams_learning/web/grouping/show.jsp (.../show.jsp) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -27,7 +27,7 @@
- +

Index: lams_learning/web/optionsActivity.jsp =================================================================== diff -u -r66f147e9d94ea10fa2c2cea70a78d6479096ddc7 -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/web/optionsActivity.jsp (.../optionsActivity.jsp) (revision 66f147e9d94ea10fa2c2cea70a78d6479096ddc7) +++ lams_learning/web/optionsActivity.jsp (.../optionsActivity.jsp) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -30,7 +30,7 @@ var form = document.forms[0]; var elements = form.elements; for (var i = 0; i < elements.length; i++) { - if (elements[i].name == "activityId") { + if (elements[i].name == "activityID") { if (elements[i].checked) { validated = true; break; @@ -109,7 +109,7 @@ <%--html:img page="/images/tick.gif" /--%> - " /> @@ -156,7 +156,7 @@ - " /> + " /> Index: lams_learning/web/requestURL.jsp =================================================================== diff -u -r2b6827b06455b7269c88062bd218427529ee0a4c -rdf5800a31c32417e062928bfca21c1b2c2ed1472 --- lams_learning/web/requestURL.jsp (.../requestURL.jsp) (revision 2b6827b06455b7269c88062bd218427529ee0a4c) +++ lams_learning/web/requestURL.jsp (.../requestURL.jsp) (revision df5800a31c32417e062928bfca21c1b2c2ed1472) @@ -33,9 +33,6 @@ - <%--c:if test="${empty activityId}"> - -