Index: lams_common/src/java/org/lamsfoundation/lams/tool/service/ICommonAssessmentService.java =================================================================== diff -u -r3085af1c7e3e6c3496af23a748d998886d7168fd -re581d656fb9eae279adb11f28b8419fd49cd05c2 --- lams_common/src/java/org/lamsfoundation/lams/tool/service/ICommonAssessmentService.java (.../ICommonAssessmentService.java) (revision 3085af1c7e3e6c3496af23a748d998886d7168fd) +++ lams_common/src/java/org/lamsfoundation/lams/tool/service/ICommonAssessmentService.java (.../ICommonAssessmentService.java) (revision e581d656fb9eae279adb11f28b8419fd49cd05c2) @@ -18,14 +18,9 @@ /** * Returns VS answers which require allocation for the given activity */ - Map> getUnallocatedVSAnswersForActivity(long toolContentId); + Map> getUnallocatedVSAnswers(long toolContentId); /** - * Returns VS answers which require allocation for the given tool question ID - */ - Map getUnallocatedVSAnswersForQuestion(long toolQuestionUid); - - /** * Counts how many questions were answered correctly by the given user, regardless of the mark given. * Currently it only works for MCQ and mark hedging questions. */ Index: lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java =================================================================== diff -u -r3085af1c7e3e6c3496af23a748d998886d7168fd -re581d656fb9eae279adb11f28b8419fd49cd05c2 --- lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java (.../LamsToolService.java) (revision 3085af1c7e3e6c3496af23a748d998886d7168fd) +++ lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java (.../LamsToolService.java) (revision e581d656fb9eae279adb11f28b8419fd49cd05c2) @@ -538,7 +538,7 @@ if (tool.getToolSignature().equals(CommonConstants.TOOL_SIGNATURE_ASSESSMENT)) { ICommonAssessmentService sessionManager = (ICommonAssessmentService) lamsCoreToolService .findToolService(tool); - return sessionManager.getUnallocatedVSAnswersForActivity(toolContentId); + return sessionManager.getUnallocatedVSAnswers(toolContentId); } return null; } Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java =================================================================== diff -u -r3085af1c7e3e6c3496af23a748d998886d7168fd -re581d656fb9eae279adb11f28b8419fd49cd05c2 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java (.../AssessmentServiceImpl.java) (revision 3085af1c7e3e6c3496af23a748d998886d7168fd) +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java (.../AssessmentServiceImpl.java) (revision e581d656fb9eae279adb11f28b8419fd49cd05c2) @@ -1402,36 +1402,26 @@ } @Override - public Map> getUnallocatedVSAnswersForActivity(long toolContentId) { + public Map> getUnallocatedVSAnswers(long toolContentId) { Map> result = new LinkedHashMap<>(); Assessment assessment = getAssessmentByContentId(toolContentId); for (AssessmentQuestion question : assessment.getQuestions()) { if (question.getType().equals(QbQuestion.TYPE_VERY_SHORT_ANSWERS)) { - Map unallocatedQuestionAnswers = getUnallocatedVSAnswersForQuestion(toolContentId, - question.getUid()); + // gets mapping answer -> user ID for all answers which were not allocation into VSA option yet + QuestionSummary questionSummary = getQuestionSummary(toolContentId, question.getUid()); + Map unallocatedQuestionAnswers = questionSummary.getNotAllocatedQuestionResults() + .stream() + .collect(Collectors.toMap(AssessmentQuestionResult::getAnswer, + r -> r.getAssessmentResult().getUser().getUserId().intValue(), (user1, user2) -> user1, + LinkedHashMap::new)); result.put(question, unallocatedQuestionAnswers); } } return result; } @Override - public Map getUnallocatedVSAnswersForQuestion(long toolQuestionUid) { - AssessmentQuestion question = getAssessmentQuestionByUid(toolQuestionUid); - return getUnallocatedVSAnswersForQuestion(question.getToolContentId(), toolQuestionUid); - } - - private Map getUnallocatedVSAnswersForQuestion(long toolContentId, long toolQuestionUid) { - // gets mapping answer -> user ID for all answers which were not allocation into VSA option yet - QuestionSummary questionSummary = getQuestionSummary(toolContentId, toolQuestionUid); - return questionSummary.getNotAllocatedQuestionResults().stream() - .collect(Collectors.toMap(AssessmentQuestionResult::getAnswer, - r -> r.getAssessmentResult().getUser().getUserId().intValue(), (user1, user2) -> user1, - LinkedHashMap::new)); - } - - @Override public QuestionSummary getQuestionSummary(Long contentId, Long questionUid) { AssessmentQuestion question = assessmentQuestionDao.getByUid(questionUid); QbQuestion qbQuestion = question.getQbQuestion(); Index: lams_tool_assessment/web/pages/monitoring/parts/questionsummary.jsp =================================================================== diff -u -r8dac82ff3870ff39cd41d273bf22f290b66994c5 -re581d656fb9eae279adb11f28b8419fd49cd05c2 --- lams_tool_assessment/web/pages/monitoring/parts/questionsummary.jsp (.../questionsummary.jsp) (revision 8dac82ff3870ff39cd41d273bf22f290b66994c5) +++ lams_tool_assessment/web/pages/monitoring/parts/questionsummary.jsp (.../questionsummary.jsp) (revision e581d656fb9eae279adb11f28b8419fd49cd05c2) @@ -13,7 +13,6 @@ - @@ -53,21 +52,13 @@ COMMENT_TEXTAREA_TIP_LABEL = '', WARN_COMMENTS_IS_BLANK_LABEL = '', WARN_MIN_NUMBER_WORDS_LABEL = ''; - - //vars for VSA allocation - var VS_ANSWER_ALLOCATED_ALERT = "", - VS_ANSWER_DEALLOCATE_CONFIRM = "", - WEB_APP_URL = "", - csrfTokenName = "", - csrfTokenValue = ""; - @@ -335,12 +326,6 @@ - - -

- <%@ include file="vsaQuestionAllocate.jsp"%> -
-