Index: lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/ResourceConstants.java =================================================================== diff -u -r694dd2c529990a94c17576dce6c98e5b821532e0 -re64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4 --- lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/ResourceConstants.java (.../ResourceConstants.java) (revision 694dd2c529990a94c17576dce6c98e5b821532e0) +++ lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/ResourceConstants.java (.../ResourceConstants.java) (revision e64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4) @@ -139,8 +139,6 @@ public static final String PAGE_EDITABLE = "isPageEditable"; - public static final String MODE_AUTHOR_SESSION = "author_session"; - public static final String ATTR_REFLECTION_ON = "reflectOn"; public static final String ATTR_REFLECTION_INSTRUCTION = "reflectInstructions"; Index: lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/web/controller/ViewItemController.java =================================================================== diff -u -r0c5d2aefd17a667d8222d8f1bb8b05aa4034ed10 -re64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4 --- lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/web/controller/ViewItemController.java (.../ViewItemController.java) (revision 0c5d2aefd17a667d8222d8f1bb8b05aa4034ed10) +++ lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/web/controller/ViewItemController.java (.../ViewItemController.java) (revision e64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4) @@ -65,19 +65,28 @@ String sessionMapID = WebUtil.readStrParam(request, ResourceConstants.ATTR_SESSION_MAP_ID, true); SessionMap sessionMap = (SessionMap) request.getSession() .getAttribute(sessionMapID); - sessionMap.put(AttributeNames.ATTR_MODE, ToolAccessMode.TEACHER); - ResourceItem item = getResourceItem(request, sessionMap, ToolAccessMode.TEACHER.toString()); + String mode = request.getParameter(AttributeNames.ATTR_MODE); + if (mode.equals(ToolAccessMode.TEACHER.toString())) { + sessionMap.put(AttributeNames.ATTR_MODE, ToolAccessMode.TEACHER); + } else { + sessionMap.put(AttributeNames.ATTR_MODE, ToolAccessMode.AUTHOR); + } + ResourceItem item = getResourceItem(request, sessionMap, mode); + if (item == null) { return "error"; } Long itemUid = NumberUtils.createLong(request.getParameter(ResourceConstants.PARAM_RESOURCE_ITEM_UID)); request.setAttribute(ResourceConstants.PARAM_RESOURCE_ITEM_UID, itemUid); + Integer itemIdx = WebUtil.readIntParam(request, ResourceConstants.PARAM_ITEM_INDEX, true); + request.setAttribute(ResourceConstants.PARAM_ITEM_INDEX, itemIdx); String idStr = request.getParameter(ResourceConstants.ATTR_TOOL_SESSION_ID); Long sessionId = NumberUtils.createLong(idStr); request.setAttribute(ResourceConstants.ATTR_TOOL_SESSION_ID, sessionId); request.setAttribute(ResourceConstants.ATTR_SESSION_MAP_ID, sessionMapID); + request.setAttribute(ResourceConstants.ATTR_TITLE, item.getTitle()); return "pages/itemreview/mainframe"; } @@ -118,7 +127,6 @@ return "error"; } - Integer itemIdx = WebUtil.readIntParam(request, ResourceConstants.PARAM_ITEM_INDEX, true); String reviewUrl = getReviewUrl(item, sessionMapID); request.setAttribute(ResourceConstants.ATTR_RESOURCE_REVIEW_URL, reviewUrl); if (item.getType() == ResourceConstants.RESOURCE_TYPE_URL) { @@ -134,8 +142,10 @@ // these attribute will be use to instruction navigator page request.setAttribute(AttributeNames.ATTR_MODE, mode); - request.setAttribute(ResourceConstants.PARAM_ITEM_INDEX, itemIdx); - Long itemUid = NumberUtils.createLong(request.getParameter(ResourceConstants.PARAM_RESOURCE_ITEM_UID)); + Long itemUid = WebUtil.readLongParam(request, ResourceConstants.PARAM_RESOURCE_ITEM_UID, true); + if (itemUid == null) { + itemUid = 0L; + } request.setAttribute(ResourceConstants.PARAM_RESOURCE_ITEM_UID, itemUid); request.setAttribute(ResourceConstants.ATTR_TOOL_SESSION_ID, sessionId); request.setAttribute(ResourceConstants.ATTR_SESSION_MAP_ID, sessionMapID); @@ -177,12 +187,12 @@ private ResourceItem getResourceItem(HttpServletRequest request, SessionMap sessionMap, String mode) { ResourceItem item = null; - if (ResourceConstants.MODE_AUTHOR_SESSION.equals(mode)) { + if (ToolAccessMode.AUTHOR.toString().equals(mode)) { int itemIdx = NumberUtils.stringToInt(request.getParameter(ResourceConstants.PARAM_ITEM_INDEX), 0); // authoring: does not save item yet, so only has ItemList from session and identity by Index List resourceList = new ArrayList<>(getResourceItemList(sessionMap)); item = resourceList.get(itemIdx); - } else if ("teacher".equals(mode)) { + } else if (ToolAccessMode.TEACHER.toString().equals(mode)) { Long itemUid = NumberUtils.createLong(request.getParameter(ResourceConstants.PARAM_RESOURCE_ITEM_UID)); // get back the resource and item list and display them on page item = resourceService.getResourceItemByUid(itemUid); Index: lams_tool_larsrc/web/pages/authoring/basic.jsp =================================================================== diff -u -r326782acda142b33013dcb8a4b57ef62a5669914 -re64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4 --- lams_tool_larsrc/web/pages/authoring/basic.jsp (.../basic.jsp) (revision 326782acda142b33013dcb8a4b57ef62a5669914) +++ lams_tool_larsrc/web/pages/authoring/basic.jsp (.../basic.jsp) (revision e64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4) @@ -21,7 +21,7 @@ function previewItem(type,idx,sessionMapID){ //1:url, 2:file //This mode is special for unsaved author page. It is different with the author mode in preview - var myUrl = ""+idx+"&sessionMapID="+sessionMapID; + var myUrl = ""+idx+"&sessionMapID="+sessionMapID; launchPopup(myUrl,"Review"); } Index: lams_tool_larsrc/web/pages/authoring/parts/itemlist.jsp =================================================================== diff -u -r326782acda142b33013dcb8a4b57ef62a5669914 -re64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4 --- lams_tool_larsrc/web/pages/authoring/parts/itemlist.jsp (.../itemlist.jsp) (revision 326782acda142b33013dcb8a4b57ef62a5669914) +++ lams_tool_larsrc/web/pages/authoring/parts/itemlist.jsp (.../itemlist.jsp) (revision e64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4) @@ -14,7 +14,7 @@ - <%-- Resource Type:1=URL,2=File,3=Website,4=Learning Object --%> + <%-- Resource Type:1=URL,2=File--%> + key="label.authoring.basic.resource.preview" /> @@ -34,7 +34,7 @@ key="label.authoring.basic.resource.file" /> : - + Index: lams_tool_larsrc/web/pages/itemreview/mainframe.jsp =================================================================== diff -u -r0c5d2aefd17a667d8222d8f1bb8b05aa4034ed10 -re64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4 --- lams_tool_larsrc/web/pages/itemreview/mainframe.jsp (.../mainframe.jsp) (revision 0c5d2aefd17a667d8222d8f1bb8b05aa4034ed10) +++ lams_tool_larsrc/web/pages/itemreview/mainframe.jsp (.../mainframe.jsp) (revision e64e0e3ca5c8b2f090ffc15cb9c8346f0cbe2ca4) @@ -24,7 +24,7 @@