Index: lams_build/lib/lams/lams-central.jar =================================================================== diff -u -rba8161c819a6b07a7deb68a5fe9344304b0b5524 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 Binary files differ Index: lams_build/lib/lams/lams.jar =================================================================== diff -u -r1fe0f4f546903187be6f35e4d5c027853da9408c -re66bdae723516ab13d4a6f81e5f598018f6dbe58 Binary files differ Index: lams_build/lib/pedagogical_planner/1/1/1/LAMS_Pedagogical_Planner_Template.zip =================================================================== diff -u -r1f477181cf09a7f9e0a4c38845b81dc075361413 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 Binary files differ Index: lams_central/conf/language/lams/ApplicationResources.properties =================================================================== diff -u -ra301da49ef54944c21a4c78c60a2637959be30b5 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision a301da49ef54944c21a4c78c60a2637959be30b5) +++ lams_central/conf/language/lams/ApplicationResources.properties (.../ApplicationResources.properties) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -243,5 +243,6 @@ error.planner.grouping.number.integer=Provided value must be a positive integer number. label.planner.grouping.equal.group.size=Equal group sizes +label.planner.editing.advice=Editing advice msg.planner.not.saved =Are you sure you want to close? If you have not saved the design, changes you have made will be lost. #======= End labels: Exported 216 labels for en AU ===== Index: lams_central/conf/language/lams/ApplicationResources_en_AU.properties =================================================================== diff -u -re6cd187fcc661f696fa9432032dc7ceec7f41d42 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision e6cd187fcc661f696fa9432032dc7ceec7f41d42) +++ lams_central/conf/language/lams/ApplicationResources_en_AU.properties (.../ApplicationResources_en_AU.properties) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -243,12 +243,12 @@ error.planner.grouping.number.integer=Provided value must be a positive integer number. label.planner.grouping.equal.group.size=Equal group sizes msg.planner.not.saved =Are you sure you want to close? If you have not saved the design, changes you have made will be lost. +label.planner.editing.advice=Editing advice label.lamscommunity.message =Login to lamscommunity.org label.lamscommunity.login =lamscommunity.org login: label.lamscommunity.password =lamscommunity.org password: index.lamscommunity =LAMS Community label.lamscommunity.changeuser =Stop using lamscommunity.org user {0} lamscommunity.login.failed =Login to lamscommunity.org failed, please try again. - #======= End labels: Exported 216 labels for en AU ===== Index: lams_central/src/java/org/lamsfoundation/lams/authoring/dto/PedagogicalPlannerActivityDTO.java =================================================================== diff -u -r05db875c7974d705f89231416ff6dfe91a5e70f1 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/src/java/org/lamsfoundation/lams/authoring/dto/PedagogicalPlannerActivityDTO.java (.../PedagogicalPlannerActivityDTO.java) (revision 05db875c7974d705f89231416ff6dfe91a5e70f1) +++ lams_central/src/java/org/lamsfoundation/lams/authoring/dto/PedagogicalPlannerActivityDTO.java (.../PedagogicalPlannerActivityDTO.java) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -25,10 +25,11 @@ public class PedagogicalPlannerActivityDTO { private String pedagogicalPlannerUrl; - private Long toolContentID; private String toolIconUrl; private String title; private String type; + private String editingAdviceUrl; + private String checkEditingAdviceUrl; public String getPedagogicalPlannerUrl() { return pedagogicalPlannerUrl; @@ -38,19 +39,12 @@ pedagogicalPlannerUrl = toolSignature; } - public Long getToolContentID() { - return toolContentID; - } - - public void setToolContentID(Long toolContentID) { - this.toolContentID = toolContentID; - } - - public PedagogicalPlannerActivityDTO(Long toolContentID, String type, String title, String pedagogicalPlannerUrl, - String toolIconUrl) { + public PedagogicalPlannerActivityDTO(String type, String title, String pedagogicalPlannerUrl, String toolIconUrl, + String checkEditingAdviceUrl, String editingAdviceUrl) { this.pedagogicalPlannerUrl = pedagogicalPlannerUrl; - this.toolContentID = toolContentID; this.toolIconUrl = toolIconUrl; + this.checkEditingAdviceUrl = checkEditingAdviceUrl; + this.editingAdviceUrl = editingAdviceUrl; this.title = title; this.type = type; } @@ -78,4 +72,20 @@ public void setType(String type) { this.type = type; } + + public String getEditingAdviceUrl() { + return editingAdviceUrl; + } + + public void setEditingAdviceUrl(String editingAdviceUrl) { + this.editingAdviceUrl = editingAdviceUrl; + } + + public String getCheckEditingAdviceUrl() { + return checkEditingAdviceUrl; + } + + public void setCheckEditingAdviceUrl(String checkEditingAdviceUrl) { + this.checkEditingAdviceUrl = checkEditingAdviceUrl; + } } \ No newline at end of file Index: lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java =================================================================== diff -u -rc234c64ad9ff9d713f6d8e3331d0c20075e49303 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java (.../IndexAction.java) (revision c234c64ad9ff9d713f6d8e3331d0c20075e49303) +++ lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java (.../IndexAction.java) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -71,7 +71,6 @@ * @struts.action-forward name="passwordChanged" path=".passwordChangeOk" * @struts.action-forward name="portrait" path="/portrait.do" * @struts.action-forward name="lessons" path="/profile.do?method=lessons" - * @struts.action-forward name="planner" path="/pedagogicalPlanner.do" */ public class IndexAction extends Action { @@ -143,7 +142,7 @@ private void setHeaderLinks(HttpServletRequest request) { List headerLinks = new ArrayList(); if (request.isUserInRole(Role.AUTHOR) || request.isUserInRole(Role.AUTHOR_ADMIN)) { - headerLinks.add(new IndexLinkBean("index.planner", "index.do?tab=planner")); + headerLinks.add(new IndexLinkBean("index.planner", "javascript:openPedagogicalPlanner()")); headerLinks.add(new IndexLinkBean("index.author", "javascript:openAuthor()")); } headerLinks.add(new IndexLinkBean("index.myprofile", "index.do?tab=profile")); Index: lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java =================================================================== diff -u -rda2924f4d15aa5587ed5e5dc7152b850994bdd87 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java (.../PedagogicalPlannerAction.java) (revision da2924f4d15aa5587ed5e5dc7152b850994bdd87) +++ lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java (.../PedagogicalPlannerAction.java) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -81,6 +81,9 @@ */ public class PedagogicalPlannerAction extends LamsDispatchAction { + private static final String CHAR_QUESTION_MARK = "?"; + private static final char CHAR_AMPERSAND = '&'; + private static final char CHAR_EQUALS = '='; private static IUserManagementService userManagementService; private static IExportToolContentService exportService; private static IAuthoringService authoringService; @@ -137,51 +140,76 @@ // create DTO that holds all the necessary information of the activities int activitySupportingPlannerCount = 0; Activity activity = learningDesign.getFirstActivity(); + int activityIndex = 1; while (activity != null) { boolean activitySupportsPlanner = false; boolean activityAdded = false; if (activity.isToolActivity()) { ToolActivity toolActivity = (ToolActivity) activity; String pedagogicalPlannerUrl = toolActivity.getTool().getPedagogicalPlannerUrl(); if (pedagogicalPlannerUrl == null) { - activitites.add(new PedagogicalPlannerActivityDTO(toolActivity.getToolContentId(), toolActivity - .getTool().getToolDisplayName(), activity.getTitle(), - CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT + "?", activity - .getLibraryActivityUiImage())); + activitites.add(new PedagogicalPlannerActivityDTO(toolActivity.getTool().getToolDisplayName(), + activity.getTitle(), CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT, activity + .getLibraryActivityUiImage(), null, null)); } else { - pedagogicalPlannerUrl += pedagogicalPlannerUrl.contains("?") ? '&' : '?'; - activitites.add(new PedagogicalPlannerActivityDTO(toolActivity.getToolContentId(), toolActivity - .getTool().getToolDisplayName(), activity.getTitle(), pedagogicalPlannerUrl, activity - .getLibraryActivityUiImage())); + pedagogicalPlannerUrl += pedagogicalPlannerUrl + .contains(PedagogicalPlannerAction.CHAR_QUESTION_MARK) ? PedagogicalPlannerAction.CHAR_AMPERSAND + : PedagogicalPlannerAction.CHAR_QUESTION_MARK; + pedagogicalPlannerUrl += AttributeNames.PARAM_TOOL_CONTENT_ID + + PedagogicalPlannerAction.CHAR_EQUALS + toolActivity.getToolContentId(); + activitites + .add(new PedagogicalPlannerActivityDTO(toolActivity.getTool().getToolDisplayName(), + activity.getTitle(), pedagogicalPlannerUrl + + PedagogicalPlannerAction.CHAR_AMPERSAND + + AttributeNames.PARAM_CONTENT_FOLDER_ID + + PedagogicalPlannerAction.CHAR_EQUALS + + learningDesign.getContentFolderID(), + activity.getLibraryActivityUiImage(), pedagogicalPlannerUrl + + PedagogicalPlannerAction.CHAR_AMPERSAND + AttributeNames.PARAM_COMMAND + + PedagogicalPlannerAction.CHAR_EQUALS + + AttributeNames.COMMAND_CHECK_EDITING_ADVICE + + PedagogicalPlannerAction.CHAR_AMPERSAND + + AttributeNames.PARAM_ACTIVITY_INDEX + + PedagogicalPlannerAction.CHAR_EQUALS + activityIndex, + pedagogicalPlannerUrl + PedagogicalPlannerAction.CHAR_AMPERSAND + + AttributeNames.PARAM_COMMAND + PedagogicalPlannerAction.CHAR_EQUALS + + AttributeNames.COMMAND_GET_EDITING_ADVICE)); activitySupportsPlanner = true; } activityAdded = true; } else if (activity.isGroupingActivity()) { GroupingActivity groupingActivity = (GroupingActivity) activity; - activitites.add(new PedagogicalPlannerActivityDTO(groupingActivity.getCreateGrouping().getGroupingId(), - null, activity.getTitle(), groupingActivity.getSystemTool().getPedagogicalPlannerUrl() + "&", - CentralConstants.IMAGE_PATH_GROUPING)); + activitites.add(new PedagogicalPlannerActivityDTO(null, activity.getTitle(), groupingActivity + .getSystemTool().getPedagogicalPlannerUrl() + + PedagogicalPlannerAction.CHAR_AMPERSAND + + AttributeNames.PARAM_TOOL_CONTENT_ID + + PedagogicalPlannerAction.CHAR_EQUALS + groupingActivity.getCreateGrouping().getGroupingId(), + CentralConstants.IMAGE_PATH_GROUPING, null, null)); activitySupportsPlanner = true; activityAdded = true; } else if (activity.isGateActivity()) { - activitites.add(new PedagogicalPlannerActivityDTO(null, null, activity.getTitle(), - CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT + "?", CentralConstants.IMAGE_PATH_GATE)); + activitites + .add(new PedagogicalPlannerActivityDTO(null, activity.getTitle(), + CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT, CentralConstants.IMAGE_PATH_GATE, + null, null)); activityAdded = true; } if (activitySupportsPlanner) { activitySupportingPlannerCount++; } if (!activityAdded) { - activitites.add(new PedagogicalPlannerActivityDTO(null, null, activity.getTitle(), - CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT + "?", activity.getLibraryActivityUiImage())); + activitites.add(new PedagogicalPlannerActivityDTO(null, activity.getTitle(), + CentralConstants.PATH_ACTIVITY_NO_PLANNER_SUPPORT, activity.getLibraryActivityUiImage(), null, + null)); } Transition transitionTo = activity.getTransitionTo(); if (transitionTo == null) { activity = null; } else { activity = transitionTo.getToActivity(); } + activityIndex++; } // Set other properties PedagogicalPlannerDTO planner = new PedagogicalPlannerDTO(); @@ -319,7 +347,8 @@ getMonitoringService().startLesson(lesson.getLessonId(), userDto.getUserID()); String newPath = mapping.findForward("preview").getPath(); - newPath = newPath + '&' + AttributeNames.PARAM_LESSON_ID + '=' + lesson.getLessonId(); + newPath = newPath + PedagogicalPlannerAction.CHAR_AMPERSAND + AttributeNames.PARAM_LESSON_ID + + PedagogicalPlannerAction.CHAR_EQUALS + lesson.getLessonId(); return new ActionForward(newPath, true); } } \ No newline at end of file Index: lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerForm.java =================================================================== diff -u -rda2924f4d15aa5587ed5e5dc7152b850994bdd87 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerForm.java (.../PedagogicalPlannerForm.java) (revision da2924f4d15aa5587ed5e5dc7152b850994bdd87) +++ lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerForm.java (.../PedagogicalPlannerForm.java) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -36,7 +36,7 @@ * @author Marcin Cieslak * */ -public class PedagogicalPlannerForm extends ActionForm { +public abstract class PedagogicalPlannerForm extends ActionForm { /** * Set when opening a Learning Design. */ @@ -50,10 +50,6 @@ * Set when submitting form in base.jsp page. */ private Integer callID; - /** - * Should the form contain tooltip with online instructions? - */ - private Boolean editingAdviceAvailable; public Long getToolContentID() { return toolContentID; @@ -103,12 +99,4 @@ public void setActivityOrderNumber(Integer activityOrderNumber) { this.activityOrderNumber = activityOrderNumber; } - - public Boolean getEditingAdviceAvailable() { - return editingAdviceAvailable; - } - - public void setEditingAdviceAvailable(Boolean editingAdviceAvailable) { - this.editingAdviceAvailable = editingAdviceAvailable; - } } \ No newline at end of file Fisheye: Tag e66bdae723516ab13d4a6f81e5f598018f6dbe58 refers to a dead (removed) revision in file `lams_central/web/css/jTip.css'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/css/jquery.cluetip.css =================================================================== diff -u -r1f477181cf09a7f9e0a4c38845b81dc075361413 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/web/css/jquery.cluetip.css (.../jquery.cluetip.css) (revision 1f477181cf09a7f9e0a4c38845b81dc075361413) +++ lams_central/web/css/jquery.cluetip.css (.../jquery.cluetip.css) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -227,9 +227,4 @@ .cluetip-rounded #cluetip-title, .cluetip-rounded #cluetip-inner { zoom: 1; -} - -a#editingAdvice{ - float: right; - margin-right: 30px; } \ No newline at end of file Index: lams_central/web/css/pedagogicalPlanner.css =================================================================== diff -u -r0cf0add4991151d21aeac41ddca7a40e76dc78f6 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/web/css/pedagogicalPlanner.css (.../pedagogicalPlanner.css) (revision 0cf0add4991151d21aeac41ddca7a40e76dc78f6) +++ lams_central/web/css/pedagogicalPlanner.css (.../pedagogicalPlanner.css) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -59,4 +59,10 @@ div#pedagogicalPlannerErrorArea{ margin-bottom: 20px; width: 60%; +} + +a.editingAdvice{ + display: none; + font-size: smaller; + margin: 0px 0px 0px 500px; } \ No newline at end of file Fisheye: Tag e66bdae723516ab13d4a6f81e5f598018f6dbe58 refers to a dead (removed) revision in file `lams_central/web/includes/javascript/jtip.js'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/main.jsp =================================================================== diff -u -r65b2816b6b46b51ef66de7ed0df1969fc9b80b88 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/web/main.jsp (.../main.jsp) (revision 65b2816b6b46b51ef66de7ed0df1969fc9b80b88) +++ lams_central/web/main.jsp (.../main.jsp) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -187,9 +187,6 @@ - - - Index: lams_central/web/pedagogical_planner/base.jsp =================================================================== diff -u -ra301da49ef54944c21a4c78c60a2637959be30b5 -re66bdae723516ab13d4a6f81e5f598018f6dbe58 --- lams_central/web/pedagogical_planner/base.jsp (.../base.jsp) (revision a301da49ef54944c21a4c78c60a2637959be30b5) +++ lams_central/web/pedagogical_planner/base.jsp (.../base.jsp) (revision e66bdae723516ab13d4a6f81e5f598018f6dbe58) @@ -9,9 +9,7 @@ <fmt:message key="title.lams"/> :: <fmt:message key="planner.title" /> - - - + + + + + + + +
@@ -74,24 +116,30 @@

${activity.title}

- + + + + - - - + + + - - - - - + + + + + -