Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/nbApplicationContext.xml =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/nbApplicationContext.xml (.../nbApplicationContext.xml) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/nbApplicationContext.xml (.../nbApplicationContext.xml) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -54,7 +54,11 @@ - + + + org.lamsfoundation.lams.tool.noticeboard.ApplicationResources + + Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbAuthoringController.java =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbAuthoringController.java (.../NbAuthoringController.java) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbAuthoringController.java (.../NbAuthoringController.java) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -24,6 +24,7 @@ package org.lamsfoundation.lams.tool.noticeboard.web.controller; import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; import org.apache.log4j.Logger; @@ -65,7 +66,6 @@ * @author mtruong */ @Controller -@RequestMapping("/authoring") public class NbAuthoringController { private static Logger logger = Logger.getLogger(NbAuthoringController.class.getName()); @@ -92,16 +92,25 @@ return user; } - public String unspecified(@ModelAttribute NbAuthoringForm nbAuthoringForm, HttpServletRequest request) { + @RequestMapping("/authoring") + public String unspecified(@ModelAttribute NbAuthoringForm nbAuthoringForm, HttpServletRequest request, + HttpServletResponse response) { /* * Retrieve the Service */ + String contentIdString = nbAuthoringForm.getToolContentID(); + Long contentId = NbWebUtil.convertToLong(nbAuthoringForm.getToolContentID()); + String contentFolderId = nbAuthoringForm.getContentFolderID(); + + + //throws exception if the content id does not exist + checkContentId(contentId); + +// Long contentId = WebUtil.readLongParam(request, NoticeboardConstants.TOOL_CONTENT_ID); +// String contentFolderId = WebUtil.readStrParam(request, NoticeboardConstants.CONTENT_FOLDER_ID); - Long contentId = WebUtil.readLongParam(request, NoticeboardConstants.TOOL_CONTENT_ID); - String contentFolderId = WebUtil.readStrParam(request, NoticeboardConstants.CONTENT_FOLDER_ID); + nbAuthoringForm.setToolContentID(contentIdString); - nbAuthoringForm.setToolContentID(contentId.toString()); - /* * DefineLater is used in the basic screen. If defineLater is set, then in the authoring page, * the two tabs {Advanced, Instructions} are not visible. @@ -157,6 +166,7 @@ } request.setAttribute(FORM, nbAuthoringForm); + return "authoring/authoring"; } @@ -177,6 +187,7 @@ } + @RequestMapping("/save") public String save(@ModelAttribute NbAuthoringForm nbAuthoringForm, HttpServletRequest request) { //copyAuthoringFormValuesIntoFormBean(request, nbForm); Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerController.java =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerController.java (.../NbLearnerController.java) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerController.java (.../NbLearnerController.java) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -119,13 +119,14 @@ * @param response * @return */ - public String finish(@ModelAttribute NbLearnerForm learnerForm, HttpServletRequest request, + @RequestMapping("/finish") + public String finish(@ModelAttribute NbLearnerForm nbLearnerForm, HttpServletRequest request, HttpServletResponse response) throws NbApplicationException, ToolException, DataMissingException, ServletException, IOException { Long userID = getUserID(request); - Long toolSessionID = NbWebUtil.convertToLong(learnerForm.getToolSessionID()); + Long toolSessionID = NbWebUtil.convertToLong(nbLearnerForm.getToolSessionID()); if (toolSessionID == null) { String error = "Unable to continue. The parameters tool session id is missing"; logger.error(error); @@ -135,7 +136,7 @@ ToolSessionManager sessionMgrService = NoticeboardServiceProxy .getNbSessionManager(applicationContext.getServletContext()); - ToolAccessMode mode = WebUtil.getToolAccessMode(learnerForm.getMode()); + ToolAccessMode mode = WebUtil.getToolAccessMode(nbLearnerForm.getMode()); if (mode == ToolAccessMode.LEARNER || mode == ToolAccessMode.AUTHOR) { NoticeboardSession nbSession = nbService.retrieveNoticeboardSession(toolSessionID); NoticeboardUser nbUser = nbService.retrieveNbUserBySession(userID, toolSessionID); @@ -154,10 +155,10 @@ if (entry == null) { // create new entry nbService.createNotebookEntry(toolSessionID, CoreNotebookConstants.NOTEBOOK_TOOL, - NoticeboardConstants.TOOL_SIGNATURE, userID.intValue(), learnerForm.getReflectionText()); + NoticeboardConstants.TOOL_SIGNATURE, userID.intValue(), nbLearnerForm.getReflectionText()); } else { // update existing entry - entry.setEntry(learnerForm.getReflectionText()); + entry.setEntry(nbLearnerForm.getReflectionText()); entry.setLastModified(new Date()); nbService.updateEntry(entry); } @@ -167,10 +168,10 @@ try { nextActivityUrl = sessionMgrService.leaveToolSession(toolSessionID, getUserID(request)); } catch (DataMissingException e) { - log.error(e); + logger.error(e); throw new ServletException(e); } catch (ToolException e) { - log.error(e); + logger.error(e); throw new ServletException(e); } @@ -181,7 +182,7 @@ } request.setAttribute(NoticeboardConstants.READ_ONLY_MODE, "true"); - return ".learnerContent"; + return "learnerContent"; } @@ -195,9 +196,10 @@ * @param response * @return */ - public String reflect(@ModelAttribute NbLearnerForm learnerForm, HttpServletRequest request) { + @RequestMapping("/reflect") + public String reflect(@ModelAttribute NbLearnerForm nbLearnerForm, HttpServletRequest request) { - Long toolSessionID = NbWebUtil.convertToLong(learnerForm.getToolSessionID()); + Long toolSessionID = NbWebUtil.convertToLong(nbLearnerForm.getToolSessionID()); NoticeboardContent nbContent = nbService.retrieveNoticeboardBySessionID(toolSessionID); request.setAttribute("reflectInstructions", nbContent.getReflectInstructions()); request.setAttribute("title", nbContent.getTitle()); @@ -215,6 +217,6 @@ LearningWebUtil.putActivityPositionInRequestByToolSessionId(toolSessionID, request, applicationContext.getServletContext()); - return ".reflectOnActivity"; + return "reflect"; } } \ No newline at end of file Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerStarterController.java =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerStarterController.java (.../NbLearnerStarterController.java) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbLearnerStarterController.java (.../NbLearnerStarterController.java) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -75,7 +75,7 @@ * */ @Controller -@RequestMapping("/starter/learner") +@RequestMapping("/starter") public class NbLearnerStarterController { static Logger logger = Logger.getLogger(NbLearnerStarterController.class.getName()); @@ -114,21 +114,21 @@ return WebUtil.readLongParam(request, AttributeNames.PARAM_USER_ID, false); } - public String unspecified(@ModelAttribute NbLearnerForm learnerForm, Errors errors, HttpServletRequest request, + public String unspecified(@ModelAttribute NbLearnerForm NbLearnerForm, Errors errors, HttpServletRequest request, HttpServletResponse response) { - return learner(learnerForm, errors, request, response); + return learner(NbLearnerForm, errors, request, response); } @RequestMapping("/learner") - public String learner(@ModelAttribute NbLearnerForm learnerForm, Errors errors, HttpServletRequest request, + public String learner(@ModelAttribute NbLearnerForm NbLearnerForm, Errors errors, HttpServletRequest request, HttpServletResponse response) { NoticeboardContent nbContent = null; NoticeboardUser nbUser = null; - saveMessages(request, null); +// saveMessages(request, null); - Long toolSessionID = NbWebUtil.convertToLong(learnerForm.getToolSessionID()); + Long toolSessionID = NbWebUtil.convertToLong(NbLearnerForm.getToolSessionID()); if (toolSessionID == null) { String error = "Unable to continue. The parameters tool session id is missing"; @@ -177,7 +177,7 @@ readOnly = true; } - learnerForm.copyValuesIntoForm(nbContent, readOnly, mode.toString()); + NbLearnerForm.copyValuesIntoForm(nbContent, readOnly, mode.toString()); NotebookEntry notebookEntry = nbService.getEntry(toolSessionID, CoreNotebookConstants.NOTEBOOK_TOOL, NoticeboardConstants.TOOL_SIGNATURE, userID.intValue()); @@ -201,25 +201,27 @@ * If the particular flag is set, control is forwarded to jsp page * displaying to the user the message according to what flag is set. */ - if (displayMessageToUser(nbContent, errors)) { - saveMessages(request, message); - return ("displayMessage"); - } +// if (displayMessageToUser(nbContent, errors)) { +// saveMessages(request, message); +//A request.setAttribute("messageForm", ); +//A return ("message"); +// } return "learnerContent"; } @RequestMapping("/teacher") - public String teacher(@ModelAttribute NbLearnerForm learnerForm, Errors errors, HttpServletRequest request, + public String teacher(@ModelAttribute NbLearnerForm NbLearnerForm, Errors errors, HttpServletRequest request, HttpServletResponse response) throws NbApplicationException { - return learner(learnerForm, errors, request, response); + return learner(NbLearnerForm, errors, request, response); } - public String author(@ModelAttribute NbLearnerForm learnerForm, Errors errors, HttpServletRequest request, + @RequestMapping("/author") + public String author(@ModelAttribute NbLearnerForm NbLearnerForm, Errors errors, HttpServletRequest request, HttpServletResponse response) throws NbApplicationException { - return learner(learnerForm, errors, request, response); + return learner(NbLearnerForm, errors, request, response); } Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbMonitoringController.java =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbMonitoringController.java (.../NbMonitoringController.java) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbMonitoringController.java (.../NbMonitoringController.java) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -31,7 +31,6 @@ import java.util.Set; import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; import org.apache.log4j.Logger; import org.lamsfoundation.lams.notebook.model.NotebookEntry; @@ -60,7 +59,6 @@ * @author mtruong */ @Controller -@RequestMapping("/monitoring") public class NbMonitoringController { static Logger logger = Logger.getLogger(NbMonitoringController.class.getName()); @@ -71,8 +69,8 @@ public final static String FORM = "NbMonitoringForm"; - public String unspecified(@ModelAttribute NbMonitoringForm monitorForm, HttpServletRequest request, - HttpServletResponse response) throws NbApplicationException { + @RequestMapping("/monitoring") + public String unspecified(@ModelAttribute NbMonitoringForm nbMonitoringForm, HttpServletRequest request) { Long toolContentId = NbWebUtil.convertToLong(request.getParameter(NoticeboardConstants.TOOL_CONTENT_ID)); String contentFolderID = WebUtil.readStrParam(request, NoticeboardConstants.CONTENT_FOLDER_ID); @@ -84,14 +82,14 @@ NoticeboardContent content = nbService.retrieveNoticeboard(toolContentId); - monitorForm.setTitle(content.getTitle()); - monitorForm.setBasicContent(content.getContent()); + nbMonitoringForm.setTitle(content.getTitle()); + nbMonitoringForm.setBasicContent(content.getContent()); request.setAttribute(NoticeboardConstants.TOOL_CONTENT_ID, toolContentId); request.setAttribute(NoticeboardConstants.CONTENT_FOLDER_ID, contentFolderID); //Get the total number of learners that have participated in this tool activity - monitorForm.setTotalLearners(nbService.calculateTotalNumberOfUsers(toolContentId)); + nbMonitoringForm.setTotalLearners(nbService.calculateTotalNumberOfUsers(toolContentId)); Set sessions = content.getNbSessions(); Iterator i = sessions.iterator(); @@ -121,8 +119,8 @@ } } } - monitorForm.setGroupStatsMap(numUsersMap); - monitorForm.setSessionIdMap(sessionIdMap); + nbMonitoringForm.setGroupStatsMap(numUsersMap); + nbMonitoringForm.setSessionIdMap(sessionIdMap); boolean isGroupedActivity = nbService.isGroupedActivity(toolContentId); request.setAttribute("isGroupedActivity", isGroupedActivity); @@ -135,11 +133,12 @@ request.setAttribute("allowComments", content.isAllowComments()); String currentTab = WebUtil.readStrParam(request, AttributeNames.PARAM_CURRENT_TAB, true); - monitorForm.setCurrentTab(currentTab != null ? currentTab : "1"); - request.setAttribute(FORM, monitorForm); - return "monitorPage"; + nbMonitoringForm.setCurrentTab(currentTab != null ? currentTab : "1"); + request.setAttribute(FORM, nbMonitoringForm); + return "/monitoring/monitoring"; } + @RequestMapping("/reflection") public String viewReflection(HttpServletRequest request) { Long userId = NbWebUtil.convertToLong(request.getParameter(NoticeboardConstants.USER_ID)); Long toolSessionId = NbWebUtil.convertToLong(request.getParameter(NoticeboardConstants.TOOL_SESSION_ID)); @@ -151,17 +150,18 @@ request.setAttribute("name", nbUser.getFullname()); } - return "monitorReflectionPage"; + return "/monitoring/reflection"; } + @RequestMapping("/comments") public String viewComments(HttpServletRequest request) { Long toolSessionID = WebUtil.readLongParam(request, NoticeboardConstants.TOOL_SESSION_ID, false); NoticeboardContent nbContent = nbService.retrieveNoticeboardBySessionID(toolSessionID); request.setAttribute(NoticeboardConstants.TOOL_SESSION_ID, toolSessionID); request.setAttribute("anonymous", nbContent.isAllowAnonymous()); - return "monitorCommentsPage"; + return "monitoring/comments"; } } Index: lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbPedagogicalPlannerController.java =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbPedagogicalPlannerController.java (.../NbPedagogicalPlannerController.java) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/web/controller/NbPedagogicalPlannerController.java (.../NbPedagogicalPlannerController.java) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -61,6 +61,7 @@ return initPedagogicalPlannerForm(plannerForm, request); } + @RequestMapping("/init") public String initPedagogicalPlannerForm(@ModelAttribute NbPedagogicalPlannerForm plannerForm, HttpServletRequest request) { Long toolContentID = WebUtil.readLongParam(request, AttributeNames.PARAM_TOOL_CONTENT_ID); @@ -72,6 +73,7 @@ } + @RequestMapping("/saveorupdate") public String saveOrUpdatePedagogicalPlannerForm(@ModelAttribute NbPedagogicalPlannerForm plannerForm, Errors errors, HttpServletRequest request) { Index: lams_tool_nb/web/WEB-INF/web.xml =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/web/WEB-INF/web.xml (.../web.xml) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/web/WEB-INF/web.xml (.../web.xml) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -3,6 +3,7 @@ + javax.servlet.jsp.jstl.fmt.localizationContext org.lamsfoundation.lams.tool.noticeboard.ApplicationResources @@ -12,19 +13,22 @@ contextConfigLocation classpath:/org/lamsfoundation/lams/tool/noticeboard/dbupdates/autopatchContext.xml + locatorFactorySelector classpath:/org/lamsfoundation/lams/beanRefContext.xml + parentContextKey context.central - - SystemSessionFilter - org.lamsfoundation.lams.web.session.SystemSessionFilter - + + + org.springframework.web.context.ContextLoaderListener + + hibernateFilter @@ -36,8 +40,14 @@ coreSessionFactory - + + SystemSessionFilter + + org.lamsfoundation.lams.web.session.SystemSessionFilter + + + LocaleFilter org.lamsfoundation.lams.web.filter.LocaleFilter @@ -49,49 +59,19 @@ - SystemSessionFilter + hibernateFilter /* - - hibernateFilter + SystemSessionFilter /* - LocaleFilter /* - - - org.springframework.web.context.ContextLoaderListener - - - - action - org.apache.struts.action.ActionServlet - - config - /WEB-INF/struts-config.xml - - - debug - 999 - - - detail - 2 - - - validate - true - - 1 - - - spring org.springframework.web.servlet.DispatcherServlet @@ -112,14 +92,16 @@ 1 - + + Instructions Download + Instructions Download download org.lamsfoundation.lams.contentrepository.client.ToolDownload toolContentHandlerBeanName - nbToolContentHandler + lataskTaskListToolContentHandler 3 @@ -140,21 +122,7 @@ - - 500 - /error.jsp - - - 403 - /403.jsp - - - 404 - /404.jsp - - - @@ -209,17 +177,20 @@ tags-xml /WEB-INF/tlds/jstl/x.tld + tags-permittedTaglibs /WEB-INF/tlds/jstl/permittedTaglibs.tld + tags-scriptfree /WEB-INF/tlds/jstl/scriptfree.tld + @@ -252,8 +223,7 @@ Authoring content /authoring/* - /authoring.do - /pedagogicalPlanner.do + /pages/authoring/* GET POST @@ -267,7 +237,8 @@ Staff content /monitoring/* - /monitoring.do + /pages/monitoring/* + /definelater.do GET POST @@ -297,10 +268,12 @@ Group Manager GROUP MANAGER + Group Administrator GROUP ADMIN + LAMS System Adminstrator SYSADMIN @@ -315,4 +288,17 @@ /login.jsp?failed=y + + + 500 + /error.jsp + + + 403 + /403.jsp + + + 404 + /404.jsp + \ No newline at end of file Index: lams_tool_nb/web/authoring/advance.jsp =================================================================== diff -u -ra2d72bee6029b7e05e8cd696c02db214f3049365 -re998cf2de8c4714022559cb5f67e61b677a2dd28 --- lams_tool_nb/web/authoring/advance.jsp (.../advance.jsp) (revision a2d72bee6029b7e05e8cd696c02db214f3049365) +++ lams_tool_nb/web/authoring/advance.jsp (.../advance.jsp) (revision e998cf2de8c4714022559cb5f67e61b677a2dd28) @@ -8,13 +8,11 @@
-