Index: lams_central/src/java/org/lamsfoundation/lams/comments/web/CommentController.java =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/src/java/org/lamsfoundation/lams/comments/web/CommentController.java (.../CommentController.java) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/src/java/org/lamsfoundation/lams/comments/web/CommentController.java (.../CommentController.java) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -156,10 +156,7 @@ sessionMap.put(CommentConstants.ATTR_ROOT_COMMENT_UID, rootComment.getUid()); prepareViewTopicData(request, sessionMap, pageSize, sortBy, true); - - boolean newUI = WebUtil.readBooleanParam(request, "newUI", false); - String viewDir = newUI ? "comments5" : "comments"; - return viewDir + "/comments"; + return "comments/comments"; } private void throwException(String msg, String loginName, Long externalId, Integer externalType, @@ -212,10 +209,7 @@ } prepareViewTopicData(request, sessionMap, pageSize, sortBy, sticky); - - boolean newUI = WebUtil.readBooleanParam(request, "newUI", false); - String viewDir = newUI ? "comments5" : "comments"; - return viewDir + (sticky ? "/allviewwrapper" : "/topicviewwrapper"); + return "comments" + (sticky ? "/allviewwrapper" : "/topicviewwrapper"); } private void prepareViewTopicData(HttpServletRequest request, SessionMap sessionMap, @@ -298,10 +292,7 @@ // don't want to try to scroll as this is a single thread, completely displayed. request.setAttribute(CommentConstants.ATTR_NO_MORE_PAGES, true); - - boolean newUI = WebUtil.readBooleanParam(request, "newUI", false); - String viewDir = newUI ? "comments5" : "comments"; - return viewDir + "/topicviewwrapper"; + return "comments/topicviewwrapper"; } /** @@ -391,10 +382,7 @@ request.getParameter(CommentConstants.ATTR_SESSION_MAP_ID)); request.setAttribute(CommentConstants.ATTR_PARENT_COMMENT_ID, request.getParameter(CommentConstants.ATTR_PARENT_COMMENT_ID)); - - boolean newUI = WebUtil.readBooleanParam(request, "newUI", false); - String viewDir = newUI ? "comments5" : "comments"; - return viewDir + "/reply"; + return "comments/reply"; } /** @@ -482,10 +470,7 @@ request.setAttribute(CommentConstants.ATTR_COMMENT_ID, commentId); request.setAttribute(CommentConstants.ATTR_COMMENT, comment); request.setAttribute(CommentConstants.ATTR_SESSION_MAP_ID, sessionMap.getSessionID()); - - boolean newUI = WebUtil.readBooleanParam(request, "newUI", false); - String viewDir = newUI ? "comments5" : "comments"; - return viewDir + "/edit"; + return "comments/edit"; } /** Index: lams_central/web/WEB-INF/tags/Comments.tag =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/WEB-INF/tags/Comments.tag (.../Comments.tag) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/web/WEB-INF/tags/Comments.tag (.../Comments.tag) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -15,7 +15,6 @@ <%@ attribute name="sortBy" required="false" rtexprvalue="true"%> <%@ attribute name="embedInAccordian" required="false" rtexprvalue="true"%> <%@ attribute name="accordionTitle" required="false" rtexprvalue="true"%> -<%@ attribute name="bootstrap5" required="false" rtexprvalue="true"%> @@ -73,7 +72,7 @@ \ No newline at end of file + + + + +
+ <%@ include file="topicview.jsp"%> +
+ + + +
+ + + + + +
+ + <%@ include file="topicview.jsp"%> + +
+ + \ No newline at end of file Index: lams_central/web/comments/allviewwrapper.jsp =================================================================== diff -u -r4c2d1f37b92435907ec4ce23cb635a7cd9e4161e -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/allviewwrapper.jsp (.../allviewwrapper.jsp) (revision 4c2d1f37b92435907ec4ce23cb635a7cd9e4161e) +++ lams_central/web/comments/allviewwrapper.jsp (.../allviewwrapper.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,13 +1,10 @@ <%@ include file="/common/taglibs.jsp"%> - - - - - - + + + <%@ include file="allview.jsp"%> Index: lams_central/web/comments/anonymouscheckbox.jsp =================================================================== diff -u -r7475d08afc280b5e2e5ddf04e8bf35e3166aaf80 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/anonymouscheckbox.jsp (.../anonymouscheckbox.jsp) (revision 7475d08afc280b5e2e5ddf04e8bf35e3166aaf80) +++ lams_central/web/comments/anonymouscheckbox.jsp (.../anonymouscheckbox.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,23 +1,35 @@ - + + + <%-- include the value so it gets returned but do not allow it to be edited --%> - + -
- -
  - <%-- Use c:out to escape any quotes in the I18N string. Then use html: true converts any escaped quotes back --%> - <%-- into real quotes. Should be safe from XSS attack as the string is coming from a translation file. --%> - - +
+ + + + + +
-
+
Index: lams_central/web/comments/comments.jsp =================================================================== diff -u -rfe19797ec82718905555353176ed719bec11043e -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/comments.jsp (.../comments.jsp) (revision fe19797ec82718905555353176ed719bec11043e) +++ lams_central/web/comments/comments.jsp (.../comments.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,71 +1,156 @@ <%@ include file="/common/taglibs.jsp"%> - - - + +<%@ page import="org.lamsfoundation.lams.comments.CommentConstants"%> - - - - - - - - - - - - - + + - + + + + + $("#commentDiv").on("change", "#sortMenu", function() { + var url = "comments/viewTopic.do?sessionMapID=${sessionMapID}&sticky=true&sortBy=" + + $(this).find("option:selected").attr('value'); + reloadDivs(url); + }); + + $('#newForm').submit(function() { // catch the form's submit event + newCommentSubmit(); + }); + }); + + function refreshComments() { + var reqIDVar = new Date(); + reloadDivs('comments/viewTopic.do?sessionMapID=${sessionMapID}&sticky=true&reqUid=' + + reqIDVar.getTime()); + } + + function reloadDivs(url) { + $('.scroll').data('jscroll', null); + $.ajaxSetup({ + cache : true + }); + $('#commentDiv').load(url); + } + + function scrollDoneCallback() { + } + + var btnName = "newCommentSubmitButton"; + + function newCommentSubmit() { + if ( isDisabled(btnName) ) { + return false; + } - - - -
- -
- <%@ include file="new.jsp"%> -
-
+ var theForm = $(newForm); + disableButton(btnName); - - + if (validateBodyText( + $('#newFormBody').val(), + <%=CommentConstants.MAX_BODY_LENGTH%>, + "" + )) { + $.ajax({ // create an AJAX call... + data : theForm.serialize(), + processData : false, // tell jQuery not to process the data + contentType : false, // tell jQuery not to set contentType + type : theForm.attr('method'), // GET or POST + url : theForm.attr('action'), // the file to call + + }).done(function(response) { + var threadUid = response.threadUid; + var commentUid = response.commentUid; + var sessionMapID = response.sessionMapID; -
- <%@ include file="allview.jsp"%> -
+ // have just added it as a standalone comment, so show the posting at the top. + var newCommentDiv = document.getElementById('newcomments'); + var newThreadDiv = document.createElement("div"); + newThreadDiv.id = 'thread' + commentUid; + newCommentDiv.insertBefore(newThreadDiv, newCommentDiv.firstChild); + + if (!newCommentDiv || !newThreadDiv) { + alert(''); + } else if (commentUid) { + var loadString = 'comments/viewTopicThread.do?sessionMapID=' + + response.sessionMapID + + "&threadUid=" + + threadUid + + "&commentUid=" + commentUid; + $.ajaxSetup({ cache: true }); + $(newThreadDiv).load(loadString, + function() { + highlightMessage(); + }); + clearNewForm(); + } else if (response.errMessage) { + alert(response.errMessage); + enableButton(btnName); + } else { + alert(''); + } + }); + } // end validateBodyText + else { + enableButton(btnName); + } + return false; + } + + function clearNewForm() { + $('#newFormBody').val(''); + $('#commentAnonymousNew').prop('checked',false); + enableButton(btnName); + return false; + } + + + +
+
+
+
+
+ + + + +
+ + + +
+ + + + + <%@include file="anonymouscheckbox.jsp"%> + +
- - \ No newline at end of file +
+
+
+
+ +
+ <%@ include file="allview.jsp"%> +
\ No newline at end of file Index: lams_central/web/comments/edit.jsp =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/edit.jsp (.../edit.jsp) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/web/comments/edit.jsp (.../edit.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,5 +1,6 @@ <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.comments.CommentConstants"%> + -
-
- - - - -
- +
+
+
+ + + + - - - <%-- Post Anonymously? --%> -
- - - <%@include file="anonymouscheckbox.jsp" %> -
- - <%-- Cancel / Edit Buttons --%> -
- - -
- - - - -   - - - -
- - +
+
+ + + +
+ + <%-- Post Anonymously? --%> + + + + <%@include file="anonymouscheckbox.jsp"%> + +
+
- - - +
+
\ No newline at end of file Index: lams_central/web/comments/msgview.jsp =================================================================== diff -u -r4a671993d031537b4a1b749a1578e88afd7b9d25 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/msgview.jsp (.../msgview.jsp) (revision 4a671993d031537b4a1b749a1578e88afd7b9d25) +++ lams_central/web/comments/msgview.jsp (.../msgview.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,181 +1,209 @@ <%-- commentDto, commentUid, msgLevel needs to be in the session elsewhere --%> - - - - + + + - + - + - - - - + + + - highlight + highlight - + - + -
-
-
-
-

- - <%-- authors name --%> - - -   - - - - - - ${msgAuthor} () - - - ${msgAuthor} - - - - - - - - - - - - - ${msgAuthor} - - - - +
+
+
+
- - - - - - - - - - - - - - - - - - - - - - + <%-- authors name --%> + + +   + + + + + + ${msgAuthor} () + + + ${msgAuthor} + + + + + + + + + + + + + + + ${msgAuthor} + + + + - - - - - | () - - -

-
-
- - -
-
- - - - - - - + + + + + + + + + + + + + + + + + + + + + + -
- + +
- - comments/newReplyTopic.do?sessionMapID=${sessionMapID}&parentUid=${commentDto.comment.uid} - Reply - · - + +
+ +
+
- - comments/editTopic.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&create=${commentDto.comment.created.time} - Edit - · - + + + + + + - - - - - - comments/hide.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&hideFlag=false - - - - - comments/hide.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&hideFlag=true - - - - · - +
+ +
+ + + + + + + comments/hide.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&hideFlag=false + + + + + + + + comments/hide.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&hideFlag=true + + + + + · + - - comments/makeSticky.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&create=${commentDto.comment.created.time}&sticky=${!commentDto.comment.sticky} - - - · - + + + comments/makeSticky.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&create=${commentDto.comment.created.time}&sticky=${!commentDto.comment.sticky} + + + · + - ${commentDto.comment.likeCount} - - - - - " - onclick="javascript:likeEntry(${commentDto.comment.uid});" id="msglikebutton${commentDto.comment.uid}"> - -  " - onclick="javascript:dislikeEntry(${commentDto.comment.uid});" id="msgdislikebutton${commentDto.comment.uid}"> - - - - " - id="msglikebutton${commentDto.comment.uid}"/> - - - - " - id="msgdislikebutton${commentDto.comment.uid}"> - - - - - + + + + + + + + + + + + + " + id="msglikebutton${commentDto.comment.uid}" + /> + + + + + " + id="msgdislikebutton${commentDto.comment.uid}" + > + + + + + + ${commentDto.comment.likeCount} + -
+ + · + + comments/editTopic.do?sessionMapID=${sessionMapID}&commentUid=${commentDto.comment.uid}&create=${commentDto.comment.created.time} + + + -
- -
+ + · + + comments/newReplyTopic.do?sessionMapID=${sessionMapID}&parentUid=${commentDto.comment.uid} + + + +
+
+
+
+
-
-
- - Index: lams_central/web/comments/msgviewwrapper.jsp =================================================================== diff -u -r4c2d1f37b92435907ec4ce23cb635a7cd9e4161e -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/msgviewwrapper.jsp (.../msgviewwrapper.jsp) (revision 4c2d1f37b92435907ec4ce23cb635a7cd9e4161e) +++ lams_central/web/comments/msgviewwrapper.jsp (.../msgviewwrapper.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,5 +1,7 @@ <%@ include file="/common/taglibs.jsp"%> + + <%-- Wraps up msgview.jsp for returning a single message - called when an edit is performed. It needs to do all the setup that topicview.jsp normally does. --%> @@ -9,20 +11,13 @@ $(".comment").click(function (e) { e.stopPropagation(); }); + + jQuery(document).ready(function() { + jQuery("time.timeago").timeago(); + }); - - - - <%@ include file="msgview.jsp"%> - - - Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments/new.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/comments/reply.jsp =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/reply.jsp (.../reply.jsp) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/web/comments/reply.jsp (.../reply.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,5 +1,6 @@ <%@ include file="/common/taglibs.jsp"%> <%@ page import="org.lamsfoundation.lams.comments.CommentConstants"%> + -
-
- - +
+
+
+ + + + -
- +
+
+ + + +
- - - <%-- Post Anonymously? --%> -
- - - <%@include file="anonymouscheckbox.jsp" %> -
- - <%-- Cancel / Edit Buttons --%> -
- - -
- - - -   - + <%-- Post Anonymously? --%> + + + + <%@include file="anonymouscheckbox.jsp"%> +
- +
+
+
\ No newline at end of file Index: lams_central/web/comments/topicview.jsp =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/topicview.jsp (.../topicview.jsp) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/web/comments/topicview.jsp (.../topicview.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,36 +1,37 @@ <%@ page import="org.lamsfoundation.lams.comments.CommentConstants"%> - - - + expandable:true,initialState:'expanded', - expanderTemplate:'${prompt}', - stringCollapse:'${hide}',stringExpand:'${show}', - clickableNodeNames:true,indent:${indent}, + expanderTemplate:'', + stringCollapse:'${hide}', + stringExpand:'${show}', + clickableNodeNames:false, + indent:${indent}, onNodeInitialized:function() { if (this.level() >= 2) { this.collapse(); } } - + expandable:true,initialState:'collapsed', - expanderTemplate:'${prompt}', - stringCollapse:'${hide}',stringExpand:'${show}', - clickableNodeNames:true,indent:${indent}, + expanderTemplate:'
+ +
+ + /comments/viewTopic.do?pageLastId=${maxThreadUid}&likeCount=${minThreadLike}&pageSize=${sessionMap.pageSize}&sessionMapID=${sessionMapID} + + " class="btn btn-sm btn-light"> + + +
+
- /comments/viewTopic.do?pageLastId=${maxThreadUid}&likeCount=${minThreadLike}&pageSize=${sessionMap.pageSize}&sessionMapID=${sessionMapID} - " class="btn btn-xs btn-default"> +
- - + Index: lams_central/web/comments/topicviewwrapper.jsp =================================================================== diff -u -r4c2d1f37b92435907ec4ce23cb635a7cd9e4161e -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/comments/topicviewwrapper.jsp (.../topicviewwrapper.jsp) (revision 4c2d1f37b92435907ec4ce23cb635a7cd9e4161e) +++ lams_central/web/comments/topicviewwrapper.jsp (.../topicviewwrapper.jsp) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -1,15 +1,12 @@ <%@ include file="/common/taglibs.jsp"%> + + + - - - - - - <%@ include file="topicview.jsp"%> Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/allview.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/allviewwrapper.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/anonymouscheckbox.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/comments.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/edit.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/msgview.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/msgviewwrapper.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/reply.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/topicview.jsp'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag f14a45648947b8813b4b99842665fcf87f5dfbed refers to a dead (removed) revision in file `lams_central/web/comments5/topicviewwrapper.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/includes/javascript/comments.js =================================================================== diff -u -r3282e8325662ca873b88ceb07e627315d415a2c6 -rf14a45648947b8813b4b99842665fcf87f5dfbed --- lams_central/web/includes/javascript/comments.js (.../comments.js) (revision 3282e8325662ca873b88ceb07e627315d415a2c6) +++ lams_central/web/includes/javascript/comments.js (.../comments.js) (revision f14a45648947b8813b4b99842665fcf87f5dfbed) @@ -15,7 +15,7 @@ } - function reloadThread(response, lamsUrl, newUi, savedCannotRedisplayMessage, errorCannotRedisplayMessage) { + function reloadThread(response, lamsUrl, savedCannotRedisplayMessage, errorCannotRedisplayMessage) { var threadDiv = document.getElementById('thread'+response.threadUid); var threadUid = response.threadUid; var commentUid = response.commentUid; @@ -24,7 +24,7 @@ if ( ! threadDiv) { alert(savedCannotRedisplayMessage); } else { - var loadString = lamsUrl+"comments/viewTopicThread.do?newUI=" + newUi + "&sessionMapID=" + response.sessionMapID + "&threadUid=" + threadUid+"&commentUid="+commentUid; + var loadString = lamsUrl+"comments/viewTopicThread.do?sessionMapID=" + response.sessionMapID + "&threadUid=" + threadUid+"&commentUid="+commentUid; $.ajaxSetup({ cache: true }); $(threadDiv).load(loadString, function() { // expand up to the reply - in case it is buried down in a lot of replies