Index: lams_build/3rdParty.userlibraries =================================================================== diff -u -rc12abbda09a033492a8f2343e260127685f872b5 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_build/3rdParty.userlibraries (.../3rdParty.userlibraries) (revision c12abbda09a033492a8f2343e260127685f872b5) +++ lams_build/3rdParty.userlibraries (.../3rdParty.userlibraries) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -8,7 +8,6 @@ - Index: lams_build/build.xml =================================================================== diff -u -rc12abbda09a033492a8f2343e260127685f872b5 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_build/build.xml (.../build.xml) (revision c12abbda09a033492a8f2343e260127685f872b5) +++ lams_build/build.xml (.../build.xml) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -448,19 +448,9 @@ + - - - - - - - - - - Index: lams_build/lib/batik/batik-1.7.jar =================================================================== diff -u -r19ce8ed8c4540f6ee4da179b3cdec9715cdd860b -rf295ad79de8fe9d221c166fa90587d0be2fdda5b Binary files differ Fisheye: Tag f295ad79de8fe9d221c166fa90587d0be2fdda5b refers to a dead (removed) revision in file `lams_build/lib/batik/batik.module.xml'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_build/lib/lams/lams.jar =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b Binary files differ Index: lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java (.../AuthoringAction.java) (revision 5e63656a12c02f7476564e278b43ff4ce86ac930) +++ lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java (.../AuthoringAction.java) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -497,7 +497,11 @@ if (AuthoringAction.log.isDebugEnabled()) { AuthoringAction.log.debug("Created a single activity lesson with ID: " + lesson.getLessonId()); } + + response.setContentType("text/plain;charset=utf-8"); + response.getWriter().write(learningDesignID.toString()); } + return null; } Index: lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java (.../CentralConstants.java) (revision 5e63656a12c02f7476564e278b43ff4ce86ac930) +++ lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java (.../CentralConstants.java) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -59,8 +59,6 @@ public static final String PARAM_METHOD = "method"; - public static final String PARAM_SVG_FORMAT = "svgFormat"; - public static final String PARAM_MODE = "mode"; public static final String PARAM_FILEPATH = "filePath"; Index: lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java (.../HomeAction.java) (revision 5e63656a12c02f7476564e278b43ff4ce86ac930) +++ lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java (.../HomeAction.java) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -39,7 +39,6 @@ import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; -import org.apache.batik.transcoder.TranscoderException; import org.apache.commons.io.IOUtils; import org.apache.log4j.Logger; import org.apache.struts.action.ActionForm; @@ -53,6 +52,7 @@ import org.lamsfoundation.lams.learningdesign.GroupUser; import org.lamsfoundation.lams.learningdesign.dao.IGroupUserDAO; import org.lamsfoundation.lams.learningdesign.service.ILearningDesignService; +import org.lamsfoundation.lams.learningdesign.service.LearningDesignService; import org.lamsfoundation.lams.lesson.Lesson; import org.lamsfoundation.lams.lesson.dto.LessonDTO; import org.lamsfoundation.lams.lesson.service.ILessonService; @@ -70,7 +70,6 @@ import org.lamsfoundation.lams.util.ConfigurationKeys; import org.lamsfoundation.lams.util.FileUtil; import org.lamsfoundation.lams.util.WebUtil; -import org.lamsfoundation.lams.util.svg.SVGGenerator; import org.lamsfoundation.lams.web.session.SessionManager; import org.lamsfoundation.lams.web.util.AttributeNames; import org.lamsfoundation.lams.workspace.service.IWorkspaceManagementService; @@ -186,12 +185,6 @@ if (lesson.isDisplayDesignImage()) { Long learningDesignId = lesson.getLearningDesign().getLearningDesignId(); req.setAttribute(AttributeNames.PARAM_LEARNINGDESIGN_ID, learningDesignId); - - if (lesson.getLearnerProgresses().isEmpty()) { - // create svg, png files on the server - getLearningDesignService().createLearningDesignSVG(learningDesignId, - SVGGenerator.OUTPUT_FORMAT_SVG); - } } return mapping.findForward("lessonIntro"); } @@ -410,20 +403,10 @@ return null; } - public ActionForward createLearningDesignThumbnail(ActionMapping mapping, ActionForm form, HttpServletRequest req, - HttpServletResponse res) throws JDOMException, IOException, TranscoderException { + public ActionForward getLearningDesignThumbnail(ActionMapping mapping, ActionForm form, HttpServletRequest req, + HttpServletResponse res) throws JDOMException, IOException { Long learningDesignId = WebUtil.readLongParam(req, CentralConstants.PARAM_LEARNING_DESIGN_ID); - Integer format = WebUtil.readIntParam(req, CentralConstants.PARAM_SVG_FORMAT, true); - format = format == null ? SVGGenerator.OUTPUT_FORMAT_SVG : format; - Long branchingActivityId = WebUtil.readLongParam(req, "branchingActivityID", true); boolean download = WebUtil.readBooleanParam(req, "download", false); - String imagePath = null; - if (branchingActivityId == null) { - imagePath = getLearningDesignService().createLearningDesignSVG(learningDesignId, format); - } else { - imagePath = getLearningDesignService().createBranchingSVG(branchingActivityId, format); - } - // should the image be downloaded or a part of page? if (download) { String name = getLearningDesignService() @@ -435,8 +418,10 @@ } else { res.setContentType("image/svg+xml"); } - OutputStream output = res.getOutputStream(); + + String imagePath = LearningDesignService.getLearningDesignSVGPath(learningDesignId); FileInputStream input = new FileInputStream(imagePath); + OutputStream output = res.getOutputStream(); IOUtils.copy(input, output); IOUtils.closeQuietly(input); IOUtils.closeQuietly(output); Fisheye: Tag f295ad79de8fe9d221c166fa90587d0be2fdda5b refers to a dead (removed) revision in file `lams_central/src/java/org/lamsfoundation/lams/webservice/LearningDesignSVGServlet.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/WEB-INF/web.xml =================================================================== diff -u -rae02cc75ca6d4d08c0e45aa9f36b33d646c893b1 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/web/WEB-INF/web.xml (.../web.xml) (revision ae02cc75ca6d4d08c0e45aa9f36b33d646c893b1) +++ lams_central/web/WEB-INF/web.xml (.../web.xml) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -412,13 +412,6 @@ - LearningDesignSVG - - org.lamsfoundation.lams.webservice.LearningDesignSVGServlet - - - - LessonManager org.lamsfoundation.lams.webservice.xml.LessonManagerServlet @@ -521,11 +514,6 @@ - LearningDesignSVG - /services/LearningDesignSVG/* - - - LessonManager /services/xml/LessonManager/* @@ -770,7 +758,6 @@ /LoginRequest /services/xml/LessonManager/* /services/xml/LearningDesignRepository/* - /services/LearningDesignSVG/* /services/Gradebook /services/xml/LessonJoin/* /services/CourseGroupManager Index: lams_central/web/addLesson.jsp =================================================================== diff -u -r5e63656a12c02f7476564e278b43ff4ce86ac930 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/web/addLesson.jsp (.../addLesson.jsp) (revision 5e63656a12c02f7476564e278b43ff4ce86ac930) +++ lams_central/web/addLesson.jsp (.../addLesson.jsp) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -28,7 +28,7 @@ users = ${users}, LAMS_URL = '', - LD_THUMBNAIL_URL_BASE = LAMS_URL + 'home.do?method=createLearningDesignThumbnail&svgFormat=1&ldId=', + LD_THUMBNAIL_URL_BASE = LAMS_URL + 'home.do?method=getLearningDesignThumbnail&ldId=', CANVAS_RESIZE_OPTION_NONE = 0, CANVAS_RESIZE_OPTION_FIT = 1, Index: lams_central/web/authoring/authoring.jsp =================================================================== diff -u -r03b0e2bc93bc7cd09dca055ec8f00ff24ec8f867 -rf295ad79de8fe9d221c166fa90587d0be2fdda5b --- lams_central/web/authoring/authoring.jsp (.../authoring.jsp) (revision 03b0e2bc93bc7cd09dca055ec8f00ff24ec8f867) +++ lams_central/web/authoring/authoring.jsp (.../authoring.jsp) (revision f295ad79de8fe9d221c166fa90587d0be2fdda5b) @@ -39,7 +39,7 @@ + + + +