Index: lams_build/lib/lams/lams-contentrepository.jar
===================================================================
RCS file: /usr/local/cvsroot/lams_build/lib/lams/lams-contentrepository.jar,v
diff -u -r1.2 -r1.3
Binary files differ
Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IFileDAO.java
===================================================================
RCS file: /usr/local/cvsroot/lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IFileDAO.java,v
diff -u -r1.2 -r1.3
--- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IFileDAO.java	21 Feb 2005 06:12:45 -0000	1.2
+++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/IFileDAO.java	6 Jul 2005 00:25:00 -0000	1.3
@@ -59,4 +59,9 @@
 	public String getFilePath(Long uuid, Long versionId) 
 						throws FileException;
 
+	/**
+	 * Is there a file on disk? Used to validate file nodes
+	 */
+	public boolean fileExists(Long uuid, Long versionId )
+						throws FileException;
 }
\ No newline at end of file
Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java
===================================================================
RCS file: /usr/local/cvsroot/lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java,v
diff -u -r1.3 -r1.4
--- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java	28 Feb 2005 07:56:21 -0000	1.3
+++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/dao/file/FileDAO.java	6 Jul 2005 00:25:00 -0000	1.4
@@ -222,6 +222,16 @@
 	}
 
 	/**
+	 * Is there a file on disk? Used to validate file nodes
+	 */
+	public boolean fileExists(Long uuid, Long versionId )
+						throws FileException {
+	    File file = new File( getFilePath(uuid, versionId));
+	    return ( file.exists() );	    
+	}
+
+	/* ***************** Getters and setters for Spring  *****************/
+	/**
 	 * @return Returns the repositoryLocation.
 	 */
 	public String getRepositoryLocation() {
Index: lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleVersionedNode.java
===================================================================
RCS file: /usr/local/cvsroot/lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleVersionedNode.java,v
diff -u -r1.2 -r1.3
--- lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleVersionedNode.java	5 Jul 2005 03:24:59 -0000	1.2
+++ lams_contentrepository/src/java/org/lamsfoundation/lams/contentrepository/service/SimpleVersionedNode.java	6 Jul 2005 00:25:00 -0000	1.3
@@ -491,7 +491,6 @@
             .append("node", node)
             .append("nodeVersion", nodeVersion)
             .append("newIStream", newIStream)
-            .append("ticket", ticket)
             .toString();
 	}
 	
@@ -538,7 +537,9 @@
 	 * <UL>
 	 * <LI>All nodes must have a node type and created date.
 	 * <LI>Root nodes must not have a file
-	 * <LI>File nodes must have a file, must have a MIMETYPE property
+	 * <LI>File nodes must have a file, must have a MIMETYPE property. Note:
+	 * we could just be doing a setProperty save, in which case the file
+	 * will already exist.
 	 * <LI>Package nodes must not have a file, must have a INITIALPATH property
 	 * @throws ValidationException if problems exist.
 	 */
@@ -560,8 +561,19 @@
 				errors = errors + "\nCreated datetimestamp is missing. ";
 			
 			if ( isNodeType(NodeType.FILENODE) ) {
-				if ( newIStream == null )
-					errors = errors + "\nNode is a file node but the file is missing. ";
+			    Long uuid = node.getNodeId();
+			    Long versionId = nodeVersion.getVersionId();
+			    try {
+				    // if it is a new node or a new version then it must have a file, otherwise check on disk.
+			        // version id will always be set. uuid isn't set until the record is written to the db,
+			        // but don't want to rely on that if we can help it in case it changes in future.
+					if ( newIStream == null &&
+					     ( uuid == null || !fileDAO.fileExists(uuid, versionId)) )
+						errors = errors + "\nNode is a file node but the file is missing. ";
+			    } catch (FileException fe){
+			        errors = "Unable to validation node due to file exception: "+fe.getMessage();
+			        log.error("File exception occured while validating node "+this.toString(), fe);
+			    }
 				if ( ! hasProperty(PropertyName.FILENAME) )
 					errors = errors + "\nNode is a file node but the filename is unknown";
 			} else {
@@ -579,7 +591,9 @@
 		}
 	}
 	
-	/** Save the changes to this node.
+	/** Save the changes to this node. This method must be called when saving a file
+	 * or package node for the first time - it does both the database and the file 
+	 * saves.
 	 * 
 	 * If it is a file node, then it writes out the db changes and then saves 
 	 * the file.
Index: lams_contentrepository/test/java/org/lamsfoundation/lams/contentrepository/service/TestSimpleRepository.java
===================================================================
RCS file: /usr/local/cvsroot/lams_contentrepository/test/java/org/lamsfoundation/lams/contentrepository/service/Attic/TestSimpleRepository.java,v
diff -u -r1.3 -r1.4
--- lams_contentrepository/test/java/org/lamsfoundation/lams/contentrepository/service/TestSimpleRepository.java	5 Jul 2005 03:24:59 -0000	1.3
+++ lams_contentrepository/test/java/org/lamsfoundation/lams/contentrepository/service/TestSimpleRepository.java	6 Jul 2005 00:25:00 -0000	1.4
@@ -243,12 +243,13 @@
 			deleteVersion(keys.getUuid(), one);
 			checkFileNodeDoesNotExist(fileDAO, keys.getUuid(), one, 0);
 			checkFileNodeDoesNotExist(fileDAO, keys.getUuid(), two, 0);
+			
         } catch (FileNotFoundException e) {
             fail("Unexpected exception "+e.getMessage());
         }
 	}
 	
-	/** create a node with two versions and test deleting them using delete node */
+	/** create a node with two versions and test deleting them using delete node. ALso tests set property */
 	public void testFileItemDeleteNode() {
 
 		IFileDAO fileDAO = (FileDAO)context.getBean("fileDAO", FileDAO.class);
@@ -259,6 +260,8 @@
 			testAddFileItem(CRResources.getZipFile(), CRResources.zipFileName,keys.getUuid(),two);
 			checkFileNodeExist(fileDAO, keys.getUuid(), two, 2);
 		
+			testSetPropertyFile(keys);
+
 			deleteNode(keys.getUuid());
 			checkFileNodeDoesNotExist(fileDAO, keys.getUuid(), one, 0);
 			checkFileNodeDoesNotExist(fileDAO, keys.getUuid(), two, 0);
@@ -469,7 +472,7 @@
 	public void testPackageItem() {
 		NodeKey keys = testPackageItem(null);
 		testPackageItem(keys.getUuid());
-		testSetProperty(keys);
+		testSetPropertyPackage(keys);
 	}
 
 	private NodeKey testPackageItem(Long uuid) {
@@ -543,8 +546,8 @@
 		return keys;
 	}
 
-	private void testSetProperty(NodeKey keys) {
-	    String propertyName = "CUSTOM";
+	private void testSetPropertyPackage(NodeKey keys) {
+	    String propertyName = "CUSTOMA";
 	    Boolean value = Boolean.TRUE;
 	    
 		List nodes;
@@ -579,6 +582,27 @@
 
 	}
 
+	private void testSetPropertyFile(NodeKey keys) {
+	    String propertyName = "CUSTOMB";
+	    String value = "avalue";
+	    
+        try {
+            IVersionedNode node = repository.getFileItem(ticket, keys.getUuid(), keys.getVersion());
+            assertTrue("File node found (A)", node != null && node.isNodeType(NodeType.FILENODE));
+            repository.setProperty(ticket, keys.getUuid(), keys.getVersion(), propertyName, value, PropertyType.BOOLEAN); 			
+			
+			// now, is the property set?
+            node = repository.getFileItem(ticket, keys.getUuid(), keys.getVersion());
+            assertTrue("File node found (A)", node != null && node.isNodeType(NodeType.FILENODE));
+			IValue newValue = node.getProperty(propertyName);
+			assertEquals("newValue "+newValue+" equals "+value, value, newValue.getString());
+			
+        } catch (RepositoryCheckedException e) {
+			failUnexpectedException("testSetProperty",e);
+        }
+
+	}
+
 	/**
 	 * @param keys
 	 * @param relPath