Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/BranchCondition.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/learningdesign/BranchCondition.java,v diff -u -r1.7 -r1.8 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/BranchCondition.java 9 Dec 2007 09:55:22 -0000 1.7 +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/BranchCondition.java 10 Dec 2007 06:20:38 -0000 1.8 @@ -346,8 +346,11 @@ return false; } - if ( typedStartValue != null && ( typedEndValue == null || typedEndValue.compareTo(typedStartValue) >= 0 ) ) { + if ( typedStartValue == null && typedEndValue != null ) return true; + + else if ( typedEndValue == null || typedEndValue.compareTo(typedStartValue) >= 0 ) { + return true; } } return false; Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/BranchConditionDTO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/BranchConditionDTO.java,v diff -u -r1.5 -r1.6 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/BranchConditionDTO.java 18 Oct 2007 07:24:09 -0000 1.5 +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/BranchConditionDTO.java 10 Dec 2007 06:20:38 -0000 1.6 @@ -36,12 +36,6 @@ */ public class BranchConditionDTO { - /** If a range is open ended e.g. starts at zero and has no end value then Flash needs a maximum value for endValue - * so that it can render a stepper. So set the max value to 9999 on the way out, and convert it back to null - * on the way in. This logic is also used for the ToolOutputDefinitionDTO. - */ - public static String MAX_FOR_FLASH = "9999"; - private Long conditionId; private Integer conditionUIID; private Integer orderID; @@ -63,9 +57,6 @@ this.startValue = condition.getStartValue(); this.endValue = condition.getEndValue(); - if ( startValue != null && endValue == null ) { - endValue = BranchConditionDTO.MAX_FOR_FLASH; - } this.exactMatchValue = condition.getExactMatchValue(); this.toolActivityUIID = toolActivityUIID; Index: lams_common/src/java/org/lamsfoundation/lams/tool/dto/ToolOutputDefinitionDTO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/tool/dto/ToolOutputDefinitionDTO.java,v diff -u -r1.3 -r1.4 --- lams_common/src/java/org/lamsfoundation/lams/tool/dto/ToolOutputDefinitionDTO.java 18 Oct 2007 07:24:09 -0000 1.3 +++ lams_common/src/java/org/lamsfoundation/lams/tool/dto/ToolOutputDefinitionDTO.java 10 Dec 2007 06:20:38 -0000 1.4 @@ -53,9 +53,6 @@ this.startValue = startValue; this.endValue = endValue; - if ( startValue != null && endValue == null ) { - endValue = BranchConditionDTO.MAX_FOR_FLASH; - } this.complexDefinition = complexDefinition; } @@ -68,9 +65,6 @@ this.startValue = (definition.getStartValue() != null) ? definition.getStartValue().toString() : null; this.endValue = (definition.getEndValue() != null) ? definition.getEndValue().toString() : null; - if ( startValue != null && endValue == null ) { - endValue = BranchConditionDTO.MAX_FOR_FLASH; - } this.complexDefinition = (definition.getComplexDefinition() != null) ? definition.getComplexDefinition().toString() : null; }