Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java,v diff -u -r1.12 -r1.13 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java 29 Mar 2005 06:14:05 -0000 1.12 +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/Grouping.java 30 Mar 2005 04:15:04 -0000 1.13 @@ -288,8 +288,13 @@ this.grouper.doGrouping(this,learner); } + /** + * Return whether a learner is a existing learner for this grouping or not. + * @param learner the current leaner + * @return the boolean result + */ public boolean doesLearnerExist(User learner) { - return getGroupBy(learner).isNull(); + return !getGroupBy(learner).isNull(); } } Index: lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java,v diff -u -r1.3 -r1.4 --- lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java 29 Mar 2005 06:14:05 -0000 1.3 +++ lams_common/src/java/org/lamsfoundation/lams/learningdesign/RandomGrouper.java 30 Mar 2005 04:15:04 -0000 1.4 @@ -146,7 +146,7 @@ for(Iterator i=learners.iterator();i.hasNext();) { User learner = (User)i.next(); - if(randomGrouping.doesLearnerExist(learner)) + if(!randomGrouping.doesLearnerExist(learner)) { Group selectedGroup = selectGroupToJoin((RandomGrouping)randomGrouping); selectedGroup.getUsers().add(learner); @@ -185,7 +185,7 @@ for(Iterator i = learners.iterator();i.hasNext();) { User learner = (User)i.next(); - if(randomGrouping.getGroupBy(learner).isNull()) + if(!randomGrouping.doesLearnerExist(learner)) newLearners++; }