Index: lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java
===================================================================
RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java,v
diff -u -r1.13 -r1.14
--- lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java	31 Oct 2006 04:13:13 -0000	1.13
+++ lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java	30 May 2007 04:14:01 -0000	1.14
@@ -245,13 +245,12 @@
 
 				try {
 					Principal p;
-					if (name!=null) {
-						p = super.createIdentity(name);
-					} else {
-						p = super.createIdentity(Role.LEARNER);
+					// Assign minimal role if user has none
+					if (name==null) {
+						name = Role.LEARNER;
 						log.info("Found no roles");
 					}
-					//if (!group.isMember(p)) {
+					p = super.createIdentity(name);
 					if (!groupMembers.contains(name)) {
 						log.info("Assign user to role " + p.getName());
 						group.addMember(p);
@@ -260,7 +259,6 @@
 					if (name.equals(Role.SYSADMIN) || name.equals(Role.AUTHOR_ADMIN)) {
 						p = super.createIdentity(Role.AUTHOR);
 						log.info("Found "+name);
-						//if (!group.isMember(p)) {
 						if (!groupMembers.contains(Role.AUTHOR)) {
 							log.info("Assign user to role "+Role.AUTHOR);
 							group.addMember(p);